comply 1.5.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: fe65a8f58c234deb6cd6076f2fd7bb2f3156704a
-  data.tar.gz: 9aeff5a90f702b671b6a5adc44d9d580c44c86d7
+SHA256:
+  metadata.gz: 2308727dd5cda38287f6a80667b39631fe41dc96b36b94c27d230bd5463ac892
+  data.tar.gz: 0a6a2baf3207d7722cd551dca5c0fae083b686ad0d7bcbc31d1d1d337504f94e
 SHA512:
-  metadata.gz: 73906bc41d482038914ecd7e0cd69ac1d176c74adac56e05c1e8a0138ac11a92e90890d15f162a3a6447edd8fb64383cb185a251432ebb4f9604154981d133b1
-  data.tar.gz: 12e732771f7564c71fa2e77579165163d653227969bcb4e7155f25112d1495167d26a49fcfd15b6e954c078698c77c3eba69a02b9961a0bf92982464e47c5716
+  metadata.gz: aa67c3fbb64dbfe632d82ba0306a1c935b047bdf645d28a59e87bc23a0873716bba3a5b75f2319400aa2db6d32995930ccb17c8721b5c8c0ed1b489e952959e1
+  data.tar.gz: 105d1246d676ba240f5ec1bb0fae9a44a39d99bbd554618d0a747ba1b41c00dbc8f7398db0733402afc0a0021593c0034f255fdacc5cc10eeb0b97b173e26d30

data/README.md

@@ -13,11 +13,6 @@ Include Comply in your gemfile:
 ```ruby
 gem 'comply'
 ```
-If you are using Rails 3, you need to include `strong_parameters`
-```ruby
-gem 'comply'
-gem 'strong_parameters'
-```
 Mount the engine in your `routes.rb`:
 ```ruby
 mount Comply::Engine => '/comply'
@@ -68,6 +63,45 @@ Want success messages to add some personality to your forms? Add the message as
 <%= f.text_field :title, data: { validate: true, validate_success: "Sweet title yo!" } %>
 ```
 
+### Validation contexts
+Supplementary reading on validation contexts:
+- [ActiveRecord Validations :on](http://guides.rubyonrails.org/active_record_validations.html#on)
+- [Also see api.rubyonrails.org](http://api.rubyonrails.org/classes/ActiveRecord/Validations.html#method-i-valid-3F)
+- [Mastering Rails Validations: Contexts](http://blog.arkency.com/2014/04/mastering-rails-validations-contexts/)
+
+By default, all validations run through Comply's `Comply::ValidationsController` will be in the `:comply` validation
+context. This gives you the option to modify how your application runs its validations. The most common way to use
+validation contexts, is when you want to skip a certain validation. Let's say we didn't want to check the uniqueness
+of a particular attribute when asking Comply to validate a model. You would do this:
+
+```ruby
+class SomeModel < ActiveRecord::Base
+  validates :my_attribute, uniqueness: true, unless: -> { validation_context == :comply }
+  # or perhaps you *ONLY* want to run the validation when in the :comply context
+  validates :other_attribute, numericality: true, on: :comply
+end
+```
+
+You now have the option to specify your own context if you inherit from `Comply::ValidationsController` if your
+model has a specific business case for needing to run/not-run a set of validations for a given context.
+
+```ruby
+class SomeController < Comply::ValidationsController
+  # ... snip
+  protected
+
+  def validation_context
+    :my_new_context
+  end
+end
+
+class SomeModel
+  validates :my_attribute, uniqueness: true, unless: -> { validation_context == :my_new_context }
+end
+```
+
+That's it!
+
 ### Event triggers
 You can change the jQuery event which triggers the input validation with the `data-validate-event` attribute.
 ```erb

data/app/assets/javascripts/comply/base_validatable_form.js.coffee

@@ -14,7 +14,7 @@ class Comply.BaseValidatableForm
     @validate inputs: @inputs, submit: true
 
   validate: (options) ->
-    $.get @validationRoute, @_params(), (response) =>
+    $.post @validationRoute, @_params(), (response) =>
       @_onValidate(response, options)
 
       if @_allSuccess(response)

data/app/controllers/comply/application_controller.rb

@@ -1,5 +1,4 @@
 module Comply
   class ApplicationController < ActionController::Base
-    include ::SslRequirement
   end
 end

data/app/controllers/comply/validations_controller.rb

@@ -1,24 +1,24 @@
-begin
-  require 'strong_parameters'
-rescue LoadError
-end
-
 module Comply
   class ValidationsController < Comply::ApplicationController
-    ssl_allowed :show
-
-    before_filter :require_model, :require_fields
+    before_action :require_model, :require_fields
 
     if ActiveModel.const_defined?(:ForbiddenAttributesProtection)
       include ActiveModel::ForbiddenAttributesProtection
     end
 
     def show
+      ActiveSupport::Deprecation.warn('GET support going away: use POST to access this endpoint') if request.request_method == 'GET'
       @instance = validation_instance
-      @instance.valid?
+      @instance.valid?(validation_context)
       render json: { error: @instance.errors }
     end
 
+    protected
+
+    def validation_context
+      :comply
+    end
+
     private
 
     def validation_instance

data/config/routes.rb

@@ -1,3 +1,5 @@
 Comply::Engine.routes.draw do
-  match '/validations' => 'validations#show', via: :get
+  match '/validations' => 'validations#show', via: [:get, :post]
+  # allow CORS requests
+  match 'validations', via: [:options], to: proc { [200, {}, ['']] }
 end

data/lib/comply.rb

@@ -1,5 +1,4 @@
 require 'comply/engine'
-require 'ssl_requirement'
 require 'comply/whitelist_constantize'
 
 module Comply

data/lib/comply/version.rb

@@ -1,3 +1,3 @@
 module Comply
-  VERSION = '1.5.0'
+  VERSION = '2.0.0'
 end

data/lib/comply/whitelist_constantize.rb

@@ -1,4 +1,4 @@
-require 'active_model/validations'
+require 'active_model'
 
 module Comply
   module WhitelistConstantize

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: comply
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 2.0.0
 platform: ruby
 authors:
 - "@jacobaweiss"
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-03 00:00:00.000000000 Z
+date: 2020-05-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: coffee-rails
@@ -28,36 +28,8 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: bartt-ssl_requirement
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.4.2
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.4.2
 - !ruby/object:Gem::Dependency
   name: rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 4.0.13
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 4.0.13
-- !ruby/object:Gem::Dependency
-  name: protected_attributes
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -88,16 +60,16 @@ dependencies:
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -155,10 +127,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.2.3
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Inline validation of your ActiveRecord models via the AJAX internets
 test_files: []
-has_rdoc: