completion-kit 0.28.3 → 0.28.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cf603335970a8ec820f2d5a40adbc2fc4d0606e59123e9ef7c2241c52e35f607
-  data.tar.gz: 6cb5a2156aaf7108fb9fd4ceac400199c0f93774b38c5e8b8be7e746dabb9c36
+  metadata.gz: 4206f8709997fb6c2e5055bcf2f201eda59d4de2c7c3ef15fc7f98dac4f92a21
+  data.tar.gz: 83e6756cc1f5ed0606d01f7e269e7157146a9efe539c7550f4dd33ace35914b0
 SHA512:
-  metadata.gz: c1977cdf2958e1facd7886830386cec116ab5a498337101f87d2d7f93842384e1370790b59d1eead00bff3f804a4990e3cfc36b8a8f20400e7e817632627b5e1
-  data.tar.gz: 38e6624b6190e40d4537f07971b2eed96754f95545872709e0788c31a784ad1430977833b0266cac2300ff551471d0dee9d422df547e727f0298afa549979a10
+  metadata.gz: 8edabb8604bbee9c38c9cf070add0732592c8392f686f8f224c8ca82cd7aef1d3a581011f41da48eb7cbd3cd0bd26a0331002483843183cf62e4167ea408689c
+  data.tar.gz: 2afb4955b727b0bca04939e4d2ce2a6fd61b25e66e3bbe843b39e48ca0a81be30fd845369b30c39b7c17d71d7029d947eb3221d78ca9f0f1faeba9e8eab0a179

data/app/assets/stylesheets/completion_kit/application.css

@@ -3206,12 +3206,10 @@ select.ck-input {
 
 .ck-run-compare-table th { white-space: nowrap; }
 .ck-run-compare-table th:nth-child(1) { width: 7rem; }
-.ck-run-compare-table th:nth-child(2) { width: auto; }
-.ck-run-compare-table th:nth-child(3) { width: 6rem; }
-.ck-run-compare-table th:nth-child(4) { width: 6rem; }
-.ck-run-compare-table th:nth-child(5) { width: 5rem; }
-.ck-run-compare-table th:nth-child(6) { width: 7rem; }
-.ck-run-compare-table th:nth-child(7) { width: 7rem; }
+.ck-run-compare-table th:nth-child(2) { width: 15rem; }
+.ck-run-compare-table th:nth-child(3) { width: 12rem; }
+.ck-run-compare-table th:nth-child(4) { width: 8rem; }
+.ck-run-compare-table th:nth-child(5) { width: auto; }
 
 .ck-run-compare-table th.ck-num,
 .ck-run-compare-table td.ck-num { text-align: right; }
@@ -3221,7 +3219,26 @@ select.ck-input {
   white-space: nowrap;
   overflow: hidden;
   text-overflow: ellipsis;
+  color: var(--ck-text);
+  font-weight: 500;
+}
+
+.ck-cmp-score__pair { display: inline-flex; align-items: center; gap: 0.45rem; }
+.ck-cmp-score__arrow { color: var(--ck-dim); font-size: 0.78rem; }
+.ck-cmp-score__link { display: inline-flex; text-decoration: none; border-radius: 7px; transition: box-shadow 0.12s ease; }
+.ck-cmp-score__link:hover { box-shadow: 0 0 0 1px var(--ck-accent); }
+.ck-cmp-score__none { color: var(--ck-dim); }
+
+.ck-cmp-delta .ck-delta { display: inline-flex; align-items: baseline; gap: 0.2rem; }
+.ck-delta__arrow { font-size: 0.72rem; }
+
+.ck-cmp-ver__one, .ck-cmp-ver__pair {
+  font-family: var(--ck-mono);
+  font-size: 0.78rem;
+  color: var(--ck-dim);
 }
+.ck-cmp-ver__pair { color: var(--ck-muted); }
+.ck-cmp-ver__arrow { color: var(--ck-dim); margin: 0 0.3rem; }
 
 .ck-compare-case { white-space: nowrap; }
 .ck-compare-case__num {

data/app/controllers/completion_kit/runs_controller.rb

@@ -16,7 +16,7 @@ module CompletionKit
       @responses_total = @run.responses.count
       @responses_per_page = RESPONSES_PER_PAGE
       @responses_total_pages = [(@responses_total.to_f / RESPONSES_PER_PAGE).ceil, 1].max
-      @responses_page = params[:page].to_i.clamp(1, @responses_total_pages)
+      @responses_page = params[:page].to_s.to_i.clamp(1, @responses_total_pages)
       @responses_offset = (@responses_page - 1) * RESPONSES_PER_PAGE
       @responses = ordered_responses_relation(@run, params[:sort])
                      .includes(:reviews)

data/app/jobs/completion_kit/model_discovery_job.rb

@@ -18,7 +18,7 @@ module CompletionKit
     discard_on ActiveJob::DeserializationError
 
     rescue_from(StandardError) do |error|
-      if error.is_a?(CompletionKit::ModelDiscoveryService::DiscoveryError)
+      unless error.is_a?(CompletionKit::ModelDiscoveryService::DiscoveryError)
         Rails.error.report(error, handled: true, context: { job: self.class.name, provider_credential_id: arguments.first })
       end
       credential = ProviderCredential.find_by(id: arguments.first)

data/app/services/completion_kit/model_discovery_service.rb

@@ -63,9 +63,19 @@ module CompletionKit
       return nil if body.blank?
       data = JSON.parse(body)
       err = data["error"]
-      (err.is_a?(Hash) && err["message"]) || data["message"] || (err.is_a?(String) && err) || nil
+      message = (err.is_a?(Hash) && err["message"]) || data["message"] || (err.is_a?(String) && err) || nil
+      redact_secrets(message)
     rescue JSON::ParserError
-      body.to_s.truncate(200)
+      redact_secrets(body.to_s.truncate(200))
+    end
+
+    def redact_secrets(text)
+      return text if text.blank?
+      redacted = text.to_s
+      redacted = redacted.gsub(@api_key, "[REDACTED]") if @api_key.present?
+      redacted = redacted.gsub(/\bsk-[A-Za-z0-9_-]{6,}/, "[REDACTED]")
+      redacted = redacted.gsub(/\bBearer\s+\S+/i, "Bearer [REDACTED]")
+      redacted.gsub(/(API key provided:\s*)\S+/i, '\1[REDACTED]')
     end
 
     def fetch_openai_models
@@ -336,11 +346,11 @@ module CompletionKit
         end
       else
         model.supports_generation = false
-        model.generation_error = "#{response.status} - #{response.body.truncate(500)}"
+        model.generation_error = redact_secrets("#{response.status} - #{response.body.truncate(500)}")
       end
     rescue StandardError => e
       model.supports_generation = false
-      model.generation_error = e.message
+      model.generation_error = redact_secrets(e.message)
     end
 
     def probe_judging(model)
@@ -364,11 +374,11 @@ module CompletionKit
         end
       else
         model.supports_judging = false
-        model.judging_error = "#{response.status} - #{response.body.truncate(500)}"
+        model.judging_error = redact_secrets("#{response.status} - #{response.body.truncate(500)}")
       end
     rescue StandardError => e
       model.supports_judging = false
-      model.judging_error = e.message
+      model.judging_error = redact_secrets(e.message)
     end
 
     OPENAI_REASONING_PROBE_BUDGET = 65_536

data/app/views/completion_kit/runs/_compare_score.html.erb

@@ -0,0 +1,12 @@
+<% has_value = kind == "check" ? !passed.nil? : score.present? %>
+<% if has_value && response %>
+  <%= link_to run_response_path(run, response), class: "ck-cmp-score__link", title: "#{side}: open this response (#{run.name})" do %>
+    <% if kind == "check" %>
+      <%= ck_check_badge(passed) %>
+    <% else %>
+      <span class="<%= ck_badge_classes(ck_score_kind(score.to_f)) %>"><%= score %></span>
+    <% end %>
+  <% end %>
+<% else %>
+  <span class="ck-cmp-score__none">—</span>
+<% end %>

data/app/views/completion_kit/runs/compare.html.erb

@@ -25,11 +25,9 @@
       <tr>
         <th scope="col">Case</th>
         <th scope="col">Metric</th>
-        <th scope="col">A score</th>
-        <th scope="col">B score</th>
+        <th scope="col">A → B</th>
         <th scope="col" class="ck-num">Δ</th>
-        <th scope="col">A version</th>
-        <th scope="col">B version</th>
+        <th scope="col">Version</th>
       </tr>
     </thead>
       <% @comparison[:rows].each do |row| %>
@@ -55,44 +53,25 @@
               </td>
             <% end %>
             <td class="ck-compare-metric" data-label="Metric" title="<%= pm[:metric_name] %>"><%= pm[:metric_name] %></td>
-            <td data-label="A score">
-              <% if pm[:kind] == "check" %>
-                <% if pm[:left_passed].nil? %>
-                  <span class="ck-meta-copy">—</span>
-                <% else %>
-                  <%= ck_check_badge(pm[:left_passed]) %>
-                <% end %>
-              <% elsif pm[:left_score] %>
-                <span class="<%= ck_badge_classes(ck_score_kind(pm[:left_score].to_f)) %>"><%= pm[:left_score] %></span>
-              <% else %>
-                <span class="ck-meta-copy">—</span>
-              <% end %>
-            </td>
-            <td data-label="B score">
-              <% if pm[:kind] == "check" %>
-                <% if pm[:right_passed].nil? %>
-                  <span class="ck-meta-copy">—</span>
-                <% else %>
-                  <%= ck_check_badge(pm[:right_passed]) %>
-                <% end %>
-              <% elsif pm[:right_score] %>
-                <span class="<%= ck_badge_classes(ck_score_kind(pm[:right_score].to_f)) %>"><%= pm[:right_score] %></span>
-              <% else %>
-                <span class="ck-meta-copy">—</span>
-              <% end %>
+            <td class="ck-cmp-score" data-label="A → B">
+              <span class="ck-cmp-score__pair">
+                <%= render "compare_score", kind: pm[:kind], passed: pm[:left_passed], score: pm[:left_score], response: row[:left_response], run: @run, side: "A" %>
+                <span class="ck-cmp-score__arrow" aria-hidden="true">→</span>
+                <%= render "compare_score", kind: pm[:kind], passed: pm[:right_passed], score: pm[:right_score], response: row[:right_response], run: @other_run, side: "B" %>
+              </span>
             </td>
-            <td class="ck-num" data-label="Δ">
+            <td class="ck-num ck-cmp-delta" data-label="Δ">
               <% if pm[:kind] == "check" %>
-                <%= ck_result_change_badge(pm[:result_change]) || content_tag(:span, "—", class: "ck-meta-copy") %>
+                <%= ck_result_change_badge(pm[:result_change]) || content_tag(:span, "—", class: "ck-cmp-score__none") %>
               <% elsif pm[:delta] %>
-                <% delta_class = pm[:delta] > 0 ? "ck-delta--positive" : pm[:delta] < 0 ? "ck-delta--negative" : "ck-delta--zero" %>
-                <span class="ck-delta <%= delta_class %>"><%= pm[:delta].positive? ? "+#{pm[:delta]}" : pm[:delta].to_s %></span>
+                <% d = pm[:delta] %>
+                <% dcls = d > 0 ? "ck-delta--positive" : d < 0 ? "ck-delta--negative" : "ck-delta--zero" %>
+                <span class="ck-delta <%= dcls %>"><span class="ck-delta__arrow" aria-hidden="true"><%= d > 0 ? "▲" : d < 0 ? "▼" : "=" %></span><%= d > 0 ? "+#{d}" : d.to_s %></span>
               <% else %>
-                <span class="ck-meta-copy">—</span>
+                <span class="ck-cmp-score__none">—</span>
               <% end %>
             </td>
-            <td data-label="A version"><% if pm[:left_version_label] %><span class="ck-source-chip ck-source-chip--current"><%= pm[:left_version_label] %></span><% end %></td>
-            <td data-label="B version"><% if pm[:right_version_label] %><span class="ck-source-chip ck-source-chip--current"><%= pm[:right_version_label] %></span><% end %></td>
+            <td class="ck-cmp-ver" data-label="Version"><% lv = pm[:left_version_label]; rv = pm[:right_version_label] %><% if lv && rv && lv != rv %><span class="ck-cmp-ver__pair"><%= lv %><span class="ck-cmp-ver__arrow" aria-hidden="true">→</span><%= rv %></span><% elsif lv || rv %><span class="ck-cmp-ver__one"><%= lv || rv %></span><% end %></td>
           </tr>
         <% end %>
         </tbody>

data/lib/completion_kit/version.rb

@@ -1,3 +1,3 @@
 module CompletionKit
-  VERSION = "0.28.3"
+  VERSION = "0.28.5"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: completion-kit
 version: !ruby/object:Gem::Version
-  version: 0.28.3
+  version: 0.28.5
 platform: ruby
 authors:
 - Damien Bastin
@@ -407,6 +407,7 @@ files:
 - app/views/completion_kit/provider_credentials/statuses.turbo_stream.erb
 - app/views/completion_kit/responses/show.html.erb
 - app/views/completion_kit/runs/_actions.html.erb
+- app/views/completion_kit/runs/_compare_score.html.erb
 - app/views/completion_kit/runs/_form.html.erb
 - app/views/completion_kit/runs/_response_row.html.erb
 - app/views/completion_kit/runs/_row.html.erb