completion-kit 0.28.10 → 0.28.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8eb41960ab1c047932e577095faa9bd23518a82b2a23ee30c84f862a32afc2d5
-  data.tar.gz: e4d577875390f29ca7b5ddd78415734fabe9d1b1de910a83ad925248d9a14809
+  metadata.gz: b2a34fdd9be7c2b821c749f4bdf7bc8433a774505f5351ed7fd605135a71f7fd
+  data.tar.gz: 906ccf1371d03af5a758a66464ffca8924ab4df36653113ea08a087f47237758
 SHA512:
-  metadata.gz: 3e820588ee5b204628a8b317d4ce9d66f66053795d9159c6c90ea325c9ac45cf940cb01ba09878cc85cd298b452090f6309654afe3a4db946bff9212a88ee85f
-  data.tar.gz: 351ea8ff2c5012dfc5221d5dd4daf27e454b90d7c7cf63ac9839e76bc69e3f9e3b6e363331a257d9c65ba8bb73e375e1c9953cba36b875fbeb6f3c38583a1735
+  metadata.gz: 4a5a11320e41d14a8de77fc2ad38e60830e6de94aa60e539d517963c9089f8538ccb82abce9f3274976aad5030e2468615ecbbb5b081507e3ecfc222aa3471c6
+  data.tar.gz: 5d0d2496547c1b834218b1eed208a186eff5f1cd82924eae22753740d78817609808afb249c25fd66cd7132c26963ce625e921c95803d7cadcf63029c1b8c7f4

data/app/controllers/completion_kit/api/v1/datasets_controller.rb

@@ -3,6 +3,7 @@ module CompletionKit
     module V1
       class DatasetsController < BaseController
         before_action :set_dataset, only: [:show, :update, :destroy]
+        before_action :reject_oversized_upload, only: [:create, :update]
 
         def index
           scope = Dataset.includes(:tags)
@@ -50,6 +51,13 @@ module CompletionKit
           permitted[:csv_data] = upload.read.to_s.force_encoding("UTF-8") if upload.respond_to?(:read)
           permitted
         end
+
+        def reject_oversized_upload
+          upload = params[:file]
+          return unless upload.respond_to?(:size) && upload.size > CompletionKit.config.max_upload_bytes
+
+          render_error("File exceeds the #{CompletionKit.config.max_upload_bytes / (1024 * 1024)} MB upload limit", status: :payload_too_large)
+        end
       end
     end
   end

data/app/controllers/completion_kit/imports_controller.rb

@@ -4,6 +4,11 @@ module CompletionKit
     end
 
     def create
+      if upload_too_large?(params[:file])
+        flash.now[:alert] = "That file is too large. The limit is #{CompletionKit.config.max_upload_bytes / (1024 * 1024)} MB."
+        return render :new, status: :payload_too_large
+      end
+
       content = uploaded_content
 
       if content.blank?
@@ -27,5 +32,9 @@ module CompletionKit
       file = params[:file]
       file.respond_to?(:read) ? file.read : params[:config]
     end
+
+    def upload_too_large?(file)
+      file.respond_to?(:size) && file.size > CompletionKit.config.max_upload_bytes
+    end
   end
 end

data/app/models/completion_kit/dataset.rb

@@ -6,6 +6,14 @@ module CompletionKit
 
     validates :name, presence: true
     validates :csv_data, presence: true
+    validate :csv_data_within_size_limit
+
+    def csv_data_within_size_limit
+      return if csv_data.blank?
+      return if csv_data.bytesize <= CompletionKit.config.max_upload_bytes
+
+      errors.add(:csv_data, "is too large (limit #{CompletionKit.config.max_upload_bytes / (1024 * 1024)} MB)")
+    end
 
     def as_json(options = {})
       {
@@ -19,9 +27,13 @@ module CompletionKit
       return 0 if csv_data.blank?
 
       require "csv"
-      ::CSV.parse(csv_data, headers: true).length
-    rescue ::CSV::MalformedCSVError
-      0
+      @row_count ||= begin
+        count = 0
+        ::CSV.new(csv_data, headers: true).each { count += 1 }
+        count
+      rescue ::CSV::MalformedCSVError
+        0
+      end
     end
 
     def headers

data/app/models/completion_kit/run.rb

@@ -116,16 +116,19 @@ module CompletionKit
       end
     end
 
+    def reviews_for_summary
+      @reviews_for_summary ||= Review.where(response_id: responses.select(:id)).to_a
+    end
+
     def avg_score
-      all_reviews = responses.flat_map(&:reviews)
-      scores = all_reviews.map(&:ai_score).compact.map(&:to_f)
+      scores = reviews_for_summary.map(&:ai_score).compact.map(&:to_f)
       return nil if scores.empty?
 
       (scores.sum / scores.length).round(2)
     end
 
     def metric_averages
-      responses.flat_map(&:reviews).group_by(&:metric_name).filter_map do |name, reviews|
+      reviews_for_summary.group_by(&:metric_name).filter_map do |name, reviews|
         scored = reviews.select { |r| r.ai_score.present? }
         if scored.any?
           scores = scored.map { |r| r.ai_score.to_f }
@@ -141,7 +144,7 @@ module CompletionKit
     end
 
     def check_pass_rate
-      resolved = responses.flat_map(&:reviews).reject { |r| r.passed.nil? }
+      resolved = reviews_for_summary.reject { |r| r.passed.nil? }
       return nil if resolved.empty?
 
       passed = resolved.count { |r| r.passed == true }

data/app/services/completion_kit/promptfoo_importer.rb

@@ -16,6 +16,10 @@ module CompletionKit
     end
 
     def call
+      if @content.bytesize > CompletionKit.config.max_upload_bytes
+        return failure("The import is too large. The limit is #{CompletionKit.config.max_upload_bytes / (1024 * 1024)} MB.")
+      end
+
       config = parse
       return failure("Could not parse YAML: #{@parse_error}") if config.nil?
       return failure("Top-level YAML must be a mapping of promptfoo config keys.") unless config.is_a?(Hash)
@@ -34,7 +38,7 @@ module CompletionKit
     private
 
     def parse
-      YAML.safe_load(@content, aliases: true)
+      YAML.safe_load(@content)
     rescue Psych::Exception => e
       @parse_error = e.message
       nil

data/app/views/completion_kit/runs/show.html.erb

@@ -14,10 +14,6 @@
   </div>
 <% end %>
 
-<% if @run.dataset %>
-  <% dataset_lines = @run.dataset.csv_data.to_s.lines %>
-  <% dataset_preview_lines = dataset_lines.first(50) %>
-<% end %>
 
 <% if CompletionKit.config.judge_agreement_enabled %>
   <% stale_summary = @run.stale_review_summary %>
@@ -130,16 +126,22 @@
       <div class="ck-modal__body">
         <%
           require "csv"
-          parsed_rows = []
           parse_error = nil
+          headers = []
+          body_rows = []
+          remaining = 0
           begin
-            parsed_rows = ::CSV.parse(@run.dataset.csv_data.to_s)
+            reader = ::CSV.new(@run.dataset.csv_data.to_s)
+            headers = reader.shift || []
+            50.times do
+              row = reader.shift
+              break unless row
+              body_rows << row
+            end
+            remaining = [@run.dataset.row_count - body_rows.length, 0].max
           rescue ::CSV::MalformedCSVError => e
             parse_error = e.message
           end
-          headers = parsed_rows.first || []
-          body_rows = parsed_rows.drop(1).first(50)
-          remaining = parsed_rows.drop(1).count - body_rows.count
         %>
         <% if parse_error %>
           <p class="ck-field-hint" style="color: var(--ck-warning); padding: 1rem;">Could not parse CSV: <%= parse_error %></p>

data/lib/completion_kit/version.rb

@@ -1,3 +1,3 @@
 module CompletionKit
-  VERSION = "0.28.10"
+  VERSION = "0.28.12"
 end

data/lib/completion_kit.rb

@@ -11,7 +11,7 @@ module CompletionKit
     attr_accessor :tenant_scope, :tenant_scope_columns
     attr_accessor :api_reference_authentication_partial
     attr_accessor :runs_display_scope, :runs_display_footer_partial
-    attr_accessor :api_rate_limit, :web_rate_limit
+    attr_accessor :api_rate_limit, :web_rate_limit, :max_upload_bytes
     attr_accessor :allow_loopback_endpoints
     attr_accessor :judge_agreement_enabled
     attr_accessor :judge_examples_from_reviews
@@ -30,6 +30,7 @@ module CompletionKit
 
       @api_rate_limit = 120
       @web_rate_limit = 300
+      @max_upload_bytes = 25 * 1024 * 1024
 
       @allow_loopback_endpoints = true
       @judge_agreement_enabled = true

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: completion-kit
 version: !ruby/object:Gem::Version
-  version: 0.28.10
+  version: 0.28.12
 platform: ruby
 authors:
 - Damien Bastin