completion-kit 0.27.9 → 0.28.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3c963af7241cc97480aa462a422e3c34fb2f25ea813a380083443e68678f724b
-  data.tar.gz: 8a20da4fd8a0fac0e6395816cd65a4bc79ebf48756439414a343467f41ab2c2b
+  metadata.gz: 49de7d9ec92e8fb633cebd08ad79baeb32158864beeb06796321b909f862dcfe
+  data.tar.gz: 47a798af3557ca3e95dc0f0897e032aa121f0014824cc71bbd71dace49437bdd
 SHA512:
-  metadata.gz: a9575cfcb4ef088a9e34c92d9852341f69eff3130f2d0e7845fc6517ce939dd9f8252c7c7722946b106de72dc2ad281388a0fc4a63134d8d8e69b9d037506825
-  data.tar.gz: 4050b952aea1c85a1871de868218fb9637cd662d30e4b1508f47ef2920f5d7e57c12b21b8a09c6cc7d0bc6e718f05032938ae6b47733767fcb458d3ccf374949
+  metadata.gz: 4a94dae22a11aa716352e8b5f44109479ad87af5a7928ea1d98ce095beccc46468fb02c79fe5afc7c044616eba4b260931c2a309ea15bbb916aa44bbc5bc3f56
+  data.tar.gz: a9a8920af149a4aad600ce8b95635fd89abf678d76e8bd84e69a462e73ec1588c29cb71a82f4159928e058f671487fe21c109f2cf7026eebde57a41c6ea94af4

data/app/assets/stylesheets/completion_kit/application.css

@@ -286,6 +286,13 @@ form.button_to {
   margin-top: 0.45rem;
 }
 
+.ck-pagination {
+  display: flex;
+  align-items: center;
+  gap: 1rem;
+  margin-top: 1rem;
+}
+
 .ck-title,
 .ck-section-title,
 .ck-card-title,

data/app/controllers/completion_kit/runs_controller.rb

@@ -10,8 +10,18 @@ module CompletionKit
       @runs = apply_tag_filter(scope)
     end
 
+    RESPONSES_PER_PAGE = 100
+
     def show
-      @responses = ordered_responses_relation(@run, params[:sort]).includes(:reviews)
+      @responses_total = @run.responses.count
+      @responses_per_page = RESPONSES_PER_PAGE
+      @responses_total_pages = [(@responses_total.to_f / RESPONSES_PER_PAGE).ceil, 1].max
+      @responses_page = params[:page].to_i.clamp(1, @responses_total_pages)
+      @responses_offset = (@responses_page - 1) * RESPONSES_PER_PAGE
+      @responses = ordered_responses_relation(@run, params[:sort])
+                     .includes(:reviews)
+                     .limit(RESPONSES_PER_PAGE)
+                     .offset(@responses_offset)
     end
 
     def new

data/app/helpers/completion_kit/application_helper.rb

@@ -29,16 +29,15 @@ module CompletionKit
       "#{base} #{styles}"
     end
 
-    def ck_delete_trigger(form_id:, label:, confirm: nil, disabled: false, title: nil)
+    def ck_delete_trigger(form_id:, label:, confirm: nil)
       content_tag(
         :button,
         type: "submit",
-        form: (disabled ? nil : form_id),
+        form: form_id,
         class: "ck-icon-btn",
-        title: title || label,
+        title: label,
         "aria-label": label,
-        disabled: disabled,
-        data: (disabled ? {} : {turbo_confirm: confirm, ck_confirm_label: "Delete", ck_confirm_tone: "danger"})
+        data: {turbo_confirm: confirm, ck_confirm_label: "Delete", ck_confirm_tone: "danger"}
       ) do
         heroicon_tag "trash", variant: :outline, size: 16, "aria-hidden": "true"
       end

data/app/models/completion_kit/provider_credential.rb

@@ -99,7 +99,7 @@ module CompletionKit
       parts = []
       parts << "#{prompt_count} #{'prompt'.pluralize(prompt_count)}" if prompt_count.positive?
       parts << "#{judge_count} judge #{'run'.pluralize(judge_count)}" if judge_count.positive?
-      "#{display_provider} is still in use by #{parts.to_sentence}. Remove those references before deleting it."
+      "#{display_provider} is in use by #{parts.to_sentence} and can't be deleted."
     end
 
     def broadcast_discovery_progress

data/app/models/completion_kit/run.rb

@@ -201,7 +201,6 @@ module CompletionKit
         end
       end
 
-      failed_row = nil
       begin
         transaction do
           responses.destroy_all
@@ -212,37 +211,46 @@ module CompletionKit
             failure_summary: nil,
             error_message: nil
           )
-          rows.each_with_index do |row, index|
-            failed_row = index
-            input = row.empty? ? nil : row.to_json
-            attrs = {
-              status: "pending",
-              row_index: index,
-              input_data: input,
-              expected_output: row[expected_column.presence || "expected_output"]
-            }
-            if judge_only?
-              attrs[:status] = "succeeded"
-              column = output_column.presence || "actual_output"
-              attrs[:response_text] = row[column].to_s if dataset && dataset.headers.include?(column)
-            end
 
-            response = responses.create!(attrs)
-
-            if judge_only?
-              llm_metrics.each { |m| JudgeReviewJob.perform_later(response.id, m.id, id) } if llm_judge_configured?
-              check_metrics.each { |m| CheckReviewJob.perform_later(response.id, m.id, id) }
-            else
-              GenerateRowJob.perform_later(id, response.id)
+          now = Time.current
+          out_col = output_column.presence || "actual_output"
+          exp_col = expected_column.presence || "expected_output"
+          judge = judge_only?
+          has_output = judge && dataset && dataset.headers.include?(out_col)
+          scope_defaults = Response.all.where_values_hash.symbolize_keys
+
+          response_attrs = rows.each_with_index.map do |row, index|
+            {
+              run_id: id,
+              status: judge ? "succeeded" : "pending",
+              row_index: index,
+              input_data: row.empty? ? nil : row.to_json,
+              expected_output: row[exp_col],
+              response_text: (judge && has_output ? row[out_col].to_s : nil),
+              attempts: 0,
+              created_at: now,
+              updated_at: now
+            }.merge(scope_defaults)
+          end
+          Response.insert_all(response_attrs)
+          responses.reset
+
+          response_ids = responses.order(:row_index).pluck(:id)
+          if judge
+            judge_metrics = llm_judge_configured? ? llm_metrics.to_a : []
+            chk_metrics = check_metrics.to_a
+            response_ids.each do |rid|
+              judge_metrics.each { |m| JudgeReviewJob.perform_later(rid, m.id, id) }
+              chk_metrics.each { |m| CheckReviewJob.perform_later(rid, m.id, id) }
             end
+            RunCompletionCheckJob.perform_later(id)
+          else
+            response_ids.each { |rid| GenerateRowJob.perform_later(id, rid) }
           end
-
-          RunCompletionCheckJob.perform_later(id) if judge_only?
         end
       rescue ActiveRecord::RecordInvalid => e
         reload
-        detail = e.record.errors.full_messages.to_sentence
-        return fail_with_summary!(failed_row ? "Row #{failed_row + 1}: #{detail}" : detail)
+        return fail_with_summary!(e.record.errors.full_messages.to_sentence)
       end
 
       safely_broadcast do

data/app/views/completion_kit/provider_credentials/_form.html.erb

@@ -1,6 +1,5 @@
 <% if provider_credential.persisted? %>
   <% pc_delete_id = "ck_delete_provider_#{provider_credential.id}" %>
-  <% pc_delete_blocked = provider_credential.in_use? %>
   <% pc_delete_confirm = "Delete the #{provider_credential.display_provider} provider and its discovered models? This can't be undone." %>
 <% end %>
 <%= form_with(model: provider_credential, local: true) do |form| %>
@@ -37,24 +36,21 @@
       <%= form.label :api_version, "API version", class: "ck-label" %>
       <%= form.text_field :api_version, class: "ck-input", placeholder: "e.g. 2024-10-21", **ck_field_aria(form, :api_version) %>
       <%= ck_field_error(form, :api_version) %>
-      <p class="ck-field-hint">Optional. Leave blank to use Azure's v1 API, or set a dated version for the legacy API (which also lists your deployments during discovery).</p>
+      <p class="ck-field-hint">Optional. Leave blank to use Azure's v1 API.</p>
     </div>
 
     <div class="ck-actions">
       <% if provider_credential.persisted? %>
-        <%= ck_delete_trigger(form_id: pc_delete_id, label: "Delete provider", confirm: pc_delete_confirm, disabled: pc_delete_blocked, title: (pc_delete_blocked ? provider_credential.in_use_message : "Delete provider")) %>
+        <%= ck_delete_trigger(form_id: pc_delete_id, label: "Delete provider", confirm: pc_delete_confirm) %>
       <% end %>
       <%= link_to "Cancel", provider_credentials_path, class: ck_button_classes(:light, variant: :outline), tabindex: "0" %>
       <%= form.submit(provider_credential.persisted? ? "Save provider" : "Create provider", class: ck_button_classes(:dark)) %>
     </div>
-    <% if provider_credential.persisted? && pc_delete_blocked %>
-      <p class="ck-field-hint"><%= provider_credential.in_use_message %></p>
-    <% end %>
 
   </div>
 <% end %>
 
-<% if provider_credential.persisted? && !pc_delete_blocked %>
+<% if provider_credential.persisted? %>
   <%= render "completion_kit/shared/delete_form", form_id: pc_delete_id, path: provider_credential_path(provider_credential) %>
 <% end %>
 

data/app/views/completion_kit/runs/show.html.erb

@@ -197,11 +197,23 @@
   </thead>
   <tbody id="run_responses">
     <% @responses.each_with_index do |response, idx| %>
-      <%= render "response_row", run: @run, response: response, index: idx + 1 %>
+      <%= render "response_row", run: @run, response: response, index: @responses_offset + idx + 1 %>
     <% end %>
   </tbody>
 </table>
 
+<% if @responses_total_pages > 1 %>
+  <nav class="ck-pagination" aria-label="Response pages">
+    <% if @responses_page > 1 %>
+      <%= link_to run_path(@run, page: @responses_page - 1, sort: params[:sort]), class: ck_button_classes(:light, variant: :outline) do %>&larr; Prev<% end %>
+    <% end %>
+    <span class="ck-meta-copy">Page <%= @responses_page %> of <%= @responses_total_pages %> &middot; <%= pluralize(@responses_total, "response") %></span>
+    <% if @responses_page < @responses_total_pages %>
+      <%= link_to run_path(@run, page: @responses_page + 1, sort: params[:sort]), class: ck_button_classes(:light, variant: :outline) do %>Next &rarr;<% end %>
+    <% end %>
+  </nav>
+<% end %>
+
 <% if @run.status.in?(%w[pending running]) %>
   <script>
     (function() {

data/lib/completion_kit/version.rb

@@ -1,3 +1,3 @@
 module CompletionKit
-  VERSION = "0.27.9"
+  VERSION = "0.28.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: completion-kit
 version: !ruby/object:Gem::Version
-  version: 0.27.9
+  version: 0.28.0
 platform: ruby
 authors:
 - Damien Bastin