completely 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c09f951fc28b18f24c2c28fd7c80a15b3731aa07456145ab905c63c2b0dc9634
-  data.tar.gz: a9a25173ab3358e7eea42fe38552cbced8c6602bf5a0e9e6c414555420ae7af6
+  metadata.gz: e8b8cc9f26134e125f8d8ec1d24081bdd3c22217e916c9233b00b471381fadc6
+  data.tar.gz: a161403557ba173302233a3f4c3a4b61b084157f648709b1c79627f48aac9c97
 SHA512:
-  metadata.gz: b6edd13c5a0084485b7cb7114c45cf30d8c144075a3791aa51a8f5e7fc71df825cb03cb4786bc8fb3832f7bc1a46f06876614493184c4602d7e2e0dfbd3d4854
-  data.tar.gz: f8eb6cb08636c4281b50d7542d3c92fc8c6914e10597605f48e29ae342b6fb8cd31fff84de9e81dc0a7011bd5e963469c11fe025719e537238883d0a5812b5d9
+  metadata.gz: 22d3aa7b9db836ed7977d8888f46412184ea05d8de95632476275b6a33905308556d240014e816a01c47d9d56a35dd3181aec02eec149996587803db3fc47699
+  data.tar.gz: a0796eedf218a01c54ba31cdb63a7a9db747ec83eb5f37726fcd67e9b201291b3f6856b28a0323310bbaf613dec3f710a2d667b6ee02751d38d391e20c079287

data/README.md

@@ -13,7 +13,10 @@ This tool is for you if:
 
 1. You develop your own command line tools.
 2. Your life feels empty without bash completions.
-3. Bash completion scripts scare you.
+3. Bash completion scripts seem overly complex to you.
+
+Note that if you are building bash command line scripts with [bashly][bashly],
+then this functionality is already integrated with it.
 
 ---
 
@@ -92,7 +95,7 @@ For more options (like setting input/output path), run
 $ completely --help
 ```
 
-### Suggesting files and directories
+### Suggesting files, directories and other bash built-ins
 
 You may have noticed that the sample file contains two special entries:
 
@@ -103,6 +106,33 @@ These patterns will add the list of files and directories
 (when `<file>` is used) or just directories (when `<directory>` is used) to
 the list of suggestions.
 
+You may add any of the below keywords to add additional suggestions:
+
+| Keyword     | Meaning
+|-------------|---------------------
+| `<alias>`     | Alias names
+| `<arrayvar>`  | Array variable names
+| `<binding>`   | Readline key binding names
+| `<builtin>`   | Names of shell builtin commands
+| `<command>`   | Command names
+| `<directory>` | Directory names
+| `<disabled>`  | Names of disabled shell builtins
+| `<enabled>`   | Names of enabled shell builtins
+| `<export>`    | Names of exported shell variables
+| `<file>`      | File names
+| `<function>`  | Names of shell functions
+| `<group>`     | Group names
+| `<helptopic>` | Help topics as accepted by the help builtin
+| `<hostname>`  | Hostnames, as taken from the file specified by the HOSTFILE shell variable
+| `<job>`       | Job names
+| `<keyword>`   | Shell reserved words
+| `<running>`   | Names of running jobs
+| `<service>`   | Service names
+| `<signal>`    | Signal names
+| `<stopped>`   | Names of stopped jobs
+| `<user>`      | User names
+| `<variable>`  | Names of all shell variables
+
 For those interested in the technical details, any word between `<...>` will
 simply be added using the [`compgen -A action`][compgen] function, so you can 
 in fact use any of its supported arguments.
@@ -152,3 +182,4 @@ to contribute, feel free to [open an issue][issues].
 
 [issues]: https://github.com/DannyBen/completely/issues
 [compgen]: https://www.gnu.org/software/bash/manual/html_node/Programmable-Completion-Builtins.html
+[bashly]: https://github.com/DannyBen/bashly

data/lib/completely.rb

@@ -3,5 +3,5 @@ if ENV['BYEBUG']
   require 'lp'
 end
 
-# requires 'completely'
+require 'completely/pattern'
 require 'completely/completions'

data/lib/completely/completions.rb

@@ -15,6 +15,10 @@ module Completely
       @config, @function_name = config, function_name
     end
 
+    def patterns
+      @patterns ||= patterns!
+    end
+
     def script
       ERB.new(template, trim_mode: '%-').result(binding)
     end
@@ -32,6 +36,12 @@ module Completely
 
   private
 
+    def patterns!
+      config.map do |text, completions|
+        Pattern.new text, completions
+      end.sort_by { |pattern| -pattern.length }
+    end
+
     def template_path
       @template_path ||= File.expand_path("template.erb", __dir__)
     end
@@ -41,11 +51,7 @@ module Completely
     end
 
     def command
-      @command ||= config.keys.first
-    end
-
-    def patterns
-      @patterns ||= config.to_a.sort_by { |k, v| -k.size }.to_h
+      @command ||= config.keys.first.split(' ').first
     end
 
     def function_name

data/lib/completely/pattern.rb

@@ -0,0 +1,42 @@
+module Completely
+  class Pattern
+    attr_reader :text, :completions
+
+    def initialize(text, completions)
+      @text = text
+      @completions = completions || []
+    end
+
+    def length
+      @length ||= text.size
+    end
+
+    def empty?
+      completions.empty?
+    end
+
+    def words
+      @words ||= completions.reject { |w| w =~ /^<.*>$/ }
+    end
+
+    def actions
+      @actions ||= completions.filter_map do |word|
+        action = word[/^<(.+)>$/, 1]
+        "-A #{action}" if action
+      end
+    end
+
+    def compgen
+      @comgen ||= compgen!
+    end
+
+  private
+
+    def compgen!
+      result = []
+      result << %Q[#{actions.join ' '}] if actions.any?
+      result << %Q[-W "#{words.join ' '}"] if words.any?
+      result.any? ? result.join(' ') : nil
+    end
+  end
+end

data/lib/completely/template.erb

@@ -7,12 +7,9 @@
   local cur=${COMP_WORDS[COMP_CWORD]}
 
   case "$COMP_LINE" in
-% patterns.each do |pattern, words|
-% next unless words
-% clean_words = words.reject { |w| w =~ /^<.*>$/ }.join " "
-% functions = words.filter_map { |w| func = w[/^<(.+)>$/, 1] ; "-A #{func}" if func }
-% flags = functions.any? ? "#{functions.join ' '} -W" : "-W"
-    '<%= pattern %>'*) COMPREPLY=($(compgen <%= flags %> "<%= clean_words %>" -- "$cur")) ;;
+% patterns.each do |pattern|
+% next if pattern.empty?
+    '<%= pattern.text %>'*) COMPREPLY=($(compgen <%= pattern.compgen %> -- "$cur")) ;;
 % end
   esac
 }

data/lib/completely/version.rb

@@ -1,3 +1,3 @@
 module Completely
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: completely
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Danny Ben Shitrit
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-07-20 00:00:00.000000000 Z
+date: 2021-07-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: colsole
@@ -51,6 +51,7 @@ files:
 - lib/completely/cli.rb
 - lib/completely/command.rb
 - lib/completely/completions.rb
+- lib/completely/pattern.rb
 - lib/completely/sample.yaml
 - lib/completely/template.erb
 - lib/completely/version.rb