compare_linker 1.1.4 → 1.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 47654b7ad39f88145694628f36f54bf1a0063a5d
-  data.tar.gz: cff0a2c629e0a4050d83a30e74f58c4738ed357b
+  metadata.gz: c0ff36e8002d51aa16c9c31b9d187f564eac1d53
+  data.tar.gz: 8adab281e5f6a8fcb53c41041a566b45a98235e7
 SHA512:
-  metadata.gz: aa2743c90967af73d6ac6fb7506871d35dd908e80e23703dc5d9c765d0ba7d85f584e54d93858f69e6538bc4bdbde3d49c8ab5f6fa10b61fd28f74e52017f2a3
-  data.tar.gz: 821f8334ea9caffe17e689fa7c66a3eab847471557b231440cfed1b5aa82b0e47f399273bbb3f6816c759fdcbca672ff162d4c0c5ea7a82ab074711cc190fae6
+  metadata.gz: bb90094ecc911eecad452ed5967cd700fd9c1646da356ba2d36d1dbb5832a55196e7af9e4935772ec0dcc98e763c919321b19f815b7606253937ebfaf26d339a
+  data.tar.gz: 75da3f152b86ce87b961df282d882c84c26c2c5da57f28c194cddd325025b79977c936c7283dfad148aea476adebd0a7869c84b5dbd8ff570f9acd9ffacb0cd6

data/Gemfile.lock

@@ -1,14 +1,14 @@
 PATH
   remote: .
   specs:
-    compare_linker (1.1.4)
+    compare_linker (1.1.5)
       httpclient
       octokit
 
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.3.7)
+    addressable (2.3.8)
     diff-lcs (1.2.5)
     faraday (0.9.1)
       multipart-post (>= 1.2, < 3)

data/lib/compare_linker/github_link_finder.rb

@@ -1,6 +1,5 @@
 require "json"
 require "httpclient"
-require "net/http"
 
 class CompareLinker
   class GithubLinkFinder
@@ -12,7 +11,7 @@ class CompareLinker
 
     def find(gem_name)
       gem_info = JSON.parse(
-        HTTPClient.get("https://rubygems.org/api/v1/gems/#{gem_name}.json").body
+        HTTPClient.get_content("https://rubygems.org/api/v1/gems/#{gem_name}.json")
       )
 
       github_url = [
@@ -23,7 +22,6 @@ class CompareLinker
       if github_url.nil?
         @homepage_uri = gem_info["homepage_uri"]
       else
-        github_url = redirect_url(github_url)
         _, @repo_owner, @repo_name = github_url.match(%r!github\.com/([^/]+)/([^/]+)!).to_a
       end
 
@@ -34,20 +32,5 @@ class CompareLinker
     def repo_full_name
       "#{@repo_owner}/#{repo_name}"
     end
-
-    private
-
-    def redirect_url(url, limit = 5)
-      raise ArgumentError, 'HTTP redirect too deep' if limit <= 0
-      response = Net::HTTP.get_response(URI.parse(url))
-      case response
-      when Net::HTTPSuccess
-        url
-      when Net::HTTPRedirection
-        redirect_url(response['location'], limit - 1)
-      else
-        raise ItemNotFound
-      end
-    end
   end
 end

data/lib/compare_linker/version.rb

@@ -1,3 +1,3 @@
 class CompareLinker
-  VERSION = "1.1.4"
+  VERSION = "1.1.5"
 end

data/spec/lib/compare_linker/github_link_finder_spec.rb

@@ -8,7 +8,7 @@ describe CompareLinker::GithubLinkFinder do
 
   describe "#find" do
     before do
-      allow(HTTPClient).to receive_message_chain(:get, :body).and_return load_fixture("rails.json")
+      allow(HTTPClient).to receive(:get_content).and_return load_fixture("rails.json")
     end
 
     it "extracts repo_owner and repo_name" do
@@ -19,7 +19,7 @@ describe CompareLinker::GithubLinkFinder do
 
     context "if github url includes trailing slash" do
       before do
-        allow(HTTPClient).to receive_message_chain(:get, :body).and_return load_fixture("web_translate_it.json")
+        allow(HTTPClient).to receive(:get_content).and_return load_fixture("web_translate_it.json")
       end
 
       it "extracts repo_owner and repo_name without trailing slash" do
@@ -31,7 +31,7 @@ describe CompareLinker::GithubLinkFinder do
 
     context "if gem not found on rubygems.org" do
       before do
-        allow(HTTPClient).to receive_message_chain(:get, :body).and_return load_fixture("not_found.json")
+        allow(HTTPClient).to receive(:get_content).and_return load_fixture("not_found.json")
       end
 
       it "extracts homepage_uri" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: compare_linker
 version: !ruby/object:Gem::Version
-  version: 1.1.4
+  version: 1.1.5
 platform: ruby
 authors:
 - Kensuke Nagae
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-24 00:00:00.000000000 Z
+date: 2015-03-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: octokit