companies_house_hub 0.0.16 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 459ca3719258db949f31567bc66d0e69b1a7f2d156651cdd37601e9f6215aa6d
-  data.tar.gz: 350813f829c850f146e9a3c490eaf7fb6fe6f890298314e9011617c6f80736c4
+  metadata.gz: 15368ba8f4030e66bbd7a356116063606bbe8ae0c3a58172fe27bcad307ea327
+  data.tar.gz: 30026ddb39dcbc297f3a41c13cdf54e36113341cd97a013a2b857f9b4f10769b
 SHA512:
-  metadata.gz: 8ad3bf8ab66493eb57810a175282d220186dfd1e11c9b47fac103270bbfcb9f0d84fd8f1d2b38b81bb37a08bf92cdd3f1bda4eb32fadba367e466184fe2be201
-  data.tar.gz: 1036d35e98f785ceb40479ca5b0096c161cc5fe2e6c6a477674fb7271dda2c827822a882cef8dd66ab119f4baa40a88d94f1d18f17fe12cd3fc1bc5e7cbf631a
+  metadata.gz: e6297b90251e9fba7eae29c2f571324c5e87c8c425810664433dc15e88fd6871fa21468703396fd7b6f6c42bcae54cead9fc5b5ccf36f352d3074f6d1980f05d
+  data.tar.gz: 177853a604528af01f3cb04ca8426d2a0911f5d17a04f98db70704890e0958eb22809cb15a0b6c799fa3133d5107c70d9a39e94fea355b2c4ee11e98a31dae7f

data/lib/companies_house_hub.rb

@@ -4,7 +4,7 @@ require 'faraday'
 require 'faraday_middleware'
 require 'companies_house_hub/configuration'
 require 'companies_house_hub/base_model'
-
+require 'companies_house_hub/errors'
 require 'companies_house_hub/models/company'
 
 module CompaniesHouseHub

data/lib/companies_house_hub/base_model.rb

@@ -1,9 +1,15 @@
 # frozen_string_literal: true
 
+require 'companies_house_hub/errors'
+
 module CompaniesHouseHub
   class BaseModel
     def self.get(path, params)
-      CompaniesHouseHub.connection.get(path, params)
+      result = CompaniesHouseHub.connection.get(path, params)
+
+      raise APIKeyError, result.body[:error] if result.status == 401
+
+      result
     end
 
     def get(path, params)

data/lib/companies_house_hub/errors.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+module CompaniesHouseHub
+  class APIKeyError < StandardError
+  end
+
+  class GenericError < StandardError
+  end
+end

data/lib/companies_house_hub/filing_history_formatter.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require 'yaml'
-
+# 02200605
 module CompaniesHouseHub
   class FilingHistoryFormatter
     def initialize(filing_history)

data/lib/companies_house_hub/models/company.rb

@@ -22,7 +22,16 @@ module CompaniesHouseHub
 
       result = get(SEARCH_PATH, options)
 
-      result.body[:items].map { |company_json| new(company_json) }
+      return [] unless result.success?
+
+      # Get all items and create a new company. If the company has no number we need to ignore it.
+      companies = result.body[:items].map do |company_json|
+        next unless company_json.dig(:company_number)
+
+        new(company_json)
+      end
+
+      companies.compact
     end
 
     def self.find(company_number, params = {})
@@ -30,7 +39,7 @@ module CompaniesHouseHub
 
       result = get(url, params)
 
-      return unless result.success?
+      return if result.status == 404
 
       new(result.body)
     end

data/lib/companies_house_hub/models/filing_history.rb

@@ -7,9 +7,12 @@ module CompaniesHouseHub
     DOCUMENT_URL = 'https://beta.companieshouse.gov.uk'
     FIND_PATH = '/company/:company_number/filing-history'
     DEFAULT_PER_PAGE = 100
+    LEGACY_DOC_DESCRIPTION = 'legacy'
 
     attr_reader :description, :action_date, :date, :type, :barcode, :links, :description_values
 
+    alias name description
+
     def self.all(options = {})
       options[:items_per_page] ||= DEFAULT_PER_PAGE
 
@@ -17,7 +20,17 @@ module CompaniesHouseHub
 
       result = get(format_url(FIND_PATH, company_number: number), options)
 
-      result.body[:items].map { |filing_json| new(filing_json) }
+      return [] unless result.body[:items].any?
+
+      # Get all items and create a new history. If the description is 'legacy' then we can safely
+      # ignore that document.
+      filing_histories = result.body[:items].map do |filing_json|
+        next if filing_json.dig(:description) == LEGACY_DOC_DESCRIPTION
+
+        new(filing_json)
+      end
+
+      filing_histories.compact
     end
 
     def initialize(json = {})

data/lib/companies_house_hub/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module CompaniesHouseHub
-  VERSION = '0.0.16'
+  VERSION = '0.1.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: companies_house_hub
 version: !ruby/object:Gem::Version
-  version: 0.0.16
+  version: 0.1.0
 platform: ruby
 authors:
 - Ricardo Otero
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-04-30 00:00:00.000000000 Z
+date: 2018-06-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -198,6 +198,7 @@ files:
 - lib/companies_house_hub.rb
 - lib/companies_house_hub/base_model.rb
 - lib/companies_house_hub/configuration.rb
+- lib/companies_house_hub/errors.rb
 - lib/companies_house_hub/filing_history_formatter.rb
 - lib/companies_house_hub/models/address.rb
 - lib/companies_house_hub/models/company.rb