community_engine 2.3.2 → 3.0.0

data/test/unit/category_test.rb

@@ -2,7 +2,7 @@ require 'test_helper'
 
 class CategoryTest < ActiveSupport::TestCase
   fixtures :categories, :posts
-        
+
   def test_should_display_new_post_text
     c = categories(:questions)
     c.new_post_text = "Ask a question"
@@ -11,4 +11,4 @@ class CategoryTest < ActiveSupport::TestCase
   end
 
 
-end
+end

data/test/unit/comment_test.rb

@@ -16,54 +16,58 @@ class CommentTest < ActiveSupport::TestCase
   end
 
   def test_should_be_created_anonymously
-    configatron.allow_anonymous_commenting = true
-    assert_difference Comment, :count, 1 do
-      comment = users(:quentin).comments.create!(
-        :comment => 'foo',
-        :author_email => 'bar@foo.com',
-        :author_ip => '123.123.123',
-        :recipient => users(:quentin)
-      )
+    configatron.temp do
+      configatron.allow_anonymous_commenting = true
+      assert_difference Comment, :count, 1 do
+        comment = users(:quentin).comments.create!(
+          :comment => 'foo',
+          :author_email => 'bar@foo.com',
+          :author_ip => '123.123.123',
+          :recipient => users(:quentin)
+        )
+      end
     end
-    configatron.allow_anonymous_commenting = false
   end
 
   def test_should_notify_previous_anonymous_commenter
-    configatron.allow_anonymous_commenting = true
-    users(:quentin).comments.create!(:comment => 'foo', :author_email => 'bruno@foo.com', :author_ip => '123.123.123', :recipient => users(:quentin))
-    users(:quentin).comments.create!(:comment => 'bar', :author_email => 'bruno@foo.com', :author_ip => '123.123.123', :recipient => users(:quentin))
+    configatron.temp do
+      configatron.allow_anonymous_commenting = true
+      users(:quentin).comments.create!(:comment => 'foo', :author_email => 'bruno@foo.com', :author_ip => '123.123.123', :recipient => users(:quentin))
+      users(:quentin).comments.create!(:comment => 'bar', :author_email => 'bruno@foo.com', :author_ip => '123.123.123', :recipient => users(:quentin))
 
-    comment = users(:quentin).comments.create!(:comment => 'bar', :author_email => 'alicia@foo.com', :author_ip => '123.123.123', :recipient => users(:quentin))
+      comment = users(:quentin).comments.create!(:comment => 'bar', :author_email => 'alicia@foo.com', :author_ip => '123.123.123', :recipient => users(:quentin))
 
-    assert_difference ActionMailer::Base.deliveries, :length, 1 do
-      comment.notify_previous_anonymous_commenters
+      assert_difference ActionMailer::Base.deliveries, :length, 1 do
+        comment.notify_previous_anonymous_commenters
+      end
     end
-    configatron.allow_anonymous_commenting = false
   end
 
   def test_should_not_notify_previous_anonymous_commenter_if_self
-    configatron.allow_anonymous_commenting = true
-    users(:quentin).comments.create!(:comment => 'foo', :author_email => 'bruno@foo.com', :author_ip => '123.123.123', :recipient => users(:quentin))
-    users(:quentin).comments.create!(:comment => 'bar', :author_email => 'bruno@foo.com', :author_ip => '123.123.123', :recipient => users(:quentin))
+    configatron.temp do
+      configatron.allow_anonymous_commenting = true
+      users(:quentin).comments.create!(:comment => 'foo', :author_email => 'bruno@foo.com', :author_ip => '123.123.123', :recipient => users(:quentin))
+      users(:quentin).comments.create!(:comment => 'bar', :author_email => 'bruno@foo.com', :author_ip => '123.123.123', :recipient => users(:quentin))
 
-    comment = users(:quentin).comments.create!(:comment => 'bar', :author_email => 'bruno@foo.com', :author_ip => '123.123.123', :recipient => users(:quentin))
+      comment = users(:quentin).comments.create!(:comment => 'bar', :author_email => 'bruno@foo.com', :author_ip => '123.123.123', :recipient => users(:quentin))
 
-    assert_difference ActionMailer::Base.deliveries, :length, 0 do
-      comment.notify_previous_anonymous_commenters
+      assert_difference ActionMailer::Base.deliveries, :length, 0 do
+        comment.notify_previous_anonymous_commenters
+      end
     end
-    configatron.allow_anonymous_commenting = nil
   end
 
   def test_should_not_notify_previous_anonymous_commenter_if_notify_by_email_is_false
-    configatron.allow_anonymous_commenting = true
-    users(:quentin).comments.create!(:comment => 'foo', :author_email => 'bruno@foo.com', :author_ip => '123.123.123', :recipient => users(:quentin), :notify_by_email => false)
+    configatron.temp do
+      configatron.allow_anonymous_commenting = true
+      users(:quentin).comments.create!(:comment => 'foo', :author_email => 'bruno@foo.com', :author_ip => '123.123.123', :recipient => users(:quentin), :notify_by_email => false)
 
-    comment = users(:quentin).comments.create!(:comment => 'bar', :author_email => 'alicia@foo.com', :author_ip => '123.123.123', :recipient => users(:quentin))
+      comment = users(:quentin).comments.create!(:comment => 'bar', :author_email => 'alicia@foo.com', :author_ip => '123.123.123', :recipient => users(:quentin))
 
-    assert_difference ActionMailer::Base.deliveries, :length, 0 do
-      comment.notify_previous_anonymous_commenters
+      assert_difference ActionMailer::Base.deliveries, :length, 0 do
+        comment.notify_previous_anonymous_commenters
+      end
     end
-    configatron.allow_anonymous_commenting = false
   end
 
   def test_should_not_be_created_anonymously
@@ -79,16 +83,19 @@ class CommentTest < ActiveSupport::TestCase
   end
 
   def test_should_unsubscribe_notifications
-    configatron.allow_anonymous_commenting = true
-    first_comment = users(:quentin).comments.create!(:comment => 'foo', :author_email => 'alicia@foo.com', :author_ip => '123.123.123', :recipient => users(:quentin), :notify_by_email => true)
-    comment = users(:quentin).comments.create!(:comment => 'bar', :author_email => 'alicia@foo.com', :author_ip => '123.123.123', :recipient => users(:quentin), :notify_by_email => true)
-    assert_equal first_comment.notify_by_email, true
-    assert_equal comment.notify_by_email, true
-    configatron.allow_anonymous_commenting = false
-
-    comment.unsubscribe_notifications('alicia@foo.com')
-    assert comment.reload.notify_by_email.eql?(false)
-    assert first_comment.reload.notify_by_email.eql?(false)
+    configatron.temp do
+      configatron.allow_anonymous_commenting = true
+      first_comment = users(:quentin).comments.create!(:comment => 'foo', :author_email => 'alicia@foo.com', :author_ip => '123.123.123', :recipient => users(:quentin), :notify_by_email => true)
+      comment = users(:quentin).comments.create!(:comment => 'bar', :author_email => 'alicia@foo.com', :author_ip => '123.123.123', :recipient => users(:quentin), :notify_by_email => true)
+      assert_equal first_comment.notify_by_email, true
+      assert_equal comment.notify_by_email, true
+
+      configatron.allow_anonymous_commenting = false
+
+      comment.unsubscribe_notifications('alicia@foo.com')
+      assert comment.reload.notify_by_email.eql?(false)
+      assert first_comment.reload.notify_by_email.eql?(false)
+    end
   end
 
   def test_should_not_notify_of_comments_on_post_with_send_notifications_off
@@ -113,30 +120,34 @@ class CommentTest < ActiveSupport::TestCase
     post = posts(:funny_post)
 
     Comment.any_instance.stubs(:spam?).returns(true)
-    configatron.stubs(:akismet_key).returns('1234')
-
-    comment = post.comments.create!(:comment => 'foo', :user => users(:aaron), :recipient => users(:quentin))
 
-    assert_equal 'pending', comment.role
+    configatron.temp do
+      configatron.akismet_key = '1234'
+      comment = post.comments.create!(:comment => 'foo', :user => users(:aaron), :recipient => users(:quentin))
+      assert_equal 'pending', comment.role
+    end
   end
 
   def test_spam_comment_notification_handling
     post = posts(:funny_post)
 
     Comment.any_instance.stubs(:spam?).returns(true)
-    configatron.stubs(:akismet_key).returns('1234')
 
-    comment = post.comments.new(:comment => 'foo', :user => users(:aaron), :recipient => users(:quentin))
+    configatron.temp do
+      configatron.akismet_key = '1234'
+      comment = post.comments.new(:comment => 'foo', :user => users(:aaron), :recipient => users(:quentin))
 
-    #no notifications for pending comments
-    assert_no_difference ActionMailer::Base.deliveries, :length do
-      comment.save!
-    end
+      #no notifications for pending comments
+      assert_no_difference ActionMailer::Base.deliveries, :length do
+        comment.save!
+      end
 
-    Comment.any_instance.stubs(:spam?).returns(false)
-    comment.role = 'published'
-    assert_difference ActionMailer::Base.deliveries, :length, 1 do
-      comment.save!
+      Comment.any_instance.stubs(:spam?).returns(false)
+
+      comment.role = 'published'
+      assert_difference ActionMailer::Base.deliveries, :length, 1 do
+        comment.save!
+      end
     end
   end
 

data/test/unit/event_test.rb

@@ -37,25 +37,25 @@ class EventTest < ActiveSupport::TestCase
   end
 
   def test_upcoming_event_scope_should_only_find_future_events
-    future_events = Event.upcoming.all
+    future_events = Event.upcoming.to_a
     assert_equal future_events.size, 3
     future_events.each {|e| assert e.end_time > Time.now}
   end
 
   def test_past_event_scope_should_only_find_old_events
-    past_events = Event.past.all
+    past_events = Event.past.to_a
     assert_equal past_events.size, 3
     past_events.each {|e| assert e.end_time <= Time.now}
   end
 
   def test_upcoming_events_shown_asc_order
-    future_events = Event.upcoming.find(:all)
+    future_events = Event.upcoming.to_a
     assert_equal future_events.first, events(:future_event)
     assert_equal future_events.second, events(:further_future_event) 
   end
 
   def test_past_events_shown_desc_order
-    future_events = Event.past.find(:all)
+    future_events = Event.past.to_a
     assert_equal future_events.first, events(:past_event)
     assert_equal future_events.second, events(:cool_event)
     assert_equal future_events.third, events(:further_past_event) 

data/test/unit/forum_test.rb

@@ -4,7 +4,7 @@ class ForumTest < ActiveSupport::TestCase
   fixtures :all
 
   def test_should_list_only_top_level_topics
-    assert_equal [topics(:sticky), topics(:il8n), topics(:ponies), topics(:pdi)], forums(:rails).topics.order('sticky DESC, created_at DESC').all
+    assert_equal [topics(:sticky), topics(:il8n), topics(:ponies), topics(:pdi)], forums(:rails).topics.order('sticky DESC, created_at DESC').to_a
   end
 
   def test_should_find_first_recent_post

data/test/unit/message_test.rb

@@ -12,7 +12,13 @@ class MessageTest < ActiveSupport::TestCase
       message = Message.create!(:sender => users(:quentin), :recipient => users(:aaron), :body => 'hey aaron', :subject => 'Hello friend!')
     end
   end
-  
+
+  def test_should_be_received
+    assert_difference users(:aaron).received_messages, :count, 1 do
+      Message.create!(:sender => users(:quentin), :recipient => users(:aaron), :body => 'hey aaron', :subject => 'Hello friend!')
+    end
+  end
+
   def test_should_be_invalid_without_subject
     m = Message.new(:subject => nil)
     assert !m.valid?

data/test/unit/page_test.rb

@@ -7,7 +7,7 @@ class PageTest < ActiveSupport::TestCase
   def test_should_find_including_unpublished
     page = pages(:draft_page)
     page.save_as_draft
-    assert Page.unscoped.all.include?(page)
+    assert Page.unscoped.to_a.include?(page)
   end
   
   def test_default_find_should_not_find_drafts
@@ -19,7 +19,7 @@ class PageTest < ActiveSupport::TestCase
   def test_default_find_should_find_published
     page = pages(:custom_page)
     page.save
-    assert Page.find(:all).include?(page)    
+    assert Page.all.include?(page)
   end
 
 end

data/test/unit/post_test.rb

@@ -1,6 +1,6 @@
 require 'test_helper'
 require 'hpricot'
-    
+
 class PostTest < ActiveSupport::TestCase
   fixtures :all
 
@@ -12,15 +12,15 @@ class PostTest < ActiveSupport::TestCase
     post = posts(:funny_post)
     post.save_as_draft
     assert Post.unscoped.find(post.id)
-    assert Post.unscoped.all.include?(post)
+    assert Post.unscoped.to_a.include?(post)
   end
-  
+
   def test_default_find_should_not_find_drafts
     post = posts(:funny_post)
     post.save_as_draft
-    assert !Post.find(:all).include?(post)    
+    assert !Post.all.include?(post)
   end
-  
+
   def test_should_find_recent
     posts = Post.find_recent(:limit => 3)
     assert_equal posts.size, 3
@@ -34,22 +34,22 @@ class PostTest < ActiveSupport::TestCase
     posts = Post.find_popular(:limit => 3, :since => 1.days)
     assert_equal posts.size, 0
   end
-  
+
   def test_should_display_name
     post = posts(:funny_post)
     assert_equal post.display_title, "HOW TO: Building communities is all about love."
   end
-  
+
   def test_should_find_previous_post
     previous = posts(:not_funny_post).previous_post
     assert_equal previous, posts(:funny_post)
   end
-  
+
   def test_should_find_next_post
     next_post = posts(:funny_post).next_post
     assert_equal next_post, posts(:not_funny_post)
   end
-  
+
   def test_should_track_post_activity
     assert_difference Activity, :count, 1 do
       post = Post.new(:title => 'testing activity tracking', :raw_post => 'will this work?', :published_as => 'live')
@@ -57,15 +57,15 @@ class PostTest < ActiveSupport::TestCase
       post.save!
     end
   end
-  
+
   def test_should_not_track_draft_post_activity
     assert_no_difference Activity, :count do
       post = Post.new(:title => 'testing activity tracking', :raw_post => 'will this work?', :published_as => 'draft')
       post.user = users(:quentin)
       post.save!
     end
-  end  
-  
+  end
+
   def test_should_delete_post_activity
     post = Post.new(:title => 'testing activity tracking', :raw_post => 'will this work?', :published_as => 'live')
     post.user = users(:quentin)
@@ -75,12 +75,12 @@ class PostTest < ActiveSupport::TestCase
       post.destroy
     end
   end
-  
-  
+
+
   # def test_link_for_rss
   #   assert_equal posts(:funny_post).link_for_rss, "http://localhost:3000/quentin/posts/1-This-is-really-good-stuff"
   # end
-  
+
   def test_create_poll
     assert_difference Poll, :count, 1 do
       assert_difference Choice, :count, 3 do
@@ -88,54 +88,54 @@ class PostTest < ActiveSupport::TestCase
       end
     end
   end
-  
+
   def test_should_not_add_empty_poll
     assert_no_difference Poll, :count do
       assert_no_difference Choice, :count do
         posts(:funny_post).create_poll({:question => 'Who can have a great time?'}, ['only one choice'])
       end
-    end    
+    end
   end
-  
+
   def test_should_not_create_poll_with_no_choices
     assert_no_difference Poll, :count do
       assert_no_difference Choice, :count do
         posts(:funny_post).create_poll({:question => 'Who can have a great time?'}, [])
       end
-    end    
+    end
   end
-  
+
   def test_update_poll
     assert posts(:not_funny_post).create_poll({:question => 'Who can have a great time?'}, ['I can', 'You can', 'No one can'])
-    
+
     assert posts(:not_funny_post).update_poll({:question => 'Who can have a terrible time?'}, ['Foo', 'Bar'])
-    
-    assert_equal 'Who can have a terrible time?', posts(:not_funny_post).poll.question 
+
+    assert_equal 'Who can have a terrible time?', posts(:not_funny_post).poll.question
     assert_equal 'Foo', posts(:not_funny_post).poll.choices.first.description
     assert_equal 'Bar', posts(:not_funny_post).poll.choices.last.description
   end
-  
+
   def test_update_poll_with_no_choices_should_delete_poll
     assert posts(:funny_post).create_poll({:question => 'Who can have a great time?'}, ['I can', 'You can', 'No one can'])
 
     assert_difference Poll, :count, -1 do
       assert posts(:funny_post).update_poll({:question => 'Who can have a terrible time?'}, [])
     end
-  end  
-  
+  end
+
   def test_should_find_most_commented
     assert_equal posts(:funny_post).id, Post.find_most_commented.first.id
-    assert_equal posts(:apt_post).id, Post.find_most_commented.last.id        
+    assert_equal posts(:apt_post).id, Post.find_most_commented.last.id
   end
 
   def test_find_recent
     assert Post.find_recent(:limit => 30)
   end
-  
+
   def test_image_for_excerpt_for_post_with_no_image_returns_avatar_url
     assert_equal posts(:funny_post).user.avatar_photo_url(:medium), posts(:funny_post).image_for_excerpt
   end
-  
+
   def test_has_been_favorited_by_user
     post  = posts(:funny_post)
     assert !post.has_been_favorited_by(users(:quentin))
@@ -143,30 +143,30 @@ class PostTest < ActiveSupport::TestCase
     favorite = Favorite.new(:ip_address => '1.1.1.1', :favoritable => post )
     favorite.user = users(:quentin)
     favorite.save
-    
-    assert post.has_been_favorited_by(users(:quentin))    
+
+    assert post.has_been_favorited_by(users(:quentin))
   end
-  
+
   def test_should_set_published_at_date_when_first_published
     post = users(:quentin).posts.new(:raw_post => 'Blog post message', :title => 'Title')
     assert !post.published_at
     post.save!
-    
+
     post.published_as = 'live'
     post.save
     assert post.published_at
   end
-  
-  def test_should_not_set_published_at_if_republishing  
+
+  def test_should_not_set_published_at_if_republishing
     post = users(:quentin).posts.create!(:raw_post => 'Blog post message', :title => 'Title')
     post.save_as_live #publish
     published_at = post.published_at
-    
+
     post.save_as_draft #unpublish
     post.save_as_live #publish again
     assert_equal post.published_at, published_at
   end
-  
+
   def test_should_show_published_at_display
     post = posts(:funny_post)
     assert_equal post.published_at_display, I18n.l(post.published_at, :format => :published_date)
@@ -177,36 +177,36 @@ class PostTest < ActiveSupport::TestCase
     post.save_as_draft
     assert_equal post.published_at_display, 'Draft'
   end
-  
+
   def test_should_not_notify_for_posts_without_comment_notification_on
     post = posts(:funny_post)
     post.send_comment_notifications = false
     post.save!
-    
-    assert_difference ActionMailer::Base.deliveries, :length, 0 do    
+
+    assert_difference ActionMailer::Base.deliveries, :length, 0 do
       comment = post.comments.create!(:comment => 'foo', :user => users(:aaron))
-      comment.send_notifications      
+      comment.send_notifications
     end
-    
+
   end
 
   test "should find related" do
     p1 = posts(:funny_post)
     p2 = posts(:not_funny_post)
-    
+
     p1.tag_list = 'tag1, tag2'
     p1.save!
     p2.tag_list = 'tag2, tag3'
     p2.save!
-    
+
     assert Post.find_related_to(p1).include?(p2)
 
     p2.tag_list = 'tag3, tag4'
     p2.save!
 
-    assert !Post.find_related_to(p1).include?(p2)    
+    assert !Post.find_related_to(p1).include?(p2)
+
 
-    
   end
-      
+
 end