communicator 0.2.1 → 0.2.2

data/lib/communicator/inbound_message.rb

@@ -57,7 +57,16 @@ class Communicator::InboundMessage < ActiveRecord::Base
       return false
     end
     source, content = message_content.first
-    Communicator.receiver_for(source).find_or_initialize_by_id(content["id"]).process_message(content)
+    
+    # We have to distinguish here between inbound messages that have an id and those that
+    # don't since some databases (at least Postgres) will raise an error when the ID is set to nil on
+    # the ActiveRecord instance because AR includes the id column and it's "NULL" value in the
+    # INSERT statement
+    if content["id"]
+      Communicator.receiver_for(source).find_or_initialize_by_id(content["id"]).process_message(content)
+    else
+      Communicator.receiver_for(source).new.process_message(content)
+    end
     self.processed_at = Time.now
     self.save!
     Communicator.logger.info "Processed inbound message ##{id} successfully"
@@ -73,4 +82,4 @@ class Communicator::InboundMessage < ActiveRecord::Base
     
     raise err
   end
-end
+end

data/lib/communicator/version.rb

@@ -1,3 +1,3 @@
 module Communicator
-  VERSION = '0.2.1'
+  VERSION = '0.2.2'
 end

data/test/test_client.rb

@@ -133,6 +133,10 @@ class TestClient < Test::Unit::TestCase
         assert_nil Communicator::OutboundMessage.last.message_content["post"]["id"]
       end
       
+      should "not have created the Post locally" do
+        assert @post.new_record?
+      end
+      
       context "after PUSH" do
         setup do
           Communicator::Client.push

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: communicator
 version: !ruby/object:Gem::Version 
-  hash: 21
+  hash: 19
   prerelease: 
   segments: 
   - 0
   - 2
-  - 1
-  version: 0.2.1
+  - 2
+  version: 0.2.2
 platform: ruby
 authors: 
 - Christoph Olszowka