commontator 4.10.5 → 4.11.0

data/spec/controllers/commontator/subscriptions_controller_spec.rb~

@@ -0,0 +1,101 @@
+require 'rails_helper'
+
+module Commontator
+  RSpec.describe SubscriptionsController, type: :controller do
+    routes { Commontator::Engine.routes }
+
+    before(:each) do
+      setup_controller_spec
+    end
+    
+    it "won't subscribe unless authorized" do
+      put :subscribe, :id => @thread.id
+      expect(response).to have_http_status(:forbidden)
+      expect(@thread.subscription_for(nil)).to be_nil
+      expect(@thread.subscription_for(@user)).to be_nil
+      
+      sign_in @user
+      put :subscribe, :id => @thread.id
+      expect(response).to have_http_status(:forbidden)
+      expect(@thread.subscription_for(@user)).to be_nil
+      
+      @thread.subscribe(@user)
+      @user.can_read = true
+      put :subscribe, :id => @thread.id
+      expect(response).to redirect_to(@thread)
+      expect(assigns(:thread).errors).not_to be_empty
+    end
+    
+    it 'must subscribe if authorized' do
+      sign_in @user
+      
+      @user.can_read = true
+      put :subscribe, :id => @thread.id
+      expect(response).to redirect_to(@thread)
+      expect(assigns(:thread).errors).to be_empty
+      expect(@thread.subscription_for(@user)).not_to be_nil
+      
+      @thread.unsubscribe(@user)
+      @user.can_read = false
+      @user.can_edit = true
+      put :subscribe, :id => @thread.id
+      expect(response).to redirect_to(@thread)
+      expect(assigns(:thread).errors).to be_empty
+      expect(@thread.subscription_for(@user)).not_to be_nil
+      
+      @thread.unsubscribe(@user)
+      @user.can_edit = false
+      @user.is_admin = true
+      put :subscribe, :id => @thread.id
+      expect(response).to redirect_to(@thread)
+      expect(assigns(:thread).errors).to be_empty
+      expect(@thread.subscription_for(@user)).not_to be_nil
+    end
+    
+    it "won't unsubscribe unless authorized" do
+      @thread.subscribe(@user)
+      put :unsubscribe, :id => @thread.id
+      expect(response).to have_http_status(:forbidden)
+      expect(@thread.subscription_for(nil)).to be_nil
+      expect(@thread.subscription_for(@user)).not_to be_nil
+      
+      sign_in @user
+      put :unsubscribe, :id => @thread.id
+      expect(response).to have_http_status(:forbidden)
+      expect(@thread.subscription_for(@user)).not_to be_nil
+      
+      @thread.unsubscribe(@user)
+      @user.can_read = true
+      put :unsubscribe, :id => @thread.id
+      expect(response).to redirect_to(@thread)
+      expect(assigns(:thread).errors).not_to be_empty
+    end
+    
+    it 'must unsubscribe if authorized' do
+      sign_in @user
+      
+      @thread.subscribe(@user)
+      @user.can_read = true
+      put :unsubscribe, :id => @thread.id
+      expect(response).to redirect_to(@thread)
+      expect(assigns(:thread).errors).to be_empty
+      expect(@thread.subscription_for(@user)).to be_nil
+      
+      @thread.subscribe(@user)
+      @user.can_read = false
+      @user.can_edit = true
+      put :unsubscribe, :id => @thread.id
+      expect(response).to redirect_to(@thread)
+      expect(assigns(:thread).errors).to be_empty
+      expect(@thread.subscription_for(@user)).to be_nil
+      
+      @thread.subscribe(@user)
+      @user.can_edit = false
+      @user.is_admin = true
+      put :unsubscribe, :id => @thread.id
+      expect(response).to redirect_to(@thread)
+      expect(assigns(:thread).errors).to be_empty
+      expect(@thread.subscription_for(@user)).to be_nil
+    end
+  end
+end

data/spec/controllers/commontator/threads_controller_spec.rb

@@ -125,6 +125,94 @@ module Commontator
       expect(assigns(:thread).errors).to be_empty
       expect(assigns(:thread).is_closed?).to eq false
     end
+    
+    context '#mentions' do
+      let(:search_phrase) { nil }
+      let(:call_request)  { get :mentions, id: @thread.id, format: :json, q: search_phrase }
+
+      let!(:other_user)   { DummyUser.create }
+
+      context 'mentions disabled' do
+        before(:all) { Commontator.mentions_enabled = false }
+        after(:all)  { Commontator.mentions_enabled = true }
+
+        it 'returns 403 Forbidden' do
+          call_request
+          expect(response).to have_http_status(:forbidden)
+        end
+      end
+
+      context 'mentions enabled' do
+        context 'anonymous user' do
+          it 'returns 403 Forbidden' do
+            call_request
+            expect(response).to have_http_status(:forbidden)
+          end
+        end
+
+        context 'unauthorized user' do
+          before { sign_in @user }
+
+          it 'returns 403 Forbidden' do
+            call_request
+            expect(response).to have_http_status(:forbidden)
+          end
+        end
+
+        context 'authorized user' do
+          before do
+            @user.can_read = true
+            sign_in @user
+          end
+
+          context 'query is blank' do
+            it 'returns a JSON error message' do
+              call_request
+              expect(response).to have_http_status(:unprocessable_entity)
+              expect(JSON.parse(response.body)['errors']).to(
+                include('Query string is too short (minimum 3 characters)')
+              )
+            end
+          end
+
+          context 'query is too short' do
+            let(:search_phrase) { 'Us' }
+
+            it 'returns a JSON error message' do
+              call_request
+              expect(response).to have_http_status(:unprocessable_entity)
+              expect(JSON.parse(response.body)['errors']).to(
+                include('Query string is too short (minimum 3 characters)')
+              )
+            end
+          end
+
+          context 'query is 3 characters or more' do
+            let(:search_phrase) { 'User' }
+
+            let(:valid_result) { [@user] }
+            let(:valid_response) do
+              { 'mentions' => valid_result.map do |user|
+                { 'id' => user.id, 'name' => user.name, 'type' => 'user' }
+              end }
+            end
+
+            it 'calls the user_mentions_proc and returns the result' do
+              expect(Commontator.user_mentions_proc).to(
+                receive(:call).with(@user, search_phrase).and_return(valid_result)
+              )
+
+              call_request
+              expect(response).to have_http_status(:success)
+
+              response_body = JSON.parse(response.body)
+              expect(response_body['errors']).to be_nil
+              expect(response_body).to eq valid_response
+            end
+          end
+        end
+      end
+    end
   end
 end
 

data/spec/controllers/commontator/threads_controller_spec.rb~

@@ -0,0 +1,218 @@
+require 'rails_helper'
+
+module Commontator
+  RSpec.describe ThreadsController, type: :controller do
+    routes { Commontator::Engine.routes }
+
+    before(:each) do
+      setup_controller_spec
+    end
+    
+    it "won't show unless authorized" do
+      get :show, :id => @thread.id
+      expect(response).to have_http_status(:forbidden)
+      
+      sign_in @user
+      get :show, :id => @thread.id
+      expect(response).to have_http_status(:forbidden)
+    end
+    
+    it 'must show if authorized' do
+      commontable_path = Rails.application.routes.url_helpers.dummy_model_path(@commontable)
+      sign_in @user
+      
+      @user.can_read = true
+      get :show, :id => @thread.id
+      expect(response).to redirect_to(commontable_path)
+      
+      @user.can_read = false
+      @user.can_edit = true
+      get :show, :id => @thread.id
+      expect(response).to redirect_to(commontable_path)
+      
+      @user.can_edit = false
+      @user.is_admin = true
+      get :show, :id => @thread.id
+      expect(response).to redirect_to(commontable_path)
+    end
+    
+    it "won't close unless authorized and open" do
+      put :close, :id => @thread.id
+      expect(response).to have_http_status(:forbidden)
+      @thread.reload
+      expect(@thread.is_closed?).to eq false
+      
+      sign_in @user
+      put :close, :id => @thread.id
+      expect(response).to have_http_status(:forbidden)
+      @thread.reload
+      expect(@thread.is_closed?).to eq false
+      
+      @user.can_read = true
+      put :close, :id => @thread.id
+      expect(response).to have_http_status(:forbidden)
+      @thread.reload
+      expect(@thread.is_closed?).to eq false
+      
+      @user.can_edit = true
+      expect(@thread.close).to eq true
+      put :close, :id => @thread.id
+      expect(response).to redirect_to(@thread)
+      expect(assigns(:thread).errors).not_to be_empty
+    end
+    
+    it 'must close if authorized and open' do
+      sign_in @user
+      
+      @user.can_edit = true
+      put :close, :id => @thread.id
+      expect(response).to redirect_to(@thread)
+      expect(assigns(:thread).errors).to be_empty
+      expect(assigns(:thread).is_closed?).to eq true
+      expect(assigns(:thread).closer).to eq @user
+      
+      expect(assigns(:thread).reopen).to eq true
+      @user.can_edit = false
+      @user.is_admin = true
+      put :close, :id => @thread.id
+      expect(response).to redirect_to(@thread)
+      expect(assigns(:thread).errors).to be_empty
+      expect(assigns(:thread).is_closed?).to eq true
+      expect(assigns(:thread).closer).to eq @user
+    end
+    
+    it "won't reopen unless authorized and closed" do
+      expect(@thread.close).to eq true
+      put :reopen, :id => @thread.id
+      expect(response).to have_http_status(:forbidden)
+      @thread.reload
+      expect(@thread.is_closed?).to eq true
+      
+      sign_in @user
+      put :reopen, :id => @thread.id
+      expect(response).to have_http_status(:forbidden)
+      @thread.reload
+      expect(@thread.is_closed?).to eq true
+      
+      @user.can_read = true
+      put :reopen, :id => @thread.id
+      expect(response).to have_http_status(:forbidden)
+      @thread.reload
+      expect(@thread.is_closed?).to eq true
+      
+      expect(@thread.reopen).to eq true
+      @user.can_edit = true
+      put :reopen, :id => @thread.id
+      expect(response).to redirect_to(@thread)
+      expect(assigns(:thread).errors).not_to be_empty
+    end
+    
+    it 'must reopen if authorized and closed' do
+      sign_in @user
+      
+      expect(@thread.close).to eq true
+      @user.can_edit = true
+      put :reopen, :id => @thread.id
+      expect(response).to redirect_to(@thread)
+      expect(assigns(:thread).errors).to be_empty
+      expect(assigns(:thread).is_closed?).to eq false
+      
+      expect(assigns(:thread).close).to eq true
+      @user.can_edit = false
+      @user.is_admin = true
+      put :reopen, :id => @thread.id
+      expect(response).to redirect_to(@thread)
+      expect(assigns(:thread).errors).to be_empty
+      expect(assigns(:thread).is_closed?).to eq false
+    end
+    
+    context '#mentions' do
+      let(:search_phrase) { nil }
+      let(:call_request)  { get :mentions, id: @thread.id, format: :json, q: search_phrase }
+
+      let!(:other_user)   { DummyUser.create }
+
+      context 'mentions disabled' do
+        before(:all) { Commontator.mentions_enabled = false }
+        after(:all)  { Commontator.mentions_enabled = true }
+
+        it 'returns 403 Forbidden' do
+          call_request
+          expect(response).to have_http_status(:forbidden)
+        end
+      end
+
+      context 'mentions enabled' do
+        context 'anonymous user' do
+          it 'returns 403 Forbidden' do
+            call_request
+            expect(response).to have_http_status(:forbidden)
+          end
+        end
+
+        context 'unauthorized user' do
+          before { sign_in @user }
+
+          it 'returns 403 Forbidden' do
+            call_request
+            expect(response).to have_http_status(:forbidden)
+          end
+        end
+
+        context 'authorized user' do
+          before do
+            @user.can_read = true
+            sign_in @user
+          end
+
+          context 'query is blank' do
+            it 'returns a JSON error message' do
+              call_request
+              expect(response).to have_http_status(:unprocessable_entity)
+              expect(JSON.parse(response.body)['errors']).to(
+                include('Query string is too short (minimum 3 characters)')
+              )
+            end
+          end
+
+          context 'query is too short' do
+            let(:search_phrase) { 'Us' }
+
+            it 'returns a JSON error message' do
+              call_request
+              expect(response).to have_http_status(:unprocessable_entity)
+              expect(JSON.parse(response.body)['errors']).to(
+                include('Query string is too short (minimum 3 characters)')
+              )
+            end
+          end
+
+          context 'query is 3 characters or more' do
+            let(:search_phrase) { 'User' }
+
+            let(:valid_result) { [@user] }
+            let(:valid_response) do
+              { 'mentions' => valid_result.map do |user|
+                { 'id' => user.id, 'name' => user.name, 'type' => 'user' }
+              end }
+            end
+
+            it 'calls the user_mentions_proc and returns the result' do
+              expect(Commontator.user_mentions_proc).to(
+                receive(:call).with(@user, search_phrase).and_return(valid_result)
+              )
+
+              call_request
+              expect(response).to have_http_status(:success)
+
+              response_body = JSON.parse(response.body)
+              expect(response_body['errors']).to be_nil
+              expect(response_body).to eq valid_response
+            end
+          end
+        end
+      end
+    end
+  end
+end
+

data/spec/dummy/README.md~

@@ -0,0 +1,3 @@
+## Dummy
+
+A dummy application used to test the Commontator engine.

data/spec/dummy/Rakefile~

@@ -0,0 +1,6 @@
+# Add your own tasks in files placed in lib/tasks ending in .rake,
+# for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
+
+require File.expand_path('../config/application', __FILE__)
+
+Dummy::Application.load_tasks

data/spec/dummy/app/assets/javascripts/application.js

@@ -12,5 +12,6 @@
 //
 //= require jquery
 //= require jquery_ujs
+//= require commontator/application
 //= require_tree .
 

data/spec/dummy/app/assets/javascripts/application.js~

@@ -0,0 +1,16 @@
+// This is a manifest file that'll be compiled into application.js, which will include all the files
+// listed below.
+//
+// Any JavaScript/Coffee file within this directory, lib/assets/javascripts, vendor/assets/javascripts,
+// or vendor/assets/javascripts of plugins, if any, can be referenced here using a relative path.
+//
+// It's not advisable to add code directly here, but if you do, it'll appear at the bottom of the
+// the compiled file.
+//
+// WARNING: THE FIRST BLANK LINE MARKS THE END OF WHAT'S TO BE PROCESSED, ANY BLANK LINE SHOULD
+// GO AFTER THE REQUIRES BELOW.
+//
+//= require jquery
+//= require jquery_ujs
+//= require_tree .
+