commontator 4.0.2 → 4.1.1

data/spec/app/controllers/commontator/subscriptions_controller_spec.rb

@@ -6,7 +6,7 @@ module Commontator
       setup_controller_spec
     end
     
-    it 'wont subscribe unless authorized' do
+    it "won't subscribe unless authorized" do
       put :subscribe, :thread_id => @thread.id, :use_route => :commontator
       assert_response 403
       @thread.subscription_for(nil).must_be_nil
@@ -50,7 +50,7 @@ module Commontator
       @thread.subscription_for(@user).wont_be_nil
     end
     
-    it 'wont unsubscribe unless authorized' do
+    it "won't unsubscribe unless authorized" do
       @thread.subscribe(@user)
       put :unsubscribe, :thread_id => @thread.id, :use_route => :commontator
       assert_response 403
@@ -69,7 +69,7 @@ module Commontator
       assigns(:thread).errors.wont_be_empty
     end
     
-    it 'must destroy if authorized' do
+    it 'must unsubscribe if authorized' do
       sign_in @user
       
       @thread.subscribe(@user)

data/spec/app/controllers/commontator/subscriptions_controller_spec.rb~

@@ -0,0 +1,99 @@
+require 'test_helper'
+
+module Commontator
+  describe SubscriptionsController do
+    before do
+      setup_controller_spec
+    end
+    
+    it 'wont subscribe unless authorized' do
+      put :subscribe, :thread_id => @thread.id, :use_route => :commontator
+      assert_response 403
+      @thread.subscription_for(nil).must_be_nil
+      @thread.subscription_for(@user).must_be_nil
+      
+      sign_in @user
+      put :subscribe, :thread_id => @thread.id, :use_route => :commontator
+      assert_response 403
+      @thread.subscription_for(@user).must_be_nil
+      
+      @thread.subscribe(@user)
+      @user.can_read = true
+      put :subscribe, :thread_id => @thread.id, :use_route => :commontator
+      assert_redirected_to @thread
+      assigns(:thread).errors.wont_be_empty
+    end
+    
+    it 'must subscribe if authorized' do
+      sign_in @user
+      
+      @user.can_read = true
+      put :subscribe, :thread_id => @thread.id, :use_route => :commontator
+      assert_redirected_to @thread
+      assigns(:thread).errors.must_be_empty
+      @thread.subscription_for(@user).wont_be_nil
+      
+      @thread.unsubscribe(@user)
+      @user.can_read = false
+      @user.can_edit = true
+      put :subscribe, :thread_id => @thread.id, :use_route => :commontator
+      assert_redirected_to @thread
+      assigns(:thread).errors.must_be_empty
+      @thread.subscription_for(@user).wont_be_nil
+      
+      @thread.unsubscribe(@user)
+      @user.can_edit = false
+      @user.is_admin = true
+      put :subscribe, :thread_id => @thread.id, :use_route => :commontator
+      assert_redirected_to @thread
+      assigns(:thread).errors.must_be_empty
+      @thread.subscription_for(@user).wont_be_nil
+    end
+    
+    it 'wont unsubscribe unless authorized' do
+      @thread.subscribe(@user)
+      put :unsubscribe, :thread_id => @thread.id, :use_route => :commontator
+      assert_response 403
+      @thread.subscription_for(nil).must_be_nil
+      @thread.subscription_for(@user).wont_be_nil
+      
+      sign_in @user
+      put :unsubscribe, :thread_id => @thread.id, :use_route => :commontator
+      assert_response 403
+      @thread.subscription_for(@user).wont_be_nil
+      
+      @thread.unsubscribe(@user)
+      @user.can_read = true
+      put :unsubscribe, :thread_id => @thread.id, :use_route => :commontator
+      assert_redirected_to @thread
+      assigns(:thread).errors.wont_be_empty
+    end
+    
+    it 'must destroy if authorized' do
+      sign_in @user
+      
+      @thread.subscribe(@user)
+      @user.can_read = true
+      put :unsubscribe, :thread_id => @thread.id, :use_route => :commontator
+      assert_redirected_to @thread
+      assigns(:thread).errors.must_be_empty
+      @thread.subscription_for(@user).must_be_nil
+      
+      @thread.subscribe(@user)
+      @user.can_read = false
+      @user.can_edit = true
+      put :unsubscribe, :thread_id => @thread.id, :use_route => :commontator
+      assert_redirected_to @thread
+      assigns(:thread).errors.must_be_empty
+      @thread.subscription_for(@user).must_be_nil
+      
+      @thread.subscribe(@user)
+      @user.can_edit = false
+      @user.is_admin = true
+      put :unsubscribe, :thread_id => @thread.id, :use_route => :commontator
+      assert_redirected_to @thread
+      assigns(:thread).errors.must_be_empty
+      @thread.subscription_for(@user).must_be_nil
+    end
+  end
+end

data/spec/app/controllers/commontator/threads_controller_spec.rb

@@ -6,7 +6,7 @@ module Commontator
       setup_controller_spec
     end
     
-    it 'wont show unless authorized' do
+    it "won't show unless authorized" do
       get :show, :id => @thread.id, :use_route => :commontator
       assert_response 403
       
@@ -34,20 +34,23 @@ module Commontator
       assert_redirected_to commontable_path
     end
     
-    it 'wont close unless authorized and open' do
+    it "won't close unless authorized and open" do
       put :close, :id => @thread.id, :use_route => :commontator
       assert_response 403
-      assigns(:thread).is_closed?.must_equal false
+      @thread.reload
+      @thread.is_closed?.must_equal false
       
       sign_in @user
       put :close, :id => @thread.id, :use_route => :commontator
       assert_response 403
-      assigns(:thread).is_closed?.must_equal false
+      @thread.reload
+      @thread.is_closed?.must_equal false
       
       @user.can_read = true
       put :close, :id => @thread.id, :use_route => :commontator
       assert_response 403
-      assigns(:thread).is_closed?.must_equal false
+      @thread.reload
+      @thread.is_closed?.must_equal false
       
       @user.can_edit = true
       @thread.close.must_equal true
@@ -76,21 +79,24 @@ module Commontator
       assigns(:thread).closer.must_equal @user
     end
     
-    it 'wont reopen unless authorized and closed' do
+    it "won't reopen unless authorized and closed" do
       @thread.close.must_equal true
       put :reopen, :id => @thread.id, :use_route => :commontator
       assert_response 403
-      assigns(:thread).is_closed?.must_equal true
+      @thread.reload
+      @thread.is_closed?.must_equal true
       
       sign_in @user
       put :reopen, :id => @thread.id, :use_route => :commontator
       assert_response 403
-      assigns(:thread).is_closed?.must_equal true
+      @thread.reload
+      @thread.is_closed?.must_equal true
       
       @user.can_read = true
       put :reopen, :id => @thread.id, :use_route => :commontator
       assert_response 403
-      assigns(:thread).is_closed?.must_equal true
+      @thread.reload
+      @thread.is_closed?.must_equal true
       
       @thread.reopen.must_equal true
       @user.can_edit = true

data/spec/app/controllers/commontator/threads_controller_spec.rb~

@@ -0,0 +1,126 @@
+require 'test_helper'
+
+module Commontator
+  describe ThreadsController do
+    before do
+      setup_controller_spec
+    end
+    
+    it "won't show unless authorized" do
+      get :show, :id => @thread.id, :use_route => :commontator
+      assert_response 403
+      
+      sign_in @user
+      get :show, :id => @thread.id, :use_route => :commontator
+      assert_response 403
+    end
+    
+    it 'must show if authorized' do
+      commontable_path = Rails.application.routes.url_helpers.dummy_model_path(@commontable)
+      sign_in @user
+      
+      @user.can_read = true
+      get :show, :id => @thread.id, :use_route => :commontator
+      assert_redirected_to commontable_path
+      
+      @user.can_read = false
+      @user.can_edit = true
+      get :show, :id => @thread.id, :use_route => :commontator
+      assert_redirected_to commontable_path
+      
+      @user.can_edit = false
+      @user.is_admin = true
+      get :show, :id => @thread.id, :use_route => :commontator
+      assert_redirected_to commontable_path
+    end
+    
+    it "won't close unless authorized and open" do
+      put :close, :id => @thread.id, :use_route => :commontator
+      assert_response 403
+      assigns(:thread).is_closed?.must_equal false
+      
+      sign_in @user
+      put :close, :id => @thread.id, :use_route => :commontator
+      assert_response 403
+      @thread.reload
+      @thread.is_closed?.must_equal false
+      
+      @user.can_read = true
+      put :close, :id => @thread.id, :use_route => :commontator
+      assert_response 403
+      @thread.reload
+      @thread.is_closed?.must_equal false
+      
+      @user.can_edit = true
+      @thread.close.must_equal true
+      put :close, :id => @thread.id, :use_route => :commontator
+      assert_redirected_to @thread
+      assigns(:thread).errors.wont_be_empty
+    end
+    
+    it 'must close if authorized and open' do
+      sign_in @user
+      
+      @user.can_edit = true
+      put :close, :id => @thread.id, :use_route => :commontator
+      assert_redirected_to @thread
+      assigns(:thread).errors.must_be_empty
+      assigns(:thread).is_closed?.must_equal true
+      assigns(:thread).closer.must_equal @user
+      
+      assigns(:thread).reopen.must_equal true
+      @user.can_edit = false
+      @user.is_admin = true
+      put :close, :id => @thread.id, :use_route => :commontator
+      assert_redirected_to @thread
+      assigns(:thread).errors.must_be_empty
+      assigns(:thread).is_closed?.must_equal true
+      assigns(:thread).closer.must_equal @user
+    end
+    
+    it "won't reopen unless authorized and closed" do
+      @thread.close.must_equal true
+      put :reopen, :id => @thread.id, :use_route => :commontator
+      assert_response 403
+      @thread.reload
+      @thread.is_closed?.must_equal true
+      
+      sign_in @user
+      put :reopen, :id => @thread.id, :use_route => :commontator
+      assert_response 403
+      @thread.reload
+      @thread.is_closed?.must_equal true
+      
+      @user.can_read = true
+      put :reopen, :id => @thread.id, :use_route => :commontator
+      assert_response 403
+      @thread.reload
+      @thread.is_closed?.must_equal true
+      
+      @thread.reopen.must_equal true
+      @user.can_edit = true
+      put :reopen, :id => @thread.id, :use_route => :commontator
+      assert_redirected_to @thread
+      assigns(:thread).errors.wont_be_empty
+    end
+    
+    it 'must reopen if authorized and closed' do
+      sign_in @user
+      
+      @thread.close.must_equal true
+      @user.can_edit = true
+      put :reopen, :id => @thread.id, :use_route => :commontator
+      assert_redirected_to @thread
+      assigns(:thread).errors.must_be_empty
+      assigns(:thread).is_closed?.must_equal false
+      
+      assigns(:thread).close.must_equal true
+      @user.can_edit = false
+      @user.is_admin = true
+      put :reopen, :id => @thread.id, :use_route => :commontator
+      assert_redirected_to @thread
+      assigns(:thread).errors.must_be_empty
+      assigns(:thread).is_closed?.must_equal false
+    end
+  end
+end

data/spec/app/helpers/commontator/application_helper_spec.rb

@@ -3,7 +3,7 @@ require 'test_helper'
 module Commontator
   describe ApplicationHelper do
     it 'must print javascript proc' do
-      javascript_proc.must_equal 'Dummy Javascript'
+      javascript_proc.must_equal ''
     end
   end
 end

data/spec/app/helpers/commontator/application_helper_spec.rb~

@@ -0,0 +1,9 @@
+require 'test_helper'
+
+module Commontator
+  describe ApplicationHelper do
+    it 'must print javascript proc' do
+      javascript_proc.must_equal 'Dummy Javascript'
+    end
+  end
+end

data/spec/app/helpers/commontator/threads_helper_spec.rb

@@ -7,11 +7,7 @@ module Commontator
     end
     
     it 'must print commontable name' do
-      commontable_name(@thread).must_equal 'dummy model'
-    end
-    
-    it 'must print commontable id' do
-      commontable_id(@thread).must_equal @thread.commontable_id
+      commontable_name(@thread).must_equal 'DummyModel #2'
     end
   end
 end

data/spec/app/helpers/commontator/threads_helper_spec.rb~

@@ -0,0 +1,13 @@
+require 'test_helper'
+
+module Commontator
+  describe ThreadsHelper do
+    before do
+      setup_helper_spec
+    end
+    
+    it 'must print commontable name' do
+      commontable_name(@thread).must_equal 'DummyModel #1'
+    end
+  end
+end

data/spec/app/models/commontator/comment_spec.rb

@@ -48,14 +48,15 @@ module Commontator
     it 'must make proper timestamps' do
       @comment.save!
       
-      @comment.timestamp.must_equal "#{@thread.config.comment_create_verb_past.capitalize} on #{@comment.created_at.strftime(@thread.config.timestamp_format)}"
+      @comment.created_timestamp.must_equal "#{@thread.config.comment_create_verb_past.capitalize} on #{@comment.created_at.strftime(@thread.config.timestamp_format)}"
+      @comment.updated_timestamp.must_equal ''
       
       @comment.body = 'Something else'
       @comment.editor = @user
       @comment.save!
       
-      @comment.timestamp.must_equal "#{@thread.config.comment_create_verb_past.capitalize} on #{@comment.created_at.strftime(@thread.config.timestamp_format)}" + \
-        " | Last #{@thread.config.comment_edit_verb_past} on #{@comment.updated_at.strftime(@thread.config.timestamp_format)}"
+      @comment.created_timestamp.must_equal "#{@thread.config.comment_create_verb_past.capitalize} on #{@comment.created_at.strftime(@thread.config.timestamp_format)}"
+      @comment.updated_timestamp.must_equal "Last #{@thread.config.comment_edit_verb_past} on #{@comment.updated_at.strftime(@thread.config.timestamp_format)}"
     end
   end
 end

data/spec/app/models/commontator/comment_spec.rb~

@@ -0,0 +1,62 @@
+require 'test_helper'
+require 'acts_as_votable'
+
+module Commontator
+  describe Comment do
+    before do
+      setup_model_spec
+      @comment = Comment.new
+      @comment.thread = @thread
+      @comment.creator = @user
+      @comment.body = 'Something'
+    end
+    
+    it 'must be votable if acts_as_votable is installed' do
+      Comment.must_respond_to(:acts_as_votable)
+      @comment.is_votable?.must_equal true
+      @comment.acts_as_votable_initialized.must_equal true
+    end
+    
+    it 'must know if it has been modified' do
+      @comment.save!
+      
+      @comment.is_modified?.must_equal false
+      
+      @comment.body = 'Something else'
+      @comment.editor = @user
+      @comment.save!
+      
+      @comment.is_modified?.must_equal true
+    end
+    
+    it 'must know if it has been deleted' do
+      user = DummyUser.new
+      
+      @comment.is_deleted?.must_equal false
+      @comment.editor.must_be_nil
+      
+      @comment.delete_by(user)
+      
+      @comment.is_deleted?.must_equal true
+      @comment.editor.must_equal user
+      
+      @comment.undelete_by(user)
+      
+      @comment.is_deleted?.must_equal false
+    end
+    
+    it 'must make proper timestamps' do
+      @comment.save!
+      
+      @comment.created_timestamp.must_equal "#{@thread.config.comment_create_verb_past.capitalize} on #{@comment.created_at.strftime(@thread.config.timestamp_format)}"
+      @comment.updated_timestamp.must_equal ''
+      
+      @comment.body = 'Something else'
+      @comment.editor = @user
+      @comment.save!
+      
+      @comment.created_timestamp.must_equal "#{@thread.config.comment_create_verb_past.capitalize} on #{@comment.created_at.strftime(@thread.config.timestamp_format)}"
+      @comment.updated_timestamp.must_equal 'Last #{@thread.config.comment_edit_verb_past} on #{@comment.updated_at.strftime(@thread.config.timestamp_format)}'
+    end
+  end
+end