commons_yellowme 0.11.0 → 0.11.1

data/spec/commons/errors/payment_required_spec.rb

@@ -0,0 +1,62 @@
+describe Commons::Errors::PaymentRequired do
+  describe 'handle_error' do
+    context 'works with no message or validation_errors' do
+      it do
+        expect do
+          raise described_class
+        end.to raise_error(described_class)
+      end
+    end
+
+    context 'default values works ok' do
+      subject { described_class.new }
+
+      it do
+        expect do
+          raise subject
+        end.to raise_error(described_class)
+      end
+      it { expect(subject.detail).to eq I18n.t('status_code.IER4009_payment_required.detail') }
+    end
+
+    context 'works with message but no validation_errors' do
+      let(:message) { 'my totally non-existent message' }
+
+      subject { described_class.new(message) }
+
+      it do
+        expect do
+          raise subject
+        end.to raise_error(described_class)
+      end
+      it { expect(subject.message).to eq message }
+    end
+
+    context 'works with message & validation_errors' do
+      let(:message) { 'my totally non-existent message' }
+      let(:detail) { { errors: 'my totally non-existent error' } }
+
+      subject { described_class.new(message, nil, detail: detail) }
+
+      it do
+        expect do
+          raise subject
+        end.to raise_error(described_class)
+      end
+      it { expect(subject.detail).to eq detail }
+    end
+
+    context 'works with message & backtrace' do
+      let(:message) { 'my totally non-existent message' }
+
+      subject { described_class.new(message, [message]) }
+
+      it do
+        expect do
+          raise subject
+        end.to raise_error(described_class)
+      end
+      it { expect(subject.backtrace).to eq [message] }
+    end
+  end
+end

data/spec/commons/errors/precondition_failed_spec.rb

@@ -0,0 +1,62 @@
+describe Commons::Errors::PreconditionFailed do
+  describe 'handle_error' do
+    context 'works with no message or validation_errors' do
+      it do
+        expect do
+          raise described_class
+        end.to raise_error(described_class)
+      end
+    end
+
+    context 'default values works ok' do
+      subject { described_class.new }
+
+      it do
+        expect do
+          raise subject
+        end.to raise_error(described_class)
+      end
+      it { expect(subject.detail).to eq I18n.t('status_code.IER4010_precondition_failed.detail') }
+    end
+
+    context 'works with message but no validation_errors' do
+      let(:message) { 'my totally non-existent message' }
+
+      subject { described_class.new(message) }
+
+      it do
+        expect do
+          raise subject
+        end.to raise_error(described_class)
+      end
+      it { expect(subject.message).to eq message }
+    end
+
+    context 'works with message & validation_errors' do
+      let(:message) { 'my totally non-existent message' }
+      let(:detail) { { errors: 'my totally non-existent error' } }
+
+      subject { described_class.new(message, nil, detail: detail) }
+
+      it do
+        expect do
+          raise subject
+        end.to raise_error(described_class)
+      end
+      it { expect(subject.detail).to eq detail }
+    end
+
+    context 'works with message & backtrace' do
+      let(:message) { 'my totally non-existent message' }
+
+      subject { described_class.new(message, [message]) }
+
+      it do
+        expect do
+          raise subject
+        end.to raise_error(described_class)
+      end
+      it { expect(subject.backtrace).to eq [message] }
+    end
+  end
+end

data/spec/commons/errors/resource_not_found_spec.rb

@@ -0,0 +1,49 @@
+describe Commons::Errors::ResourceNotFound do
+  describe 'handle_error' do
+    context 'works with no message or validation_errors' do
+      it do
+        expect do
+          raise described_class
+        end.to raise_error(described_class)
+      end
+    end
+
+    context 'default values works ok' do
+      subject { described_class.new }
+
+      it do
+        expect do
+          raise subject
+        end.to raise_error(described_class)
+      end
+      it { expect(subject.detail).to eq I18n.t('status_code.IER4011_resource_not_found.detail') }
+    end
+
+    context 'works with message but no validation_errors' do
+      let(:message) { 'my totally non-existent message' }
+
+      subject { described_class.new(message) }
+
+      it do
+        expect do
+          raise subject
+        end.to raise_error(described_class)
+      end
+      it { expect(subject.message).to eq message }
+    end
+
+    context 'works with message & validation_errors' do
+      let(:message) { 'my totally non-existent message' }
+      let(:detail) { { errors: 'my totally non-existent error' } }
+
+      subject { described_class.new(message, detail: detail) }
+
+      it do
+        expect do
+          raise subject
+        end.to raise_error(described_class)
+      end
+      it { expect(subject.detail).to eq detail }
+    end
+  end
+end

data/spec/commons/errors/route_not_found_spec.rb

@@ -0,0 +1,49 @@
+describe Commons::Errors::RouteNotFound do
+  describe 'handle_error' do
+    context 'works with no message or validation_errors' do
+      it do
+        expect do
+          raise described_class
+        end.to raise_error(described_class)
+      end
+    end
+
+    context 'default values works ok' do
+      subject { described_class.new }
+
+      it do
+        expect do
+          raise subject
+        end.to raise_error(described_class)
+      end
+      it { expect(subject.detail).to eq I18n.t('status_code.IER4001_route_not_found.detail') }
+    end
+
+    context 'works with message but no validation_errors' do
+      let(:message) { 'my totally non-existent message' }
+
+      subject { described_class.new(message) }
+
+      it do
+        expect do
+          raise subject
+        end.to raise_error(described_class)
+      end
+      it { expect(subject.message).to eq message }
+    end
+
+    context 'works with message & validation_errors' do
+      let(:message) { 'my totally non-existent message' }
+      let(:detail) { { errors: 'my totally non-existent error' } }
+
+      subject { described_class.new(message, detail: detail) }
+
+      it do
+        expect do
+          raise subject
+        end.to raise_error(described_class)
+      end
+      it { expect(subject.detail).to eq detail }
+    end
+  end
+end

data/spec/commons/errors/unauthorized_spec.rb

@@ -0,0 +1,62 @@
+describe Commons::Errors::Unauthorized do
+  describe 'handle_error' do
+    context 'works with no message or validation_errors' do
+      it do
+        expect do
+          raise described_class
+        end.to raise_error(described_class)
+      end
+    end
+
+    context 'default values works ok' do
+      subject { described_class.new }
+
+      it do
+        expect do
+          raise subject
+        end.to raise_error(described_class)
+      end
+      it { expect(subject.detail).to eq I18n.t('status_code.IER4002_unauthorized.detail') }
+    end
+
+    context 'works with message but no validation_errors' do
+      let(:message) { 'my totally non-existent message' }
+
+      subject { described_class.new(message) }
+
+      it do
+        expect do
+          raise subject
+        end.to raise_error(described_class)
+      end
+      it { expect(subject.message).to eq message }
+    end
+
+    context 'works with message & validation_errors' do
+      let(:message) { 'my totally non-existent message' }
+      let(:detail) { { errors: 'my totally non-existent error' } }
+
+      subject { described_class.new(message, nil, detail: detail) }
+
+      it do
+        expect do
+          raise subject
+        end.to raise_error(described_class)
+      end
+      it { expect(subject.detail).to eq detail }
+    end
+
+    context 'works with message & backtrace' do
+      let(:message) { 'my totally non-existent message' }
+
+      subject { described_class.new(message, [message]) }
+
+      it do
+        expect do
+          raise subject
+        end.to raise_error(described_class)
+      end
+      it { expect(subject.backtrace).to eq [message] }
+    end
+  end
+end

data/spec/commons/errors/unprocessable_entity_spec.rb

@@ -0,0 +1,62 @@
+describe Commons::Errors::UnprocessableEntity do
+  describe 'handle_error' do
+    context 'works with no message or validation_errors' do
+      it do
+        expect do
+          raise described_class
+        end.to raise_error(described_class)
+      end
+    end
+
+    context 'default values works ok' do
+      subject { described_class.new }
+
+      it do
+        expect do
+          raise subject
+        end.to raise_error(described_class)
+      end
+      it { expect(subject.detail).to eq I18n.t('status_code.IER4222_unprocessable_entity.detail') }
+    end
+
+    context 'works with message but no validation_errors' do
+      let(:message) { 'my totally non-existent message' }
+
+      subject { described_class.new(message) }
+
+      it do
+        expect do
+          raise subject
+        end.to raise_error(described_class)
+      end
+      it { expect(subject.message).to eq message }
+    end
+
+    context 'works with message & validation_errors' do
+      let(:message) { 'my totally non-existent message' }
+      let(:detail) { { errors: 'my totally non-existent error' } }
+
+      subject { described_class.new(message, nil, detail: detail) }
+
+      it do
+        expect do
+          raise subject
+        end.to raise_error(described_class)
+      end
+      it { expect(subject.detail).to eq detail }
+    end
+
+    context 'works with message & backtrace' do
+      let(:message) { 'my totally non-existent message' }
+
+      subject { described_class.new(message, [message]) }
+
+      it do
+        expect do
+          raise subject
+        end.to raise_error(described_class)
+      end
+      it { expect(subject.backtrace).to eq [message] }
+    end
+  end
+end

data/spec/commons/formatter/e164_phone_spec.rb

@@ -0,0 +1,155 @@
+def phone_list
+  [
+    { phone: '+1 (415) 555-3695', format: '+14155553695', custom_format: nil },
+    { phone: '5345 8120', format: "+5353458120", custom_format: nil },
+    { phone: '898 5754', format: nil, custom_format: nil }, # local
+    { phone: '208 516 7431', format: nil, custom_format: nil }, # USA pero sin +1
+    { phone: '+57 301 2665494', format: '+573012665494', custom_format: nil }, # Colombia
+    { phone: '+54 9 342 429 8094', format: '+5493424298094', custom_format: nil }, # Argentina móvil
+    { phone: '+1 712-269-8405', format: '+17122698405', custom_format: nil },
+    { phone: '+52 998 260 0303', format: '+529982600303', custom_format: '+529982600303' },
+    { phone: '+52 998 260 0550', format: '+529982600550', custom_format: '+529982600550' },
+    { phone: '999 227 4887', format: '+529992274887', custom_format: '+529992274887' },
+    { phone: '998 260 0550', format: '+529982600550', custom_format: '+529982600550' },
+    { phone: '998 260 0303', format: '+529982600303', custom_format: '+529982600303' },
+    # El siguiente número es USA pero sin +1 pasa todas las validaciones, es un falso positivo
+    { phone: '712-269-8405', format: '+527122698405', custom_format: '+527122698405' },
+    { phone: '999 926 3252', format: '+529999263252', custom_format: '+529999263252' }, # MX local
+    { phone: '998-898-5754', format: '+529988985754', custom_format: '+529988985754' },
+    { phone: '722.196.0105', format: '+527221960105', custom_format: '+527221960105' },
+    # Número de USA pero sin (+)
+    { phone: '1832 928 5078', format: '+528329285078', custom_format: nil },
+    { phone: '+1 (972) 3636278', format: '+19723636278', custom_format: nil },
+    { phone: '+ 1 (832) 928 5078', format: '+18329285078', custom_format: nil },
+    { phone: '8880178769', format: '+528880178769', custom_format: '+528880178769' },
+    { phone: '+5218880178769', format: '+528880178769', custom_format: '+528880178769' },
+  ]
+end
+
+RSpec.describe Commons::Formatter::E164Phone do
+  describe 'valid for México' do
+    phone_list.each do |testCase|
+      context "number #{testCase[:phone]}" do
+        formatter = Commons::Formatter::E164Phone.new(testCase[:phone])
+        formatted_phone = formatter.format
+        it { expect(formatted_phone).to eq testCase[:format] }
+       end
+    end
+  end
+
+  context 'with valid phone numbers' do
+    test_cases = [
+      { phone: '(999)1485541', result: '+529991485541' },
+      { phone: '+5219991485541', result: '+529991485541' },
+      { phone: '999 1 48 55 41', result: '+529991485541' },
+      { phone: '999-1-48-55-41', result: '+529991485541' },
+      { phone: '+529991485541', result: '+529991485541' },
+      { phone: '019991485541', result: '+529991485541' },
+      { phone: '019991485541', result: '+529991485541' },
+    ]
+
+    test_cases.each do |test_case|
+      context "number #{test_case[:phone]}" do
+        subject { Commons::Formatter::E164Phone.new(test_case[:phone]) }
+
+        it { expect(subject.format).to eq test_case[:result] }
+      end
+    end
+  end
+
+  context 'invalid phone numbers' do
+    test_cases = [
+      { phone: ')' },
+      { phone: '()' },
+      { phone: '' },
+    ]
+
+    test_cases.each do |test_case|
+      context "number #{test_case[:phone]}" do
+        subject { Commons::Formatter::E164Phone.new(test_case[:phone]) }
+
+        it { expect(subject.format).to be_nil }
+      end
+    end
+  end
+
+  context 'format_national works ok!' do
+    test_cases = [
+      { phone: '9991485541', result: '9991485541' },
+      { phone: '(999)1485541', result: '9991485541' },
+      { phone: '+5219991485541', result: '9991485541' },
+      { phone: '999 1 48 55 41', result: '9991485541' },
+      { phone: '999-1-48-55-41', result: '9991485541' },
+      { phone: '+529991485541', result: '9991485541' },
+      { phone: '019991485541', result: '9991485541' },
+      { phone: '019991485541', result: '9991485541' },
+    ]
+
+    test_cases.each do |test_case|
+      context "number #{test_case[:phone]}" do
+        subject { Commons::Formatter::E164Phone.new(test_case[:phone]) }
+
+        it { expect(subject.format_national).to eq test_case[:result] }
+      end
+    end
+  end
+
+  context 'format_extension works ok!' do
+    test_cases = [
+      { phone: '+5219991485541', result: '52' },
+      { phone: '+529991485541', result: '52' },
+      { phone: '+1 (972) 3636278', result: '1' },
+      { phone: '+ 1 (832) 928 5078', result: '1' },
+      { phone: '+57 301 2665494', result: '57' },
+      { phone: '+54 9 342 429 8094', result: '54' },
+    ]
+
+    test_cases.each do |test_case|
+      context "number #{test_case[:phone]}" do
+        subject { Commons::Formatter::E164Phone.new(test_case[:phone]) }
+
+        it { expect(subject.country_code).to eq test_case[:result] }
+      end
+    end
+  end
+
+  describe 'canonical_phone' do
+    context 'matches valid phones' do
+      test_cases = [
+        { phone: '+5219991485541', result: '9991485541' },
+        { phone: '+529991485541', result: '9991485541' },
+        { phone: '9723636278', result: '9723636278' },
+        { phone: '  (832) 928 5078', result: '8329285078' },
+        { phone: '+52 301 2665494', result: '3012665494' },
+        { phone: '+52 342 429 8094', result: '3424298094' },
+      ]
+
+      test_cases.each do |test_case|
+        context "number #{test_case[:phone]}" do
+          subject { Commons::Formatter::E164Phone.canonical_phone(test_case[:phone]) }
+
+          it { expect(subject).to eq test_case[:result] }
+        end
+      end
+    end
+
+    context 'do not match invalid phones' do
+      test_cases = [
+        '+52219991485541',
+        '+5229991485541',
+        '+1 (972) 3636278',
+        '+ 1 (832) 928 5078',
+        '+57 301 2665494',
+        '+54 9 342 429 8094',
+      ]
+
+      test_cases.each do |test_case|
+        context "number #{test_case}" do
+          subject { Commons::Formatter::E164Phone.canonical_phone(test_case) }
+
+          it { expect(subject).to be_nil }
+        end
+      end
+    end
+  end
+end