commonmarker 0.20.1 → 0.22.0

data/test/test_node.rb

@@ -12,7 +12,7 @@ class TestNode < Minitest::Test
     @doc.walk do |node|
       nodes << node.type
     end
-    assert_equal [:document, :paragraph, :text, :emph, :text, :text], nodes
+    assert_equal %i[document paragraph text emph text text], nodes
   end
 
   def test_each
@@ -20,29 +20,29 @@ class TestNode < Minitest::Test
     @doc.first_child.each do |node|
       nodes << node.type
     end
-    assert_equal [:text, :emph, :text], nodes
+    assert_equal %i[text emph text], nodes
   end
 
   def test_deprecated_each_child
     nodes = []
-    out, err = capture_io do
+    _, err = capture_io do
       @doc.first_child.each_child do |node|
         nodes << node.type
       end
     end
-    assert_equal [:text, :emph, :text], nodes
-    assert_match /`each_child` is deprecated/, err
+    assert_equal %i[text emph text], nodes
+    assert_match(/`each_child` is deprecated/, err)
   end
 
   def test_select
     nodes = @doc.first_child.select { |node| node.type == :text }
     assert_equal CommonMarker::Node, nodes.first.class
-    assert_equal [:text, :text], nodes.map(&:type)
+    assert_equal %i[text text], nodes.map(&:type)
   end
 
   def test_map
     nodes = @doc.first_child.map(&:type)
-    assert_equal [:text, :emph, :text], nodes
+    assert_equal %i[text emph text], nodes
   end
 
   def test_insert_illegal
@@ -63,9 +63,7 @@ class TestNode < Minitest::Test
 
   def test_walk_and_set_string_content
     @doc.walk do |node|
-      if node.type == :text && node.string_content == 'there'
-        node.string_content = 'world'
-      end
+      node.string_content = 'world' if node.type == :text && node.string_content == 'there'
     end
     result = HtmlRenderer.new.render(@doc)
     assert_equal "<p>Hi <em>world</em>, I am mostly text!</p>\n", result
@@ -82,10 +80,10 @@ class TestNode < Minitest::Test
   end
 
   def test_inspect
-    assert_match /#<CommonMarker::Node\(document\):/, @doc.inspect
+    assert_match(/#<CommonMarker::Node\(document\):/, @doc.inspect)
   end
 
   def test_pretty_print
-    assert_match /#<CommonMarker::Node\(document\):/, PP.pp(@doc, ''.dup)
+    assert_match(/#<CommonMarker::Node\(document\):/, PP.pp(@doc, +''))
   end
 end

data/test/test_options.rb

@@ -4,34 +4,34 @@ require 'test_helper'
 
 class TestExtensions < Minitest::Test
   def test_full_info_string
-    md = <<-MD
-```ruby
-module Foo
-```
+    md = <<~MD
+      ```ruby
+      module Foo
+      ```
     MD
 
     CommonMarker.render_html(md, :FULL_INFO_STRING).tap do |out|
-      assert_includes out, %q(<pre><code class="language-ruby">)
+      assert_includes out, '<pre><code class="language-ruby">'
     end
 
-    md = <<-MD
-```ruby my info string
-module Foo
-```
+    md = <<~MD
+      ```ruby my info string
+      module Foo
+      ```
     MD
 
     CommonMarker.render_html(md, :FULL_INFO_STRING).tap do |out|
-      assert_includes out, %q(<pre><code class="language-ruby" data-meta="my info string">)
+      assert_includes out, '<pre><code class="language-ruby" data-meta="my info string">'
     end
 
-    md = <<-MD
-```ruby my \x00 string
-module Foo
-```
+    md = <<~MD
+      ```ruby my \x00 string
+      module Foo
+      ```
     MD
 
     CommonMarker.render_html(md, :FULL_INFO_STRING).tap do |out|
-      assert_includes out, %Q(<pre><code class="language-ruby" data-meta="my � string">)
+      assert_includes out, %(<pre><code class="language-ruby" data-meta="my � string">)
     end
   end
 end

data/test/test_pathological_inputs.rb

@@ -3,14 +3,14 @@
 require 'test_helper'
 require 'minitest/benchmark' if ENV['BENCH']
 
-def markdown(s)
-  CommonMarker.render_doc(s).to_html
+def markdown(str)
+  CommonMarker.render_doc(str).to_html
 end
 
 # list of pairs consisting of input and a regex that must match the output.
 pathological = {
   'nested strong emph' =>
-              [('*a **a ' * 65_000) + 'b' + (' a** a*' * 65_000),
+              ["#{'*a **a ' * 65_000}b#{' a** a*' * 65_000}",
                Regexp.compile('(<em>a <strong>a ){65_000}b( a</strong> a</em>){65_000}')],
   'many emph closers with no openers' =>
                [('a_ ' * 65_000),
@@ -34,10 +34,10 @@ pathological = {
                ['**x [a*b**c*](d)',
                 Regexp.compile('\\*\\*x <a href=\'d\'>a<em>b</em><em>c</em></a>')],
   'nested brackets' =>
-               [('[' * 50_000) + 'a' + (']' * 50_000),
+               ["#{'[' * 50_000}a#{']' * 50_000}",
                 Regexp.compile('\[{50000}a\]{50000}')],
   'nested block quotes' =>
-               [(('> ' * 50_000) + 'a'),
+               ["#{'> ' * 50_000}a",
                 Regexp.compile('(<blockquote>\n){50000}')],
   'U+0000 in input' =>
                ['abc\u0000de\u0000',
@@ -53,41 +53,41 @@ end
 
 if ENV['BENCH']
   class PathologicalInputsPerformanceTest < Minitest::Benchmark
-    def bench_pathological_1
+    def test_bench_pathological_one
       assert_performance_linear 0.99 do |n|
         star = '*' * (n * 10)
         markdown("#{star}#{star}hi#{star}#{star}")
       end
     end
 
-    def bench_pathological_2
+    def test_bench_pathological_two
       assert_performance_linear 0.99 do |n|
         c = '`t`t`t`t`t`t' * (n * 10)
         markdown(c)
       end
     end
 
-    def bench_pathological_3
+    def test_bench_pathological_three
       assert_performance_linear 0.99 do |n|
         markdown(" [a]: #{'A' * n}\n\n#{'[a][]' * n}\n")
       end
     end
 
-    def bench_pathological_4
+    def test_bench_pathological_four
       assert_performance_linear 0.5 do |n|
         markdown("#{'[' * n}a#{']' * n}")
       end
     end
 
-    def bench_pathological_5
+    def test_bench_pathological_five
       assert_performance_linear 0.99 do |n|
         markdown("#{'**a *a ' * n}#{'a* a**' * n}")
       end
     end
 
-    def bench_unbound_recursion
+    def test_bench_unbound_recursion
       assert_performance_linear 0.99 do |n|
-        markdown(('[' * n) + 'foo' + ('](bar)' * n))
+        markdown("#{'[' * n}foo#{'](bar)' * n}")
       end
     end
   end

data/test/test_plaintext.rb

@@ -4,19 +4,19 @@ require 'test_helper'
 
 class TestPlaintext < Minitest::Test
   def setup
-    @markdown = <<-MD
-Hi *there*!
+    @markdown = <<~MD
+      Hi *there*!
 
-1. I am a numeric list.
-2. I continue the list.
-* Suddenly, an unordered list!
-* What fun!
+      1. I am a numeric list.
+      2. I continue the list.
+      * Suddenly, an unordered list!
+      * What fun!
 
-Okay, _enough_.
+      Okay, _enough_.
 
-| a   | b   |
-| --- | --- |
-| c   | d   |
+      | a   | b   |
+      | --- | --- |
+      | c   | d   |
     MD
   end
 
@@ -27,20 +27,20 @@ Okay, _enough_.
   def test_to_commonmark
     compare = render_doc(@markdown).to_plaintext
 
-    assert_equal <<-PLAINTEXT, compare
-Hi there!
+    assert_equal <<~PLAINTEXT, compare
+      Hi there!
 
-1.  I am a numeric list.
-2.  I continue the list.
+      1.  I am a numeric list.
+      2.  I continue the list.
 
-  - Suddenly, an unordered list!
-  - What fun!
+        - Suddenly, an unordered list!
+        - What fun!
 
-Okay, enough.
+      Okay, enough.
 
-| a | b |
-| --- | --- |
-| c | d |
-      PLAINTEXT
+      | a | b |
+      | --- | --- |
+      | c | d |
+    PLAINTEXT
   end
 end

data/test/test_renderer.rb

@@ -14,17 +14,34 @@ class TestRenderer < Minitest::Test
   end
 
   def test_multiple_tables
-    content = '''
-| Input       | Expected         | Actual    |
-| ----------- | ---------------- | --------- |
-| One         | Two              | Three     |
-
-| Header   | Row  | Example |
-| :------: | ---: | :------ |
-| Foo      | Bar  | Baz     |
-'''
-    doc = CommonMarker.render_doc(content, :DEFAULT, [:autolink, :table, :tagfilter])
+    content = <<~DOC
+      | Input       | Expected         | Actual    |
+      | ----------- | ---------------- | --------- |
+      | One         | Two              | Three     |
+
+      | Header   | Row  | Example |
+      | :------: | ---: | :------ |
+      | Foo      | Bar  | Baz     |
+    DOC
+    doc = CommonMarker.render_doc(content, :DEFAULT, %i[autolink table tagfilter])
     results = CommonMarker::HtmlRenderer.new.render(doc)
     assert_equal 2, results.scan(/<tbody>/).size
   end
+
+  def test_escape_html_encoding
+    my_renderer = Class.new(HtmlRenderer) do
+      attr_reader :input_encoding, :output_encoding
+
+      def text(node)
+        @input_encoding = node.string_content.encoding
+        escape_html(node.string_content).tap do |escaped|
+          @output_encoding = escaped.encoding
+        end
+      end
+    end
+
+    renderer = my_renderer.new
+    assert_equal Encoding::UTF_8, renderer.render(@doc).encoding
+    assert_equal renderer.input_encoding, renderer.output_encoding
+  end
 end

data/test/test_spec.rb

@@ -8,6 +8,7 @@ class TestSpec < Minitest::Test
 
   spec.each do |testcase|
     next if testcase[:extensions].include?(:disabled)
+
     doc = CommonMarker.render_doc(testcase[:markdown], :DEFAULT, testcase[:extensions])
 
     define_method("test_to_html_example_#{testcase[:example]}") do
@@ -21,8 +22,8 @@ class TestSpec < Minitest::Test
     end
 
     define_method("test_sourcepos_example_#{testcase[:example]}") do
-      lhs = doc.to_html([:UNSAFE, :SOURCEPOS], testcase[:extensions]).rstrip
-      rhs = HtmlRenderer.new(options: [:UNSAFE, :SOURCEPOS], extensions: testcase[:extensions]).render(doc).rstrip
+      lhs = doc.to_html(%i[UNSAFE SOURCEPOS], testcase[:extensions]).rstrip
+      rhs = HtmlRenderer.new(options: %i[UNSAFE SOURCEPOS], extensions: testcase[:extensions]).render(doc).rstrip
       assert_equal lhs, rhs, testcase[:markdown]
     end
   end

data/test/test_tasklists.rb

@@ -7,13 +7,13 @@ class TestTasklists < Minitest::Test
     text = <<-MD
  - [x] Add task list
  - [ ] Define task list
-MD
+    MD
     @doc = CommonMarker.render_doc(text, :DEFAULT, %i[tasklist])
-    @expected = <<-HTML
-<ul>
-<li><input type="checkbox" checked="" disabled="" /> Add task list</li>
-<li><input type="checkbox" disabled="" /> Define task list</li>
-</ul>
+    @expected = <<~HTML
+      <ul>
+      <li><input type="checkbox" checked="" disabled="" /> Add task list</li>
+      <li><input type="checkbox" disabled="" /> Define task list</li>
+      </ul>
     HTML
   end
 
@@ -28,6 +28,16 @@ MD
   def test_tasklist_state
     list = @doc.first_child
     assert_equal 'checked', list.first_child.tasklist_state
+    assert list.first_child.tasklist_item_checked?
     assert_equal 'unchecked', list.first_child.next.tasklist_state
+    refute list.first_child.next.tasklist_item_checked?
+  end
+
+  def test_set_tasklist_state
+    list = @doc.first_child
+    list.first_child.tasklist_item_checked = false
+    refute list.first_child.tasklist_item_checked?
+    list.first_child.next.tasklist_item_checked = true
+    assert list.first_child.next.tasklist_item_checked?
   end
 end

metadata

@@ -1,88 +1,74 @@
 --- !ruby/object:Gem::Specification
 name: commonmarker
 version: !ruby/object:Gem::Version
-  version: 0.20.1
+  version: 0.22.0
 platform: ruby
 authors:
 - Garen Torikian
 - Ashe Connor
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-04-29 00:00:00.000000000 Z
+date: 2021-06-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: ruby-enum
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.5'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.5'
-- !ruby/object:Gem::Dependency
-  name: minitest
+  name: awesome_print
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '5.6'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '5.6'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: minitest-focus
+  name: json
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: '2.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: '2.3'
 - !ruby/object:Gem::Dependency
-  name: rake-compiler
+  name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '5.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '5.6'
 - !ruby/object:Gem::Dependency
-  name: json
+  name: minitest-focus
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.8.1
+        version: '1.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.8.1
+        version: '1.1'
 - !ruby/object:Gem::Dependency
-  name: awesome_print
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -96,33 +82,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: rake-compiler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.9'
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.1'
+        version: '6.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.1'
+        version: '6.2'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -153,7 +139,7 @@ dependencies:
         version: '0'
 description: A fast, safe, extensible parser for CommonMark. This wraps the official
   libcmark library.
-email: 
+email:
 executables:
 - commonmarker
 extensions:
@@ -246,8 +232,11 @@ files:
 - test/benchmark.rb
 - test/fixtures/curly.md
 - test/fixtures/dingus.md
+- test/fixtures/strong.md
+- test/fixtures/table.md
 - test/test_attributes.rb
 - test/test_basics.rb
+- test/test_commands.rb
 - test/test_commonmark.rb
 - test/test_doc.rb
 - test/test_encoding.rb
@@ -269,7 +258,7 @@ homepage: https://github.com/gjtorikian/commonmarker
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options:
 - "-x"
 - ext/commonmarker/cmark/.*
@@ -280,38 +269,43 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.0.0
+      version: '2.6'
+  - - "<"
+    - !ruby/object:Gem::Version
+      version: '4.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.1
-signing_key: 
+rubygems_version: 3.1.4
+signing_key:
 specification_version: 4
 summary: CommonMark parser and renderer. Written in C, wrapped in Ruby.
 test_files:
-- test/benchmark.rb
-- test/fixtures/curly.md
-- test/fixtures/dingus.md
 - test/test_attributes.rb
-- test/test_basics.rb
-- test/test_commonmark.rb
+- test/test_linebreaks.rb
 - test/test_doc.rb
+- test/test_plaintext.rb
+- test/test_pathological_inputs.rb
+- test/test_node.rb
+- test/test_maliciousness.rb
+- test/test_commands.rb
+- test/test_tasklists.rb
+- test/test_commonmark.rb
 - test/test_encoding.rb
-- test/test_extensions.rb
+- test/test_smartpunct.rb
+- test/test_spec.rb
 - test/test_footnotes.rb
-- test/test_gc.rb
+- test/test_extensions.rb
+- test/fixtures/dingus.md
+- test/fixtures/strong.md
+- test/fixtures/table.md
+- test/fixtures/curly.md
 - test/test_helper.rb
-- test/test_linebreaks.rb
-- test/test_maliciousness.rb
-- test/test_node.rb
 - test/test_options.rb
-- test/test_pathological_inputs.rb
-- test/test_plaintext.rb
+- test/benchmark.rb
+- test/test_basics.rb
 - test/test_renderer.rb
-- test/test_smartpunct.rb
-- test/test_spec.rb
-- test/test_tasklists.rb
+- test/test_gc.rb