commonmarker 0.17.13 → 0.23.4

data/test/test_linebreaks.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class TestLinebreaks < Minitest::Test

data/test/test_maliciousness.rb

@@ -1,263 +1,262 @@
-require 'test_helper'
+# frozen_string_literal: true
 
-class CommonMarker::TestMaliciousness < Minitest::Test
-  def setup
-    @doc = CommonMarker.render_doc('Hi *there*')
-  end
+require 'test_helper'
 
-  def test_init_with_bad_type
-    assert_raises TypeError do
-      Node.new(123)
+module CommonMarker
+  class TestMaliciousness < Minitest::Test
+    def setup
+      @doc = CommonMarker.render_doc('Hi *there*')
     end
 
-    assert_raises NodeError do
-      Node.new(:totes_fake)
-    end
+    def test_init_with_bad_type
+      assert_raises TypeError do
+        Node.new(123)
+      end
 
-    assert_raises TypeError do
-      Node.new([])
-    end
+      assert_raises NodeError do
+        Node.new(:totes_fake)
+      end
 
-    assert_raises TypeError do
-      Node.new([23])
-    end
+      assert_raises TypeError do
+        Node.new([])
+      end
 
-    assert_raises TypeError do
-      Node.new(nil)
-    end
-  end
+      assert_raises TypeError do
+        Node.new([23])
+      end
 
-  def test_rendering_with_bad_type
-    assert_raises TypeError do
-      CommonMarker.render_html("foo \n baz", 123)
+      assert_raises TypeError do
+        Node.new(nil)
+      end
     end
 
-    assert_raises TypeError do
-      CommonMarker.render_html("foo \n baz", :totes_fake)
-    end
+    def test_rendering_with_bad_type
+      assert_raises TypeError do
+        CommonMarker.render_html("foo \n baz", 123)
+      end
 
-    assert_raises TypeError do
-      CommonMarker.render_html("foo \n baz", [])
-    end
+      assert_raises TypeError do
+        CommonMarker.render_html("foo \n baz", :totes_fake)
+      end
 
-    assert_raises TypeError do
-      CommonMarker.render_html("foo \n baz", [23])
-    end
+      assert_raises TypeError do
+        CommonMarker.render_html("foo \n baz", [])
+      end
 
-    assert_raises TypeError do
-      CommonMarker.render_html("foo \n baz", nil)
-    end
+      assert_raises TypeError do
+        CommonMarker.render_html("foo \n baz", [23])
+      end
 
-    assert_raises TypeError do
-      CommonMarker.render_html("foo \n baz", [:SMART, 'totes_fake'])
-    end
+      assert_raises TypeError do
+        CommonMarker.render_html("foo \n baz", nil)
+      end
 
-    assert_raises TypeError do
-      CommonMarker.render_html(123)
-    end
+      assert_raises TypeError do
+        CommonMarker.render_html("foo \n baz", [:SMART, 'totes_fake'])
+      end
 
-    assert_raises TypeError do
-      CommonMarker.render_html([123])
-    end
+      assert_raises TypeError do
+        CommonMarker.render_html(123)
+      end
 
-    assert_raises TypeError do
-      CommonMarker.render_html(nil)
-    end
+      assert_raises TypeError do
+        CommonMarker.render_html([123])
+      end
 
-    err = assert_raises TypeError do
-      CommonMarker.render_html("foo \n baz", [:SMART])
-    end
-    assert_equal err.message, 'option \':SMART\' does not exist for CommonMarker::Config::Render'
+      assert_raises TypeError do
+        CommonMarker.render_html(nil)
+      end
 
-    assert_raises TypeError do
-      CommonMarker.render_doc("foo \n baz", 123)
-    end
+      assert_raises TypeError do
+        CommonMarker.render_doc("foo \n baz", 123)
+      end
 
-    err = assert_raises TypeError do
-      CommonMarker.render_doc("foo \n baz", :safe)
-    end
-    assert_equal err.message, 'option \':safe\' does not exist for CommonMarker::Config::Parse'
+      err = assert_raises TypeError do
+        CommonMarker.render_doc("foo \n baz", :safe)
+      end
+      assert_equal('option \':safe\' does not exist for CommonMarker::Config::OPTS[:parse]', err.message)
 
-    assert_raises TypeError do
-      CommonMarker.render_doc("foo \n baz", :totes_fake)
-    end
+      assert_raises TypeError do
+        CommonMarker.render_doc("foo \n baz", :totes_fake)
+      end
 
-    assert_raises TypeError do
-      CommonMarker.render_doc("foo \n baz", [])
-    end
+      assert_raises TypeError do
+        CommonMarker.render_doc("foo \n baz", [])
+      end
 
-    assert_raises TypeError do
-      CommonMarker.render_doc("foo \n baz", [23])
-    end
+      assert_raises TypeError do
+        CommonMarker.render_doc("foo \n baz", [23])
+      end
 
-    assert_raises TypeError do
-      CommonMarker.render_doc("foo \n baz", nil)
-    end
+      assert_raises TypeError do
+        CommonMarker.render_doc("foo \n baz", nil)
+      end
 
-    assert_raises TypeError do
-      CommonMarker.render_doc("foo \n baz", [:SMART, 'totes_fake'])
-    end
+      assert_raises TypeError do
+        CommonMarker.render_doc("foo \n baz", [:SMART, 'totes_fake'])
+      end
 
-    assert_raises TypeError do
-      CommonMarker.render_doc(123)
-    end
+      assert_raises TypeError do
+        CommonMarker.render_doc(123)
+      end
 
-    assert_raises TypeError do
-      CommonMarker.render_doc([123])
-    end
+      assert_raises TypeError do
+        CommonMarker.render_doc([123])
+      end
 
-    assert_raises TypeError do
-      CommonMarker.render_doc(nil)
+      assert_raises TypeError do
+        CommonMarker.render_doc(nil)
+      end
     end
-  end
 
-  def test_bad_set_string_content
-    assert_raises TypeError do
-      @doc.string_content = 123
+    def test_bad_set_string_content
+      assert_raises TypeError do
+        @doc.string_content = 123
+      end
     end
-  end
-
-  def test_bad_walking
-    assert_nil @doc.parent
-    assert_nil @doc.previous
-  end
 
-  def test_bad_insertion
-    code = Node.new(:code)
-    assert_raises NodeError do
-      @doc.insert_before(code)
+    def test_bad_walking
+      assert_nil @doc.parent
+      assert_nil @doc.previous
     end
 
-    paragraph = Node.new(:paragraph)
-    assert_raises NodeError do
-      @doc.insert_after(paragraph)
-    end
+    def test_bad_insertion
+      code = Node.new(:code)
+      assert_raises NodeError do
+        @doc.insert_before(code)
+      end
 
-    document = Node.new(:document)
-    assert_raises NodeError do
-      @doc.prepend_child(document)
-    end
+      paragraph = Node.new(:paragraph)
+      assert_raises NodeError do
+        @doc.insert_after(paragraph)
+      end
 
-    assert_raises NodeError do
-      @doc.append_child(document)
-    end
-  end
+      document = Node.new(:document)
+      assert_raises NodeError do
+        @doc.prepend_child(document)
+      end
 
-  def test_bad_url_get
-    assert_raises NodeError do
-      @doc.url
+      assert_raises NodeError do
+        @doc.append_child(document)
+      end
     end
-  end
 
-  def test_bad_url_set
-    assert_raises NodeError do
-      @doc.url = '123'
+    def test_bad_url_get
+      assert_raises NodeError do
+        @doc.url
+      end
     end
 
-    link = CommonMarker.render_doc('[GitHub](https://www.github.com)').first_child.first_child
-    assert_raises TypeError do
-      link.url = 123
-    end
-  end
+    def test_bad_url_set
+      assert_raises NodeError do
+        @doc.url = '123'
+      end
 
-  def test_bad_title_get
-    assert_raises NodeError do
-      @doc.title
+      link = CommonMarker.render_doc('[GitHub](https://www.github.com)').first_child.first_child
+      assert_raises TypeError do
+        link.url = 123
+      end
     end
-  end
 
-  def test_bad_title_set
-    assert_raises NodeError do
-      @doc.title = '123'
+    def test_bad_title_get
+      assert_raises NodeError do
+        @doc.title
+      end
     end
 
-    image = CommonMarker.render_doc('![alt text](https://github.com/favicon.ico "Favicon")')
-    image = image.first_child.first_child
-    assert_raises TypeError do
-      image.title = 123
-    end
-  end
+    def test_bad_title_set
+      assert_raises NodeError do
+        @doc.title = '123'
+      end
 
-  def test_bad_header_level_get
-    assert_raises NodeError do
-      @doc.header_level
+      image = CommonMarker.render_doc('![alt text](https://github.com/favicon.ico "Favicon")')
+      image = image.first_child.first_child
+      assert_raises TypeError do
+        image.title = 123
+      end
     end
-  end
 
-  def test_bad_header_level_set
-    assert_raises NodeError do
-      @doc.header_level = 1
+    def test_bad_header_level_get
+      assert_raises NodeError do
+        @doc.header_level
+      end
     end
 
-    header = CommonMarker.render_doc('### Header Three').first_child
-    assert_raises TypeError do
-      header.header_level = '123'
-    end
-  end
+    def test_bad_header_level_set
+      assert_raises NodeError do
+        @doc.header_level = 1
+      end
 
-  def test_bad_list_type_get
-    assert_raises NodeError do
-      @doc.list_type
+      header = CommonMarker.render_doc('### Header Three').first_child
+      assert_raises TypeError do
+        header.header_level = '123'
+      end
     end
-  end
 
-  def test_bad_list_type_set
-    assert_raises NodeError do
-      @doc.list_type = :bullet_list
+    def test_bad_list_type_get
+      assert_raises NodeError do
+        @doc.list_type
+      end
     end
 
-    ul_list = CommonMarker.render_doc("* Bullet\n*Bullet").first_child
-    assert_raises NodeError do
-      ul_list.list_type = :fake
-    end
-    assert_raises TypeError do
-      ul_list.list_type = 1234
-    end
-  end
+    def test_bad_list_type_set
+      assert_raises NodeError do
+        @doc.list_type = :bullet_list
+      end
 
-  def test_bad_list_start_get
-    assert_raises NodeError do
-      @doc.list_start
+      ul_list = CommonMarker.render_doc("* Bullet\n*Bullet").first_child
+      assert_raises NodeError do
+        ul_list.list_type = :fake
+      end
+      assert_raises TypeError do
+        ul_list.list_type = 1234
+      end
     end
-  end
 
-  def test_bad_list_start_set
-    assert_raises NodeError do
-      @doc.list_start = 12
+    def test_bad_list_start_get
+      assert_raises NodeError do
+        @doc.list_start
+      end
     end
 
-    ol_list = CommonMarker.render_doc("1. One\n2. Two").first_child
-    assert_raises TypeError do
-      ol_list.list_start = :fake
-    end
-  end
+    def test_bad_list_start_set
+      assert_raises NodeError do
+        @doc.list_start = 12
+      end
 
-  def test_bad_list_tight_get
-    assert_raises NodeError do
-      @doc.list_tight
+      ol_list = CommonMarker.render_doc("1. One\n2. Two").first_child
+      assert_raises TypeError do
+        ol_list.list_start = :fake
+      end
     end
-  end
 
-  def test_bad_list_tight_set
-    assert_raises NodeError do
-      @doc.list_tight = false
+    def test_bad_list_tight_get
+      assert_raises NodeError do
+        @doc.list_tight
+      end
     end
-  end
 
-  def test_bad_fence_info_get
-    assert_raises NodeError do
-      @doc.fence_info
+    def test_bad_list_tight_set
+      assert_raises NodeError do
+        @doc.list_tight = false
+      end
     end
-  end
 
-  def test_bad_fence_info_set
-    assert_raises NodeError do
-      @doc.fence_info = 'ruby'
+    def test_bad_fence_info_get
+      assert_raises NodeError do
+        @doc.fence_info
+      end
     end
 
-    fence = CommonMarker.render_doc("``` ruby\nputs 'wow'\n```").first_child
-    assert_raises TypeError do
-      fence.fence_info = 123
+    def test_bad_fence_info_set
+      assert_raises NodeError do
+        @doc.fence_info = 'ruby'
+      end
+
+      fence = CommonMarker.render_doc("``` ruby\nputs 'wow'\n```").first_child
+      assert_raises TypeError do
+        fence.fence_info = 123
+      end
     end
   end
 end

data/test/test_node.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class TestNode < Minitest::Test
@@ -10,7 +12,7 @@ class TestNode < Minitest::Test
     @doc.walk do |node|
       nodes << node.type
     end
-    assert_equal [:document, :paragraph, :text, :emph, :text, :text], nodes
+    assert_equal %i[document paragraph text emph text text], nodes
   end
 
   def test_each
@@ -18,29 +20,29 @@ class TestNode < Minitest::Test
     @doc.first_child.each do |node|
       nodes << node.type
     end
-    assert_equal [:text, :emph, :text], nodes
+    assert_equal %i[text emph text], nodes
   end
 
   def test_deprecated_each_child
     nodes = []
-    out, err = capture_io do
+    _, err = capture_io do
       @doc.first_child.each_child do |node|
         nodes << node.type
       end
     end
-    assert_equal [:text, :emph, :text], nodes
-    assert_match /`each_child` is deprecated/, err
+    assert_equal %i[text emph text], nodes
+    assert_match(/`each_child` is deprecated/, err)
   end
 
   def test_select
     nodes = @doc.first_child.select { |node| node.type == :text }
     assert_equal CommonMarker::Node, nodes.first.class
-    assert_equal [:text, :text], nodes.map(&:type)
+    assert_equal %i[text text], nodes.map(&:type)
   end
 
   def test_map
     nodes = @doc.first_child.map(&:type)
-    assert_equal [:text, :emph, :text], nodes
+    assert_equal %i[text emph text], nodes
   end
 
   def test_insert_illegal
@@ -61,9 +63,7 @@ class TestNode < Minitest::Test
 
   def test_walk_and_set_string_content
     @doc.walk do |node|
-      if node.type == :text && node.string_content == 'there'
-        node.string_content = 'world'
-      end
+      node.string_content = 'world' if node.type == :text && node.string_content == 'there'
     end
     result = HtmlRenderer.new.render(@doc)
     assert_equal "<p>Hi <em>world</em>, I am mostly text!</p>\n", result
@@ -80,10 +80,10 @@ class TestNode < Minitest::Test
   end
 
   def test_inspect
-    assert_match /#<CommonMarker::Node\(document\):/, @doc.inspect
+    assert_match(/#<CommonMarker::Node\(document\):/, @doc.inspect)
   end
 
   def test_pretty_print
-    assert_match /#<CommonMarker::Node\(document\):/, PP.pp(@doc, '')
+    assert_match(/#<CommonMarker::Node\(document\):/, PP.pp(@doc, +''))
   end
 end

data/test/test_options.rb

@@ -1,35 +1,37 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class TestExtensions < Minitest::Test
   def test_full_info_string
-    md = <<-MD
-```ruby
-module Foo
-```
+    md = <<~MD
+      ```ruby
+      module Foo
+      ```
     MD
 
     CommonMarker.render_html(md, :FULL_INFO_STRING).tap do |out|
-      assert_includes out, %q(<pre><code class="language-ruby">)
+      assert_includes out, '<pre><code class="language-ruby">'
     end
 
-    md = <<-MD
-```ruby my info string
-module Foo
-```
+    md = <<~MD
+      ```ruby my info string
+      module Foo
+      ```
     MD
 
     CommonMarker.render_html(md, :FULL_INFO_STRING).tap do |out|
-      assert_includes out, %q(<pre><code class="language-ruby" data-meta="my info string">)
+      assert_includes out, '<pre><code class="language-ruby" data-meta="my info string">'
     end
 
-    md = <<-MD
-```ruby my \x00 string
-module Foo
-```
+    md = <<~MD
+      ```ruby my \x00 string
+      module Foo
+      ```
     MD
 
     CommonMarker.render_html(md, :FULL_INFO_STRING).tap do |out|
-      assert_includes out, %Q(<pre><code class="language-ruby" data-meta="my � string">)
+      assert_includes out, %(<pre><code class="language-ruby" data-meta="my � string">)
     end
   end
 end

data/test/test_pathological_inputs.rb

@@ -1,14 +1,16 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 require 'minitest/benchmark' if ENV['BENCH']
 
-def markdown(s)
-  CommonMarker.render_doc(s).to_html
+def markdown(str)
+  CommonMarker.render_doc(str).to_html
 end
 
 # list of pairs consisting of input and a regex that must match the output.
 pathological = {
   'nested strong emph' =>
-              [('*a **a ' * 65_000) + 'b' + (' a** a*' * 65_000),
+              ["#{'*a **a ' * 65_000}b#{' a** a*' * 65_000}",
                Regexp.compile('(<em>a <strong>a ){65_000}b( a</strong> a</em>){65_000}')],
   'many emph closers with no openers' =>
                [('a_ ' * 65_000),
@@ -32,10 +34,10 @@ pathological = {
                ['**x [a*b**c*](d)',
                 Regexp.compile('\\*\\*x <a href=\'d\'>a<em>b</em><em>c</em></a>')],
   'nested brackets' =>
-               [('[' * 50_000) + 'a' + (']' * 50_000),
+               ["#{'[' * 50_000}a#{']' * 50_000}",
                 Regexp.compile('\[{50000}a\]{50000}')],
   'nested block quotes' =>
-               [(('> ' * 50_000) + 'a'),
+               ["#{'> ' * 50_000}a",
                 Regexp.compile('(<blockquote>\n){50000}')],
   'U+0000 in input' =>
                ['abc\u0000de\u0000',
@@ -51,41 +53,41 @@ end
 
 if ENV['BENCH']
   class PathologicalInputsPerformanceTest < Minitest::Benchmark
-    def bench_pathological_1
+    def test_bench_pathological_one
       assert_performance_linear 0.99 do |n|
         star = '*' * (n * 10)
         markdown("#{star}#{star}hi#{star}#{star}")
       end
     end
 
-    def bench_pathological_2
+    def test_bench_pathological_two
       assert_performance_linear 0.99 do |n|
         c = '`t`t`t`t`t`t' * (n * 10)
         markdown(c)
       end
     end
 
-    def bench_pathological_3
+    def test_bench_pathological_three
       assert_performance_linear 0.99 do |n|
         markdown(" [a]: #{'A' * n}\n\n#{'[a][]' * n}\n")
       end
     end
 
-    def bench_pathological_4
+    def test_bench_pathological_four
       assert_performance_linear 0.5 do |n|
         markdown("#{'[' * n}a#{']' * n}")
       end
     end
 
-    def bench_pathological_5
+    def test_bench_pathological_five
       assert_performance_linear 0.99 do |n|
         markdown("#{'**a *a ' * n}#{'a* a**' * n}")
       end
     end
 
-    def bench_unbound_recursion
+    def test_bench_unbound_recursion
       assert_performance_linear 0.99 do |n|
-        markdown(('[' * n) + 'foo' + ('](bar)' * n))
+        markdown("#{'[' * n}foo#{'](bar)' * n}")
       end
     end
   end