common_validators 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d988741f639f92a4b78583e01e4be5c63ad55bd1
-  data.tar.gz: bd01cb9d66ad674994afa62b96465033fff88608
+  metadata.gz: 0636e8954956dd555d02f51f19635b2837a8eb37
+  data.tar.gz: 76d1469d5b1fd38aa4a41cd54901da7871e25165
 SHA512:
-  metadata.gz: 7ba5d948547f2052aa1b1a7ef5895c1fc993a20be7bcd4234288f924c2b326806ee80e01e597aa8158762297c5977af46bac9f472d955c652f310eb286549578
-  data.tar.gz: 527d1f8d6d86eccdfc1f7385e42cea26a98b1a3be8bf5a5b6951483f5b3dfdb3eb2ae0f9cc169d8989945cdc0a1484e20bea2f3a22885eb5e10f04ffa2d2b2f4
+  metadata.gz: 2efed94056579becd591685b04de708414585507165422ef7c7720b60d3f1b40bf0e87fa190cd281f61bf581cc965e55194f814c4742e87757a1cb186c46a7b7
+  data.tar.gz: e9e4cefad3b2617d1e39ea4c070a199648152d15a8333505ad12825ea5ab12c2645d2a5c6bd52713d738c03dae5e82281ced8c4c109acc9908f743c4de01373c

data/Guardfile

@@ -5,6 +5,6 @@ guard :minitest do
   watch(%r{^test/.+_test\.rb$})
   watch('test/test_helper.rb') { "test" }
 
-  watch(%r{^app/models/(.+)\.rb$})     { |m| "test/#{m[1]}_test.rb" }
-  watch(%r{^app/validators/(.+)\.rb$}) { |m| "test/#{m[1]}_test.rb" }
+  watch(%r{^app/models/(.+)\.rb$})     { |m| "test/models/#{m[1]}_test.rb" }
+  watch(%r{^app/validators/(.+)\.rb$}) { |m| "test/models/#{m[1]}_test.rb" }
 end

data/app/validators/email_format_validator.rb

@@ -9,7 +9,12 @@
 #   validates :email, email_format: true                 # optional
 #   validates :email, email_format: true, presence: true # required
 class EmailFormatValidator < ActiveModel::EachValidator
-  EMAIL_REGEX = /\A(([^(),:;<>@\[\\\]\s]+)@((?:[-a-z0-9]+\.)+[a-z]{2,}))?\z/i
+  # Local part is basically a-z 0-9 and common symbols
+  # http://en.wikipedia.org/wiki/E-mail_address#Local_part
+  #
+  # Domain part is basically any unicode character while the TLD is still
+  # restricted to at least two characters in range of a-z
+  EMAIL_REGEX = /\A(([a-zA-Z0-9+_!#$%&'*+~=\/\{\}\|\`\^\?\-\.]+)@((?:[^(),:;<>@\[\\\]\s\.]+\.)+[a-z]{2,}))?\z/i
 
   def validate_each(record, attr_name, value)
     return if value.blank?

data/lib/common_validators/version.rb

@@ -1,3 +1,3 @@
 module CommonValidators
-  VERSION = "1.1.0"
+  VERSION = "1.1.1"
 end

data/test/models/email_format_validator_test.rb

@@ -43,11 +43,18 @@ class EmailFormatValidatorTest < ActiveSupport::TestCase
     assert_invalid_email "a[lice@example.com"
     assert_invalid_email "a\\lice@example.com"
     assert_invalid_email "a]lice@example.com"
+
+    # this causes Ruby email library to crash
+    assert_invalid_email "momodk1é@hotmail.fr"
   end
 
   test "valid email" do
     assert_valid_email ""
     assert_valid_email "alice@example.com"
+    assert_valid_email "alice+spam@example.com"
     assert_valid_email "alice@example.com"
+    assert_valid_email "ALICE_123@example.com"
+    assert_valid_email "ann.other@example.com"
+    assert_valid_email "hei@やる.ca"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: common_validators
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Gerry Shaw
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-16 00:00:00.000000000 Z
+date: 2014-01-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails