common_core_js 0.4.6 → 0.4.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 809e054efc9ed1738f6c972124840343fb2053bc5b890b091ad4eb4a6872dd67
-  data.tar.gz: c053c54714bd148a1b39f245a5b594f18954a1d72a6fb80b1ff94d9bd91e48c9
+  metadata.gz: 34c76baa6457d9e7647a7f703c72c4403f99c8e713a9edb3eeab161fa5087dfc
+  data.tar.gz: 168c7944599f096a31a35cec07168c019160dedf5d7713f271f5a4fab434bb4a
 SHA512:
-  metadata.gz: 94a720a687266f365d01273c520481187455bb25d829a45fd05023936e38268c818fa9e3c577ad11ec980b4f3b94ed62912727e3d8d20ea2ce12bff1fa030ce8
-  data.tar.gz: ac6abf280f684bbc16dfc504507a9edcc0679b9919dabd50ac89f159334eda9d959cd82444972f8d0e009809eb8d3f30eff9fd6ff6c6ecc0964834b99a3c4353
+  metadata.gz: bbc731908589e37e2bc52aa0a49fbe639acbcdbfe85a4a50faaae730d119bce2c9b80caeb09f0898f4f64dbcab1eedbb78c8f3e0eb899790e984ad64e9b2cfe0
+  data.tar.gz: de536f01b261a6d79e67c7ed1bb54a38df3cc3fc62b6053f38eab0c778eb5031e8e6638d6fd1ab8e5147335b4349d189dc491c3dd4430a88316bf6adfccbd206

data/README.md

@@ -295,14 +295,27 @@ module.exports = environment
 ```
 # VERSION HISTORY
 
+## 0.4.7
+- fixes some problems with display labeling through active record associations (was using a funky syntax for this)
+- significant improvments to error messaging, like:
+
+if you don't have a `current_user` and you don't specify an auth or auth_identifier (and you aren't using `--god` mode), helpful hint:
+
+"*** Oops: It looks like is no association from current_user to a class called Invoice. If your user is called something else, pass with flag auth=current_X where X is the model for your users as lowercase. Also, be sure to implement current_X as a method on your controller. (If you really don't want to implement a current_X on your controller and want me to check some other method for your current user, see the section in the docs for auth_identifier.) To make a controller that can read all records, specify with --god."
+
+
+If an association is on a model but the assocition has no field that can be used to display its name, you get this hint:
+
+"*** Oops: Can't find any column to use as the display label for the account association on the Invoice model . TODO: Please implement just one of: 1) name, 2) to_label, 3) full_name, 4) display_name, or 5) email directly on your Account model (either as database field or model methods), then RERUN THIS GENERATOR. (If more than one is implemented, the field to use will be chosen based on the rank here, e.g., if name is present it will be used; if not, I will look for a to_label, etc)"
+
 ## 0.4.6
 
-- Fixes a bug with nested args
+- Fixes a bug that would happen if you had no nested args
 
 ## 0.4.2 - 0.4.5 - Oct 2020
 
-- Not sure what I was doing here or why I made 3 released on the same day
-- Several bugfixes
+- Not sure what I was doing here or why I made 3 releases on the same day(?)
+- Several bugfixes happened during these iterations
 
 ## 0.3.0 - 0.4.1 - August 2020
 

data/lib/common_core_js/version.rb

@@ -1,3 +1,3 @@
 module CommonCoreJs
-  VERSION = '0.4.6'
+  VERSION = '0.4.7'
 end

data/lib/generators/common_core/scaffold_generator.rb

@@ -47,7 +47,7 @@ module CommonCore
       begin
         object = eval(class_name)
       rescue StandardError => e
-        puts "Ooops... it looks like there is no object for #{class_name}. Please define the object + database table first."
+        puts "*** Oops: It looks like there is no object for #{class_name}. Please define the object + database table first."
         exit
       end
 
@@ -68,7 +68,6 @@ module CommonCore
 
       args[1..-1].each do |a|
         var_name, var_value = a.split("=")
-        puts var_name
         case (var_name)
 
         when "plural"
@@ -108,7 +107,7 @@ module CommonCore
       end
 
       if @specs_only && @no_specs
-        puts "oops… you seem to have specified both the --specs-only flag and --no-specs flags. this doesn't make any sense, so I am aborting. sorry."
+        puts "*** Oops: You seem to have specified both the --specs-only flag and --no-specs flags. this doesn't make any sense, so I am aborting. sorry."
         exit
       end
 
@@ -157,7 +156,11 @@ module CommonCore
         if assoc
           ownership_field = assoc.name.to_s + "_id"
         else
-          puts "Ooops... it looks like is no association for #{@object_owner_sym} on #{singular_class} "
+          if @auth
+            puts "*** Oops: It looks like is no association from current_#{@object_owner_sym} to a class called #{singular_class}. If your user is called something else, pass with flag auth=current_X where X is the model for your users as lowercase. Also, be sure to implement current_X as a method on your controller. (If you really don't want to implement a current_X on your controller and want me to check some other method for your current user, see the section in the docs for auth_identifier.) To make a controller that can read all records, specify with --god."
+          else
+            puts "*** Oops:  god mode could not find the association(?). something is wrong."
+          end
           exit
         end
       end
@@ -449,26 +452,27 @@ module CommonCore
               puts "*** Oops. on the #{singular_class} object, there doesn't seem to be an association called '#{assoc_name}'"
               exit
             end
-            assoc_class_name = eval("#{singular_class}.reflect_on_association(:#{assoc_name})").class_name
 
-            if assoc.active_record.column_names.include?("name")
+
+            assoc_class = eval(assoc.class_name)
+
+            if assoc_class.column_names.include?("name")
               display_column = "name"
-            elsif assoc.active_record.column_names.include?("to_label")
+            elsif assoc_class.column_names.include?("to_label")
               display_column = "to_label"
-            elsif assoc.active_record.column_names.include?("full_name")
+            elsif assoc_class.column_names.include?("full_name")
               display_column = "full_name"
-            elsif assoc.active_record.column_names.include?("display_name")
+            elsif assoc_class.column_names.include?("display_name")
               display_column = "display_name"
-            elsif assoc.active_record.column_names.include?("email")
+            elsif assoc_class.column_names.include?("email")
               display_column = "email"
             else
-              puts "Can't find a display_column on {singular_class} object"
+              puts "*** Oops: Can't find any column to use as the display label for the #{assoc.name.to_s} association on the #{singular_class} model . TODO: Please implement just one of: 1) name, 2) to_label, 3) full_name, 4) display_name, or 5) email directly on your #{assoc.class_name} model (either as database field or model methods), then RERUN THIS GENERATOR. (If more than one is implemented, the field to use will be chosen based on the rank here, e.g., if name is present it will be used; if not, I will look for a to_label, etc)"
             end
 
-
             ".row
   %div{class: \"form-group col-md-4 \#{'alert-danger' if #{singular}.errors.details.keys.include?(:#{assoc_name.to_s})}\"}
-    = f.collection_select(:#{col.to_s}, #{assoc_class_name}.all, :id, :#{display_column}, {prompt: true, selected: @#{singular}.#{col.to_s} }, class: 'form-control')
+    = f.collection_select(:#{col.to_s}, #{assoc_class}.all, :id, :#{display_column}, {prompt: true, selected: @#{singular}.#{col.to_s} }, class: 'form-control')
     %label.small.form-text.text-muted
       #{col.to_s.humanize}"
 
@@ -549,18 +553,21 @@ module CommonCore
               exit
             end
 
-            if assoc.active_record.column_names.include?("name")
+
+            assoc_class = eval(assoc.class_name)
+
+            if assoc_class.column_names.include?("name")
               display_column = "name"
-            elsif assoc.active_record.column_names.include?("to_label")
+            elsif assoc_class.column_names.include?("to_label")
               display_column = "to_label"
-            elsif assoc.active_record.column_names.include?("full_name")
+            elsif assoc_class.column_names.include?("full_name")
               display_column = "full_name"
-            elsif assoc.active_record.column_names.include?("display_name")
+            elsif assoc_class.column_names.include?("display_name")
               display_column = "display_name"
-            elsif assoc.active_record.column_names.include?("email")
+            elsif assoc_class.column_names.include?("email")
               display_column = "email"
             else
-              puts "cant find any column to use as label for #{assoc.name.to_s}; any of name, to_labe, full_name, display_name, or email"
+              puts "*** Oops: Can't find any column to use as the display label for the #{assoc.name.to_s} association on the #{singular_class} model . TODO: Please implement just one of: 1) name, 2) to_label, 3) full_name, 4) display_name, or 5) email directly on your #{assoc.class_name} model (either as database field or model methods), then RERUN THIS GENERATOR. (If more than one is implemented, the field to use will be chosen based on the rank here, e.g., if name is present it will be used; if not, I will look for a to_label, etc)"
             end
 
             "  %td

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: common_core_js
 version: !ruby/object:Gem::Version
-  version: 0.4.6
+  version: 0.4.7
 platform: ruby
 authors:
 - Jason Fleetwood-Boldt
@@ -229,7 +229,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.7
+rubygems_version: 3.0.8
 signing_key:
 specification_version: 4
 summary: A gem build scaffolding.