committee 5.6.1 → 5.6.3

data/test/middleware/request_validation_open_api_3_test.rb

@@ -84,42 +84,14 @@ describe Committee::Middleware::RequestValidation do
       [200, {}, []]
     }
 
-    @app = new_rack_app_with_lambda(check_parameter,
-                                    schema: open_api_3_schema,
-                                    coerce_date_times: true,
-                                    allow_get_body: true)
+    @app = new_rack_app_with_lambda(check_parameter, schema: open_api_3_schema, coerce_date_times: true, allow_get_body: true)
 
     get "/string_params_coercer", { no_problem: true }, { input: params.to_json }
     assert_equal 200, last_response.status
   end
 
   it "passes given a datetime and with coerce_date_times enabled on POST endpoint" do
-    params = {
-        "nested_array" => [
-            {
-                "update_time" => "2016-04-01T16:00:00.000+09:00",
-                "nested_coercer_object" => {
-                    "update_time" => "2016-04-01T16:00:00.000+09:00",
-                },
-                "nested_no_coercer_object" => {
-                    "update_time" => "2016-04-01T16:00:00.000+09:00",
-                },
-                "nested_coercer_array" => [
-                    {
-                        "update_time" => "2016-04-01T16:00:00.000+09:00",
-                    }
-                ],
-                "nested_no_coercer_array" => [
-                    {
-                        "update_time" => "2016-04-01T16:00:00.000+09:00",
-                    }
-                ]
-            },
-            {
-                "update_time" => "2016-04-01T16:00:00.000+09:00",
-            }
-        ]
-    }
+    params = { "nested_array" => [{ "update_time" => "2016-04-01T16:00:00.000+09:00", "nested_coercer_object" => { "update_time" => "2016-04-01T16:00:00.000+09:00", }, "nested_no_coercer_object" => { "update_time" => "2016-04-01T16:00:00.000+09:00", }, "nested_coercer_array" => [{ "update_time" => "2016-04-01T16:00:00.000+09:00", }], "nested_no_coercer_array" => [{ "update_time" => "2016-04-01T16:00:00.000+09:00", }] }, { "update_time" => "2016-04-01T16:00:00.000+09:00", }] }
 
     check_parameter = lambda { |env|
       nested_array = env['committee.params']["nested_array"]
@@ -166,11 +138,7 @@ describe Committee::Middleware::RequestValidation do
       [200, {}, []]
     }
 
-    @app = new_rack_app_with_lambda(check_parameter,
-                                    coerce_query_params: true,
-                                    coerce_recursive: true,
-                                    coerce_date_times: true,
-                                    schema: open_api_3_schema)
+    @app = new_rack_app_with_lambda(check_parameter, coerce_query_params: true, coerce_recursive: true, coerce_date_times: true, schema: open_api_3_schema)
 
     get "/string_params_coercer", params
 
@@ -178,51 +146,7 @@ describe Committee::Middleware::RequestValidation do
   end
 
   it "passes given a nested datetime and with coerce_recursive=true and coerce_date_times=true on POST endpoint" do
-    params = {
-        "nested_array" => [
-            {
-                "update_time" => "2016-04-01T16:00:00.000+09:00",
-                "per_page" => 1,
-                "nested_coercer_object" => {
-                    "update_time" => "2016-04-01T16:00:00.000+09:00",
-                    "threshold" => 1.5
-                },
-                "nested_no_coercer_object" => {
-                    "per_page" => 1,
-                    "threshold" => 1.5
-                },
-                "nested_coercer_array" => [
-                    {
-                        "update_time" => "2016-04-01T16:00:00.000+09:00",
-                        "threshold" => 1.5
-                    }
-                ],
-                "nested_no_coercer_array" => [
-                    {
-                        "per_page" => 1,
-                        "threshold" => 1.5
-                    }
-                ],
-                "integer_array" => [
-                    1, 2, 3
-                ],
-                "datetime_array" => [
-                    "2016-04-01T16:00:00.000+09:00",
-                    "2016-04-01T17:00:00.000+09:00",
-                    "2016-04-01T18:00:00.000+09:00"
-                ]
-            },
-            {
-                "update_time" => "2016-04-01T16:00:00.000+09:00",
-                "per_page" => 1,
-                "threshold" => 1.5
-            },
-            {
-                "threshold" => 1.5,
-                "per_page" => 1
-            }
-        ]
-    }
+    params = { "nested_array" => [{ "update_time" => "2016-04-01T16:00:00.000+09:00", "per_page" => 1, "nested_coercer_object" => { "update_time" => "2016-04-01T16:00:00.000+09:00", "threshold" => 1.5 }, "nested_no_coercer_object" => { "per_page" => 1, "threshold" => 1.5 }, "nested_coercer_array" => [{ "update_time" => "2016-04-01T16:00:00.000+09:00", "threshold" => 1.5 }], "nested_no_coercer_array" => [{ "per_page" => 1, "threshold" => 1.5 }], "integer_array" => [1, 2, 3], "datetime_array" => ["2016-04-01T16:00:00.000+09:00", "2016-04-01T17:00:00.000+09:00", "2016-04-01T18:00:00.000+09:00"] }, { "update_time" => "2016-04-01T16:00:00.000+09:00", "per_page" => 1, "threshold" => 1.5 }, { "threshold" => 1.5, "per_page" => 1 }] }
 
     check_parameter = lambda { |env|
       hash = env['committee.params']
@@ -330,6 +254,14 @@ describe Committee::Middleware::RequestValidation do
     assert_equal 200, last_response.status
   end
 
+  it "ignores similar prefix paths outside the prefix in strict mode" do
+    @app = new_rack_app(prefix: "/v1", schema: open_api_3_schema, strict: true)
+    params = { "string_post_1" => 1 }
+    header "Content-Type", "application/json"
+    post "/v11/characters", JSON.generate(params)
+    assert_equal 200, last_response.status
+  end
+
   it "don't check prefix with no option" do
     @app = new_rack_app(schema: open_api_3_schema)
     params = { "string_post_1" => 1 }
@@ -431,6 +363,26 @@ describe Committee::Middleware::RequestValidation do
     get "/coerce_path_params/1"
   end
 
+  it "coerces path params even when query param coercion is disabled" do
+    check_parameter_string = lambda { |env|
+      assert env['committee.path_hash']['integer'].is_a?(Integer)
+      assert env['committee.params']['integer'].is_a?(Integer)
+      [200, {}, []]
+    }
+
+    @app = new_rack_app_with_lambda(check_parameter_string, schema: open_api_3_schema, coerce_path_params: true, coerce_query_params: false)
+    get "/coerce_path_params/1"
+    assert_equal 200, last_response.status
+  end
+
+  it "does not coerce path params when path coercion is disabled even if query coercion is enabled" do
+    @app = new_rack_app(schema: open_api_3_schema, coerce_path_params: false, coerce_query_params: true)
+    get "/coerce_path_params/1"
+
+    assert_equal 400, last_response.status
+    assert_match(/integer/i, last_response.body)
+  end
+
   describe "overwrite same parameter (old rule)" do
     # (high priority) path_hash_key -> request_body_hash -> query_param
     it "set query parameter to committee.params and query hash" do
@@ -627,6 +579,125 @@ describe Committee::Middleware::RequestValidation do
     end
   end
 
+  describe ':strict_query_params option' do
+    it 'allows unknown query params when strict_query_params is false' do
+      @app = new_rack_app(schema: open_api_3_schema, strict_query_params: false)
+      get "/characters", { limit: 10, unknown_param: "value" }
+      assert_equal 200, last_response.status
+    end
+
+    it 'rejects unknown query params when strict_query_params is true' do
+      @app = new_rack_app(schema: open_api_3_schema, strict_query_params: true)
+      get "/characters", { limit: 10, unknown_param: "value" }
+      assert_equal 400, last_response.status
+      assert_match(/unknown_param/, last_response.body)
+    end
+
+    it 'allows defined query params when strict_query_params is true' do
+      @app = new_rack_app(schema: open_api_3_schema, strict_query_params: true)
+      get "/characters", { limit: 10, school_name: "test" }
+      assert_equal 200, last_response.status
+    end
+
+    it 'handles empty query params when strict_query_params is true' do
+      @app = new_rack_app(schema: open_api_3_schema, strict_query_params: true)
+      get "/characters"
+      assert_equal 200, last_response.status
+    end
+
+    it 'rejects multiple unknown query params' do
+      @app = new_rack_app(schema: open_api_3_schema, strict_query_params: true)
+      get "/characters", { limit: 10, unknown1: "a", unknown2: "b" }
+      assert_equal 400, last_response.status
+      assert_match(/unknown1/, last_response.body)
+      assert_match(/unknown2/, last_response.body)
+    end
+
+    it 'allows partial query params (only some defined params)' do
+      @app = new_rack_app(schema: open_api_3_schema, strict_query_params: true)
+      get "/characters", { limit: 10 }
+      assert_equal 200, last_response.status
+    end
+
+    it 'works with POST requests that have query params' do
+      @app = new_rack_app(schema: open_api_3_schema, strict_query_params: true)
+      header "Content-Type", "application/json"
+      post "/additional_properties?first_name=test&unknown=value", JSON.generate(last_name: "test")
+      assert_equal 400, last_response.status
+      assert_match(/unknown/, last_response.body)
+    end
+
+    it 'allows defined query params in POST requests' do
+      @app = new_rack_app(schema: open_api_3_schema, strict_query_params: true)
+      header "Content-Type", "application/json"
+      post "/additional_properties?first_name=test", JSON.generate(last_name: "test")
+      assert_equal 200, last_response.status
+    end
+
+    it 'works with DELETE requests' do
+      @app = new_rack_app(schema: open_api_3_schema, strict_query_params: true)
+      delete "/characters?limit=10"
+      assert_equal 200, last_response.status
+    end
+
+    it 'rejects unknown query params in DELETE requests' do
+      @app = new_rack_app(schema: open_api_3_schema, strict_query_params: true)
+      delete "/characters?limit=10&unknown=value"
+      assert_equal 400, last_response.status
+      assert_match(/unknown/, last_response.body)
+    end
+
+    it 'works with HEAD requests' do
+      @app = new_rack_app(schema: open_api_3_schema, strict_query_params: true)
+      head "/characters?limit=10"
+      assert_equal 200, last_response.status
+    end
+
+    it 'rejects unknown query params in HEAD requests' do
+      @app = new_rack_app(schema: open_api_3_schema, strict_query_params: true)
+      head "/characters?limit=10&unknown=value"
+      assert_equal 400, last_response.status
+    end
+  end
+
+  describe 'bracket-style query params' do
+    it 'validates query params declared with bracket notation names' do
+      check_parameter = lambda { |env|
+        assert_equal '/test', env['committee.query_hash']['filter[slug]']
+        refute env['committee.query_hash'].key?('filter')
+        [200, {}, []]
+      }
+
+      @app = new_rack_app_with_lambda(check_parameter, schema: query_param_schema(bracket_notation_query_parameter))
+
+      get '/events?filter[slug]=%2Ftest'
+
+      assert_equal 200, last_response.status
+    end
+
+    it 'rejects unknown nested query params with strict_query_params' do
+      @app = new_rack_app(schema: query_param_schema(bracket_notation_query_parameter), strict_query_params: true)
+
+      get '/events?filter[slug]=%2Ftest&filter[status]=active'
+
+      assert_equal 400, last_response.status
+      assert_match(/filter\[status\]/, last_response.body)
+    end
+
+    it 'continues to support deepObject query params from Rack nested hashes' do
+      check_parameter = lambda { |env|
+        assert_equal '/test', env['committee.query_hash']['filter']['slug']
+        [200, {}, []]
+      }
+
+      @app = new_rack_app_with_lambda(check_parameter, schema: query_param_schema(deep_object_query_parameter))
+
+      get '/events?filter[slug]=%2Ftest'
+
+      assert_equal 200, last_response.status
+    end
+  end
+
   private
 
   def new_rack_app(options = {})
@@ -641,4 +712,53 @@ describe Committee::Middleware::RequestValidation do
       run check_lambda
     }
   end
+
+  def query_param_schema(parameter)
+    Committee::Drivers.load_from_data(query_param_document(parameter), nil, parser_options: { strict_reference_validation: true })
+  end
+
+  def bracket_notation_query_parameter
+    {
+      'name' => 'filter[slug]',
+      'in' => 'query',
+      'required' => true,
+      'schema' => { 'type' => 'string' },
+    }
+  end
+
+  def deep_object_query_parameter
+    {
+      'name' => 'filter',
+      'in' => 'query',
+      'required' => true,
+      'style' => 'deepObject',
+      'explode' => true,
+      'schema' => {
+        'type' => 'object',
+        'required' => ['slug'],
+        'properties' => {
+          'slug' => { 'type' => 'string' },
+        },
+      },
+    }
+  end
+
+  def query_param_document(parameter)
+    {
+      'openapi' => '3.0.3',
+      'info' => { 'title' => 'test', 'version' => '1.0.0' },
+      'paths' => {
+        '/events' => {
+          'get' => {
+            'parameters' => [parameter],
+            'responses' => {
+              '200' => {
+                'description' => 'ok',
+              },
+            },
+          },
+        },
+      },
+    }
+  end
 end

data/test/middleware/request_validation_test.rb

@@ -9,49 +9,7 @@ describe Committee::Middleware::RequestValidation do
     @app
   end
 
-  ARRAY_PROPERTY = [
-      {
-          "update_time" => "2016-04-01T16:00:00.000+09:00",
-          "per_page" => 1,
-          "nested_coercer_object" => {
-              "update_time" => "2016-04-01T16:00:00.000+09:00",
-              "threshold" => 1.5
-          },
-          "nested_no_coercer_object" => {
-              "per_page" => 1,
-              "threshold" => 1.5
-          },
-          "nested_coercer_array" => [
-              {
-                  "update_time" => "2016-04-01T16:00:00.000+09:00",
-                  "threshold" => 1.5
-              }
-          ],
-          "nested_no_coercer_array" => [
-              {
-                  "per_page" => 1,
-                  "threshold" => 1.5
-              }
-          ],
-          "integer_array" => [
-              1, 2, 3
-          ],
-          "datetime_array" => [
-              "2016-04-01T16:00:00.000+09:00",
-              "2016-04-01T17:00:00.000+09:00",
-              "2016-04-01T18:00:00.000+09:00"
-          ]
-      },
-      {
-          "update_time" => "2016-04-01T16:00:00.000+09:00",
-          "per_page" => 1,
-          "threshold" => 1.5
-      },
-      {
-          "threshold" => 1.5,
-          "per_page" => 1
-      }
-  ]
+  ARRAY_PROPERTY = [{ "update_time" => "2016-04-01T16:00:00.000+09:00", "per_page" => 1, "nested_coercer_object" => { "update_time" => "2016-04-01T16:00:00.000+09:00", "threshold" => 1.5 }, "nested_no_coercer_object" => { "per_page" => 1, "threshold" => 1.5 }, "nested_coercer_array" => [{ "update_time" => "2016-04-01T16:00:00.000+09:00", "threshold" => 1.5 }], "nested_no_coercer_array" => [{ "per_page" => 1, "threshold" => 1.5 }], "integer_array" => [1, 2, 3], "datetime_array" => ["2016-04-01T16:00:00.000+09:00", "2016-04-01T17:00:00.000+09:00", "2016-04-01T18:00:00.000+09:00"] }, { "update_time" => "2016-04-01T16:00:00.000+09:00", "per_page" => 1, "threshold" => 1.5 }, { "threshold" => 1.5, "per_page" => 1 }]
 
   it "passes through a valid request" do
     @app = new_rack_app(schema: hyper_schema)
@@ -98,11 +56,7 @@ describe Committee::Middleware::RequestValidation do
 
   it "passes a nested object with recursive option" do
     key_name = "update_time"
-    params = {
-        key_name => "2016-04-01T16:00:00.000+09:00",
-        "query" => "cloudnasium",
-        "array_property" => ARRAY_PROPERTY
-    }
+    params = { key_name => "2016-04-01T16:00:00.000+09:00", "query" => "cloudnasium", "array_property" => ARRAY_PROPERTY }
 
     check_parameter = lambda { |env|
       hash = env['rack.request.query_hash']
@@ -116,11 +70,7 @@ describe Committee::Middleware::RequestValidation do
       [200, {}, []]
     }
 
-    @app = new_rack_app_with_lambda(check_parameter,
-                                    coerce_query_params: true,
-                                    coerce_recursive: true,
-                                    coerce_date_times: true,
-                                    schema: hyper_schema)
+    @app = new_rack_app_with_lambda(check_parameter, coerce_query_params: true, coerce_recursive: true, coerce_date_times: true, schema: hyper_schema)
 
     get "/search/apps", params
     assert_equal 200, last_response.status
@@ -128,11 +78,7 @@ describe Committee::Middleware::RequestValidation do
 
   it "passes a nested object with coerce_recursive false" do
     key_name = "update_time"
-    params = {
-        key_name => "2016-04-01T16:00:00.000+09:00",
-        "query" => "cloudnasium",
-        "array_property" => ARRAY_PROPERTY
-    }
+    params = { key_name => "2016-04-01T16:00:00.000+09:00", "query" => "cloudnasium", "array_property" => ARRAY_PROPERTY }
 
     @app = new_rack_app(coerce_query_params: true, coerce_date_times: true, coerce_recursive: false, schema: hyper_schema)
 
@@ -142,11 +88,7 @@ describe Committee::Middleware::RequestValidation do
 
   it "passes a nested object with coerce_recursive default(true)" do
     key_name = "update_time"
-    params = {
-        key_name => "2016-04-01T16:00:00.000+09:00",
-        "query" => "cloudnasium",
-        "array_property" => ARRAY_PROPERTY
-    }
+    params = { key_name => "2016-04-01T16:00:00.000+09:00", "query" => "cloudnasium", "array_property" => ARRAY_PROPERTY }
 
     @app = new_rack_app(coerce_query_params: true, coerce_date_times: true, schema: hyper_schema)
 
@@ -321,6 +263,13 @@ describe Committee::Middleware::RequestValidation do
     assert_equal 200, last_response.status
   end
 
+  it "ignores similar prefix paths outside the prefix in strict mode" do
+    @app = new_rack_app(prefix: "/v1", schema: hyper_schema, strict: true)
+    header "Content-Type", "application/json"
+    post "/v11/apps", JSON.generate({ "name" => 1 })
+    assert_equal 200, last_response.status
+  end
+
   it "routes to paths not in schema" do
     @app = new_rack_app(schema: hyper_schema)
     get "/not-a-resource"
@@ -429,13 +378,7 @@ describe Committee::Middleware::RequestValidation do
   end
 
   it "not exist path and options" do
-    options = {
-        coerce_form_params: true,
-        coerce_date_times: true,
-        coerce_query_params: true,
-        coerce_path_params: true,
-        coerce_recursive: true
-    }
+    options = { coerce_form_params: true, coerce_date_times: true, coerce_query_params: true, coerce_path_params: true, coerce_recursive: true }
 
     @app = new_rack_app({ schema: hyper_schema }.merge(options))
     header "Content-Type", "application/x-www-form-urlencoded"

data/test/middleware/response_validation_open_api_3_test.rb

@@ -33,6 +33,13 @@ describe Committee::Middleware::ResponseValidation do
     assert_equal 200, last_response.status
   end
 
+  it "passes through a valid response with a +json content-type" do
+    @app = new_response_rack(JSON.generate(CHARACTERS_RESPONSE), { "Content-Type" => "application/problem+json; charset=utf-8" }, schema: open_api_3_schema, parse_response_by_content_type: true,)
+
+    get "/characters"
+    assert_equal 200, last_response.status
+  end
+
   it "passes through a invalid json" do
     @app = new_response_rack("not_json", {}, schema: open_api_3_schema)
 
@@ -187,12 +194,7 @@ describe Committee::Middleware::ResponseValidation do
 
   describe 'validate error option' do
     it "detects an invalid response status code" do
-      @app = new_response_rack({ integer: '1' }.to_json,
-                               {},
-                               app_status: 400,
-                               schema: open_api_3_schema,
-                               raise: true,
-                               validate_success_only: false)
+      @app = new_response_rack({ integer: '1' }.to_json, {}, app_status: 400, schema: open_api_3_schema, raise: true, validate_success_only: false)
 
       e = assert_raises(Committee::InvalidResponse) do
         get "/characters"
@@ -202,12 +204,7 @@ describe Committee::Middleware::ResponseValidation do
     end
 
     it "detects an invalid response status code with validate_success_only=true" do
-      @app = new_response_rack({ string_1: :honoka }.to_json,
-                               {},
-                               app_status: 400,
-                               schema: open_api_3_schema,
-                               raise: true,
-                               validate_success_only: true)
+      @app = new_response_rack({ string_1: :honoka }.to_json, {}, app_status: 400, schema: open_api_3_schema, raise: true, validate_success_only: true)
 
       get "/characters"
 
@@ -235,6 +232,36 @@ describe Committee::Middleware::ResponseValidation do
     end
   end
 
+  describe 'response type validation' do
+    it "detects string value for number field when coerce_response_values is false" do
+      @app = new_response_rack({ integer: '726' }.to_json, {}, app_status: 400, schema: open_api_3_schema, raise: true, validate_success_only: false, coerce_response_values: false)
+
+      e = assert_raises(Committee::InvalidResponse) do
+        get "/characters"
+      end
+
+      assert_match(/expected integer, but received String/i, e.message)
+    end
+
+    it "passes string value for number field when coerce_response_values is true" do
+      @app = new_response_rack({ integer: '726' }.to_json, {}, app_status: 400, schema: open_api_3_schema, raise: true, validate_success_only: false, coerce_response_values: true)
+
+      get "/characters"
+
+      assert_equal 400, last_response.status
+    end
+
+    it "detects string value for number field by default (coerce_response_values defaults to false)" do
+      @app = new_response_rack({ integer: '726' }.to_json, {}, app_status: 400, schema: open_api_3_schema, raise: true, validate_success_only: false)
+
+      e = assert_raises(Committee::InvalidResponse) do
+        get "/characters"
+      end
+
+      assert_match(/expected integer, but received String/i, e.message)
+    end
+  end
+
   it 'does not suppress application error' do
     @app = Rack::Builder.new {
       use Committee::Middleware::ResponseValidation, { schema: open_api_3_schema, raise: true }
@@ -269,11 +296,7 @@ describe Committee::Middleware::ResponseValidation do
   end
 
   it "strict and invalid content type with raise" do
-    @app = new_response_rack("abc",
-      {},
-      { schema: open_api_3_schema, strict: true, raise: true },
-      { content_type: 'application/text' }
-    )
+    @app = new_response_rack("abc", {}, { schema: open_api_3_schema, strict: true, raise: true }, { content_type: 'application/text' })
 
     assert_raises(Committee::InvalidResponse) do
       get "/characters"

data/test/middleware/response_validation_test.rb

@@ -199,10 +199,7 @@ describe Committee::Middleware::ResponseValidation do
   describe 'streaming response' do
     describe "text/event-stream; e.g. server-sent events" do
       it 'validates the response stream as a string' do
-        options = {
-          schema: open_api_3_streaming_response_schema,
-          streaming_content_parsers: { 'text/event-stream' => ->(body) { body } },
-        }
+        options = { schema: open_api_3_streaming_response_schema, streaming_content_parsers: { 'text/event-stream' => ->(body) { body } }, }
         status = 200
         headers = { 'content-type' => 'text/event-stream' }
         @app = Rack::Builder.new {
@@ -221,11 +218,7 @@ describe Committee::Middleware::ResponseValidation do
       it "successfully validates the response as a special stream using a customized parser" do
         error_handler_called = false
         error_handler = ->(_e, _env) { error_handler_called = true }
-        options = {
-          schema: open_api_3_streaming_response_schema,
-          streaming_content_parsers: { 'application/x-json-stream' => ->(body) { JSON.parse!(body) } },
-          error_handler: error_handler,
-        }
+        options = { schema: open_api_3_streaming_response_schema, streaming_content_parsers: { 'application/x-json-stream' => ->(body) { JSON.parse!(body) } }, error_handler: error_handler, }
         status = 200
         headers = { 'content-type' => 'application/x-json-stream' }
         @app = Rack::Builder.new {
@@ -243,11 +236,7 @@ describe Committee::Middleware::ResponseValidation do
       it "fails to validate the response as a special stream using a customized parser due to a schema mismatch" do
         error_handler_called = false
         error_handler = ->(_e, _env) { error_handler_called = true }
-        options = {
-          schema: open_api_3_streaming_response_schema,
-          streaming_content_parsers: { 'application/x-json-stream' => ->(body) { JSON.parse!(body) } },
-          error_handler: error_handler,
-        }
+        options = { schema: open_api_3_streaming_response_schema, streaming_content_parsers: { 'application/x-json-stream' => ->(body) { JSON.parse!(body) } }, error_handler: error_handler, }
         status = 200
         headers = { 'content-type' => 'application/x-json-stream' }
         @app = Rack::Builder.new {

data/test/request_unpacker_test.rb

@@ -137,22 +137,14 @@ describe Committee::RequestUnpacker do
   end
 
   it "includes request body when`use_get_body` is true" do
-    env = {
-        "rack.input" => StringIO.new('{"x":1, "y":2}'),
-        "REQUEST_METHOD" => "GET",
-        "QUERY_STRING" => "data=value&x=aaa",
-    }
+    env = { "rack.input" => StringIO.new('{"x":1, "y":2}'), "REQUEST_METHOD" => "GET", "QUERY_STRING" => "data=value&x=aaa", }
     request = Rack::Request.new(env)
     unpacker = Committee::RequestUnpacker.new({ allow_query_params: true, allow_get_body: true })
     assert_equal([{ 'x' => 1, 'y' => 2 }, false], unpacker.unpack_request_params(request))
   end
 
   it "doesn't include request body when `use_get_body` is false" do
-    env = {
-        "rack.input" => StringIO.new('{"x":1, "y":2}'),
-        "REQUEST_METHOD" => "GET",
-        "QUERY_STRING" => "data=value&x=aaa",
-    }
+    env = { "rack.input" => StringIO.new('{"x":1, "y":2}'), "REQUEST_METHOD" => "GET", "QUERY_STRING" => "data=value&x=aaa", }
     request = Rack::Request.new(env)
     unpacker = Committee::RequestUnpacker.new({ allow_query_params: true, use_get_body: false })
     assert_equal({ 'data' => 'value', 'x' => 'aaa' }, unpacker.unpack_query_params(request))

data/test/schema_validator/hyper_schema/parameter_coercer_test.rb

@@ -35,43 +35,7 @@ describe Committee::SchemaValidator::HyperSchema::ParameterCoercer do
   end
 
   it "pass array property" do
-    params = {
-        "array_property" => [
-            {
-                "update_time" => "2016-04-01T16:00:00.000+09:00",
-                "per_page" => 1,
-                "nested_coercer_object" => {
-                    "update_time" => "2016-04-01T16:00:00.000+09:00",
-                    "threshold" => 1.5
-                },
-                "nested_no_coercer_object" => {
-                    "per_page" => 1,
-                    "threshold" => 1.5
-                },
-                "nested_coercer_array" => [
-                    {
-                        "update_time" => "2016-04-01T16:00:00.000+09:00",
-                        "threshold" => 1.5
-                    }
-                ],
-                "nested_no_coercer_array" => [
-                    {
-                        "per_page" => 1,
-                        "threshold" => 1.5
-                    }
-                ]
-            },
-            {
-                "update_time" => "2016-04-01T16:00:00.000+09:00",
-                "per_page" => 1,
-                "threshold" => 1.5
-            },
-            {
-                "threshold" => 1.5,
-                "per_page" => 1
-            }
-        ],
-    }
+    params = { "array_property" => [{ "update_time" => "2016-04-01T16:00:00.000+09:00", "per_page" => 1, "nested_coercer_object" => { "update_time" => "2016-04-01T16:00:00.000+09:00", "threshold" => 1.5 }, "nested_no_coercer_object" => { "per_page" => 1, "threshold" => 1.5 }, "nested_coercer_array" => [{ "update_time" => "2016-04-01T16:00:00.000+09:00", "threshold" => 1.5 }], "nested_no_coercer_array" => [{ "per_page" => 1, "threshold" => 1.5 }] }, { "update_time" => "2016-04-01T16:00:00.000+09:00", "per_page" => 1, "threshold" => 1.5 }, { "threshold" => 1.5, "per_page" => 1 }], }
     call(params, coerce_date_times: true, coerce_recursive: true)
 
     first_data = params["array_property"][0]