committee 3.0.0.alpha → 3.0.0.beta

data/test/middleware/response_validation_open_api_3_test.rb

@@ -10,13 +10,13 @@ describe Committee::Middleware::ResponseValidation do
   end
 
   it "passes through a valid response" do
-    @app = new_response_rack(JSON.generate(CHARACTERS_RESPONSE), {}, open_api_3: open_api_3_schema)
+    @app = new_response_rack(JSON.generate(CHARACTERS_RESPONSE), {}, schema: open_api_3_schema)
     get "/characters"
     assert_equal 200, last_response.status
   end
 
   it "passes through a invalid json" do
-    @app = new_response_rack("not_json", {}, open_api_3: open_api_3_schema)
+    @app = new_response_rack("not_json", {}, schema: open_api_3_schema)
 
     get "/characters"
 
@@ -25,15 +25,15 @@ describe Committee::Middleware::ResponseValidation do
   end
 
   it "passes through not definition" do
-    @app = new_response_rack(JSON.generate(CHARACTERS_RESPONSE), {}, open_api_3: open_api_3_schema)
+    @app = new_response_rack(JSON.generate(CHARACTERS_RESPONSE), {}, schema: open_api_3_schema)
     get "/no_data"
     assert_equal 200, last_response.status
   end
 
   it "detects a response invalid due to schema" do
-    @app = new_response_rack("[]", {}, open_api_3: open_api_3_schema)
+    @app = new_response_rack("[]", {}, schema: open_api_3_schema, raise: true)
 
-    e = assert_raises(Committee::InvalidRequest) { # TODO: change invalid request
+    e = assert_raises(Committee::InvalidResponse) {
       get "/characters"
     }
 
@@ -41,44 +41,111 @@ describe Committee::Middleware::ResponseValidation do
   end
 
   it "passes through a 204 (no content) response" do
-    @app = new_response_rack("", {}, {open_api_3: open_api_3_schema}, {status: 204})
+    @app = new_response_rack("", {}, {schema: open_api_3_schema}, {status: 204})
     post "/validate"
     assert_equal 204, last_response.status
   end
 
   it "passes through a valid response with prefix" do
-    @app = new_response_rack(JSON.generate(CHARACTERS_RESPONSE), {}, open_api_3: open_api_3_schema, prefix: "/v1")
+    @app = new_response_rack(JSON.generate(CHARACTERS_RESPONSE), {}, schema: open_api_3_schema, prefix: "/v1")
     get "/v1/characters"
     assert_equal 200, last_response.status
   end
 
   it "passes through a invalid json with prefix" do
-    @app = new_response_rack("not_json", {}, open_api_3: open_api_3_schema, prefix: "/v1")
+    @app = new_response_rack("not_json", {}, schema: open_api_3_schema, prefix: "/v1")
 
     get "/v1/characters"
 
-    # TODO: support prefix
-    assert_equal 200, last_response.status
-    # assert_equal 500, last_response.status
-    # assert_equal "{\"id\":\"invalid_response\",\"message\":\"Response wasn't valid JSON.\"}", last_response.body
+    assert_equal 500, last_response.status
+    assert_equal "{\"id\":\"invalid_response\",\"message\":\"Response wasn't valid JSON.\"}", last_response.body
   end
 
   it "rescues JSON errors" do
-    @app = new_response_rack("_42", {}, open_api_3: open_api_3_schema, raise: true)
+    @app = new_response_rack("_42", {}, schema: open_api_3_schema, raise: true)
     assert_raises(Committee::InvalidResponse) do
       get "/characters"
     end
   end
 
   it "not parameter requset" do
-    @app = new_response_rack({integer: '1'}.to_json, {}, open_api_3: open_api_3_schema)
+    @app = new_response_rack({integer: '1'}.to_json, {}, schema: open_api_3_schema, raise: true)
 
-    # TODO: error change
-    assert_raises(Committee::InvalidRequest) do
+    assert_raises(Committee::InvalidResponse) do
       patch "/validate_no_parameter", {no_schema: 'no'}
     end
   end
 
+  it "optionally validates non-2xx blank responses" do
+    @app = new_response_rack("", {}, schema: open_api_3_schema, validate_success_only: false)
+    get "/characters"
+    assert_equal 200, last_response.status
+  end
+
+  it "optionally validates non-2xx invalid responses with invalid json" do
+    @app = new_response_rack("{_}", {}, schema: open_api_3_schema, validate_success_only: false)
+    get "/characters"
+    assert_equal 500, last_response.status
+    assert_match(/valid JSON/i, last_response.body)
+  end
+
+  describe 'check header' do
+    it 'valid type header' do
+      @app = new_response_rack({}.to_json, {'x-limit' => 1}, schema: open_api_3_schema, raise: true)
+
+      get "/header"
+
+      assert_equal 200, last_response.status
+    end
+
+    it 'invalid type header' do
+      @app = new_response_rack({}.to_json, {'x-limit' => '1'}, schema: open_api_3_schema, raise: true)
+
+      assert_raises(Committee::InvalidResponse) do
+        get "/header"
+      end
+    end
+
+    it 'invalid type but not check' do
+      @app = new_response_rack({}.to_json, {'x-limit' => '1'}, schema: open_api_3_schema, raise: true, check_header: false)
+
+      get "/header"
+
+      assert_equal 200, last_response.status
+    end
+  end
+
+  describe 'validate error option' do
+    it "detects an invalid response status code" do
+      @app = new_response_rack({ integer: '1' }.to_json,
+                               {},
+                               app_status: 400,
+                               schema: open_api_3_schema,
+                               raise: true,
+                               validate_success_only: false)
+
+
+      e = assert_raises(Committee::InvalidResponse) do
+        get "/characters"
+      end
+      assert_match(/1 class is String/i, e.message)
+    end
+
+    it "detects an invalid response status code with validate_success_only=true" do
+      @app = new_response_rack({ string_1: :honoka }.to_json,
+                               {},
+                               app_status: 400,
+                               schema: open_api_3_schema,
+                               raise: true,
+                               validate_success_only: true)
+
+
+      get "/characters"
+
+      assert_equal 400, last_response.status
+    end
+  end
+
   private
 
   def new_response_rack(response, headers = {}, options = {}, rack_options = {})

data/test/middleware/response_validation_test.rb

@@ -15,8 +15,8 @@ describe Committee::Middleware::ResponseValidation do
 
   it "doesn't call error_handler when response is valid" do
     called = false
-    pr = ->(e) { called = true }
-    @app = new_rack_app(JSON.generate([ValidApp]), {}, schema: hyper_schema)
+    pr = ->(_e) { called = true }
+    @app = new_rack_app(JSON.generate([ValidApp]), {}, schema: hyper_schema, error_handler: pr)
     get "/apps"
     assert !called, "error_handler is called"
   end
@@ -29,7 +29,7 @@ describe Committee::Middleware::ResponseValidation do
   end
 
   it "detects a response invalid due to not being JSON" do
-    @app = new_rack_app("", {}, schema: hyper_schema)
+    @app = new_rack_app("{_}", {}, schema: hyper_schema)
     get "/apps"
     assert_equal 500, last_response.status
     assert_match(/valid JSON/i, last_response.body)
@@ -42,9 +42,14 @@ describe Committee::Middleware::ResponseValidation do
   end
 
   it "optionally validates non-2xx invalid responses" do
-    @app = new_rack_app("", {}, app_status: 404, validate_errors: true,
-      schema: hyper_schema)
+    @app = new_rack_app("", {}, app_status: 404, validate_success_only: false, schema: hyper_schema)
+    get "/apps"
+    assert_equal 500, last_response.status
+    assert_match(/Invalid response/i, last_response.body)
+  end
 
+  it "optionally validates non-2xx invalid responses with invalid json" do
+    @app = new_rack_app("{_}", {}, app_status: 404, validate_success_only: false, schema: hyper_schema)
     get "/apps"
     assert_equal 500, last_response.status
     assert_match(/valid JSON/i, last_response.body)
@@ -56,8 +61,15 @@ describe Committee::Middleware::ResponseValidation do
     assert_equal 204, last_response.status
   end
 
+  it "skip validation when 4xx" do
+    @app = new_rack_app("[{x:y}]", {}, schema: hyper_schema, validate_success_only: true, app_status: 400)
+    get "/apps"
+    assert_equal 400, last_response.status
+    assert_match("[{x:y}]", last_response.body)
+  end
+
   it "rescues JSON errors" do
-    @app = new_rack_app("[{x:y}]", {}, schema: hyper_schema)
+    @app = new_rack_app("[{x:y}]", {}, schema: hyper_schema, validate_success_only: false)
     get "/apps"
     assert_equal 500, last_response.status
     assert_match(/valid json/i, last_response.body)
@@ -103,7 +115,7 @@ describe Committee::Middleware::ResponseValidation do
   end
 
   it "detects an invalid response for OpenAPI" do
-    @app = new_rack_app("", {}, schema: open_api_2_schema)
+    @app = new_rack_app("{_}", {}, schema: open_api_2_schema)
     get "/api/pets"
     assert_equal 500, last_response.status
     assert_match(/valid JSON/i, last_response.body)

data/test/middleware/stub_test.rb

@@ -98,7 +98,7 @@ describe Committee::Middleware::Stub do
 
   it "caches the response if called multiple times" do
     cache = {}
-    @app = new_rack_app(cache: cache, open_api_3: open_api_3_schema)
+    @app = new_rack_app(cache: cache, schema: open_api_3_schema)
 
     assert_raises(Committee::NotSupportOpenAPI3) do
       get "/characters"

data/test/{parameter_coercer_test.rb → schema_validator/hyper_schema/parameter_coercer_test.rb}

@@ -1,8 +1,8 @@
-require_relative "test_helper"
+require_relative "../../test_helper"
 
 require "stringio"
 
-describe Committee::ParameterCoercer do
+describe Committee::SchemaValidator::HyperSchema::ParameterCoercer do
   before do
     @schema = JsonSchema.parse!(hyper_schema_data)
     @schema.expand_references!
@@ -106,6 +106,6 @@ describe Committee::ParameterCoercer do
 
   def call(params, options={})
     link = Committee::Drivers::HyperSchema::Link.new(@link)
-    Committee::ParameterCoercer.new(params, link.schema, options).call!
+    Committee::SchemaValidator::HyperSchema::ParameterCoercer.new(params, link.schema, options).call!
   end
 end

data/test/schema_validator/hyper_schema/router_test.rb

@@ -60,6 +60,12 @@ describe Committee::SchemaValidator::HyperSchema::Router do
     assert_equal '/api/pets/dog', link.href
   end
 
+  it "fewer match not support in HyperSchema" do
+    link, _ = hyper_schema_router.find_link("GET", "/apps/abc")
+    refute_nil link
+    assert_equal '/apps/{(%23%2Fdefinitions%2Fapp%2Fdefinitions%2Fname)}', link.href
+  end
+
   def hyper_schema_router(options = {})
     schema = Committee::Drivers::HyperSchema.new.parse(hyper_schema_data)
     validator_option = Committee::SchemaValidator::Option.new(options, schema, :hyper_schema)

data/test/schema_validator/open_api_3/operation_wrapper_test.rb

@@ -14,6 +14,8 @@ describe Committee::SchemaValidator::OpenAPI3::OperationWrapper do
       open_api_3_schema.operation_object(@path, @method)
     end
 
+    HEADER = { 'Content-Type' => 'application/json' }
+
     SCHEMA_PROPERTIES_PAIR = [
         ['string', 'str'],
         ['integer', 1],
@@ -23,7 +25,7 @@ describe Committee::SchemaValidator::OpenAPI3::OperationWrapper do
     ]
 
     it 'correct data' do
-      operation_object.validate_request_params(SCHEMA_PROPERTIES_PAIR.to_h, @validator_option)
+      operation_object.validate_request_params(SCHEMA_PROPERTIES_PAIR.to_h, HEADER, @validator_option)
       assert true
     end
 
@@ -37,6 +39,7 @@ describe Committee::SchemaValidator::OpenAPI3::OperationWrapper do
                                              "number_1" => nil
                                          }
                                  },
+                                               HEADER,
                                                @validator_option)
 
       assert true
@@ -44,7 +47,7 @@ describe Committee::SchemaValidator::OpenAPI3::OperationWrapper do
 
     it 'invalid params' do
       e = assert_raises(Committee::InvalidRequest) {
-        operation_object.validate_request_params({"string" => 1}, @validator_option)
+        operation_object.validate_request_params({"string" => 1}, HEADER, @validator_option)
       }
 
       # FIXME: when ruby 2.3 dropped, fix because ruby 2.3 return Fixnum, ruby 2.4 or later return Integer
@@ -53,10 +56,10 @@ describe Committee::SchemaValidator::OpenAPI3::OperationWrapper do
 
     it 'support put method' do
       @method = "put"
-      operation_object.validate_request_params({"string" => "str"}, @validator_option)
+      operation_object.validate_request_params({"string" => "str"}, HEADER, @validator_option)
 
       e = assert_raises(Committee::InvalidRequest) {
-        operation_object.validate_request_params({"string" => 1}, @validator_option)
+        operation_object.validate_request_params({"string" => 1}, HEADER, @validator_option)
       }
 
       # FIXME: when ruby 2.3 dropped, fix because ruby 2.3 return Fixnum, ruby 2.4 or later return Integer
@@ -65,17 +68,17 @@ describe Committee::SchemaValidator::OpenAPI3::OperationWrapper do
 
     it 'support patch method' do
       @method = "patch"
-      operation_object.validate_request_params({"integer" => 1}, @validator_option)
+      operation_object.validate_request_params({"integer" => 1}, HEADER, @validator_option)
 
       e = assert_raises(Committee::InvalidRequest) {
-        operation_object.validate_request_params({"integer" => "str"}, @validator_option)
+        operation_object.validate_request_params({"integer" => "str"}, HEADER, @validator_option)
       }
 
       assert e.message.start_with?("str class is String but it's not valid")
     end
 
     it 'unknown param' do
-      operation_object.validate_request_params({"unknown" => 1}, @validator_option)
+      operation_object.validate_request_params({"unknown" => 1}, HEADER, @validator_option)
     end
 
     describe 'support get method' do
@@ -84,15 +87,24 @@ describe Committee::SchemaValidator::OpenAPI3::OperationWrapper do
       end
 
       it 'correct' do
-        operation_object.validate_request_params({"query_string" => "query", "query_integer_list" => [1, 2]}, @validator_option)
-        operation_object.validate_request_params({"query_string" => "query", "query_integer_list" => [1, 2], "optional_integer" => 1}, @validator_option)
+        operation_object.validate_request_params(
+            {"query_string" => "query", "query_integer_list" => [1, 2]},
+            HEADER,
+            @validator_option
+        )
+
+        operation_object.validate_request_params(
+            {"query_string" => "query", "query_integer_list" => [1, 2], "optional_integer" => 1},
+            HEADER,
+            @validator_option
+        )
 
         assert true
       end
 
       it 'not exist required' do
         e = assert_raises(Committee::InvalidRequest) {
-          operation_object.validate_request_params({"query_integer_list" => [1, 2]}, @validator_option)
+          operation_object.validate_request_params({"query_integer_list" => [1, 2]}, HEADER, @validator_option)
         }
 
         assert e.message.start_with?("required parameters query_string not exist in")
@@ -100,7 +112,11 @@ describe Committee::SchemaValidator::OpenAPI3::OperationWrapper do
 
       it 'invalid type' do
         e = assert_raises(Committee::InvalidRequest) {
-          operation_object.validate_request_params({"query_string" => 1, "query_integer_list" => [1, 2], "optional_integer" => 1}, @validator_option)
+          operation_object.validate_request_params(
+              {"query_string" => 1, "query_integer_list" => [1, 2], "optional_integer" => 1},
+              HEADER,
+              @validator_option
+          )
         }
 
         # FIXME: when ruby 2.3 dropped, fix because ruby 2.3 return Fixnum, ruby 2.4 or later return Integer
@@ -115,14 +131,14 @@ describe Committee::SchemaValidator::OpenAPI3::OperationWrapper do
       end
 
       it 'correct' do
-        operation_object.validate_request_params({"limit" => "1"}, @validator_option)
+        operation_object.validate_request_params({"limit" => "1"}, HEADER, @validator_option)
 
         assert true
       end
 
       it 'invalid type' do
         e = assert_raises(Committee::InvalidRequest) {
-          operation_object.validate_request_params({"limit" => "a"}, @validator_option)
+          operation_object.validate_request_params({"limit" => "a"}, HEADER, @validator_option)
         }
 
         assert e.message.start_with?("a class is String but")

data/test/schema_validator/open_api_3/request_validator_test.rb

@@ -1,151 +1,50 @@
 require_relative "../../test_helper"
 
-require "stringio"
-
-# TODO: fix
-
 describe Committee::SchemaValidator::OpenAPI3::RequestValidator do
-  describe 'open_api_3' do
-    before do
-      @schema = JsonSchema.parse!(hyper_schema_data)
-      @schema.expand_references!
-      # POST /apps/:id
-      @link = @schema.properties["app"].links[0]
-      @request = Rack::Request.new({
-                                     "CONTENT_TYPE"   => "application/json",
-                                     "rack.input"     => StringIO.new("{}"),
-                                     "REQUEST_METHOD" => "POST"
-                                   })
-    end
+  describe 'OpenAPI3' do
+    include Rack::Test::Methods
 
-    it "passes through a valid request with Content-Type options" do
-      @headers = { "Content-Type" => "application/json; charset=utf-8" }
-      call({})
+    def app
+      @app
     end
 
-    it "passes through a valid request" do
-      data = {
-        "name" => "heroku-api",
+    it "optionally content_type check" do
+      @app = new_rack_app(check_content_type: true, schema: open_api_3_schema)
+      params = {
+          "string_post_1" => "cloudnasium"
       }
-      call(data)
+      header "Content-Type", "text/html"
+      post "/characters", JSON.generate(params)
+      assert_equal 400, last_response.status
     end
 
-    it "passes through a valid request with Content-Type options" do
-      @request =
-        Rack::Request.new({
-                            "CONTENT_TYPE" => "application/json; charset=utf-8",
-                            "rack.input"   => StringIO.new("{}"),
-                          })
-      data = {
-        "name" => "heroku-api",
+    it "optionally skip content_type check" do
+      @app = new_rack_app(check_content_type: false, schema: open_api_3_schema)
+      params = {
+          "string_post_1" => "cloudnasium"
       }
-      call(data)
+      header "Content-Type", "text/html"
+      post "/characters", JSON.generate(params)
+      assert_equal 200, last_response.status
     end
 
-    it "detects an invalid request Content-Type" do
-      e = assert_raises(Committee::InvalidRequest) {
-        @request =
-          Rack::Request.new({
-                              "CONTENT_TYPE" => "application/x-www-form-urlencoded",
-                              "rack.input"   => StringIO.new("{}"),
-                            })
-        call({})
+    it "if not exist requsetBody definition, skip content_type check" do
+      @app = new_rack_app(check_content_type: true, schema: open_api_3_schema)
+      params = {
+          "string_post_1" => "cloudnasium"
       }
-      message =
-        %{"Content-Type" request header must be set to "application/json".}
-      assert_equal message, e.message
-    end
-
-    it "allows skipping content_type check" do
-      @request =
-        Rack::Request.new({
-                            "CONTENT_TYPE" => "application/x-www-form-urlencoded",
-                            "rack.input"   => StringIO.new("{}"),
-                          })
-      call({}, {}, check_content_type: false)
-    end
-
-    it "detects an missing parameter in GET requests" do
-      # GET /apps/search?query=...
-      @link = @schema.properties["app"].links[5]
-      @request = Rack::Request.new({})
-      e = assert_raises(Committee::InvalidRequest) do
-        call({})
-      end
-      message =
-        %{Invalid request.\n\n#: failed schema #/definitions/app/links/5/schema: "query" wasn't supplied.}
-      assert_equal message, e.message
-    end
-
-    it "allows an invalid Content-Type with an empty body" do
-      @request =
-        Rack::Request.new({
-                            "CONTENT_TYPE" => "application/x-www-form-urlencoded",
-                            "rack.input"   => StringIO.new(""),
-                          })
-      call({})
-    end
-
-    it "detects a parameter of the wrong pattern" do
-      data = {
-        "name" => "%@!"
-      }
-      e = assert_raises(Committee::InvalidRequest) do
-        call(data)
-      end
-      message = %{Invalid request.\n\n#/name: failed schema #/definitions/app/links/0/schema/properties/name: %@! does not match /^[a-z][a-z0-9-]{3,30}$/.}
-      assert_equal message, e.message
-    end
-
-    private
-
-    def call(data, headers={}, options={})
-      # hyper-schema link should be dropped into driver wrapper before it's used
-      link = Committee::Drivers::HyperSchema::Link.new(@link)
-      Committee::SchemaValidator::HyperSchema::RequestValidator.new(link, options).call(@request, data, headers)
+      header "Content-Type", "application/json"
+      patch "/validate_no_parameter", JSON.generate(params)
+      assert_equal 200, last_response.status
     end
-  end
 
-  describe 'OpenAPI 2' do
-    before do
-      @schema = open_api_2_schema
-      @link = @schema.routes['GET'][0][1]
-      @request = Rack::Request.new({
-                                     "CONTENT_TYPE"   => "application/json",
-                                     "rack.input"     => StringIO.new("{}"),
-                                     "REQUEST_METHOD" => "POST"
-                                   })
-    end
-
-
-    it "passes through a valid request" do
-      headers = {
-        "AUTH-TOKEN" => "xxx"
+    def new_rack_app(options = {})
+      Rack::Builder.new {
+        use Committee::Middleware::RequestValidation, options
+        run lambda { |_|
+          [200, {}, []]
+        }
       }
-      call({}, headers)
-    end
-
-    it "detects an missing header parameter in GET requests" do
-      @link = @schema.routes['GET'][0][1]
-      @request = Rack::Request.new({})
-      e = assert_raises(Committee::InvalidRequest) do
-        call({}, {})
-      end
-      message = %{Invalid request.\n\n#: failed schema : "AUTH-TOKEN" wasn't supplied.}
-      assert_equal message, e.message
-    end
-
-    it "allows skipping header schema check" do
-      @link = @schema.routes['GET'][0][1]
-      @request = Rack::Request.new({})
-      call({}, {}, { check_header: false })
-    end
-
-    private
-
-    def call(data, headers={}, options={})
-      # hyper-schema link should be dropped into driver wrapper before it's used
-      Committee::SchemaValidator::HyperSchema::RequestValidator.new(@link, options).call(@request, data, headers)
     end
   end
 end

data/test/schema_validator/open_api_3/response_validator_test.rb

@@ -22,18 +22,30 @@ describe Committee::SchemaValidator::OpenAPI3::ResponseValidator do
     call_response_validator
   end
 
-  # TODO: raise error option
-  it "passes through a valid response with no registered Content-Type" do
+  it "passes through a valid response with no registered Content-Type with strict = false" do
     @headers = { "Content-Type" => "application/xml" }
     call_response_validator
   end
 
-  # TODO: raise error option
+  it "passes through a valid response with no registered Content-Type with strict = true" do
+    @headers = { "Content-Type" => "application/xml" }
+    assert_raises(Committee::InvalidResponse) {
+      call_response_validator(true)
+    }
+  end
+
   it "passes through a valid response with no Content-Type" do
     @headers = {}
     call_response_validator
   end
 
+  it "passes through a valid response with no Content-Type with strict option" do
+    @headers = {}
+    assert_raises(Committee::InvalidResponse) {
+      call_response_validator(true)
+    }
+  end
+
   it "passes through a valid list response" do
     @path = '/validate_response_array'
     @method = 'get'
@@ -48,8 +60,10 @@ describe Committee::SchemaValidator::OpenAPI3::ResponseValidator do
 
   private
 
-  def call_response_validator
+  def call_response_validator(strict = false)
     @operation_object = open_api_3_schema.operation_object(@path, @method)
-    Committee::SchemaValidator::OpenAPI3::ResponseValidator.new(@operation_object, @validator_option).call(@status, @headers, @data)
+    Committee::SchemaValidator::OpenAPI3::ResponseValidator.
+        new(@operation_object, @validator_option).
+        call(@status, @headers, @data, strict)
   end
 end

data/test/test/methods_new_version_test.rb

@@ -46,7 +46,23 @@ describe Committee::Test::Methods do
     end
 
     it "detects an invalid response Content-Type" do
-      @app = new_rack_app(JSON.generate([ValidApp]), {})
+      @app = new_rack_app(JSON.generate([ValidApp]), 200, {})
+      get "/apps"
+      e = assert_raises(Committee::InvalidResponse) do
+        assert_schema_conform
+      end
+      assert_match(/response header must be set to/i, e.message)
+    end
+
+    it "detects an invalid response Content-Type but ignore because it's not success status code" do
+      @committee_options.merge!(validate_success_only: true)
+      @app = new_rack_app(JSON.generate([ValidApp]), 400, {})
+      get "/apps"
+      assert_schema_conform
+    end
+
+    it "detects an invalid response Content-Type and check all status code" do
+      @app = new_rack_app(JSON.generate([ValidApp]), 400, {})
       get "/apps"
       e = assert_raises(Committee::InvalidResponse) do
         assert_schema_conform
@@ -57,10 +73,10 @@ describe Committee::Test::Methods do
 
   private
 
-  def new_rack_app(response, headers={ "Content-Type" => "application/json" })
+  def new_rack_app(response, status=200, headers={ "Content-Type" => "application/json" })
     Rack::Builder.new {
       run lambda { |_|
-        [200, headers, [response]]
+        [status, headers, [response]]
       }
     }
   end