commission_junction 1.7.3 → 1.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 75905dfef02eddb83dc1441839a42ab720533b6b
-  data.tar.gz: b98a7d4ee12ea22cee9be46d9a3d027793978a90
+  metadata.gz: bae9d34f121c997545515282c9ff05fb25a24a4a
+  data.tar.gz: 3ee56677421920706ceb322f6b038da241cb38d4
 SHA512:
-  metadata.gz: c300121aac7c08c9f09209100f59bee34a6228cb7d1933779c5812033efe9c65d2f9ff259ad9285fce7b5cb9af12a17d6f7b2c7e2deceda239527e0c559c896b
-  data.tar.gz: 283bd1a79bb664846802e503c694453e698b821d6a35e73dff0680d2ec4f0f475614f91b2c2e7b6c8e900fdcdc2735a467a5bfdc38b6fbb49434d5d68ee09c91
+  metadata.gz: dbb7d127f62de372d6aa32bbd6f0616ae0bb333e9e51c191da5c737f62532c33b8022897ea27a48f5f6089caa72a6aa51287acd4d2447860013ea8dbc32bd814
+  data.tar.gz: 8ac81f01181cc6050141d66203134657bf8e47affede11bd4b617d5ed070238e6e45092d36767e1d74f5abb5cbef467f4f0646e1c76a55cdd14061a4bfc97d9a

data/.rubocop.yml

@@ -0,0 +1,8 @@
+Metrics/LineLength:
+  Enabled: false
+Metrics/MethodLength:
+  Enabled: false
+Metrics/AbcSize:
+  Enabled: false
+Metrics/ClassLength:
+  Enabled: false

data/README.md

@@ -2,6 +2,8 @@
 
 Ruby wrapper for the Commission Junction web services APIs (REST)
 
+See https://cjcommunity.force.com/s/article/4777058.
+
 [![Gem Version](https://badge.fury.io/rb/commission_junction.png)](http://badge.fury.io/rb/commission_junction)
 
 ## Installation
@@ -21,18 +23,17 @@ Or install it yourself as:
 ## Example
 
 ```ruby
-require 'rubygems'
 require 'commission_junction'
 
-# See https://api.cj.com/sign_up.cj
-DEVELOPER_KEY = '????????'
+# See https://api.cj.com/sign_up.cj.
+DEVELOPER_KEY = '????????'.freeze
 
-# See cj.com > Account > Web site Settings > PID
-WEBSITE_ID = '????????'
+# See cj.com > Account > Websites.
+WEBSITE_ID = '????????'.freeze
 
 cj = CommissionJunction.new(DEVELOPER_KEY, WEBSITE_ID)
 
-# See http://help.cj.com/en/web_services/product_catalog_search_service_rest.htm
+# See https://cjcommunity.force.com/s/article/4777185
 # for the list of request and response parameters.
 cj.product_search('keywords' => '+blue +jeans',
                   'advertiser-ids' => 'joined',
@@ -45,7 +46,7 @@ cj.product_search('keywords' => '+blue +jeans',
   puts ''
 end
 
-# See http://help.cj.com/en/web_services/advertiser_lookup_service_rest.htm
+# See https://cjcommunity.force.com/s/article/4777195
 # for the list of request and response parameters.
 cj.advertiser_lookup('keywords' => '+used +books',
                      'advertiser-ids' => 'joined',
@@ -56,7 +57,7 @@ cj.advertiser_lookup('keywords' => '+used +books',
   puts ''
 end
 
-# See http://help.cj.com/en/web_services/link_search_service_rest.htm
+# See https://cjcommunity.force.com/s/article/4777180
 # for the list of request and response parameters.
 cj.link_search('keywords' => '+used +books',
                'advertiser-ids' => 'joined',
@@ -68,13 +69,16 @@ cj.link_search('keywords' => '+used +books',
   puts ''
 end
 
-# See http://help.cj.com/en/web_services/support_services_rest.htm
+# See https://cjcommunity.force.com/s/article/4777190
 # for the list of request and response parameters.
 puts cj.categories
 
-# See http://help.cj.com/en/web_services/Commission_Detail_Service.htm
+# See https://cjcommunity.force.com/s/article/4777175
 # for the list of request and response parameters.
+ids = []
+
 cj.commissions.each do |commission|
+  ids << commission.original_action_id
   puts commission.action_type
   puts commission.aid
   puts commission.commission_id
@@ -84,6 +88,26 @@ cj.commissions.each do |commission|
   puts commission.sid
   puts ''
 end
+
+# Each commission comes from the sale of one or more items.
+# Commissions and their items are linked by original_action_id.
+cj.item_detail(ids[0, 50]).each do |item_detail|
+  puts item_detail['original_action_id']
+
+  items = item_detail['item']
+  # If there is exactly one item, put it in an array.
+  items = [items] if items.is_a?(Hash)
+
+  items.each do |item|
+    puts item['sku']
+    puts item['quantity']
+    puts item['posting_date']
+    puts item['commission_id']
+    puts item['sale_amount']
+    puts item['discount']
+    puts item['publisher_commission']
+  end if items
+end
 ```
 
 ## Dependencies

data/Rakefile

@@ -7,4 +7,4 @@ Rake::TestTask.new(:test) do |test|
   test.verbose = true
 end
 
-task :default => :test
+task default: :test

data/commission_junction.gemspec

@@ -8,16 +8,16 @@ Gem::Specification.new do |gem|
   gem.version       = CommissionJunction::VERSION
   gem.author        = 'Albert Vernon'
   gem.email         = 'aev@vernon.nu'
-  gem.description   = %q{Ruby wrapper for the Commission Junction web services APIs (REST)}
-  gem.summary       = %q{Commission Junction web services APIs (REST)}
-  gem.homepage      = %q{https://github.com/aevernon/commission_junction}
+  gem.description   = 'Ruby wrapper for the Commission Junction web services APIs (REST)'
+  gem.summary       = 'Commission Junction web services APIs (REST)'
+  gem.homepage      = 'https://github.com/aevernon/commission_junction'
 
-  gem.files         = `git ls-files`.split($/)
-  gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
+  gem.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
+  gem.executables   = gem.files.grep(%r{^bin/}).map { |f| File.basename(f) }
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ['lib']
   gem.add_dependency 'httparty', '~> 0.13'
   gem.add_development_dependency 'minitest', '~> 0'
   gem.add_dependency 'ox', '~> 2.1'
-  gem.license       = 'BSD-3-Clause'
+  gem.license = 'BSD-3-Clause'
 end

data/lib/commission_junction/version.rb

@@ -1,3 +1,3 @@
 class CommissionJunction
-  VERSION = '1.7.3'
+  VERSION = '1.8.0'.freeze
 end

data/lib/commission_junction.rb

@@ -3,11 +3,12 @@ require 'ox'
 require 'httparty'
 
 # Interact with CJ web services.
+# See https://cjcommunity.force.com/s/article/4777058.
 class CommissionJunction
   include HTTParty
   default_options.update(verify: false) # Skip SSL certificate verification.
   format(:xml)
-  #debug_output $stderr
+  # debug_output $stderr
 
   attr_reader :total_matched,
               :records_returned,
@@ -15,20 +16,21 @@ class CommissionJunction
               :cj_objects
 
   WEB_SERVICE_URIS =
-  {
-    :product_search    => 'https://product-search.api.cj.com/v2/product-search',
-    :link_search       => 'https://link-search.api.cj.com/v2/link-search',
-    :advertiser_lookup => 'https://advertiser-lookup.api.cj.com/v3/advertiser-lookup',
-    :categories        => 'https://support-services.api.cj.com/v2/categories',
-    :commissions       => 'https://commission-detail.api.cj.com/v3/commissions'
-  }
+    {
+      product_search: 'https://product-search.api.cj.com/v2/product-search',
+      link_search: 'https://link-search.api.cj.com/v2/link-search',
+      advertiser_lookup: 'https://advertiser-lookup.api.cj.com/v3/advertiser-lookup',
+      categories: 'https://support-services.api.cj.com/v2/categories',
+      commissions: 'https://commission-detail.api.cj.com/v3/commissions',
+      item_detail: 'https://commission-detail.api.cj.com/v3/item-detail/'
+    }.freeze
 
   def initialize(developer_key, website_id, timeout = 10)
     raise ArgumentError, "developer_key must be a String; got #{developer_key.class} instead" unless developer_key.is_a?(String)
-    raise ArgumentError, "You must supply your developer key.\nSee https://api.cj.com/sign_up.cj" unless developer_key.length > 0
+    raise ArgumentError, "You must supply your developer key.\nSee https://api.cj.com/sign_up.cj" if developer_key.empty?
 
     website_id = website_id.to_s
-    raise ArgumentError, "You must supply your website ID.\nSee cj.com > Account > Web site Settings > PID" unless website_id.length > 0
+    raise ArgumentError, "You must supply your website ID.\nSee cj.com > Account > Web site Settings > PID" if website_id.empty?
     @website_id = website_id
 
     raise ArgumentError, "timeout must be a Fixnum; got #{timeout.class} instead" unless timeout.is_a?(Fixnum)
@@ -42,21 +44,21 @@ class CommissionJunction
   def categories(params = {})
     raise ArgumentError, "params must be a Hash; got #{params.class} instead" unless params.is_a?(Hash)
 
-    params = {'locale' => 'en'}.merge(params)
+    params = { 'locale' => 'en' }.merge(params)
 
-    response = self.class.get(WEB_SERVICE_URIS[:categories], :query => params, :timeout => @timeout)
+    response = self.class.get(WEB_SERVICE_URIS[:categories], query: params, timeout: @timeout)
     @categories = extract_contents(response, 'categories', 'category')
   end
 
   def advertiser_lookup(params = {})
     raise ArgumentError, "params must be a Hash; got #{params.class} instead" unless params.is_a?(Hash)
 
-    params = {'advertiser-ids' => 'joined'}.merge(params)
+    params = { 'advertiser-ids' => 'joined' }.merge(params)
 
     @cj_objects = []
 
     begin
-      response = self.class.get(WEB_SERVICE_URIS[:advertiser_lookup], :query => params)
+      response = self.class.get(WEB_SERVICE_URIS[:advertiser_lookup], query: params)
       advertisers = extract_contents(response, 'advertisers')
 
       @total_matched = advertisers['total_matched'].to_i
@@ -76,8 +78,8 @@ class CommissionJunction
   def product_search(params)
     raise ArgumentError, "params must be a Hash; got #{params.class} instead" unless params.is_a?(Hash)
 
-    unless params.size > 0
-      raise ArgumentError, "You must provide at least one request parameter, for example, \"keywords\".\nSee http://help.cj.com/en/web_services/product_catalog_search_service_rest.htm"
+    if params.empty?
+      raise ArgumentError, "You must provide at least one request parameter, for example, \"keywords\".\nSee https://cjcommunity.force.com/s/article/4777185."
     end
 
     params['website-id'] = @website_id
@@ -85,7 +87,7 @@ class CommissionJunction
     @cj_objects = []
 
     begin
-      response = self.class.get(WEB_SERVICE_URIS[:product_search], :query => params, :timeout => @timeout)
+      response = self.class.get(WEB_SERVICE_URIS[:product_search], query: params, timeout: @timeout)
       products = extract_contents(response, 'products')
 
       @total_matched = products['total_matched'].to_i
@@ -105,8 +107,8 @@ class CommissionJunction
   def link_search(params)
     raise ArgumentError, "params must be a Hash; got #{params.class} instead" unless params.is_a?(Hash)
 
-    unless params.size > 0
-      raise ArgumentError, "You must provide at least one request parameter, for example, \"keywords\".\nSee http://help.cj.com/en/web_services/product_catalog_search_service_rest.htm"
+    if params.empty?
+      raise ArgumentError, "You must provide at least one request parameter, for example, \"keywords\".\nSee https://cjcommunity.force.com/s/article/4777180."
     end
 
     params['website-id'] = @website_id
@@ -114,7 +116,7 @@ class CommissionJunction
     @cj_objects = []
 
     begin
-      response = self.class.get(WEB_SERVICE_URIS[:link_search], :query => params, :timeout => @timeout)
+      response = self.class.get(WEB_SERVICE_URIS[:link_search], query: params, timeout: @timeout)
       links = extract_contents(response, 'links')
 
       @total_matched = links['total_matched'].to_i
@@ -134,12 +136,12 @@ class CommissionJunction
   def commissions(params = {})
     raise ArgumentError, "params must be a Hash; got #{params.class} instead" unless params.is_a?(Hash)
 
-    params = {'date-type' => 'event'}.merge(params)
+    params = { 'date-type' => 'event' }.merge(params)
 
     @cj_objects = []
 
     begin
-      response = self.class.get(WEB_SERVICE_URIS[:commissions], :query => params)
+      response = self.class.get(WEB_SERVICE_URIS[:commissions], query: params)
       commissions = extract_contents(response, 'commissions')
 
       @total_matched = commissions['total_matched'].to_i
@@ -156,10 +158,31 @@ class CommissionJunction
     @cj_objects
   end
 
-  def extract_contents(response, first_level, second_level=nil)
+  def item_detail(original_action_ids)
+    raise ArgumentError, "original_action_ids must be an Array; got #{original_action_ids.class} instead" unless original_action_ids.is_a?(Array)
+
+    unless (1..50).cover?(original_action_ids.size)
+      raise ArgumentError, "You must provide between 1 and 50 original action IDs.\nSee https://cjcommunity.force.com/s/article/4777175."
+    end
+
+    @cj_objects = []
+
+    begin
+      ids = original_action_ids.join(',')
+      response = self.class.get(WEB_SERVICE_URIS[:item_detail] + ids, query: "original-action-id=#{ids}")
+      @cj_objects = extract_contents(response, 'item_details')
+      @cj_objects = [@cj_objects] if @cj_objects.is_a?(Hash) # If we got exactly one result, put it in an array.
+    rescue Timeout::Error
+      @total_matched = @records_returned = @page_number = 0
+    end
+
+    @cj_objects
+  end
+
+  def extract_contents(response, first_level, second_level = nil)
     cj_api = response['cj_api']
 
-    raise ArgumentError, "cj api missing from response" if cj_api.nil?
+    raise ArgumentError, 'cj api missing from response' if cj_api.nil?
 
     error_message = cj_api['error_message']
 
@@ -169,10 +192,11 @@ class CommissionJunction
     cj_api[first_level][second_level]
   end
 
+  # Turn a hash into an object where each key becomes an instance method.
   class CjObject
     def initialize(params)
       raise ArgumentError, "params must be a Hash; got #{params.class} instead" unless params.is_a?(Hash)
-      raise ArgumentError, 'Expecting at least one parameter' unless params.size > 0
+      raise ArgumentError, 'Expecting at least one parameter' if params.empty?
 
       # Create instance variables and attribute readers on the fly.
       # Credit:  http://listlibrary.net/ruby-talk/2004/03/00sGI1cD
@@ -180,7 +204,7 @@ class CommissionJunction
         raise ArgumentError, "key must be a String; got #{key.class} instead" unless key.is_a?(String)
         clean_key = clean_key_name(key)
         instance_variable_set("@#{clean_key}".intern, val)
-        instance_eval %Q{ class << self ; attr_reader #{clean_key.intern.inspect} ; end }
+        instance_eval %( class << self ; attr_reader #{clean_key.intern.inspect} ; end )
       end
     end
 

data/test/commission_junction_test.rb

@@ -43,11 +43,11 @@ class CommissionJunctionTest < Minitest::Test
 
   def test_new_cj_with_non_string_param
     assert_raises ArgumentError do
-      CommissionJunction.new(123456, 'website_id')
+      CommissionJunction.new(123_456, 'website_id')
     end
 
     assert_nothing_raised ArgumentError do
-      CommissionJunction.new('developer_key', 123456)
+      CommissionJunction.new('developer_key', 123_456)
     end
   end
 
@@ -103,7 +103,7 @@ class CommissionJunctionTest < Minitest::Test
 
   def test_new_product_with_hash_params_and_non_string_keys
     assert_raises ArgumentError do
-      CommissionJunction::Product.new(:name => 'blue jeans', :price => '49.95')
+      CommissionJunction::Product.new(name: 'blue jeans', price: '49.95')
     end
   end
 
@@ -151,12 +151,11 @@ class CommissionJunctionTest < Minitest::Test
   end
 
   def test_product_search_with_keywords_live
-    key_file = File.join(ENV['HOME'], '.commission_junction.yaml')
-
-    skip "#{key_file} does not exist. Put your CJ developer key and website ID in there to enable live testing." unless File.exist?(key_file)
+    unless ENV['CJ_DEVELOPER_KEY'] && ENV['CJ_WEBSITE_ID']
+      skip 'Skipping live testing because environment variables CJ_DEVELOPER_KEY and CJ_WEBSITE_ID are not set.'
+    end
 
-    credentials = YAML.load(File.read(key_file))
-    cj = CommissionJunction.new(credentials['developer_key'], credentials['website_id'])
+    cj = CommissionJunction.new(ENV['CJ_DEVELOPER_KEY'], ENV['CJ_WEBSITE_ID'])
 
     # Zero results
     assert_nothing_raised do
@@ -180,7 +179,7 @@ class CommissionJunctionTest < Minitest::Test
     check_search_results(cj)
 
     # Short timeout
-    cj = CommissionJunction.new(credentials['developer_key'], credentials['website_id'], 1)
+    cj = CommissionJunction.new(ENV['CJ_DEVELOPER_KEY'], ENV['CJ_WEBSITE_ID'], 1)
 
     assert_nothing_raised do
       cj.product_search('keywords' => 'One Great Blue Jean~No Limits', 'records-per-page' => '1')
@@ -219,12 +218,11 @@ class CommissionJunctionTest < Minitest::Test
   end
 
   def test_advertiser_lookup_live
-    key_file = File.join(ENV['HOME'], '.commission_junction.yaml')
-
-    skip "#{key_file} does not exist. Put your CJ developer key and website ID in there to enable live testing." unless File.exist?(key_file)
+    unless ENV['CJ_DEVELOPER_KEY'] && ENV['CJ_WEBSITE_ID']
+      skip 'Skipping live testing because environment variables CJ_DEVELOPER_KEY and CJ_WEBSITE_ID are not set.'
+    end
 
-    credentials = YAML.load(File.read(key_file))
-    cj = CommissionJunction.new(credentials['developer_key'], credentials['website_id'])
+    cj = CommissionJunction.new(ENV['CJ_DEVELOPER_KEY'], ENV['CJ_WEBSITE_ID'])
 
     # Use default lookup parameters.
     assert_nothing_raised do
@@ -248,7 +246,7 @@ class CommissionJunctionTest < Minitest::Test
     check_advertiser_lookup_results(cj)
 
     # Short timeout
-    cj = CommissionJunction.new(credentials['developer_key'], credentials['website_id'], 1)
+    cj = CommissionJunction.new(ENV['CJ_DEVELOPER_KEY'], ENV['CJ_WEBSITE_ID'], 1)
 
     assert_nothing_raised do
       cj.advertiser_lookup('keywords' => 'One Great Blue Jean~No Limits', 'records-per-page' => '1')
@@ -280,23 +278,21 @@ class CommissionJunctionTest < Minitest::Test
   end
 
   def test_categories_live
-    key_file = File.join(ENV['HOME'], '.commission_junction.yaml')
-
-    skip "#{key_file} does not exist. Put your CJ developer key and website ID in there to enable live testing." unless File.exist?(key_file)
+    unless ENV['CJ_DEVELOPER_KEY'] && ENV['CJ_WEBSITE_ID']
+      skip 'Skipping live testing because environment variables CJ_DEVELOPER_KEY and CJ_WEBSITE_ID are not set.'
+    end
 
-    credentials = YAML.load(File.read(key_file))
-    cj = CommissionJunction.new(credentials['developer_key'], credentials['website_id'])
+    cj = CommissionJunction.new(ENV['CJ_DEVELOPER_KEY'], ENV['CJ_WEBSITE_ID'])
 
-    assert cj.categories.size > 0
+    assert !cj.categories.empty?
   end
 
   def test_commissions_live
-    key_file = File.join(ENV['HOME'], '.commission_junction.yaml')
-
-    skip "#{key_file} does not exist. Put your CJ developer key and website ID in there to enable live testing." unless File.exist?(key_file)
+    unless ENV['CJ_DEVELOPER_KEY'] && ENV['CJ_WEBSITE_ID']
+      skip 'Skipping live testing because environment variables CJ_DEVELOPER_KEY and CJ_WEBSITE_ID are not set.'
+    end
 
-    credentials = YAML.load(File.read(key_file))
-    cj = CommissionJunction.new(credentials['developer_key'], credentials['website_id'])
+    cj = CommissionJunction.new(ENV['CJ_DEVELOPER_KEY'], ENV['CJ_WEBSITE_ID'])
 
     assert_nothing_raised do
       cj.commissions
@@ -342,13 +338,86 @@ class CommissionJunctionTest < Minitest::Test
     end
   end
 
-  def test_link_search_live
-    key_file = File.join(ENV['HOME'], '.commission_junction.yaml')
+  def test_item_detail_with_no_params
+    assert_raises ArgumentError do
+      CommissionJunction.new('developer_key', 'website_id').item_detail
+    end
+  end
+
+  def test_item_detail_with_nil_params
+    assert_raises ArgumentError do
+      CommissionJunction.new('developer_key', 'website_id').item_detail(nil)
+    end
+  end
+
+  def test_item_detail_with_too_few_ids
+    assert_raises ArgumentError do
+      CommissionJunction.new('developer_key', 'website_id').item_detail([])
+    end
+  end
+
+  def test_item_detail_with_too_many_ids
+    assert_raises ArgumentError do
+      CommissionJunction.new('developer_key', 'website_id').item_detail(Array.new(51))
+    end
+  end
 
-    skip "#{key_file} does not exist. Put your CJ developer key and website ID in there to enable live testing." unless File.exist?(key_file)
+  def test_item_detail_with_non_array_params
+    assert_raises ArgumentError do
+      CommissionJunction.new('developer_key', 'website_id').item_detail('string')
+    end
+  end
+
+  def test_item_detail_live
+    unless ENV['CJ_DEVELOPER_KEY'] && ENV['CJ_WEBSITE_ID']
+      skip 'Skipping live testing because environment variables CJ_DEVELOPER_KEY and CJ_WEBSITE_ID are not set.'
+    end
+
+    cj = CommissionJunction.new(ENV['CJ_DEVELOPER_KEY'], ENV['CJ_WEBSITE_ID'])
+
+    ids = []
+
+    cj.commissions.each do |commission|
+      ids << commission.original_action_id
+    end
+
+    skip 'Skipping live testing of item_detail because there are no original action IDs in your account.' if ids.empty?
+
+    assert_nothing_raised do
+      cj.item_detail(ids[0, 1])
+      check_item_detail_results(cj)
+      cj.item_detail(ids[0, 2])
+      check_item_detail_results(cj)
+    end
+  end
+
+  def check_item_detail_results(results)
+    assert_instance_of(Array, results.cj_objects)
+
+    results.cj_objects.each do |item_detail|
+      assert_instance_of(Hash, item_detail)
+      assert item_detail.key?('original_action_id')
+      assert item_detail.key?('item')
+
+      item = item_detail['item']
+      item = item.first if item.is_a?(Array)
+
+      assert item.key?('sku')
+      assert item.key?('quantity')
+      assert item.key?('posting_date')
+      assert item.key?('commission_id')
+      assert item.key?('sale_amount')
+      assert item.key?('discount')
+      assert item.key?('publisher_commission')
+    end
+  end
+
+  def test_link_search_live
+    unless ENV['CJ_DEVELOPER_KEY'] && ENV['CJ_WEBSITE_ID']
+      skip 'Skipping live testing because environment variables CJ_DEVELOPER_KEY and CJ_WEBSITE_ID are not set.'
+    end
 
-    credentials = YAML.load(File.read(key_file))
-    cj = CommissionJunction.new(credentials['developer_key'], credentials['website_id'])
+    cj = CommissionJunction.new(ENV['CJ_DEVELOPER_KEY'], ENV['CJ_WEBSITE_ID'])
 
     assert_nothing_raised do
       cj.link_search('keywords' => '+blue +jeans', 'advertiser-ids' => 'joined')
@@ -390,35 +459,35 @@ class CommissionJunctionTest < Minitest::Test
   end
 
   def set_up_service
-    CommissionJunction.new('developer_key', 123456)
+    CommissionJunction.new('developer_key', 123_456)
   end
 
   def test_contents_extractor_with_first_level
-    contents = "abc"
-    response = {'cj_api' => {'first' => contents}}
+    contents = 'abc'
+    response = { 'cj_api' => { 'first' => contents } }
 
     cj = set_up_service
 
-    assert_equal(contents, cj.extract_contents(response, "first"))
+    assert_equal(contents, cj.extract_contents(response, 'first'))
   end
 
   def test_contents_extractor_with_second_level
-    contents = "abc"
-    response = {'cj_api' => {'first' => {'second' => contents}}}
+    contents = 'abc'
+    response = { 'cj_api' => { 'first' => { 'second' => contents } } }
 
     cj = set_up_service
 
-    assert_equal(contents, cj.extract_contents(response, "first", "second"))
+    assert_equal(contents, cj.extract_contents(response, 'first', 'second'))
   end
 
   def test_contents_extractor_with_error_message
-    contents = "abc"
-    response = {'cj_api' => {'error_message' => contents}}
+    contents = 'abc'
+    response = { 'cj_api' => { 'error_message' => contents } }
 
     cj = set_up_service
 
     assert_raises ArgumentError do
-      cj.extract_contents(response, "first")
+      cj.extract_contents(response, 'first')
     end
   end
 
@@ -428,28 +497,28 @@ class CommissionJunctionTest < Minitest::Test
     cj = set_up_service
 
     assert_raises ArgumentError do
-      cj.extract_contents(response, "first")
+      cj.extract_contents(response, 'first')
     end
   end
 
   def set_up_cj_object
-    CommissionJunction::CjObject.new({"a" => "a"})
+    CommissionJunction::CjObject.new('a' => 'a')
   end
 
   def test_key_conversion_with_spaces
     cjo = set_up_cj_object
 
-    assert_equal("abc_def", cjo.clean_key_name("abc def"))
+    assert_equal('abc_def', cjo.clean_key_name('abc def'))
   end
 
   def test_key_conversion_with_trailing_spaces
     cjo = set_up_cj_object
 
-    assert_equal("abcdef", cjo.clean_key_name("abcdef "))
+    assert_equal('abcdef', cjo.clean_key_name('abcdef '))
   end
 
   def test_initializing_product_using_key_with_spaces
-    product = CommissionJunction::Product.new("abc def" => "123")
-    assert_equal(product.abc_def, "123")
+    product = CommissionJunction::Product.new('abc def' => '123')
+    assert_equal(product.abc_def, '123')
   end
 end

data/test/test_helper.rb

@@ -1,4 +1,3 @@
-require 'rubygems'
 require 'minitest/autorun'
 
 $LOAD_PATH.unshift(File.dirname(__FILE__))

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: commission_junction
 version: !ruby/object:Gem::Version
-  version: 1.7.3
+  version: 1.8.0
 platform: ruby
 authors:
 - Albert Vernon
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-12 00:00:00.000000000 Z
+date: 2016-06-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -59,6 +59,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
 - Gemfile
 - LICENSE
 - README.md
@@ -88,7 +89,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Commission Junction web services APIs (REST)