commission_junction 1.7.2 → 1.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e00330e15a7b42cf61330c9aa59685979dbdfd50
-  data.tar.gz: c56a45455189f9c159b871f70f9fdf22bdfcafb4
+  metadata.gz: 75905dfef02eddb83dc1441839a42ab720533b6b
+  data.tar.gz: b98a7d4ee12ea22cee9be46d9a3d027793978a90
 SHA512:
-  metadata.gz: 41046a5ab67a67afe7efd89461180923740a47de1cf87ac2df6bc05b683be395da0f5a4382de0a4bf46f03c4d1ca39f6742ade2f964b901fa88d71dd46777c2a
-  data.tar.gz: f5e6df6e63b1007d415288a19def29301729d26e2fb4f922417deb5eceac987e292455df8affda7d09747f752d71b790f133a51aaf70cc9521894b86ddb303ef
+  metadata.gz: c300121aac7c08c9f09209100f59bee34a6228cb7d1933779c5812033efe9c65d2f9ff259ad9285fce7b5cb9af12a17d6f7b2c7e2deceda239527e0c559c896b
+  data.tar.gz: 283bd1a79bb664846802e503c694453e698b821d6a35e73dff0680d2ec4f0f475614f91b2c2e7b6c8e900fdcdc2735a467a5bfdc38b6fbb49434d5d68ee09c91

data/lib/commission_junction/version.rb

@@ -1,3 +1,3 @@
 class CommissionJunction
-  VERSION = '1.7.2'
+  VERSION = '1.7.3'
 end

data/lib/commission_junction.rb

@@ -178,10 +178,15 @@ class CommissionJunction
       # Credit:  http://listlibrary.net/ruby-talk/2004/03/00sGI1cD
       params.each do |key, val|
         raise ArgumentError, "key must be a String; got #{key.class} instead" unless key.is_a?(String)
-        instance_variable_set("@#{key}".intern, val)
-        instance_eval %Q{ class << self ; attr_reader #{key.intern.inspect} ; end }
+        clean_key = clean_key_name(key)
+        instance_variable_set("@#{clean_key}".intern, val)
+        instance_eval %Q{ class << self ; attr_reader #{clean_key.intern.inspect} ; end }
       end
     end
+
+    def clean_key_name(name)
+      name.strip.gsub(/\s/, '_')
+    end
   end
 
   class Product < CjObject

data/test/commission_junction_test.rb

@@ -389,11 +389,15 @@ class CommissionJunctionTest < Minitest::Test
     end
   end
 
+  def set_up_service
+    CommissionJunction.new('developer_key', 123456)
+  end
+
   def test_contents_extractor_with_first_level
     contents = "abc"
     response = {'cj_api' => {'first' => contents}}
 
-    cj = CommissionJunction.new('developer_key', 123456)
+    cj = set_up_service
 
     assert_equal(contents, cj.extract_contents(response, "first"))
   end
@@ -402,7 +406,7 @@ class CommissionJunctionTest < Minitest::Test
     contents = "abc"
     response = {'cj_api' => {'first' => {'second' => contents}}}
 
-    cj = CommissionJunction.new('developer_key', 123456)
+    cj = set_up_service
 
     assert_equal(contents, cj.extract_contents(response, "first", "second"))
   end
@@ -411,7 +415,7 @@ class CommissionJunctionTest < Minitest::Test
     contents = "abc"
     response = {'cj_api' => {'error_message' => contents}}
 
-    cj = CommissionJunction.new('developer_key', 123456)
+    cj = set_up_service
 
     assert_raises ArgumentError do
       cj.extract_contents(response, "first")
@@ -421,10 +425,31 @@ class CommissionJunctionTest < Minitest::Test
   def test_contents_extractor_with_no_cj_api
     response = {}
 
-    cj = CommissionJunction.new('developer_key', 123456)
+    cj = set_up_service
 
     assert_raises ArgumentError do
       cj.extract_contents(response, "first")
     end
   end
+
+  def set_up_cj_object
+    CommissionJunction::CjObject.new({"a" => "a"})
+  end
+
+  def test_key_conversion_with_spaces
+    cjo = set_up_cj_object
+
+    assert_equal("abc_def", cjo.clean_key_name("abc def"))
+  end
+
+  def test_key_conversion_with_trailing_spaces
+    cjo = set_up_cj_object
+
+    assert_equal("abcdef", cjo.clean_key_name("abcdef "))
+  end
+
+  def test_initializing_product_using_key_with_spaces
+    product = CommissionJunction::Product.new("abc def" => "123")
+    assert_equal(product.abc_def, "123")
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: commission_junction
 version: !ruby/object:Gem::Version
-  version: 1.7.2
+  version: 1.7.3
 platform: ruby
 authors:
 - Albert Vernon
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-10 00:00:00.000000000 Z
+date: 2015-01-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty