commendo 0.0.8 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 62cfaa4fff44e045a7adf83a7bc3ccb29db84812
-  data.tar.gz: 8473e5cb764e1474f2aa541b195afd22ca123a84
+  metadata.gz: 80baa49ab8364f70fd8dd4f2127f95d4f5ad0da2
+  data.tar.gz: 355812df077e1df1cb4d0425fb36fac8334d19f6
 SHA512:
-  metadata.gz: 2e2911b2ab856cc6ce7514f289a02cf1fe3e29e9e4a546aca1a11a97da8c4f4b9a2518074ed8b1b4148ffde164c62a970d36f42cd1c6e56b9c49021f513b818f
-  data.tar.gz: f8664d3e2e048c9026865929c1c39375242b3f05d669b6b14212442f3ffaeb0aeca03a8a80091c42e1b59d6e305d7622b5ffb8eca516f083a4af991aaeaf8ef7
+  metadata.gz: a1c2164296cfe3c47d0ef943594aeb6b4f20a007f421729ddd5b4328c3ffd2e90033f7315fac9451f98f39a088b504f0252cc3540a75560f6df9b4052bc4c9b6
+  data.tar.gz: 5d31d9f878a2eb7ab19e97b13887adb95b3df416866993b5c9ff8008a21f24b97c7acaf685a1baeb17d9003fa6716a5b1d5041efe057de1f2dc70327c8eba4df

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+# 0.0.9 / 2014-04-09
+* [BUGFIX] Fix similarity calculation for resources in many sets
+
 # 0.0.8 / 2014-04-09
 * [FEATURE] Allow degree of set membership to be included when adding data and incrementally increase scores when adding new data
 

data/lib/commendo/pair_comparison.lua

@@ -4,8 +4,8 @@ local left_similarity_key = KEYS[3]
 local right_similarity_key = KEYS[4]
 
 local tmp_key_base = ARGV[1]
-local left = tonumber(ARGV[2])
-local right = tonumber(ARGV[3])
+local left = ARGV[2]
+local right = ARGV[3]
 local threshold = tonumber(ARGV[4])
 
 local function round(num, idp)
@@ -40,9 +40,14 @@ if table.getn(intersect) > 0 then
     end
 
     local similarity = round(intersect_score / union_score, 3)
+    redis.log(redis.LOG_NOTICE, 'Similarity from pair comparison for ' .. left_key .. ' ' .. right_key .. ', ' .. similarity .. ', ' .. threshold)
     if similarity > threshold then
+        redis.log(redis.LOG_NOTICE, 'Saving ' .. left_similarity_key .. ', ' .. similarity .. ', ' .. right)
         redis.call('ZADD', left_similarity_key, similarity, right)
+        redis.log(redis.LOG_NOTICE, 'Saving ' .. right_similarity_key .. ', ' .. similarity .. ', ' .. left)
         redis.call('ZADD', right_similarity_key, similarity, left)
+    else
+        redis.log(redis.LOG_NOTICE, 'NOT saving ' .. right_similarity_key .. ', ' .. similarity .. ', ' .. left)
     end
 end
 

data/lib/commendo/version.rb

@@ -1,3 +1,3 @@
 module Commendo
-  VERSION = '0.0.8'
+  VERSION = '0.0.9'
 end

data/test/content_set_test.rb

@@ -52,6 +52,22 @@ module Commendo
       assert_equal expected, cs.similar_to('resource-1')
     end
 
+    def test_recommends_with_large_number_of_groups
+      redis = Redis.new(db: 15)
+      redis.flushdb
+      key_base = 'CommendoTests'
+      cs = ContentSet.new(redis, key_base)
+      (0..3000).each do |i|
+        cs.add('resource-1', ["group-#{i}", i/100.0], ["group-#{i+1}", i/20.0])
+        cs.add('resource-9', ["group-#{i}", i/100.0], ["group-#{i+1}", i/20.0])
+      end
+      cs.calculate_similarity
+      expected = [
+        {resource: 'resource-9', similarity: 1.0}
+      ]
+      assert_equal expected, cs.similar_to('resource-1')
+    end
+
     def test_recommends_when_extra_scores_added
       test_recommends_when_added_with_scores
       redis = Redis.new(db: 15)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: commendo
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
 platform: ruby
 authors:
 - Rob Styles
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-09 00:00:00.000000000 Z
+date: 2014-04-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis