commander 4.4.5 → 4.4.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 3a1cbc50f621accf022cc6ff4e1d753c897014b8
-  data.tar.gz: e43562746b1399a48c7e106fdddff3a504659b23
+SHA256:
+  metadata.gz: 584705d6b59c75d49df6d2369763f91b5a5dbc5013575dbb2be575983b040f60
+  data.tar.gz: 0bab3911300bcc194406717c08ab1718608c86fe62703f0219a16a645bded947
 SHA512:
-  metadata.gz: 1102742dbd50e6d51804db0856a17311d34204c3131d66f8e11a53e7f3cee9ef564c3e093721118118ee44c1d327e67f8a7b5bf96b1e73a8a8c6104b10d23c24
-  data.tar.gz: e0b816eb1a4bc45348c317455939e548d5386e0d20fa79380ec00ed265552f8cb030d316702dac5a0463741e0fcce90701c3202fa4a21c2f68011e7fd5168574
+  metadata.gz: 1bb1d5703d53f0c6a140e7f24e0d4c9f0e80283425b2daf49d80da554a78122d4eb731bb9ee817c11e0636732938ffab81367312f599b40c3c8f8dc036ab9604
+  data.tar.gz: 1da0b8c354a4b0fc744e170c6d6e3393ddbb759ae9fecf50cf06274ee1611dd48d1f9c69e0414c3b28d2d810d56e0a6348c17eec3c58b084dd14f594a7f9a3b4

data/History.rdoc

@@ -1,3 +1,7 @@
+=== 4.4.6 / 2018-07-31
+
+* Fix unexpected internal behavior change introduced in 4.4.5.
+
 === 4.4.5 / 2018-05-22
 
 * Make internal command state less mutable. (@doriantaylor)

data/lib/commander/command.rb

@@ -161,6 +161,9 @@ module Commander
 
     def parse_options_and_call_procs(*args)
       return args if args.empty?
+      # empty proxy_options before populating via OptionParser
+      # prevents duplication of options if the command is run twice
+      proxy_options.clear
       @options.each_with_object(OptionParser.new) do |option, opts|
         opts.on(*option[:args], &option[:proc])
         opts
@@ -175,9 +178,6 @@ module Commander
       meth ||= :call
       options = proxy_option_struct
 
-      # empty the proxy option stack before the next invocation
-      proxy_options.clear
-
       case object
       when Proc then object.call(args, options)
       when Class then meth != :call ? object.new.send(meth, args, options) : object.new(args, options)

data/lib/commander/version.rb

@@ -1,3 +1,3 @@
 module Commander
-  VERSION = '4.4.5'.freeze
+  VERSION = '4.4.6'.freeze
 end

data/spec/command_spec.rb

@@ -80,9 +80,11 @@ describe Commander::Command do
         expect(@command.run('twice')).to eql('test twice')
       end
 
-      it 'should empty @proxy_options after running' do
+      it 'should not accumulate entries in @proxy_options when run twice' do
         expect(@command.run('--verbose')).to eql('test ')
-        expect(@command.proxy_options.empty?).to be true
+        expect(@command.proxy_options).to eq([[:verbose, true]])
+        expect(@command.run('foo')).to eql('test foo')
+        expect(@command.proxy_options).to eq([])
       end
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: commander
 version: !ruby/object:Gem::Version
-  version: 4.4.5
+  version: 4.4.6
 platform: ruby
 authors:
 - TJ Holowaychuk
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-22 00:00:00.000000000 Z
+date: 2018-08-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: highline
@@ -157,7 +157,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.7.4
 signing_key: 
 specification_version: 4
 summary: The complete solution for Ruby command-line executables