command_tower 0.14.0 → 0.15.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bce961e0a6770bd17a23396e3fdb5066655dbe937f91c85b00c4605802c48f7d
-  data.tar.gz: e5247dda098ad94825317ec31cfff34c1fa060aac6fcf432ca5a082f93c83e02
+  metadata.gz: 408a811a73f66bbaa2785653542b4b94e1824381f325f5f60a1cfc06e97a913a
+  data.tar.gz: 84a05525bd6cba9201672711ffee110ad20e856d3a0d278f23994610e57d389e
 SHA512:
-  metadata.gz: dd5117447c0bf551b4b55e3a402fbda78a915c8bd0e31a2fbc10a785ef747cc9c6b7c5c8e3aa5306978872fd89910233fb67a69563a3dc1c5105fe06ce67834b
-  data.tar.gz: bb8d35c52ca0e32b44134015a81462350357fa5e678e3e3bce0daa11a3f76c2e14ff7d2e0731f8ddea812185f579df464886e01464670e68a375490d21528b03
+  metadata.gz: 1fe68a093c4add78fb8143068ba91c2aad354219aa33ed8f7b80b3c205e0d72025888842364c26034ed1856b7899c2ce05f4d52ee8a4a94c4a7d53d989c04eb5
+  data.tar.gz: f538a68acaffbe712d185ab5fc843b171c2c07d95837e6d81fc3f334b70f6fb6b2d71b4ffeb61805c2c72ada4828dbe68f165fe304bf84ae28c8274b38eb4740

data/app/controllers/command_tower/me/push_controller.rb

@@ -51,6 +51,14 @@ module CommandTower
         render_application_result(result)
       end
 
+      def test
+        result = CommandTower::Workflows::Me::Push::TestWorkflow.call(
+          current_user: current_user,
+          auth_context: current_auth_context,
+        )
+        render_application_result(result)
+      end
+
       private
 
       def render_deserializer_errors

data/app/errors/command_tower/errors/account/push_test_no_endpoint_error.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+module CommandTower
+  module Errors
+    module Account
+      class PushTestNoEndpointError < CommandTower::Errors::ApplicationError
+        def code
+          "push_test_no_endpoint"
+        end
+
+        def message
+          "No active push endpoint is registered for this account"
+        end
+
+        def log_level
+          :warn
+        end
+      end
+    end
+  end
+end

data/app/errors/command_tower/errors/account/push_test_rate_limit_error.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+module CommandTower
+  module Errors
+    module Account
+      class PushTestRateLimitError < CommandTower::Errors::ApplicationError
+        def initialize(retry_after_seconds: nil)
+          super(details: retry_after_seconds ? { retry_after_seconds: retry_after_seconds } : nil)
+        end
+
+        def code
+          "push_test_rate_limited"
+        end
+
+        def message
+          "Too many push test notifications. Please try again later."
+        end
+
+        def log_level
+          :warn
+        end
+      end
+    end
+  end
+end

data/app/services/command_tower/services/account/push/check_self_test_rate_limit.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+module CommandTower
+  module Services
+    module Account
+      module Push
+        # Enforces Me push self-test rate limits via existing RateLimits::Check.
+        # Ceiling and window come from config.messaging.expo composers — not hardcoded here.
+        class CheckSelfTestRateLimit < CommandTower::Services::ApplicationService
+          validate :user, is_a: User, required: true
+
+          def call
+            expo = CommandTower.config.messaging.expo
+            limit = expo.self_test_per_user_hour
+            ttl_seconds = expo.self_test_window_seconds
+
+            result = CommandTower::Services::RateLimits::Check.call(
+              key: "me:push:self_test:user:#{user.id}",
+              ttl_seconds:,
+            )
+            if result.failure?
+              context.fail!(application_error: result.errors.first)
+              return
+            end
+
+            count = result.data[:count]
+            return if count <= limit
+
+            ttl = result.data[:ttl]
+            retry_after = ttl.positive? ? ttl : nil
+            context.fail!(
+              application_error: CommandTower::Errors::Account::PushTestRateLimitError.new(
+                retry_after_seconds: retry_after,
+              ),
+            )
+          end
+        end
+      end
+    end
+  end
+end

data/app/services/command_tower/services/account/push/send_self_test.rb

@@ -0,0 +1,57 @@
+# frozen_string_literal: true
+
+module CommandTower
+  module Services
+    module Account
+      module Push
+        # Me self-test: Produce a host-registered push_delivery_test communication.
+        # Does not bypass Messaging; does not talk to Expo directly.
+        class SendSelfTest < CommandTower::Services::ApplicationService
+          NOTIFICATION_TYPE_KEY = "push_delivery_test"
+          TITLE = "Push notifications"
+          BODY = "This is a test notification from your account."
+
+          validate :user, is_a: User, required: true
+
+          def call
+            list_result = CommandTower::Services::Account::Push::List.call(user:)
+            unless list_result.success?
+              context.fail!(application_error: list_result.errors.first)
+              return
+            end
+
+            if Array(list_result.data[:safe_views]).empty?
+              context.fail!(application_error: CommandTower::Errors::Account::PushTestNoEndpointError.new)
+              return
+            end
+
+            rate_result = CommandTower::Services::Account::Push::CheckSelfTestRateLimit.call(user:)
+            unless rate_result.success?
+              context.fail!(application_error: rate_result.errors.first)
+              return
+            end
+
+            produce_result = CommandTower::Services::Messaging::Communications::Produce.call(
+              user:,
+              notification_type_key: NOTIFICATION_TYPE_KEY,
+              host_event_identity: "push_delivery_test/#{user.id}/#{SecureRandom.uuid}",
+              title: TITLE,
+              body: BODY,
+              metadata: {},
+              platform_enabled_channels: CommandTower::Services::Messaging::Preferences::PlatformEnabledChannels.call,
+            )
+            unless produce_result.success?
+              context.fail!(application_error: produce_result.errors.first)
+              return
+            end
+
+            context.communication_id = produce_result.data[:communication_id]
+            context.destination_plan_id = produce_result.data[:destination_plan_id]
+            context.selected_channels = produce_result.data[:selected_channels]
+            context.communication_status = produce_result.data[:communication_status]
+          end
+        end
+      end
+    end
+  end
+end

data/app/workflows/command_tower/workflows/me/error_mapping.rb

@@ -25,9 +25,11 @@ module CommandTower
                CommandTower::Errors::Account::PushoverAlreadyConfiguredError,
                CommandTower::Errors::Account::PushoverVerificationFailedError,
                CommandTower::Errors::Account::PushEndpointNotFoundError,
+               CommandTower::Errors::Account::PushTestNoEndpointError,
                CommandTower::Errors::ValidationError
             :unprocessable_entity
-          when CommandTower::Errors::Account::PhoneVerificationThrottledError
+          when CommandTower::Errors::Account::PhoneVerificationThrottledError,
+               CommandTower::Errors::Account::PushTestRateLimitError
             :too_many_requests
           when CommandTower::Errors::Account::SmsCapabilityUnavailableError,
                CommandTower::Errors::Account::PushoverCapabilityUnavailableError,

data/app/workflows/command_tower/workflows/me/push/test_workflow.rb

@@ -0,0 +1,54 @@
+# frozen_string_literal: true
+
+module CommandTower
+  module Workflows
+    module Me
+      module Push
+        class TestWorkflow < CommandTower::Workflows::ApplicationWorkflow
+          retry_strategy :none
+
+          def call(current_user:, auth_context: nil)
+            unless CommandTower::Services::Me::PushProductGate.enabled?
+              return failure(**WorkflowSupport.capability_failure)
+            end
+
+            result = CommandTower::Services::Account::Push::SendSelfTest.call(user: current_user)
+            unless result.success?
+              error = result.errors.first
+              return failure(
+                errors: result.errors,
+                http_status: http_status_for(error),
+              )
+            end
+
+            success(
+              payload: {
+                communicationId: result.data[:communication_id],
+                destinationPlanId: result.data[:destination_plan_id],
+                selectedChannels: result.data[:selected_channels],
+                status: result.data[:communication_status],
+              },
+              http_status: :ok,
+              response_effects: WorkflowSupport.expire_header_effects(auth_context),
+            )
+          end
+
+          private
+
+          def http_status_for(error)
+            case error
+            when CommandTower::Errors::ValidationError,
+                 CommandTower::Errors::Messaging::RecipientUnresolvedError,
+                 CommandTower::Errors::Messaging::AcceptRejectedError
+              :unprocessable_entity
+            when CommandTower::Errors::Messaging::IdempotencyConflictError
+              :conflict
+            else
+              CommandTower::Workflows::Me::ErrorMapping.http_status_for(error)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/config/routes.rb

@@ -104,8 +104,10 @@ CommandTower::Engine.routes.draw do
     # Expo push lifecycle always drawn (no route constraints).
     # Product readiness is workflow-gated as 503 push_capability_unavailable.
     # Collection JSON (multi-active). No verification POST — create/replace mark_verified.
+    # Self-test must be declared before :id routes so "test" is not captured as an id.
     get "push", to: "push#index"
     post "push", to: "push#create"
+    post "push/test", to: "push#test"
     patch "push/:id", to: "push#update"
     put "push/:id", to: "push#update"
     delete "push/:id", to: "push#destroy"

data/docs/upgrades/0.15.0.md

@@ -0,0 +1,32 @@
+# Upgrade: CommandTower 0.15.0
+
+**From:** `0.14.0`  
+**To:** `0.15.0`
+
+Minor release: Me push self-test (`POST /me/push/test`) through Messaging Produce, with configurable rate limits. No schema migration.
+
+## Host-visible changes
+
+| Change | Host impact |
+|--------|-------------|
+| `POST /api/me/push/test` | Authenticated self-test. Produces `push_delivery_test` via Communications::Produce (Expo path). Requires at least one active push endpoint. Returns Produce identifiers only (no Expo tokens). |
+| RBAC `me_push` | Adds action `test` (same entity). Hosts that already grant `me_push` get the new action. |
+| `config.messaging.expo.self_test_per_user_hour` | Max self-test sends per user per rolling window (default **10**). |
+| `config.messaging.expo.self_test_window_seconds` | Rolling window length (default **3600**). |
+| Rate limit HTTP | Exceeded limit → **429** `push_test_rate_limited` with `retry_after_seconds` details (existing CT envelope). |
+| No endpoint | **422** `push_test_no_endpoint`. |
+| Gate off | **503** `push_capability_unavailable` (same as other `/me/push*` when Expo adapter disabled). |
+
+## Host actions
+
+1. Bump gem to `0.15.0` (or `>= 0.15.0`).
+2. **No new migration.**
+3. **Required before enabling Account Push notifications settings:** register notification type `push_delivery_test` with push-only plan (e.g. `allowed/default %w[push]`, `inbox_available: false`, `user_configurable: false`, not preference-visible). CT hardcodes this type key for Me self-test.
+4. Set `config.messaging.expo.self_test_per_user_hour` explicitly when product policy differs from the default (Pick’em: **10**).
+5. Keep Expo adapter enabled (`http` / `fake`) and `me_push` granted for roles that use push.
+
+## Not in this release
+
+- CT FE Account Push notifications settings / device lifecycle migration
+- Host Pick’em enablement / type registration / IPA
+- Physical TestFlight proof

data/docs/upgrades/README.md

@@ -4,6 +4,7 @@ Host-facing upgrade / change summaries for CommandTower releases.
 
 | Version | Summary |
 |---------|---------|
+| [0.15.0](0.15.0.md) | Me `POST /me/push/test` → Produce (`push_delivery_test`); configurable Expo self-test rate limit composers; `me_push#test` |
 | [0.14.0](0.14.0.md) | Expo push Messaging channel (`config.messaging.expo`) + `/api/me/push*` registration HTTP; `me_push` RBAC |
 | [0.13.1](0.13.1.md) | Canonical `Intervention::Severity` constants (`blocking`, `warning`, `informational`) |
 | [0.13.0](0.13.0.md) | Account self-service deletion (`DELETE /api/me/account`); tombstone + PII scrub; `me_account` RBAC; `users.deleted_at` migration |

data/lib/command_tower/authorization/default.yml

@@ -75,6 +75,7 @@ entities:
       - create
       - update
       - destroy
+      - test
   - name: me_audit_events
     controller: CommandTower::Me::AuditEventsController
     only:

data/lib/command_tower/configuration/messaging/expo.rb

@@ -32,6 +32,19 @@ module CommandTower
                 "Required only if the Expo project enables enhanced push security. Never log.",
           allowed: String,
           default: ""
+
+        add_composer :self_test_per_user_hour,
+          desc: "Max Me push self-test (POST /me/push/test) sends allowed per user per rolling window. " \
+                "Hosts enabling Account Push notifications settings should set this explicitly " \
+                "(Pick'em: 10).",
+          allowed: Integer,
+          default: 10
+
+        add_composer :self_test_window_seconds,
+          desc: "Rolling window length in seconds for Me push self-test rate limiting " \
+                "(default 3600 = one hour).",
+          allowed: Integer,
+          default: 3600
       end
     end
   end

data/lib/command_tower/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module CommandTower
-  VERSION = "0.14.0"
+  VERSION = "0.15.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: command_tower
 version: !ruby/object:Gem::Version
-  version: 0.14.0
+  version: 0.15.0
 platform: ruby
 authors:
 - matt-taylor
@@ -271,6 +271,8 @@ files:
 - app/errors/command_tower/errors/account/phone_verification_throttled_error.rb
 - app/errors/command_tower/errors/account/push_capability_unavailable_error.rb
 - app/errors/command_tower/errors/account/push_endpoint_not_found_error.rb
+- app/errors/command_tower/errors/account/push_test_no_endpoint_error.rb
+- app/errors/command_tower/errors/account/push_test_rate_limit_error.rb
 - app/errors/command_tower/errors/account/pushover_already_configured_error.rb
 - app/errors/command_tower/errors/account/pushover_capability_unavailable_error.rb
 - app/errors/command_tower/errors/account/pushover_not_configured_error.rb
@@ -599,11 +601,13 @@ files:
 - app/services/command_tower/services/account/clear_phone.rb
 - app/services/command_tower/services/account/phone_verification/send.rb
 - app/services/command_tower/services/account/phone_verification/verify.rb
+- app/services/command_tower/services/account/push/check_self_test_rate_limit.rb
 - app/services/command_tower/services/account/push/create.rb
 - app/services/command_tower/services/account/push/ct_support.rb
 - app/services/command_tower/services/account/push/destroy.rb
 - app/services/command_tower/services/account/push/list.rb
 - app/services/command_tower/services/account/push/replace.rb
+- app/services/command_tower/services/account/push/send_self_test.rb
 - app/services/command_tower/services/account/pushover/create.rb
 - app/services/command_tower/services/account/pushover/ct_support.rb
 - app/services/command_tower/services/account/pushover/destroy.rb
@@ -740,6 +744,7 @@ files:
 - app/workflows/command_tower/workflows/me/push/destroy_workflow.rb
 - app/workflows/command_tower/workflows/me/push/index_workflow.rb
 - app/workflows/command_tower/workflows/me/push/replace_workflow.rb
+- app/workflows/command_tower/workflows/me/push/test_workflow.rb
 - app/workflows/command_tower/workflows/me/push/workflow_support.rb
 - app/workflows/command_tower/workflows/me/pushover/create_workflow.rb
 - app/workflows/command_tower/workflows/me/pushover/destroy_workflow.rb
@@ -798,6 +803,7 @@ files:
 - docs/upgrades/0.13.0.md
 - docs/upgrades/0.13.1.md
 - docs/upgrades/0.14.0.md
+- docs/upgrades/0.15.0.md
 - docs/upgrades/README.md
 - lib/command_tower.rb
 - lib/command_tower/admin_scope.rb