comma_splice 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bd44bca5b615b5f267ae81b16aaa6b379b53963e637af1cc000d6229996963d4
-  data.tar.gz: bd70a25937f8baf3cec97eeb5276ce050f3898a76f5be9cf8e0c8e726bc5a8fa
+  metadata.gz: dd12b113b4440991523636f0cb9e7cf193394704cf12234f640632001bee96fa
+  data.tar.gz: 9ad043ca537cef2ab6e3ada54e56e07c04e762c58d3ecca314b894222e86ca42
 SHA512:
-  metadata.gz: 991f2138d4d08941b1a83d231338a5197bce6bcea0e136c3cbb67ca67cf04b31ad425ce148d48f2bf5ca8280bfee2b736d7ace002cd043dac071bdee8ca2ad2f
-  data.tar.gz: 4d9e601ab359fe6511d9c54b3469104e64f057953924a7867c6b7e58df224c9b5d9b279060ff7e67e3d965da7460334ed23f97c1fd2792c32441e2cc9f8161da
+  metadata.gz: d1efb0c81ae6927969ac5e142d94553f845a454620774c333b23a97d4afffca93a8929156f8b2216d2360446fcf97f986d09ba4e1a4983b25f59822f07cef406
+  data.tar.gz: 5cabfeb12c2329e1d8ed3be5c0518435863a0d63dd7c226c11dd3339cca1c38990b0527b20ceb000e1c3ad4cdaed53235041d5741a63ccae56eb393909e5e2ba

data/.gitignore

@@ -8,3 +8,4 @@
 /tmp/
 .DS_Store
 .byebug_history
+test-file.txt

data/CHANGELOG.md

@@ -1,6 +1,11 @@
 # Changelog
 
-### 0.2 (January 27, 2020)
+### 0.2.1 (January 26, 2020)
+- [BUGFIX] Remove debug information from option output
+- [IMPROVEMENT] Add debug option to display scoring info
+- [BUGFIX] Fixed scoring for comma separated numbers
+
+### 0.2 (January 26, 2020)
 - [IMPROVEMENT] Add scoring model to better handle cases that needed prompting before, like comma-separated numbers
 - [IMPROVEMENT] Correct line escaping even on lines that don't have incorrect commas to ensure correct parsing of generated CSV down the line
 - [IMPROVEMENT] Use ruby csv library to generate lines instead of handling escaping cases manually

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    comma_splice (0.2.0)
+    comma_splice (0.2.1)
 
 GEM
   remote: https://rubygems.org/

data/bin/comma_splice

@@ -7,6 +7,7 @@ require 'thor'
 class CommaSpliceCLI < Thor
   class_option :start_line, type: :numeric, default: nil
   class_option :end_line, type: :numeric, default: nil
+  class_option :debug, type: :boolean, default: false
 
   desc 'version', 'print the current comma_splice version'
   def version
@@ -15,6 +16,8 @@ class CommaSpliceCLI < Thor
 
   desc 'correct FILE_PATH', 'return corrected file contents'
   def correct(file_path)
+    setup
+
     file_corrector = CommaSplice::FileCorrector.new(
       file_path,
       start_line: options[:start_line],
@@ -26,6 +29,8 @@ class CommaSpliceCLI < Thor
 
   desc 'fix FILE_PATH [SAVE_PATH]', 'return corrected file contents'
   def fix(file_path, fix_path)
+    setup
+
     file_corrector = CommaSplice::FileCorrector.new(
       file_path,
       start_line: options[:start_line],
@@ -37,6 +42,8 @@ class CommaSpliceCLI < Thor
 
   desc 'bad_lines FILE_PATH', 'show bad lines'
   def bad_lines(file_path)
+    setup
+
     file_corrector = CommaSplice::FileCorrector.new(
       file_path,
       start_line: options[:start_line],
@@ -48,6 +55,8 @@ class CommaSpliceCLI < Thor
 
   desc 'bad_line_count FILE_PATH', 'check file contents for needed corrections'
   def bad_line_count(file_path)
+    setup
+
     file_corrector = CommaSplice::FileCorrector.new(
       file_path,
       start_line: options[:start_line],
@@ -56,6 +65,10 @@ class CommaSpliceCLI < Thor
 
     puts file_corrector.bad_lines.size
   end
+
+  def setup
+    CommaSplice.debug = options[:debug]
+  end
 end
 
 CommaSpliceCLI.start(ARGV)

data/lib/comma_splice/helpers/comma_calculator.rb

@@ -73,6 +73,8 @@ module CommaSplice
       longest_header = @headers.max_by(&:length)
 
       options.each_with_index do |option, index|
+        score_breakdown = option.breakdown
+
         @headers.each_with_index do |header, i|
           marker = if i.zero?
                      "(#{index + 1})"
@@ -80,12 +82,16 @@ module CommaSplice
                      ''
                    end
 
-          puts marker.ljust(7) +
-               header.ljust(longest_header.size) + ': ' +
-               option.option[i].to_s
+          line = marker.ljust(7) +
+                 header.ljust(longest_header.size) + ': ' +
+                 option.option[i].to_s.ljust(75)
+
+          if CommaSplice.debug
+            line = line + "| " + (score_breakdown.shift || "")
+          end
+          puts line
         end
-        puts ''.ljust(7) + "(score = #{option.score})"
-        puts ''.ljust(7) + option.breakdown
+
         puts "\n"
       end
 

data/lib/comma_splice/helpers/option_scorer.rb

@@ -21,7 +21,7 @@ module CommaSplice
         end
       end
 
-      breakdown.join("\n")
+      breakdown.unshift("score: #{score}")
     end
 
     def score
@@ -96,8 +96,8 @@ module CommaSplice
 
       option.collect do |o|
         result = o.to_s.scan(/\d{1,3}(?:,\d{1,3})*(?:\.\d+)?/)
-        if result.first && result.first.index(',')
-          result.first.size
+        if result.size.positive? && result.first.index(',')
+          result.join(',').size
         else
           0
         end

data/lib/comma_splice/version.rb

@@ -1,3 +1,3 @@
 module CommaSplice
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

data/lib/comma_splice.rb

@@ -16,4 +16,5 @@ require 'byebug'
 
 module CommaSplice
   class Error < StandardError; end
+  mattr_accessor :debug
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: comma_splice
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Jeff Keen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-26 00:00:00.000000000 Z
+date: 2020-01-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler