comma_splice 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e0a958c45c6fe94fbc6a4af1cb5fc2a0c20cf7a68728520d227b62a79e2078a5
-  data.tar.gz: 7e4e09b4a3308a2ccb2c5a58d1b56ced9f6f5927bf41d89680c4401b5aad2b5d
+  metadata.gz: 74958cacc824b9e475df20acee4cc75ac354738ab4ed475a7ddc5f3ce5c7c553
+  data.tar.gz: 3b7129b58e24be7e9549e2971b994fd159e0d21675118e3c413a38dc1823db9c
 SHA512:
-  metadata.gz: 1daff9cfdd5f54c37bd47edc83b02308a0f3fe7b0d8af86dd0a910e264929a5b5b1191386b3b06df42f157770c4bc733c656e3beb4d9bafe10d7bc65a5483185
-  data.tar.gz: f6e4c32e2e03d3bf915a9b8360146eaa34ed9b34a954cb4b9a74b08c68ef4f8ae15cba83c854f96b88b098b791f802200992e46194a373e27cdd388c40311136
+  metadata.gz: 112fea4670275a7222bbf60d13c8f61cea9386a60eaaf2cf16fd514f5c0ffd69a4e2e0453658408977607608340ca1e94e7f53581565d10014501c18d61a6570
+  data.tar.gz: b62a9835b22555efd4aad03c467c1d24f298d50c34b399171f8fc5bcb0d8c1ddfff1be14268599fe5ce67b88c6b9201c6c3e250e72de34361ba252594a6146e1

data/CHANGELOG.md

@@ -0,0 +1,9 @@
+# Changelog
+
+### 0.1.1 (January 24, 2020)
+- [BUGFIX] handle case where all columns are equal widths
+- [BUGFIX] Improve error message
+- [IMPROVEMENT] simplify slicing [\#1](https://github.com/jkeen/comma_splice/pull/1) ([AlexMooney](https://github.com/AlexMooney))
+
+### 0.1.0 (August 5th, 2019)
+- Initial Release

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    comma_splice (0.1.0)
+    comma_splice (0.1.1)
 
 GEM
   remote: https://rubygems.org/
@@ -49,4 +49,4 @@ DEPENDENCIES
   thor
 
 BUNDLED WITH
-   2.0.1
+   2.1.4

data/README.md

@@ -1,6 +1,6 @@
 # Comma Splice
 
-This gem tackles one very specific problem: when CSVs have commas in the values and the values haven't been quoted. This determines which commas separate fields and which commas are part of a value, and corrects the file.
+This gem tackles [one very specific problem](https://medium.com/@jeffkeen/how-to-correct-32-000-incorrect-csv-files-in-fewer-than-32-000-steps-a5f1ba25d951): when CSVs have commas in the values and the values haven't been quoted. This determines which commas separate fields and which commas are part of a value, and corrects the file.
 
 For example, given the following CSV
 
@@ -19,7 +19,7 @@ which parses incorrectly as:
 | 01-27-2019 @ 12:31:00 | Lester Sterling | Lester Sterling Special | Merritone Rock Steady 2: This Music Got Soul 1966-1967 | Dub Store   |
 
 
-Running this through `comma_splice fix /path/to/file` will return this corrected content:
+Running this through `comma_splice correct /path/to/file` will return this corrected content:
 
 ```
 timestamp,artist,title,albumtitle,label

data/lib/comma_splice/helpers/variable_column_finder.rb

@@ -34,10 +34,10 @@ module CommaSplice
       end
 
       start_column = variables.find_index(true)
-      end_column = variables.reverse.find_index(true) * -1
+      end_column = variables.reverse.find_index(true)
 
-      @start_column = start_column
-      @end_column = end_column
+      @start_column = start_column || 0
+      @end_column = (end_column || 1) * -1
     end
 
     private

data/lib/comma_splice/line_corrector.rb

@@ -13,8 +13,8 @@ module CommaSplice
       @left_bounds = left_bounds
       @right_bounds = right_bounds
 
-      raise 'right bounds must be less than -1' unless right_bounds < 0
-      raise 'left bounds must be greater than zero' unless left_bounds >= 0
+      raise 'right bounds must be negative' unless right_bounds.negative?
+      raise 'left bounds must be not be negative' if left_bounds.negative?
     end
 
     def needs_correcting?
@@ -35,17 +35,8 @@ module CommaSplice
       # the only values that could contain an extra comma are "artist,title,albumtitle,label"
       # therefore our left_bounds = 4, right_bounds = -5
 
-      values_before = if left_bounds > 0
-                        values[0..(left_bounds - 1)]
-                      else
-                        []
-                      end
-
-      values_after =  if right_bounds < -1
-                        values[(right_bounds + 1)..-1]
-                      else
-                        []
-                      end
+      values_before = values[0...left_bounds]
+      values_after = values.slice(right_bounds + 1, -(right_bounds + 1))
       [values_before, corrector.correction, values_after].flatten.join(',')
     end
 

data/lib/comma_splice/version.rb

@@ -1,3 +1,3 @@
 module CommaSplice
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: comma_splice
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Jeff Keen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-07 00:00:00.000000000 Z
+date: 2020-01-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -104,6 +104,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- CHANGELOG.md
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt
@@ -142,8 +143,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.8
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: Fixes CSVs with unescaped commas