comma 4.2.0 → 4.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b02d517f98eed136e0730795406aa4aef0a746ab7bcf17a85079615db2a61750
-  data.tar.gz: 87a0807f59d155d6728772b5998c20383f40dd8ebeda81b31600529c002d91f4
+  metadata.gz: 6cf7285c1a29ce4bdcded81d2b665722fd3ccec1ac004b5e9876d2e2b3850c5d
+  data.tar.gz: df207352976ad2a0dadd2c6dc8f863089eeb285701261dd4e636818fd904a0ad
 SHA512:
-  metadata.gz: 997614df5dd1f0d6c1b19507d7ad0ead2ee2132cd138389e75ce573ac0b89073d08101552e1e85fc71904ff965a22492da39de72cb6e82bc3c85ecbf02f0e5a3
-  data.tar.gz: c97395442a447a96cb5943b6b814b7927c182d4e1a42c0b69d2fbd4ceec7833ad1160dbda4f85c7aee528fec126ee0d476dd9203776723e9e51d58b66a4b186f
+  metadata.gz: 71ca924db46f66ac2f79ba17c21045369845668c3b804ea0e7c2c04d3f803b921727d70c52c60c6896398574be6a726cacf57a1be3e7905dc556899b57bda825
+  data.tar.gz: f8d5063d39e18e8c6231654a6b3215b1d19dabbb75bd3d924f7c9e7dfb59dd91149b2b076e91acee39756b92367053324cdd4907f3d5818ee55f99984ecb0233

data/.rubocop.yml

@@ -2,9 +2,18 @@ inherit_from: .rubocop_todo.yml
 
 AllCops:
   DisplayCopNames: true
+  TargetRubyVersion: 2.3
   Exclude:
     - 'gemfiles/**/*'
 
-Style/FileName:
+Metrics/LineLength:
+  IgnoreCopDirectives: true
+  Max: 120
+
+Naming/FileName:
   Exclude:
     - 'Appraisals'
+
+Naming/VariableNumber:
+  EnforcedStyle: snake_case
+

data/.rubocop_todo.yml

@@ -6,83 +6,15 @@
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 1
-Lint/AmbiguousOperator:
-  Exclude:
-    - 'lib/comma/extractor.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: AlignWith, SupportedStyles, AutoCorrect.
-# SupportedStyles: keyword, variable, start_of_line
-Lint/EndAlignment:
-  Exclude:
-    - 'lib/comma.rb'
-
-# Offense count: 3
-Lint/HandleExceptions:
-  Exclude:
-    - 'lib/comma/mongoid.rb'
-    - 'spec/spec_helper.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Lint/UnneededSplatExpansion:
-  Exclude:
-    - 'spec/spec_helper.rb'
-
-# Offense count: 5
-# Cop supports --auto-correct.
-# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
-Lint/UnusedBlockArgument:
-  Exclude:
-    - 'lib/comma/data_extractor.rb'
-    - 'lib/comma/header_extractor.rb'
-    - 'spec/comma/data_extractor_spec.rb'
-
-# Offense count: 6
-# Cop supports --auto-correct.
-# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
-Lint/UnusedMethodArgument:
-  Exclude:
-    - 'lib/comma/data_extractor.rb'
-    - 'lib/comma/header_extractor.rb'
-
-# Offense count: 5
-Lint/UselessAssignment:
-  Exclude:
-    - 'lib/comma.rb'
-    - 'spec/comma/comma_spec.rb'
-
-# Offense count: 19
-Lint/Void:
-  Exclude:
-    - 'spec/controllers/users_controller_spec.rb'
-
 # Offense count: 2
 Metrics/AbcSize:
   Max: 21
 
-# Offense count: 80
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes.
-# URISchemes: http, https
-Metrics/LineLength:
-  Max: 223
-
 # Offense count: 3
 # Configuration parameters: CountComments.
 Metrics/MethodLength:
   Max: 17
 
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: always, conditionals
-Style/AndOr:
-  Exclude:
-    - 'lib/comma.rb'
-    - 'lib/comma/generator.rb'
-
 # Offense count: 15
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles, ProceduralMethods, FunctionalMethods, IgnoredMethods.
@@ -96,39 +28,6 @@ Style/BlockDelimiters:
     - 'spec/comma/data_extractor_spec.rb'
     - 'spec/comma/header_extractor_spec.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: braces, no_braces, context_dependent
-Style/BracesAroundHashParameters:
-  Exclude:
-    - 'spec/comma/rails/active_record_spec.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: IndentWhenRelativeTo, SupportedStyles, IndentOneStep, IndentationWidth.
-# SupportedStyles: case, end
-Style/CaseIndentation:
-  Exclude:
-    - 'lib/comma.rb'
-
-# Offense count: 3
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: nested, compact
-Style/ClassAndModuleChildren:
-  Exclude:
-    - 'lib/comma/data_mapper_collection.rb'
-    - 'lib/comma/mongoid.rb'
-    - 'lib/comma/relation.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, SingleLineConditionsOnly.
-# SupportedStyles: assign_to_condition, assign_inside_condition
-Style/ConditionalAssignment:
-  Exclude:
-    - 'lib/comma.rb'
-
 # Offense count: 11
 Style/Documentation:
   Exclude:
@@ -144,279 +43,19 @@ Style/Documentation:
     - 'lib/comma/object.rb'
     - 'lib/comma/relation.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/EmptyLines:
-  Exclude:
-    - 'spec/comma/comma_spec.rb'
-
-# Offense count: 45
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: empty_lines, no_empty_lines
-Style/EmptyLinesAroundBlockBody:
-  Exclude:
-    - 'spec/comma/comma_spec.rb'
-    - 'spec/comma/data_extractor_spec.rb'
-    - 'spec/comma/header_extractor_spec.rb'
-    - 'spec/comma/rails/active_record_spec.rb'
-    - 'spec/comma/rails/data_mapper_collection_spec.rb'
-    - 'spec/comma/rails/mongoid_spec.rb'
-    - 'spec/controllers/users_controller_spec.rb'
-
-# Offense count: 7
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: empty_lines, no_empty_lines
-Style/EmptyLinesAroundClassBody:
+Style/MethodMissingSuper:
   Exclude:
     - 'lib/comma/data_extractor.rb'
-    - 'lib/comma/extractor.rb'
-    - 'lib/comma/generator.rb'
     - 'lib/comma/header_extractor.rb'
-    - 'spec/rails_app/rails_app.rb'
 
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: empty_lines, no_empty_lines
-Style/EmptyLinesAroundModuleBody:
+Style/MissingRespondToMissing:
   Exclude:
     - 'lib/comma/data_extractor.rb'
-    - 'lib/comma/extractor.rb'
-    - 'lib/comma/generator.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/EmptyLiteral:
-  Exclude:
-    - 'spec/comma/comma_spec.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
-Style/ExtraSpacing:
-  Exclude:
-    - 'spec/controllers/users_controller_spec.rb'
-
-# Offense count: 29
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: when_needed, always
-Style/FrozenStringLiteralComment:
-  Enabled: false
-
-# Offense count: 2
-# Configuration parameters: MinBodyLength.
-Style/GuardClause:
-  Exclude:
-    - 'lib/comma/generator.rb'
     - 'lib/comma/header_extractor.rb'
 
-# Offense count: 94
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
-# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
-Style/HashSyntax:
-  Exclude:
-    - 'lib/comma.rb'
-    - 'spec/comma/comma_spec.rb'
-    - 'spec/comma/rails/active_record_spec.rb'
-    - 'spec/comma/rails/data_mapper_collection_spec.rb'
-    - 'spec/comma/rails/mongoid_spec.rb'
-    - 'spec/controllers/users_controller_spec.rb'
-    - 'spec/non_rails_app/ruby_classes.rb'
-    - 'spec/rails_app/mongoid/config.rb'
-    - 'spec/rails_app/rails_app.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
-# SupportedStyles: special_inside_parentheses, consistent, align_braces
-Style/IndentHash:
-  Exclude:
-    - 'lib/comma.rb'
-
-# Offense count: 10
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: line_count_dependent, lambda, literal
-Style/Lambda:
-  Exclude:
-    - 'spec/comma/comma_spec.rb'
-    - 'spec/comma/data_extractor_spec.rb'
-    - 'spec/comma/rails/active_record_spec.rb'
-
-# Offense count: 7
-# Cop supports --auto-correct.
-Style/LeadingCommentSpace:
-  Exclude:
-    - 'lib/comma.rb'
-    - 'lib/comma/mongoid.rb'
-    - 'spec/comma/rails/active_record_spec.rb'
-    - 'spec/controllers/users_controller_spec.rb'
-
-# Offense count: 3
-Style/MethodMissing:
-  Exclude:
-    - 'lib/comma/data_extractor.rb'
-    - 'lib/comma/header_extractor.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/MutableConstant:
-  Exclude:
-    - 'lib/comma.rb'
-    - 'lib/comma/version.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/ParallelAssignment:
-  Exclude:
-    - 'spec/non_rails_app/ruby_classes.rb'
-
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: PreferredDelimiters.
-Style/PercentLiteralDelimiters:
-  Exclude:
-    - 'comma.gemspec'
-    - 'spec/spec_helper.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/PreferredHashMethods:
-  Exclude:
-    - 'lib/comma/generator.rb'
-
-# Offense count: 5
-# Cop supports --auto-correct.
-Style/RedundantSelf:
-  Exclude:
-    - 'lib/comma/header_extractor.rb'
-    - 'spec/comma/rails/active_record_spec.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/RescueModifier:
-  Exclude:
-    - 'lib/comma/header_extractor.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: AllowIfMethodIsEmpty.
-Style/SingleLineMethods:
-  Exclude:
-    - 'spec/non_rails_app/ruby_classes.rb'
-
-# Offense count: 6
-# Cop supports --auto-correct.
-Style/SpaceAfterComma:
-  Exclude:
-    - 'spec/controllers/users_controller_spec.rb'
-
-# Offense count: 12
-# Cop supports --auto-correct.
-# Configuration parameters: AllowForAlignment.
-Style/SpaceAroundOperators:
-  Exclude:
-    - 'spec/controllers/users_controller_spec.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: space, no_space
-Style/SpaceBeforeBlockBraces:
-  Exclude:
-    - 'lib/comma/generator.rb'
-    - 'spec/comma/comma_spec.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/SpaceBeforeComma:
-  Exclude:
-    - 'spec/spec_helper.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
-# SupportedStyles: space, no_space
-Style/SpaceInsideBlockBraces:
-  Exclude:
-    - 'spec/comma/comma_spec.rb'
-
-# Offense count: 16
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SupportedStyles.
-# SupportedStyles: space, no_space, compact
-Style/SpaceInsideHashLiteralBraces:
-  Exclude:
-    - 'spec/comma/rails/active_record_spec.rb'
-    - 'spec/controllers/users_controller_spec.rb'
-    - 'spec/rails_app/active_record/config.rb'
-    - 'spec/rails_app/rails_app.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: use_perl_names, use_english_names
-Style/SpecialGlobalVars:
-  Exclude:
-    - 'comma.gemspec'
-
-# Offense count: 33
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline.
-# SupportedStyles: single_quotes, double_quotes
-Style/StringLiterals:
-  Exclude:
-    - 'comma.gemspec'
-    - 'lib/comma.rb'
-    - 'lib/comma/relation.rb'
-    - 'spec/comma/comma_spec.rb'
-    - 'spec/comma/rails/active_record_spec.rb'
-    - 'spec/comma/rails/data_mapper_collection_spec.rb'
-    - 'spec/comma/rails/mongoid_spec.rb'
-    - 'spec/controllers/users_controller_spec.rb'
-    - 'spec/rails_app/active_record/models.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: IgnoredMethods.
-# IgnoredMethods: respond_to, define_method
-Style/SymbolProc:
-  Exclude:
-    - 'spec/comma/data_extractor_spec.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: final_newline, final_blank_line
-Style/TrailingBlankLines:
-  Exclude:
-    - 'lib/comma/mongoid.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/TrailingWhitespace:
-  Exclude:
-    - 'lib/comma/header_extractor.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/UnneededPercentQ:
-  Exclude:
-    - 'comma.gemspec'
-
 # Offense count: 2
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: snake_case, camelCase
-Style/VariableName:
+Naming/VariableName:
   Exclude:
     - 'spec/comma/comma_spec.rb'
-
-# Offense count: 6
-# Configuration parameters: SupportedStyles.
-# SupportedStyles: snake_case, normalcase, non_integer
-Style/VariableNumber:
-  Enabled: false

data/.travis.yml

@@ -5,66 +5,47 @@ services: mongodb
 language: ruby
 cache: bundler
 rvm:
-  - 2.1.10
-  - 2.2.10
-  - 2.3.7
-  - 2.4.4
-  - 2.5.1
-  - rbx-2
-  - jruby
+  - 2.3.8
+  - 2.4.6
+  - 2.5.5
+  - 2.6.2
 gemfile:
-  - gemfiles/active4.1.16.gemfile
-  - gemfiles/active4.2.8.gemfile
-  - gemfiles/active5.0.1.gemfile
-  - gemfiles/active5.1.0.gemfile
-  - gemfiles/active5.2.0.gemfile
-  - gemfiles/rails4.1.16.gemfile
-  - gemfiles/rails4.2.8.gemfile
-  - gemfiles/rails5.0.1.gemfile
-  - gemfiles/rails5.1.0.gemfile
-  - gemfiles/rails5.2.0.gemfile
+  - gemfiles/active4.2.11.1.gemfile
+  - gemfiles/active5.0.7.2.gemfile
+  - gemfiles/active5.1.7.gemfile
+  - gemfiles/active5.2.3.gemfile
+  - gemfiles/active6.0.0.gemfile
+  - gemfiles/rails4.2.11.1.gemfile
+  - gemfiles/rails5.0.7.2.gemfile
+  - gemfiles/rails5.1.7.gemfile
+  - gemfiles/rails5.2.3.gemfile
+  - gemfiles/rails6.0.0.gemfile
 matrix:
   exclude:
-    - rvm: 2.1.10
-      gemfile: gemfiles/active5.0.1.gemfile
-    - rvm: 2.1.10
-      gemfile: gemfiles/active5.1.0.gemfile
-    - rvm: 2.1.10
-      gemfile: gemfiles/active5.2.0.gemfile
-    - rvm: 2.1.10
-      gemfile: gemfiles/rails5.0.1.gemfile
-    - rvm: 2.1.10
-      gemfile: gemfiles/rails5.1.0.gemfile
-    - rvm: 2.1.10
-      gemfile: gemfiles/rails5.2.0.gemfile
-    - rvm: 2.2.10
-      gemfile: gemfiles/active5.2.0.gemfile
-    - rvm: 2.2.10
-      gemfile: gemfiles/rails5.2.0.gemfile
-    - rvm: 2.4.4
-      gemfile: gemfiles/active4.1.16.gemfile
-    - rvm: 2.4.4
-      gemfile: gemfiles/active4.2.8.gemfile
-    - rvm: 2.4.4
-      gemfile: gemfiles/rails4.1.16.gemfile
-    - rvm: 2.4.4
-      gemfile: gemfiles/rails4.2.8.gemfile
-    - rvm: 2.5.1
-      gemfile: gemfiles/active4.1.16.gemfile
-    - rvm: 2.5.1
-      gemfile: gemfiles/active4.2.8.gemfile
-    - rvm: 2.5.1
-      gemfile: gemfiles/rails4.1.16.gemfile
-    - rvm: 2.5.1
-      gemfile: gemfiles/rails4.2.8.gemfile
-  allow_failures:
-    - rvm: rbx-2
-    - rvm: jruby
+    - rvm: 2.3.8
+      gemfile: gemfiles/active6.0.0.gemfile
+    - rvm: 2.3.8
+      gemfile: gemfiles/rails6.0.0.gemfile
+    - rvm: 2.4.6
+      gemfile: gemfiles/active4.2.11.1.gemfile
+    - rvm: 2.4.6
+      gemfile: gemfiles/active6.0.0.gemfile
+    - rvm: 2.4.6
+      gemfile: gemfiles/rails4.2.11.1.gemfile
+    - rvm: 2.4.6
+      gemfile: gemfiles/rails6.0.0.gemfile
+    - rvm: 2.5.5
+      gemfile: gemfiles/active4.2.11.1.gemfile
+    - rvm: 2.5.5
+      gemfile: gemfiles/rails4.2.11.1.gemfile
+    - rvm: 2.6.2
+      gemfile: gemfiles/active4.2.11.1.gemfile
+    - rvm: 2.6.2
+      gemfile: gemfiles/rails4.2.11.1.gemfile
   fast_finish: true
-bundler_args: ""
-# Need to update because there is a bug in bundler that Travis CI uses.
 before_install:
-  - gem update bundler
+  - gem uninstall -v '>= 2' -i $(rvm gemdir)@global -ax bundler || true
+  - gem install bundler -v '< 2'
 script:
   - bundle exec rake rubocop
   - bundle exec rake spec