comgate_ruby 0.8.2 → 0.8.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d020da6b1614a32495b473b497b9931406275e575a5be5012b70c46313a60041
-  data.tar.gz: ff070de8de6f549aaf6482c3a00f07cf7d496e683a6829cbdca7a40854ee8049
+  metadata.gz: 4a86d9ae209a84c1dd4d9942b70d6bc33724567029891397a1a2fe6aa685b540
+  data.tar.gz: b296ea50f4e2c1ebd450c02e38508b52c15d7e730aedfc2a9200a7ae3093a7a0
 SHA512:
-  metadata.gz: cde1b8d7a8b37148cfa1af8afd799ca9858b565f52a34d265651233ac49a5dd90879ebc2c602097ed654aa1c79ae4cc764b08af0bda7a2047f9a7e3943a6d16d
-  data.tar.gz: 56490bc816c7e2a5afa3b9ca30d36d4603ae388853d157d078b43ffe1e42376e627541e4b8e4b95eb9edccb0d00c96e2304486365f1d286dd7dbbbb01fbab973
+  metadata.gz: e88150f9ae6eb61eb202209794ff100df4cf74c7f0201000cce7562476462d6f33c7b077cb76ea01611e818de016db35238936b6481cd79ef9f5ae8420a37a81
+  data.tar.gz: 0a511d5d5b38e465cd48ce14dba204b23f2500e38222f7374ccc69d3bc342ecb5b91f5edba057be1d978aaa5ed2da54c1fee25549fc70d2f342a8eefadcfeef1

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## [0.8.3.1] - 2023-06-28
+- fixed internal passing errors
+
+## [0.8.3] - 2023-06-27
+- If response from Comgate API is error, but contain "transId", we do not raise exception but pass info up to stack
+
 ## [0.8.2] - 2023-06-20
 - If ENV["COMGATE_MIN_LOG_LEVEL"] is set, calls and responses to Comgate are logged at that level. Otherwise `:debug` is used.
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    comgate_ruby (0.8.1)
+    comgate_ruby (0.8.3.1)
 
 GEM
   remote: https://rubygems.org/

data/lib/comgate/api_caller.rb

@@ -37,8 +37,20 @@ module Comgate
 
     attr_accessor :response
 
+    HttpResponseStubStruct = Struct.new(:code, :body, :uri, :headers, keyword_init: true) do
+      def [](key)
+        headers[key]
+      end
+    end
+
     def call_api
       self.response = https_conn.request(request)
+      # body =""
+      # binding.pry
+      # self.response = HttpResponseStubStruct.new(code: "200",
+      #   body: body,
+      #   uri: URI.parse("example.com"),
+      #   headers: { "content-type" => "application/x-www-form-urlencoded; charset=UTF-8" })
     rescue *KNOWN_CONNECTION_ERRORS => e
       handle_connection_error(e)
     end
@@ -122,9 +134,12 @@ module Comgate
     def record_api_error
       return unless api_error?
 
-      errors[:api] = ["[Error ##{result[:response_body]["error"]}] #{result[:response_body]["message"]}"]
-      @result[:errors] = { api: { code: result[:response_body]["error"].to_i,
-                                  message: result[:response_body]["message"] } }
+      msg = [result[:response_body]["message"], result[:response_body]["extraMessage"]].compact.join(" ")
+      errors[:api] = ["[Error ##{result[:response_body]["error"]}] #{msg}"]
+      @result[:errors] = { api: [
+        { code: result[:response_body]["error"].to_i,
+          message: msg }
+      ] }
     end
 
     def api_error?

data/lib/comgate/gateway.rb

@@ -42,6 +42,7 @@ module Comgate
       transferId: %i[transfer_id],
       code: %i[code],
       message: %i[message],
+      extraMessage: %i[extra_message],
       payerId: %i[payer id],
       payerName: %i[payer account_name],
       payer_name: %i[payer account_name],
@@ -148,7 +149,7 @@ module Comgate
     def process_callback(comgate_params)
       Comgate::Response.new({ response_body: comgate_params }, DATA_CONVERSION_HASH)
     end
-    alias process_payment_callback process_callback  # backward compatibility
+    alias process_payment_callback process_callback # backward compatibility
 
     def allowed_payment_methods(payment_data)
       ph = gateway_params.merge(convert_data_to_comgate_params(%i[curr lang country], payment_data, required: false))
@@ -178,10 +179,11 @@ module Comgate
       raise "There are errors in pre-api-call phase: #{payload[:errors]}" unless payload[:errors].nil?
 
       srv = Comgate::ApiCaller.call(url: url, payload: payload, test_call: test_call, proxy_uri: proxy_uri)
+
       if srv.success?
         Comgate::Response.new(srv.result, conversion_hash)
       else
-        handle_failure_from(srv.errors)
+        handle_failure_from(srv, conversion_hash)
       end
     end
 
@@ -189,8 +191,11 @@ module Comgate
       test_from_data.nil? ? test_calls_used? : (test_from_data == true)
     end
 
-    def handle_failure_from(errors)
-      raise errors.to_s
+    def handle_failure_from(srv, conversion_hash)
+      raise srv.errors.to_s if srv.result.dig(:response_body, "transId").nil?
+
+      # pretends to be a successfull response, and keep payment check to decide what to do next
+      Comgate::Response.new(srv.result, conversion_hash)
     end
 
     def single_payment_payload(payment_data)

data/lib/comgate/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Comgate
-  VERSION = "0.8.2"
+  VERSION = "0.8.3.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: comgate_ruby
 version: !ruby/object:Gem::Version
-  version: 0.8.2
+  version: 0.8.3.1
 platform: ruby
 authors:
 - Petr Mlčoch
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-06-20 00:00:00.000000000 Z
+date: 2023-06-28 00:00:00.000000000 Z
 dependencies: []
 description: Write a longer description or delete this line.
 email: