comgate_ruby 0.8.1 → 0.8.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c7882560b8946462a01c78940b5c3f9c1e771418b90123e5de3b4f4e3c8dea2e
-  data.tar.gz: 47271d5e947abd8f189c42f79e248fd0992d56e3a92eb24b624e3f8559ec09fb
+  metadata.gz: f70dc5da596b91029a905c8cdb1987b96e805d9d222f54c3a8896947119ca0c8
+  data.tar.gz: 6ffc03ac6e2e119c35bce6aa561bab416c20f63dd8b8748c186969952e3f82ce
 SHA512:
-  metadata.gz: 72e412a79248be368f95a76c7a8e3214e7156edb8a2336af3150ac1b652e7d95c2e8614ad1c1e4d1f2a3b7d201a7aa915101a6f05fa6fb7f58497f32dd17fd36
-  data.tar.gz: 8ce0f483ea79eebd5c25cfac010cc0761b5de48cfd1bb5b36155aabf2621bfc9a834e42428f75dcf4bff89554adec82a6289f34a4af8966ce8e86e2afa841239
+  metadata.gz: 994a8c9c9450d07e709da2dfe4e7787cffc72e3176b18ec0a1ac8b10718c6b6f9b848fb83e83a28017c5fc06d36ebf87d51b02b8a7720fe7600a2e40cc3fab9d
+  data.tar.gz: 5f512b4a460484552f42304cd539a45dbb233e8c2344f037b8ab5712537e5139f5607293f735e069fb064ca36084b273d199ed10abf9f5e0d1cf4fd9688756e4

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## [0.8.3] - 2023-06-27
+- If response from Comgate API is error, but containt "transId" we do not raise exception but pass info up to stack
+
+## [0.8.2] - 2023-06-20
+- If ENV["COMGATE_MIN_LOG_LEVEL"] is set, calls and responses to Comgate are logged at that level. Otherwise `:debug` is used.
+
 ## [0.8.1] - 2023-06-13
 - Allowed  `proxy_uri` param for Comgate::Gateway
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    comgate_ruby (0.8.1)
+    comgate_ruby (0.8.3)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -148,7 +148,9 @@ Maximal mixed version looks like:
         expiration_time: "10h", # input ( use "m" or  "h" or "d", but only one of them; allowed rage "30m".."7d")
         description: "Some description",
         reccurrence: { init_transaction_id: "12AD-dfsA-4568",
-                       period: 1 } },
+                       period: 1,
+                       cycle: :month, # :on_demand
+                       valid_to: } },
     },
     payer: {
         email: "payer1@gmail.com", # input/output
@@ -189,6 +191,8 @@ This may be refactored in future.
 ## One more thing
 This gem extends `Hash` with methods `deep_symbolize_keys` and `deep_merge` (if needed).
 
+Every request to Comgate is logged/printout at `:debug` level. You can change the minimal level with ENV variable "COMGATE_MIN_LOG_LEVEL".
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake test` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.

data/lib/comgate/api_caller.rb

@@ -122,9 +122,10 @@ module Comgate
     def record_api_error
       return unless api_error?
 
-      errors[:api] = ["[Error ##{result[:response_body]["error"]}] #{result[:response_body]["message"]}"]
+      msg = [result[:response_body]["message"], result[:response_body]["extraMessage"]].compact.join(" ")
+      errors[:api] = ["[Error ##{result[:response_body]["error"]}] #{msg}"]
       @result[:errors] = { api: { code: result[:response_body]["error"].to_i,
-                                  message: result[:response_body]["message"] } }
+                                  message: msg } }
     end
 
     def api_error?
@@ -167,11 +168,13 @@ module Comgate
       else
         puts("#{Time.now} [#{forced_log_level(level)}] #{message}")
       end
+    rescue StandardError => e
+      puts("#{Time.now} [#{forced_log_level(level)}] #{message} - #{e}")
     end
 
     def forced_log_level(original_level)
       levels = { debug: 0, info: 1, error: 2 }
-      minimal_level = :error
+      minimal_level = ENV["COMGATE_MIN_LOG_LEVEL"]&.to_sym || :debug
       levels[original_level] > levels[minimal_level] ? original_level : minimal_level
     end
 

data/lib/comgate/gateway.rb

@@ -42,6 +42,7 @@ module Comgate
       transferId: %i[transfer_id],
       code: %i[code],
       message: %i[message],
+      extraMessage: %i[extra_message],
       payerId: %i[payer id],
       payerName: %i[payer account_name],
       payer_name: %i[payer account_name],
@@ -148,7 +149,7 @@ module Comgate
     def process_callback(comgate_params)
       Comgate::Response.new({ response_body: comgate_params }, DATA_CONVERSION_HASH)
     end
-    alias process_payment_callback process_callback  # backward compatibility
+    alias process_payment_callback process_callback # backward compatibility
 
     def allowed_payment_methods(payment_data)
       ph = gateway_params.merge(convert_data_to_comgate_params(%i[curr lang country], payment_data, required: false))
@@ -181,7 +182,7 @@ module Comgate
       if srv.success?
         Comgate::Response.new(srv.result, conversion_hash)
       else
-        handle_failure_from(srv.errors)
+        handle_failure_from(srv)
       end
     end
 
@@ -189,8 +190,11 @@ module Comgate
       test_from_data.nil? ? test_calls_used? : (test_from_data == true)
     end
 
-    def handle_failure_from(errors)
-      raise errors.to_s
+    def handle_failure_from(srv)
+      raise srv.errors.to_s unless srv.result.dig(:response_body, "transId").present?
+
+      # pretends to be a successfull response, and keep payment check to decide what to do next
+      Comgate::Response.new(srv.result, conversion_hash)
     end
 
     def single_payment_payload(payment_data)

data/lib/comgate/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Comgate
-  VERSION = "0.8.1"
+  VERSION = "0.8.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: comgate_ruby
 version: !ruby/object:Gem::Version
-  version: 0.8.1
+  version: 0.8.3
 platform: ruby
 authors:
 - Petr Mlčoch
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-06-13 00:00:00.000000000 Z
+date: 2023-06-27 00:00:00.000000000 Z
 dependencies: []
 description: Write a longer description or delete this line.
 email: