comgate_ruby 0.5.0 → 0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a7d8a030a101f774292a7f3214a1d3338238afa11fbc9c98e348db15259d6fde
-  data.tar.gz: 6253ba9e4d7e3a1737f491b3efccbd82bd85afc1c802c97c4939e3114dcc88ed
+  metadata.gz: 72f2698e92aee79da30f44ca5e7bff94f91fd2e5040e592376ed5da708917357
+  data.tar.gz: 3da9f58a4a35c420d2b1297352caacbcef7def37e00765fa3029362ef597a631
 SHA512:
-  metadata.gz: 47713672ee0beed059c9e26b90bbaebded0cdc29db78f08e20c9e406678c2ffd59562a439f81c8b5a2a9d0716ab7b637af9dcc86068a9010df0e0350c4984ff9
-  data.tar.gz: 9d2a09ac2489566918c5f131764636c34113bfb92cc57be659b72d349bbd78c7ebbec0fb7c2d5108e28261a4f728dc6ef4ca312dc684f331a12981ad7c6cf988
+  metadata.gz: bebb119abe984f6f30f03d4ed37481fbff9ca749f74978cc54456c2e16c132de0ddddc1d3587555659b392a7952ca554bb61e5a401c7025610764771fcb2c933
+  data.tar.gz: e65fc6812ceaa251f0d3a730cf71ad243485118941462dfcc30f11122be90f16dd081f0df3a22a65115bcccd165a2e294d58b60638d12d95980fa45999da5efa

data/CHANGELOG.md

@@ -3,3 +3,8 @@
 - Initial release
 
 
+## [0.7.0] - 2023-04-27
+
+- better handling errors not in "error" param from Comgate
+- renamed  `check_state` to `check_transaction` (and keep backward compatibility)
+- renamed  `process_payment_callback` to `process_callback` (and keep backward compatibility)

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    comgate_ruby (0.5.0)
+    comgate_ruby (0.6.0)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -18,13 +18,13 @@ If bundler is not being used to manage dependencies, install the gem by executin
 ### 1) set gateway object
   As singleton on app init or for each transaction:
   ```ruby
-    gateway = Commgate::Gateway.new(merchant_gateway_id: ":comgate_id",
-                                    test_calls: false,
-                                    secret: ":comgate_secret")
+    gateway = Comgate::Gateway.new(merchant_gateway_id: ":comgate_id",
+                                   test_calls: false,
+                                   client_secret: ":comgate_secret")
   ```
 
 ### 2) prepare endpoint
- Comgate sends POST requests to your app about transactions updates. The URL of it needs to be setup in Comgate Client portal. At endpoint, just call `gateway.process_payment_callback(params)`, which will return
+ Comgate sends POST requests to your app about transactions updates. The URL of it needs to be setup in Comgate Client portal. At endpoint, just call `gateway.process_callback(params)`, which will return
     `{state: :paid, transaction_id: ":transID"}` (at least). See bullets 4) and 5) in Single payment process bellow.
 ### 3) call appropriate method
  (see bellow)
@@ -83,7 +83,7 @@ If bundler is not being used to manage dependencies, install the gem by executin
 
 ### Check payment state (ad-hoc)
 0) The endpoint must be always implemented, this is just additional way to check payment state
-1) Call `gateway.check_state(transaction_id: ":transID")`. It will return `{state: :paid, transaction_id: ":transID"}` and some more infos.
+1) Call `gateway.check_transaction(transaction_id: ":transID")`. It will return `{state: :paid, transaction_id: ":transID"}` and some more infos.
 2) Handle status change like bullet 5) in single payment
 
 ### Get payment methods allowed to merchant

data/lib/comgate/api_caller.rb

@@ -115,8 +115,14 @@ module Comgate
 
     def api_error?
       return false unless decoded_response_body.is_a?(Hash)
+      return true if decoded_response_body["error"].to_i.positive?
 
-      decoded_response_body["error"].to_i.positive?
+      if decoded_response_body["code"].to_i.positive?
+        decoded_response_body["error"] = decoded_response_body["code"]
+        return true
+      end
+
+      false
     end
 
     def handle_connection_error(error)

data/lib/comgate/gateway.rb

@@ -25,6 +25,18 @@ module Comgate
       preauth: %i[payment preauthorization],
       verification: %i[payment verification_payment],
 
+      ## not used for Comgate, but for other Gateway payments they are needed
+      ## so here they are for evidence
+      # firstName: %i[payer first_name],
+      # lastName: %i[payer last_name],
+      # street: %i[payer street_line],
+      # city: %i[payer city],
+      # postalCode: %i[payer postal_code],
+      # payerCountryCode: %i[payer country_code],
+      # description: %i[payment description],
+      # returnUrl: %i[options shop_return_url],
+      # callbackUrl: %i[options callback_url],
+
       # responses
       transId: %i[transaction_id],
       transferId: %i[transfer_id],
@@ -53,9 +65,9 @@ module Comgate
 
     def initialize(options)
       @options = options
-      return unless options[:merchant_gateway_id].nil? || options[:secret].nil? || options[:test_calls].nil?
+      return unless options[:merchant_gateway_id].nil? || options[:client_secret].nil? || options[:test_calls].nil?
 
-      raise ArgumentError "options have to include :merchant_gateway_id, :secret and :test_calls"
+      raise ArgumentError, "options have to include :merchant_gateway_id, :client_secret and :test_calls"
     end
 
     def test_calls_used?
@@ -122,15 +134,16 @@ module Comgate
                 test_call: false)
     end
 
-    def check_state(transaction_id:)
+    def check_transaction(transaction_id:)
       make_call(url: "#{BASE_URL}/status",
                 payload: gateway_params.merge(transId: transaction_id),
                 test_call: false)
     end
 
-    def process_payment_callback(comgate_params)
+    def process_callback(comgate_params)
       Comgate::Response.new({ response_body: comgate_params }, DATA_CONVERSION_HASH)
     end
+    alias process_payment_callback process_callback  # backward compatibility
 
     def allowed_payment_methods(payment_data)
       ph = gateway_params.merge(convert_data_to_comgate_params(%i[curr lang country], payment_data, required: false))
@@ -189,7 +202,7 @@ module Comgate
 
     def gateway_params
       { merchant: options[:merchant_gateway_id],
-        secret: options[:secret] }
+        secret: options[:client_secret] }
     end
 
     def convert_data_to_comgate_params(comgate_keys, data, required:)

data/lib/comgate/response.rb

@@ -31,7 +31,7 @@ module Comgate
       1500 => "unexpected error"
     }.freeze
 
-    attr_accessor :http_code, :redirect_to, :hash, :array, :errors
+    attr_accessor :http_code, :transaction_id, :redirect_to, :hash, :array, :errors
     attr_reader :params_conversion_hash
 
     def initialize(caller_result, params_conversion_hash = {})
@@ -46,6 +46,7 @@ module Comgate
       case converted_body
       when Hash
         @hash = converted_body
+        @transaction_id = converted_body[:transaction_id]
         @array = nil
       when Array
         @array = converted_body

data/lib/comgate/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Comgate
-  VERSION = "0.5.0"
+  VERSION = "0.7"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: comgate_ruby
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: '0.7'
 platform: ruby
 authors:
 - Petr Mlčoch
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-04-20 00:00:00.000000000 Z
+date: 2023-04-27 00:00:00.000000000 Z
 dependencies: []
 description: Write a longer description or delete this line.
 email: