comfy_middle_seat 4.3.0 → 4.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9433cede5d17f15d7c30a4a6bb30e9951ddb944129c317dc8b9a008f8e8d69f0
-  data.tar.gz: 6f30614dae87dfc9735ee436c640f5431ef66e58a084483549fb105ab43bffa2
+  metadata.gz: 654bed46bea3e8580f57ce3b9ba688ceb7b592d83f76c6762b771ee21c11266c
+  data.tar.gz: 6164127c75dd90045b376a401887ab95976a6722f9b084bc3e7b937056d7570e
 SHA512:
-  metadata.gz: fba6ed160d2930727df376eb665f184df898ad3bf732b45a734abbee4f4edbe0f063f056db66c8f95adcba9111b9fd43a0640f8f5aebb1860c36b451ddcc09d5
-  data.tar.gz: f0801cb516d4d98bd8adc25c8e51bf73c2fc13b25f8930a6597c854abd216dd7a98ba5b08dd214cd45f85f73139844a7e5a6a3bb7771e8bd6c66954dd026c187
+  metadata.gz: 1c2c3126c49194876cb5794df8d986f524ed93fc159337d08651f54dcd88fbcd9a2f9ccfb3ee80ea8eb6046217a0a82b94f73dcf442aa4c33877c196b61bad01
+  data.tar.gz: 235b0a6ecc612706f168d2daf513f1935addbd9083afea5a2f80726dffb65e80fc74021dae0cd3de1284d26f4df19ab084f336907489b409324f071c0e49171b

data/.github/workflows/coveralls.yml

@@ -39,6 +39,9 @@ jobs:
           ruby-version: ${{ matrix.ruby-version }}
           bundler-cache: true
 
+      - name: Install image processors
+        run: sudo apt-get update && sudo apt-get install -y imagemagick libvips-dev
+
       - name: Update CMS gem
         run: bundle update comfy_middle_seat
 

data/.github/workflows/rubyonrails.yml

@@ -40,6 +40,9 @@ jobs:
           ruby-version: ${{ matrix.ruby-version }}
           bundler-cache: true
 
+      - name: Install image processors
+        run: sudo apt-get update && sudo apt-get install -y imagemagick libvips-dev
+
       - name: Update CMS gem
         run: bundle update comfy_middle_seat
 

data/CHANGELOG.md

@@ -14,9 +14,21 @@ This changelog follows the project's lineage: **Comfortable Mexican Sofa → Com
 
 ### Added
 
-- Add CMS comment blocks and short notes to hide content without processing enclosed tags.
-- Expand CMS tags with editor shortcuts and searchable completion.
-- Open the shortcut selector with `;;` + Tab and filter with fuzzy search.
+- Resize, crop, and pad images with ImageMagick or Vips.
+- Validate image dimensions with a configurable size limit.
+
+### Fixed
+
+- Restore supported legacy image resizing and modernize admin thumbnails.
+- Keep original file links for images that cannot be resized.
+
+## [v4.3.0] - 2026-10-17
+
+### Added
+
+- Hide content with CMS comment blocks and add short inline notes.
+- Insert CMS tags with editor shortcuts and selected parameter placeholders.
+- Find shortcuts with `;;` + Tab or Ctrl+Space and fuzzy search.
 
 ## [v4.2.0] - 2026-10-13
 
@@ -262,7 +274,8 @@ First release of `comfortable_media_surfer`. This new gem is a revival of [Comfo
 
 - Rebranded **ComfortableMexicanSofa** as **ComfortableMediaSurfer** in order to publish new gem (database table names and schema have not changed).
 
-[Unreleased]: https://github.com/avonderluft/comfy-middle-seat/compare/v4.2.0...master
+[Unreleased]: https://github.com/avonderluft/comfy-middle-seat/compare/v4.3.0...master
+[v4.3.0]: https://github.com/avonderluft/comfy-middle-seat/compare/v4.2.0...v4.3.0
 [v4.2.0]: https://github.com/avonderluft/comfy-middle-seat/compare/v4.1.0...v4.2.0
 [v4.1.0]: https://github.com/avonderluft/comfy-middle-seat/compare/v4.0.4...v4.1.0
 [v4.0.4]: https://github.com/avonderluft/comfy-middle-seat/compare/ea2bb99c0398e1f4d6e850a25e0c13afc577c3ad...v4.0.4

data/README.md

@@ -178,6 +178,62 @@ Comments produce no rendered output and do not create editor fields. Unlike HTML
 
 Blocks may be nested and must end with `{{cms:endcomment}}`, not `{{cms:end}}`. Short notes accept single or double quotes, with backslash-escaped quotes. Unclosed blocks and malformed comment tags raise a clear syntax error. Comments work in layouts, snippets, and rendered fragment content, including Markdown. They are not a place for secrets: original source remains available to editors and may be exposed by APIs that include raw content.
 
+### Image resizing
+
+Resize images from the media library or page attachments without changing the originals:
+
+```liquid
+{{ cms:image "Homepage banner", resize_to_limit: "1600x600" }}
+{{ cms:file card_photo, as: image, resize_to_fill: "600x400" }}
+{{ cms:image "Product photo", resize_and_pad: "500x500" }}
+```
+
+The same options work with `file`, `files`, `image`, `file_link`, and `page_file_link`:
+
+| Option | Result |
+| --- | --- |
+| `resize_to_limit` | Fit within the dimensions; never enlarge. |
+| `resize_to_fit` | Fit within the dimensions; allow enlargement. |
+| `resize_to_fill` | Fill the exact dimensions with a centered crop. |
+| `resize_and_pad` | Fit the whole image into the exact dimensions with padding. |
+
+Specify one operation and positive dimensions as `"WIDTHxHEIGHT"`. Invalid values, conflicting operations, and dimensions above the configured limit raise an error. Padding uses the processor's defaults; its color/transparency can differ between processors and image formats. Sizing options are ignored for missing attachments and files that Active Storage cannot transform, such as PDFs and SVGs under its default configuration. Missing attachments render nothing; non-transformable files retain their original URLs.
+
+The default maximum requested width or height is 4096 pixels. Change it in `config/initializers/comfy_middle_seat.rb`:
+
+```ruby
+ComfyMiddleSeat.configure do |config|
+  config.max_image_dimension = 6000
+end
+```
+
+This limits requested tag dimensions, not upload sizes or all intermediate processing memory. Admin thumbnails use fixed sizes.
+
+The CMS respects your application's Active Storage processor. Use ImageMagick with `:mini_magick`, or install libvips and add `ruby-vips` to your application's Gemfile, then configure:
+
+```ruby
+# config/application.rb, inside your application class
+config.active_storage.variant_processor = :vips
+```
+
+Restart after changing processors. No processor switch is required to use the new options; the gem retains its existing MiniMagick dependency for compatibility.
+
+#### Existing image tags
+
+- `resize: "400x300"` translates to `resize_to_fit`; `resize: "400x300>"` translates to `resize_to_limit`. Both work with either processor.
+- Supported legacy combinations of `resize`, `gravity`, and `crop` retain their operation order under MiniMagick. Resize accepts `WxH` with an optional `>`, `<`, `!`, or `^` suffix; crop requires `WxH+X+Y` (signed offsets). Offset-free crops are rejected because ImageMagick treats them as tiling, not a single crop. Gravity accepts the standard compass positions and `center`.
+- Other legacy geometry, including percentages and one-dimensional sizes, raises an actionable error. Replace it with an explicit two-dimensional operation. The size limit applies to legacy dimensions too.
+- Complex legacy expressions are not silently approximated on Vips. Convert them before switching processors; do not mix legacy and modern options in a tag.
+
+After upgrading, clear rendered page and translation caches once so image links use the new transformations:
+
+```ruby
+Comfy::Cms::Page.update_all(content_cache: nil)
+Comfy::Cms::Translation.update_all(content_cache: nil)
+```
+
+No database migration or re-upload is needed. New variants are generated on demand and may increase storage use temporarily; originals and old variants are not deleted. Purge any external page/CDN HTML caches separately. Clear rendered caches again after changing the sizing policy. Active Storage's variant keys do not include the processor: switching processors reuses existing variants with the same options, even after clearing page caches. To regenerate those images with the new processor, invalidate the affected derived variants separately, preserving the original uploads, and clear any cached derivative files on your CDN.
+
 ### Publishing pages
 
 A page is publicly visible only when it and all its ancestors are published. Unpublishing a parent hides its branch without changing descendants’ individual publication settings. Republishing the parent restores only descendants whose full ancestor chain is published; drafts stay unpublished. Translations must also satisfy their own publication settings.
@@ -194,7 +250,7 @@ Development mode continues to show unpublished pages for preview. Check public v
 | Rails | CI tests 7.2, 8.0, and 8.1 |
 | Node.js | 18 or newer for asset compilation |
 | File storage | Active Storage |
-| Image processing | ImageMagick |
+| Image processing | ImageMagick or libvips (via Active Storage) |
 
 Pagination is provided by [Kaminari](https://github.com/amatsuda/kaminari). The admin uses Bootstrap, CodeMirror, and Redactor.
 

data/app/controllers/comfy/admin/cms/files_controller.rb

@@ -23,7 +23,13 @@ class Comfy::Admin::Cms::FilesController < Comfy::Admin::Cms::BaseController
         case params[:type]
         when 'image'
           file_scope.with_images.collect do |file|
-            { thumb: url_for(file.attachment.variant(combine_options: Comfy::Cms::File::VARIANT_SIZE[:redactor])),
+            attachment = file.attachment
+            thumbnail = if attachment.variable?
+                          attachment.variant(Comfy::Cms::File::VARIANT_SIZE[:redactor])
+                        else
+                          attachment
+                        end
+            { thumb: url_for(thumbnail),
               image: url_for(file.attachment),
               title: file.label }
           end

data/app/models/comfy/cms/file.rb

@@ -6,9 +6,9 @@ class Comfy::Cms::File < ActiveRecord::Base
   include Comfy::Cms::WithCategories
 
   VARIANT_SIZE = {
-    redactor: { resize: '100x75^', gravity: 'center', crop: '100x75+0+0' },
-    thumb: { resize: '200x150^', gravity: 'center', crop: '200x150+0+0' },
-    icon: { resize: '28x28^', gravity: 'center', crop: '28x28+0+0' }
+    redactor: { resize_to_fill: [100, 75] },
+    thumb: { resize_to_fill: [200, 150] },
+    icon: { resize_to_fill: [28, 28] }
   }.freeze
 
   # temporary place to store attachment

data/app/views/comfy/admin/cms/fragments/_form_fragment_attachments.html.haml

@@ -2,7 +2,7 @@
   - attachments.each do |attachment|
     :ruby
       thumb_url = if attachment.variable?
-        url_for(attachment.variant(combine_options: Comfy::Cms::File::VARIANT_SIZE[:thumb]))
+        url_for(attachment.variant(Comfy::Cms::File::VARIANT_SIZE[:thumb]))
       end
       filename = attachment.filename.to_s
       truncated_filename = truncate(filename, length: 40, omission: "...#{filename.last(10)}")

data/config/initializers/comfy_middle_seat.rb

@@ -46,6 +46,10 @@ ComfyMiddleSeat.configure do |config|
   # object you want to keep. Set it to 0 if you wish to turn this feature off.
   #   config.revisions_limit = 25
 
+  # Maximum requested width or height for image resizing in CMS tags.
+  # Values above this limit raise an error rather than being silently reduced.
+  #   config.max_image_dimension = 4096
+
   # Locale definitions. If you want to define your own locale merge
   # {:locale => 'Locale Title'} with this.
   #   config.locales = {:en => 'English', :es => 'Español'}

data/lib/comfy_middle_seat/configuration.rb

@@ -84,6 +84,9 @@ class ComfyMiddleSeat::Configuration
   # For example: include fragments into json data with `config.page_to_json_options = { include: [:fragments] }`
   attr_accessor :page_to_json_options
 
+  # Maximum requested width or height for image transformations in CMS tags.
+  attr_accessor :max_image_dimension
+
   # Configuration defaults
   def initialize
     @cms_title              = 'ComfyMiddleSeat CMS Engine'
@@ -99,6 +102,7 @@ class ComfyMiddleSeat::Configuration
     @enable_seeds           = false
     @seeds_path             = File.expand_path('db/cms_seeds', Rails.root)
     @revisions_limit        = 25
+    @max_image_dimension    = 4096
     @locales                = {
       'ar' => 'عربي',
       'ca' => 'Català',

data/lib/comfy_middle_seat/content/image_transformations.rb

@@ -0,0 +1,100 @@
+# frozen_string_literal: true
+
+# Restrict CMS-authored transformations to bounded image operations. Never pass
+# arbitrary tag options through to an image processor.
+class ComfyMiddleSeat::Content::ImageTransformations
+  OPERATIONS = %w[resize_to_limit resize_to_fit resize_to_fill resize_and_pad].freeze
+  LEGACY_OPTIONS = %w[resize gravity crop].freeze
+  OPTIONS = (OPERATIONS + LEGACY_OPTIONS).freeze
+  GRAVITIES = %w[northwest north northeast west center east southwest south southeast].freeze
+
+  def self.normalize(options, processor: ActiveStorage.variant_processor)
+    new(options, processor).normalize
+  end
+
+  def initialize(options, processor)
+    @options = options.stringify_keys
+    @processor = processor
+  end
+
+  def normalize
+    return {} if @options.empty?
+
+    unknown = @options.keys - OPTIONS
+    error!("Unknown image options: #{unknown.join(', ')}") if unknown.any?
+    modern = @options.keys & OPERATIONS
+    if modern.size > 1 || (modern.any? && @options.keys.intersect?(LEGACY_OPTIONS))
+      error!('Use one resize operation; do not mix modern and legacy image options')
+    end
+
+    if modern.any?
+      operation = modern.first
+      { operation.to_sym => dimensions(@options[operation], operation) }
+    else
+      legacy_transformations
+    end
+  end
+
+private
+
+  def dimensions(value, operation)
+    match = value.is_a?(String) && %r{\A\s*(\d+)\s*x\s*(\d+)\s*\z}.match(value)
+    error!("#{operation} must be dimensions such as \"400x300\"") unless match
+    validate_dimensions(match[1].to_i, match[2].to_i)
+  end
+
+  def validate_dimensions(width, height)
+    limit = ComfyMiddleSeat.config.max_image_dimension
+    unless limit.is_a?(Integer) && limit.positive?
+      error!('max_image_dimension must be a positive integer')
+    end
+    unless width.positive? && height.positive? && width <= limit && height <= limit
+      error!("Image dimensions must be between 1 and #{limit} pixels; adjust max_image_dimension if needed")
+    end
+    [width, height]
+  end
+
+  def legacy_transformations
+    if @options.key?('resize')
+      size, modifier = legacy_resize
+      if @options.keys == ['resize'] && ['', '>'].include?(modifier)
+        operation = modifier == '>' ? :resize_to_limit : :resize_to_fit
+        return { operation => size }
+      end
+    end
+
+    validate_legacy_crop if @options.key?('crop')
+
+    if @options.key?('gravity') && !GRAVITIES.include?(@options['gravity'])
+      error!("Unsupported gravity; choose #{GRAVITIES.join(', ')}")
+    end
+    unless @options.key?('resize') || @options.key?('crop')
+      error!('Legacy gravity requires resize or crop')
+    end
+    unless @processor == :mini_magick
+      error!('Legacy crop, gravity, and resize modifiers require MiniMagick; use a modern resize option with Vips')
+    end
+
+    # image_processing combines these operations itself. The order matters for
+    # existing resize/gravity/crop expressions; combine_options is unsupported.
+    @options.slice(*LEGACY_OPTIONS).symbolize_keys
+  end
+
+  def legacy_resize
+    value = @options['resize']
+    match = value.is_a?(String) && %r{\A(\d+)x(\d+)([!<>^]?)\z}.match(value)
+    error!('Legacy resize must be WxH with an optional >, <, !, or ^ suffix; use a modern resize option') unless match
+    [validate_dimensions(match[1].to_i, match[2].to_i), match[3]]
+  end
+
+  def validate_legacy_crop
+    value = @options['crop']
+    match = value.is_a?(String) && %r{\A(\d+)x(\d+)[+-]\d+[+-]\d+\z}.match(value)
+    error!('Legacy crop requires explicit offsets: WxH+X+Y; use resize_to_fill for a centered crop') unless match
+    validate_dimensions(match[1].to_i, match[2].to_i)
+  end
+
+  def error!(message)
+    raise ComfyMiddleSeat::Content::Tag::Error, message
+  end
+end

data/lib/comfy_middle_seat/content/tags/file.rb

@@ -8,9 +8,8 @@ require_relative 'mixins/file_content'
 #
 # `as`      - url (default) | link | image - render out link or image tag
 # `label`   - attach label attribute to link or image tag
-# `resize`  - imagemagic option. For example: "100x50>"
-# `gravity` - imagemagic option. For example: "center"
-# `crop`    - imagemagic option. For example: "100x50+0+0"
+# Image sizing: resize_to_limit, resize_to_fit, resize_to_fill, resize_and_pad ("100x50").
+# Legacy resize/gravity/crop expressions remain supported for MiniMagick.
 # `class`   - any html classes that you want on the result link or image tag. For example "class1 class2"
 #
 class ComfyMiddleSeat::Content::Tags::File < ComfyMiddleSeat::Content::Tags::Fragment
@@ -28,7 +27,7 @@ class ComfyMiddleSeat::Content::Tags::File < ComfyMiddleSeat::Content::Tags::Fra
     @as             = options['as'] || 'url'
     @label          = options['label']
     @class          = options['class']
-    @variant_attrs  = options.slice('resize', 'gravity', 'crop')
+    @variant_attrs  = options.slice(*ComfyMiddleSeat::Content::ImageTransformations::OPTIONS)
   end
 
   def form_field(object_name, view, index)

data/lib/comfy_middle_seat/content/tags/file_link.rb

@@ -9,12 +9,8 @@ require_relative 'mixins/file_content'
 # `as`      - url (default) | link | image - how file gets rendered out
 # `class`   - any html classes that you want on the result link or image tag. For example "class1 class2"
 #
-# - variant_attrs are not functional, perhaps due to some change in ImageMagick
-# - Simply use a class in your CSS / SASS to style your image display
-# `label`   - attach label attribute to link or image tag
-# `resize`  - imagemagick option. For example: "100x50>"
-# `gravity` - imagemagick option. For example: "center"
-# `crop`    - imagemagick option. For example: "100x50+0+0"
+# Image sizing: resize_to_limit, resize_to_fit, resize_to_fill, resize_and_pad ("100x50").
+# Legacy resize/gravity/crop expressions remain supported for MiniMagick.
 #
 class ComfyMiddleSeat::Content::Tags::FileLink < ComfyMiddleSeat::Content::Tag
   include ComfyMiddleSeat::Content::Tags::Mixins::FileContent
@@ -28,7 +24,7 @@ class ComfyMiddleSeat::Content::Tags::FileLink < ComfyMiddleSeat::Content::Tag
     @identifier     = params[0]
     @as             = options['as'] || 'url'
     @class          = options['class']
-    @variant_attrs  = options.slice('resize', 'gravity', 'crop') # broken for ImageMagick
+    @variant_attrs  = options.slice(*ComfyMiddleSeat::Content::ImageTransformations::OPTIONS)
 
     return if @identifier.present?
 

data/lib/comfy_middle_seat/content/tags/image.rb

@@ -7,12 +7,8 @@ require_relative 'mixins/file_content'
 #
 # `class`   - any html classes that you want on the image tag. For example "class1 class2"
 #
-# - variant_attrs are not functional, perhaps due to some change in ImageMagick
-# - Simply use a class in your CSS / SASS to style your image display
-# `label`   - attach label attribute to link or image tag
-# `resize`  - imagemagick option. For example: "100x50>"
-# `gravity` - imagemagick option. For example: "center"
-# `crop`    - imagemagick option. For example: "100x50+0+0"
+# Image sizing: resize_to_limit, resize_to_fit, resize_to_fill, resize_and_pad ("100x50").
+# Legacy resize/gravity/crop expressions remain supported for MiniMagick.
 
 class ComfyMiddleSeat::Content::Tags::Image < ComfyMiddleSeat::Content::Tag
   include ComfyMiddleSeat::Content::Tags::Mixins::FileContent
@@ -26,7 +22,7 @@ class ComfyMiddleSeat::Content::Tags::Image < ComfyMiddleSeat::Content::Tag
     @identifier     = params[0]
     @as             = 'image'
     @class          = options['class']
-    @variant_attrs  = options.slice('resize', 'gravity', 'crop') # broken for ImageMagick
+    @variant_attrs  = options.slice(*ComfyMiddleSeat::Content::ImageTransformations::OPTIONS)
 
     return if @identifier.present?
 

data/lib/comfy_middle_seat/content/tags/mixins/file_content.rb

@@ -1,11 +1,13 @@
 # frozen_string_literal: true
 
+require_relative '../../image_transformations'
+
 # A mixin for tags that returns the file as their content.
 module ComfyMiddleSeat::Content::Tags::Mixins
   module FileContent
     # @param [ActiveStorage::Blob] file
     # @param ["link", "image", "url"] as
-    # @param [{String => String}] variant_attrs ImageMagick variant attributes
+    # @param [{String => String}] variant_attrs Modern or legacy image options
     # @param [String] label alt text for `as: "image"`, link text for `as: "link"`
     # @return [String]
     def content(file: self.file, as: self.as, variant_attrs: self.variant_attrs, label: self.label)
@@ -14,8 +16,9 @@ module ComfyMiddleSeat::Content::Tags::Mixins
       url_helpers = Rails.application.routes.url_helpers
 
       attachment_url =
-        if variant_attrs.present? && file.image?
-          variant = file.variant(combine_options: variant_attrs)
+        if variant_attrs.present? && file.variable?
+          transformations = ComfyMiddleSeat::Content::ImageTransformations.normalize(variant_attrs)
+          variant = file.variant(transformations)
           url_helpers.rails_representation_path(variant, only_path: true)
         else
           url_helpers.rails_blob_path(file, only_path: true)

data/lib/comfy_middle_seat/content/tags/page_file_link.rb

@@ -18,12 +18,8 @@ require_relative 'mixins/file_content'
 # `as`      - url (default) | link | image - how file gets rendered out
 # `class`   - any html classes that you want on the result link or image tag. For example "class1 class2"
 #
-# - the following params are deprecated / not functional, perhaps due to some change in ImageMagick
-# - Simply use a class in your CSS / SASS to style your image display
-# `label`   - attach label attribute to link or image tag
-# `resize`  - imagemagick option. For example: "100x50>"
-# `gravity` - imagemagick option. For example: "center"
-# `crop`    - imagemagick option. For example: "100x50+0+0"
+# Image sizing: resize_to_limit, resize_to_fit, resize_to_fill, resize_and_pad ("100x50").
+# Legacy resize/gravity/crop expressions remain supported for MiniMagick.
 #
 class ComfyMiddleSeat::Content::Tags::PageFileLink < ComfyMiddleSeat::Content::Tag
   include ComfyMiddleSeat::Content::Tags::Mixins::FileContent
@@ -48,7 +44,7 @@ class ComfyMiddleSeat::Content::Tags::PageFileLink < ComfyMiddleSeat::Content::T
     @identifier     = params[0]
     @as             = options['as'] || 'url'
     @class          = options['class']
-    @variant_attrs  = options.slice('resize', 'gravity', 'crop')
+    @variant_attrs  = options.slice(*ComfyMiddleSeat::Content::ImageTransformations::OPTIONS)
     @filename       = options['filename']
 
     return if @identifier.present?

data/lib/comfy_middle_seat/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ComfyMiddleSeat
-  VERSION = '4.3.0'
+  VERSION = '4.4.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: comfy_middle_seat
 version: !ruby/object:Gem::Version
-  version: 4.3.0
+  version: 4.4.0
 platform: ruby
 authors:
 - Oleg Khabarov
@@ -574,6 +574,7 @@ files:
 - lib/comfy_middle_seat/configuration.rb
 - lib/comfy_middle_seat/content.rb
 - lib/comfy_middle_seat/content/block.rb
+- lib/comfy_middle_seat/content/image_transformations.rb
 - lib/comfy_middle_seat/content/params_parser.rb
 - lib/comfy_middle_seat/content/renderer.rb
 - lib/comfy_middle_seat/content/tag.rb