comfortable_media_surfer 3.1.7 → 3.2.0

data/lib/comfortable_media_surfer/routing.rb

@@ -35,6 +35,8 @@ module ComfortableMediaSurfer::Routing
                 concerns :with_revisions, controller: 'revisions/page'
 
                 get :toggle_branch, on: :member
+                patch :publish_children, on: :member
+                patch :unpublish_children, on: :member
 
                 resources :translations, except: [:index] do
                   concerns :with_form_fragments

data/lib/comfortable_media_surfer/seeds/page/importer.rb

@@ -63,16 +63,21 @@ module ComfortableMediaSurfer::Seeds::Page
 
         new_frag_identifiers, fragments_attributes =
           construct_fragments_attributes(fragments_hash, page, path)
-        page.fragments_attributes = fragments_attributes
+        page_saved = begin
+          page.fragments_attributes = fragments_attributes
+          page.save
+        ensure
+          close_fragment_files(fragments_attributes)
+        end
 
-        if page.save
+        if page_saved
           message = "[CMS SEEDS] Imported Page \t #{page.full_path}"
           ComfortableMediaSurfer.logger.info(message)
 
           # defering target page linking
           if target_page.present?
             self.target_pages ||= {}
-            self.target_pages[page.id] = target_page
+            target_pages[page.id] = target_page
           end
 
           # cleaning up old fragments
@@ -127,9 +132,14 @@ module ComfortableMediaSurfer::Seeds::Page
 
         new_frag_identifiers, fragments_attributes =
           construct_fragments_attributes(fragments_hash, translation, path)
-        translation.fragments_attributes = fragments_attributes
+        translation_saved = begin
+          translation.fragments_attributes = fragments_attributes
+          translation.save
+        ensure
+          close_fragment_files(fragments_attributes)
+        end
 
-        if translation.save
+        if translation_saved
           message = "[CMS SEEDS] Imported Translation \t #{locale}"
           ComfortableMediaSurfer.logger.info(message)
 
@@ -186,13 +196,15 @@ module ComfortableMediaSurfer::Seeds::Page
     # ActiveStorage and a list of ids of old attachements to destroy
     def files_content(record, identifier, path, frag_content)
       # preparing attachments
-      files = frag_content.split("\n").collect do |filename|
-        file_handler = File.open(File.join(path, filename))
-        {
+      files = []
+      frag_content.split("\n").each do |filename|
+        file_handler = File.new(File.join(path, filename), 'rb')
+        attachment = {
           io: file_handler,
-          filename: filename,
-          content_type: MimeMagic.by_magic(file_handler)
+          filename: filename
         }
+        files << attachment
+        attachment[:content_type] = MimeMagic.by_magic(file_handler)
       end
 
       # ensuring that old attachments get removed
@@ -202,12 +214,28 @@ module ComfortableMediaSurfer::Seeds::Page
       end
 
       [files, ids_destroy]
+    rescue StandardError
+      close_files(files)
+      raise
+    end
+
+    def close_fragment_files(fragment_attributes)
+      fragment_attributes.each do |attributes|
+        close_files(attributes[:files])
+      end
+    end
+
+    def close_files(files)
+      Array(files).each do |file|
+        io = file[:io]
+        io.close unless io.closed?
+      end
     end
 
     def link_target_pages
-      return unless self.target_pages.present?
+      return unless target_pages.present?
 
-      self.target_pages.each do |page_id, target|
+      target_pages.each do |page_id, target|
         if (target = site.pages.find_by(full_path: target))
           @site.pages.find(page_id).update_column(:target_page_id, target.id)
         end

data/lib/comfortable_media_surfer/seeds.rb

@@ -46,9 +46,7 @@ module ComfortableMediaSurfer::Seeds
       text = ::File.read(file_path)
       tokens = text.split(%r{^\[(.*?)\]\r?\n})
       tokens.shift # first item should be blank
-      tokens.in_groups_of(2).each_with_object({}) do |pair, h|
-        h[pair[0]] = pair[1]
-      end
+      tokens.in_groups_of(2).to_h
     end
 
     def fresh_seed?(object, file_path)

data/lib/comfortable_media_surfer/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ComfortableMediaSurfer
-  VERSION = '3.1.7'
+  VERSION = '3.2.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: comfortable_media_surfer
 version: !ruby/object:Gem::Version
-  version: 3.1.7
+  version: 3.2.0
 platform: ruby
 authors:
 - Oleg Khabarov
@@ -556,7 +556,6 @@ files:
 - db/migrate/00_create_active_storage_tables.active_storage.rb
 - db/migrate/01_create_cms.rb
 - db/migrate/02_add_markdown_to_snippets.rb
-- gemfiles/7.1.gemfile
 - gemfiles/7.2.gemfile
 - gemfiles/8.0.gemfile
 - gemfiles/8.1.gemfile
@@ -659,7 +658,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.7.2
+rubygems_version: 4.0.18
 specification_version: 4
 summary: Rails 7.0+ CMS Engine
 test_files: []

data/gemfiles/7.1.gemfile

@@ -1,35 +0,0 @@
-# frozen_string_literal: true
-
-source 'https://rubygems.org'
-git_source(:github) { |repo| "https://github.com/#{repo}.git" }
-
-gemspec path: '../'
-
-gem 'rails', '~> 7.1.0', '>= 7.1.5.1'
-
-group :development, :test do
-  gem 'autoprefixer-rails', '~> 10.4.16.0'
-  gem 'byebug',             '~> 11.1.0', platforms: %i[mri mingw x64_mingw]
-  gem 'image_processing',   '>= 1.12.0'
-  gem 'propshaft',          '~> 1.1.0'
-  gem 'sqlite3',            '>= 2.1'
-end
-
-group :test do
-  gem 'brakeman',                 '~> 7.1.0'
-  gem 'bundler-audit',            '~> 0.9.1'
-  gem 'coveralls_reborn',         '~> 0.29.0', require: false
-  gem 'cuprite',                  '>= 0.15'
-  gem 'diffy'
-  gem 'equivalent-xml',           '~> 0.6.0'
-  gem 'minitest',                 '< 6.0.0'
-  gem 'minitest-reporters',       '>= 1.6.1'
-  gem 'mocha',                    '>= 2.3.0', require: false
-  gem 'ostruct'
-  gem 'puma'
-  gem 'rails-controller-testing', '~> 1.0.5'
-  gem 'rubocop',                  '~> 1.81.1', require: false
-  gem 'rubocop-minitest'
-  gem 'rubocop-rails'
-  gem 'simplecov', '~> 0.22.0', require: false
-end