combine_pdf 1.0.5 → 1.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: aae99be65f85291a4eb366e78d93e015822e1dcd
-  data.tar.gz: b92628654f3a544d3fd54fe3b9e56c344227605c
+  metadata.gz: b455928d3e64892b983f743f94243bd3850f1324
+  data.tar.gz: '0925ba5c1a7754bd54311ba499329771b0bc36b4'
 SHA512:
-  metadata.gz: ac30f12f96a4bd58e1290859713f88917639f1ff92ba3d14ab72cfdfbdd70655727cd30a1082374fdf43e0fc8f1f502323a8b35c8f37d8a059a89baf096fb221
-  data.tar.gz: 4e2d3f8609b1f531c95c1e28af217eaf6e93a9a112ee96e2678d562ccb7bc895b5629b56fb90e6631a891ae1fed45985ab6cafab2ec999d52a3c1e7bbfbd11e4
+  metadata.gz: 1a382e673cf8c042ed95638d44cb9cd804a52190bc06130ba3d9ae5a5aac564184c13c41b6a44ecbf265590a1ed3fdd97a011c252dc647502295255051fb473c
+  data.tar.gz: 0a77bd1af453712bcff6de7e3fbae6a745c0b3137351c8b147a614aac8d0062feee0044e66cba8e4924213ab7c9020ec5c8087fb9cc5d1258edb7303a23a919b

data/README.md

@@ -1,6 +1,7 @@
 # CombinePDF - the ruby way for merging PDF files
 [![Gem Version](https://badge.fury.io/rb/combine_pdf.svg)](http://badge.fury.io/rb/combine_pdf)
 [![GitHub](https://img.shields.io/badge/GitHub-Open%20Source-blue.svg)](https://github.com/boazsegev/combine_pdf)
+[![Maintainers Wanted](https://img.shields.io/badge/maintainers-wanted-red.svg)](https://github.com/pickhardt/maintainers-wanted)
 
 CombinePDF is a nifty model, written in pure Ruby, to parse PDF files and combine (merge) them with other PDF files, watermark them or stamp them (all using the PDF file format and pure Ruby code).
 
@@ -12,6 +13,16 @@ Install with ruby gems:
 gem install combine_pdf
 ```
 
+## Help Wanted
+
+I need help maintaining the CombinePDF Ruby gem.
+
+I wrote this gem because I needed to solve an issue with bates-numbering existing PDF documents. However, during the last three years or so I have been maintaining the project for no reason at all, except that I enjoyed sharing it with the community.
+
+I love this gem, but I feel it's time I took a step back from maintaining it and concentrate on my music and other things I want to develop.
+
+Please hit me up if you would like to join in and eventually take over.
+
 ## Known Limitations
 
 Quick rundown:

data/lib/combine_pdf/api.rb

@@ -28,7 +28,7 @@ module CombinePDF
    rescue
      false
    end) ? load(string) : parse(string)
-    rescue => e
+   rescue => _e
       raise 'General PDF error - Use CombinePDF.load or CombinePDF.parse for a non-general error message (the requested file was not found OR the string received is not a valid PDF stream OR the file was found but not valid).'
     end
   end
@@ -167,4 +167,14 @@ module CombinePDF
   def register_font_from_pdf_object(font_name, font_object)
     register_existing_font font_name, font_object
   end
+
+  # Gets the equality depth limit. This is the point at which CombinePDF will stop testing for nested items being equal.
+  def eq_depth_limit
+    @eq_depth_limit
+  end
+  # Sets the equality depth limit. This is the point at which CombinePDF will stop testing for nested items being equal.
+  def eq_depth_limit= value
+    @eq_depth_limit = value
+  end
+  @eq_depth_limit = 8
 end

data/lib/combine_pdf/decrypt.rb

@@ -147,7 +147,7 @@ module CombinePDF
         cipher.iv = encrypted[0..15]
         cipher.padding = 0
         cipher.update(encrypted[16..-1]) + cipher.final
-      rescue StandardError => e
+      rescue StandardError => _e
         # puts e.class.name
         encrypted
       end

data/lib/combine_pdf/filter.rb

@@ -51,14 +51,14 @@ module CombinePDF
         when :FlateDecode
           raise_unsupported_error params_array[0] unless params_array[0].nil?
           if params_array[0] && params_array[0][:Predictor].to_i > 1
-            bits = params_array[0][:BitsPerComponent] || 8
             predictor = params_array[0][:Predictor].to_i
-            columns = params_array[0][:Columns] || 1
-            if (2..9).cover? params_array[0][:Predictor].to_i
+            # bits = params_array[0][:BitsPerComponent] || 8
+            # columns = params_array[0][:Columns] || 1
+            if (2..9).cover? predictor
               ####
               # prepare TIFF group
               raise_unsupported_error params_array[0]
-            elsif (10..15).cover? params_array[0][:Predictor].to_i == 2
+            elsif (10..15).cover? predictor
               ####
               # prepare PNG group
               raise_unsupported_error params_array[0]

data/lib/combine_pdf/fonts.rb

@@ -389,7 +389,7 @@ module CombinePDF
       until scanner.eos?
         if do_scan
           while do_scan && !scanner.eos?
-            if scanner.scan(/[\<]?[\d\w]+[\>]?/)
+            if scanner.scan(/[\<]?[\w]+[\>]?/)
               if scanner.matched[0] == '<'
                 lines_found.last << scanner.matched[1..-2]
               else

data/lib/combine_pdf/page_methods.rb

@@ -63,9 +63,9 @@ module CombinePDF
       # setup references to avoid method calls.
       local_res = resources
       local_val = nil
-      # setup references to avoid method calls.
-      remote_res = obj.resources
-      remote_val = nil
+      # # setup references to avoid method calls.
+      # remote_res = obj.resources
+      # remote_val = nil
 
       # add each of the new resources in the uncoming Page to the local resource Hash
       obj.resources.each do |key, new_val|
@@ -493,19 +493,19 @@ module CombinePDF
 
     # rotate the page 90 degrees counter clockwise
     def rotate_left
-      self[:Rotate] = self[:Rotate].to_f + 90
+      self[:Rotate] = (self[:Rotate].to_f() + 90)
       fix_rotation
     end
 
     # rotate the page 90 degrees clockwise
     def rotate_right
-      self[:Rotate] = self[:Rotate].to_f - 90
+      self[:Rotate] = (self[:Rotate].to_f() - 90)
       fix_rotation
     end
 
     # rotate the page by 180 degrees
     def rotate_180
-      self[:Rotate] = self[:Rotate].to_f +180
+      self[:Rotate] = (self[:Rotate].to_f() + 180)
       fix_rotation
     end
 
@@ -816,9 +816,9 @@ module CombinePDF
       out = []
       scanner = StringScanner.new text
       until scanner.eos?
-        if scanner.scan /[#{rtl_characters} ]/
+        if scanner.scan(/[#{rtl_characters} ]/)
           out.unshift scanner.matched
-        elsif scanner.scan /[^#{rtl_characters}]+/
+        elsif scanner.scan(/[^#{rtl_characters}]+/)
           if out.empty? && scanner.matched.match(/[\s]$/) && !scanner.eos?
             white_space_to_move = scanner.matched.match(/[\s]+$/).to_s
             out.unshift scanner.matched[0..-1 - white_space_to_move.length]

data/lib/combine_pdf/parser.rb

@@ -65,11 +65,11 @@ module CombinePDF
       @scanner = StringScanner.new @string_to_parse
       @scanner.pos = 0
       @scanner.skip(/[^%]*/) if @scanner.exist?(/%PDF/i)
-      if @scanner.scan /\%PDF\-[\d\-\.]+/
+      if @scanner.scan(/\%PDF\-[\d\-\.]+/)
         @version = @scanner.matched.scan(/[\d\.]+/)[0].to_f
         loop do
           break unless @scanner.scan(/[^\d\r\n]+/)
-          break if @scanner.check(/([\d]+[\s]+[\d]+[\s]+obj[\n\r\s]+\<\<)|([\n\r]+)/)
+          break if @scanner.check(/([\d]+[\s]+[\d]+[\s]+obj[\s]+\<\<)|([\n\r]+)/)
           break if @scanner.eos?
           @scanner.pos += 1
         end
@@ -381,7 +381,7 @@ module CombinePDF
           # is a comment, skip until new line
           loop do
             # break unless @scanner.scan(/[^\d\r\n]+/)
-            break if @scanner.check(/([\d]+[\s]+[\d]+[\s]+obj[\n\r\s]+\<\<)|([\n\r]+)/) || @scanner.eos? # || @scanner.scan(/[^\d]+[\r\n]+/) ||
+            break if @scanner.check(/([\d]+[\s]+[\d]+[\s]+obj[\s]+\<\<)|([\n\r]+)/) || @scanner.eos? # || @scanner.scan(/[^\d]+[\r\n]+/) ||
             @scanner.scan(/[^\d\r\n]+/) || @scanner.pos += 1
           end
         # puts "AFTER COMMENT: #{@scanner.peek 8}"

data/lib/combine_pdf/pdf_protected.rb

@@ -20,8 +20,6 @@ module CombinePDF
     #
     # this is used for internal operations, such as injectng data using the << operator.
     def add_referenced()
-      # add references but not root
-      dup_pages = nil
       # an existing object map
       resolved = {}.dup
       existing = {}.dup
@@ -156,7 +154,7 @@ module CombinePDF
     # there is no point is calling the method before preparing the output.
     def rebuild_catalog_and_objects
       catalog = rebuild_catalog
-      page_objects = catalog[:Pages][:referenced_object][:Kids].map { |e| @objects << e[:referenced_object]; e[:referenced_object] }
+      catalog[:Pages][:referenced_object][:Kids].each { |e| @objects << e[:referenced_object]; e[:referenced_object] }
       # adds every referenced object to the @objects (root), addition is performed as pointers rather then copies
       add_referenced()
       catalog
@@ -339,12 +337,12 @@ module CombinePDF
         end
       end
       formatted_outline_str << "\n" * 10
-      File.open(file, 'w') { |file| file.write(formatted_outline_str) }
+      File.open(file, 'w') { |f| f.write(formatted_outline_str) }
     end
 
     private
 
-    def equal_layers obj1, obj2, layer = 3
+    def equal_layers obj1, obj2, layer = CombinePDF.eq_depth_limit
       return true   if(layer == 0)
       return true if obj1.object_id == obj2.object_id
       if obj1.is_a? Hash

data/lib/combine_pdf/pdf_public.rb

@@ -275,7 +275,7 @@ module CombinePDF
     #   pdf.save "both_files_merged.pdf"
     # data:: is PDF page (Hash), and Array of PDF pages or a parsed PDF object to be added.
     def <<(data)
-      insert -1, data
+      insert(-1, data)
     end
 
     # add the pages (or file) to the BEGINNING of the PDF (combine/merge) and RETURNS SELF for nesting operators.

data/lib/combine_pdf/renderer.rb

@@ -42,7 +42,7 @@ module CombinePDF
 
     def format_string_to_pdf(object)
       # object.force_encoding(Encoding::ASCII_8BIT)
-      if !object.match(/[^D\:\d\+\-\Z\']/) # if format is set to Literal and string isn't a date
+      if !object.match(/[^D\:\d\+\-Z\']/) # if format is set to Literal and string isn't a date
         ('(' + ([].tap { |out| object.bytes.to_a.each { |byte| STRING_REPLACEMENT_HASH[byte.chr] ? (STRING_REPLACEMENT_HASH[byte.chr].bytes.each { |b| out << b }) : out << byte } }).pack('C*') + ')').force_encoding(Encoding::ASCII_8BIT)
       else
         # A hexadecimal string shall be written as a sequence of hexadecimal digits (0–9 and either A–F or a–f)

data/lib/combine_pdf/version.rb

@@ -1,3 +1,3 @@
 module CombinePDF
-  VERSION = '1.0.5'.freeze
+  VERSION = '1.0.6'.freeze
 end

data/test/automated

@@ -1,5 +1,7 @@
 #!/usr/bin/env ruby
 
+$VERBOSE = true
+
 require 'benchmark'
 $LOAD_PATH.unshift File.expand_path(File.join('..', '..', 'lib'), __FILE__)
 require 'combine_pdf'

data/test/console

@@ -1,5 +1,7 @@
 #!/usr/bin/env ruby
 
+$VERBOSE = true
+
 require 'benchmark'
 $LOAD_PATH.unshift File.expand_path(File.join('..', '..', 'lib'), __FILE__)
 require 'combine_pdf'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: combine_pdf
 version: !ruby/object:Gem::Version
-  version: 1.0.5
+  version: 1.0.6
 platform: ruby
 authors:
 - Boaz Segev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-14 00:00:00.000000000 Z
+date: 2017-08-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ruby-rc4