columns_on_demand 5.2.0 → 6.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c35479e9e268cbc8b33a8b981e28728a76745894e3dd91ca4fcbc92903fcd1b4
-  data.tar.gz: cc6bc4f1ed2476f225d40fd3aa74f47ab1ef8041661efda8e4ba4a2cb41d4fef
+  metadata.gz: 1883a4021dfc69d3c3ce1b12c02f14cfb8d5ad40b7dcf0e382c638ebe20528f1
+  data.tar.gz: b9da84f7409d34203123dc0c9a2c9ed59ed65004cfb08994ad4f13be1e1bad83
 SHA512:
-  metadata.gz: 0f48f8af4a0cdfcaac66e0169467125513fc54d9995dc8e798d06ed9b30901196ad2a14959622afec8579ba4306545d766d4f48a197b888360feb951c2f4f314
-  data.tar.gz: 48643342903f8b5d04d69d27f3a5573a78d776f72f6fbdfdcb3f3287e60c016c08b1223cce6c7d0ccd70383ed1a5dad116979e48def4ee340435f3595a02330e
+  metadata.gz: 25931accb7f33e305383400d6d780d119508298a3ae4baa66fdc374daaf459f47cee7fd7390de790af785075ef7a62b53bd6d79716269487e989952d6979a4c2
+  data.tar.gz: 5477645b767cbc9bf7f9acff349b6fd7c515980905921137f49f8e335c4ed937b89b2cd689f802fd5b296b5129ae1e73899303dd438265af22ca06e36335a3c7

data/.travis.yml

@@ -0,0 +1,14 @@
+---
+sudo: false
+language: ruby
+cache: bundler
+dist: bionic
+rvm:
+  - 2.6
+services:
+  - postgresql
+  - mysql
+before_script:
+  - createdb -U postgres columns_on_demand_test
+  - mysqladmin -u root create columns_on_demand_test
+script: ./test_all.sh

data/Gemfile

@@ -11,3 +11,4 @@ gemspec
 # your gem to rubygems.org.
 
 gem 'rails', ENV['RAILS_VERSION']
+gem 'sqlite3', ENV['SQLITE3_VERSION']

data/README.md

@@ -21,9 +21,7 @@ Compatibility
 
 Supports mysql, mysql2, postgresql, and sqlite3.
 
-Currently tested against Rails 5.2 (up to 5.2.0.beta2), 5.1 (up to 5.1.4), 5.0 (up to 5.0.6), and 4.2 (up to 4.2.10), on Ruby 2.3.6, 2.4.3, and 2.5.0.
-
-For earlier versions of Rails, use an older version of the gem.
+Currently tested against Rails 6.1.0.rc1, 6.0.3.4, 5.2.4.4, 5.1.7, and 5.0.7.2, with older gem versions compatible with earlier Rails versions.
 
 
 Example
@@ -53,5 +51,6 @@ Thanks
 * Tim Connor (@tlconnor)
 * Tobias Matthies (@tobmatth)
 * Phil Ross (@philr)
+* Jens Schmidt (@w3dot0)
 
-Copyright (c) 2008-2018 Will Bryant, Sekuda Ltd, released under the MIT license
+Copyright (c) 2008-2020 Will Bryant, Sekuda Ltd, released under the MIT license

data/columns_on_demand.gemspec

@@ -19,16 +19,7 @@ pages since they are not stored wholly in the record's page itself.
 
 Although this plugin is mainly used for BLOB and TEXT columns, it will actually
 work on all types - and is just as useful for large string fields etc.
-
-
-Compatibility
-=============
-
-Supports mysql, mysql2, postgresql, and sqlite3.
-
-Currently tested against Rails 3.2.18, 4.0.8, and 4.1.4, on Ruby 2.0.0.
 EOF
-  gem.has_rdoc     = false
   gem.author       = "Will Bryant"
   gem.email        = "will.bryant@gmail.com"
   gem.homepage     = "http://github.com/willbryant/columns_on_demand"

data/lib/columns_on_demand.rb

@@ -107,6 +107,16 @@ module ColumnsOnDemand
       super(attr_name, &block)
     end
 
+    def write_attribute(attr_name, value)
+      ensure_loaded(attr_name)
+      super(attr_name, value)
+    end
+
+    def _write_attribute(attr_name, value)
+      ensure_loaded(attr_name)
+      super(attr_name, value)
+    end
+
     def missing_attribute(attr_name, *args)
       if columns_to_load_on_demand.include?(attr_name)
         load_attributes(attr_name)

data/lib/columns_on_demand/version.rb

@@ -1,3 +1,3 @@
 module ColumnsOnDemand
-  VERSION = '5.2.0'
+  VERSION = '6.0.0'
 end

data/test/columns_on_demand_test.rb

@@ -148,6 +148,13 @@ class ColumnsOnDemandTest < ActiveSupport::TestCase
     assert_equal "somefile.txt", attributes["original_filename"]
     assert_equal "This is the file data!", attributes["file_data"]
   end
+
+  test "it loads the column when changing its value" do
+    record = Implicit.first
+    record.file_data = 'This is the new file data!'
+    assert_equal "This is the file data!", record.file_data_was
+    assert_equal ["This is the file data!", "This is the new file data!"], record.changes[:file_data]
+  end
   
   test "it loads the column when generating #to_json" do
     ActiveRecord::Base.include_root_in_json = true
@@ -177,7 +184,8 @@ class ColumnsOnDemandTest < ActiveSupport::TestCase
   
   test "it does not think the column has been loaded if a reloaded instance that has not loaded the attribute is saved" do
     record = Implicit.first
-    record.update_attributes!(:file_data => "New file data")
+    record.file_data = "New file data"
+    record.save!
 
     record.reload
     record.save!
@@ -187,7 +195,8 @@ class ColumnsOnDemandTest < ActiveSupport::TestCase
 
   test "it does not think the column has been loaded if a fresh instance that has not loaded the attribute is saved" do
     record = Implicit.first
-    record.update_attributes!(:file_data => "New file data")
+    record.file_data = "New file data"
+    record.save!
 
     record = Implicit.find(record.id)
     record.save!
@@ -281,9 +290,9 @@ class ColumnsOnDemandTest < ActiveSupport::TestCase
     
     assert !ValidatedImplicit.new(:original_filename => "test.txt").valid?
     instance = ValidatedImplicit.create!(:original_filename => "test.txt", :file_data => "test file data", :results => "test results")
-    instance.update_attributes!({}) # file_data and results are already loaded
+    assert instance.valid? # file_data and results are already loaded
     new_instance = ValidatedImplicit.find(instance.id)
-    new_instance.update_attributes!({}) # file_data and results aren't loaded yet, but will be loaded to validate
+    assert new_instance.valid? # file_data and results aren't loaded yet, but will be loaded to validate
   end
   
   test "it works with serialized columns" do

data/test_all.sh

@@ -2,10 +2,18 @@
 
 set -e
 
-for version in 4.2.10 5.0.6 5.1.4 5.2.0.beta2
+for version in 5.0.7.2 5.1.7 5.2.4.4
 do
-	RAILS_VERSION=$version bundle update rails
+	RAILS_VERSION=$version SQLITE3_VERSION=1.3.9 bundle update rails sqlite3
 	RAILS_ENV=sqlite3 bundle exec rake
 	RAILS_ENV=postgresql bundle exec rake
 	RAILS_ENV=mysql2 bundle exec rake
-done
+done
+
+for version in 6.0.3.4 6.1.0.rc1
+do
+	RAILS_VERSION=$version SQLITE3_VERSION=1.4.1 bundle update rails sqlite3
+	RAILS_ENV=sqlite3 bundle exec rake
+	RAILS_ENV=postgresql bundle exec rake
+	RAILS_ENV=mysql2 bundle exec rake
+done

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: columns_on_demand
 version: !ruby/object:Gem::Version
-  version: 5.2.0
+  version: 6.0.0
 platform: ruby
 authors:
 - Will Bryant
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-01-02 00:00:00.000000000 Z
+date: 2020-11-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -108,20 +108,13 @@ description: |
 
   Although this plugin is mainly used for BLOB and TEXT columns, it will actually
   work on all types - and is just as useful for large string fields etc.
-
-
-  Compatibility
-  =============
-
-  Supports mysql, mysql2, postgresql, and sqlite3.
-
-  Currently tested against Rails 3.2.18, 4.0.8, and 4.1.4, on Ruby 2.0.0.
 email: will.bryant@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".travis.yml"
 - Gemfile
 - MIT-LICENSE
 - README.md
@@ -143,7 +136,7 @@ homepage: http://github.com/willbryant/columns_on_demand
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -158,9 +151,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.3
-signing_key: 
+rubygems_version: 3.0.3
+signing_key:
 specification_version: 4
 summary: Lazily loads large columns on demand.
 test_files: