color_hash 0.1.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ddbbc3200aa561a17d07ecbd7c209822e97d276d35965dfc6027ac16cd3dfd4c
-  data.tar.gz: 68bda518a95968b69339e1b30e94b45bd42e14948fec050194944b5a2ec19a0b
+  metadata.gz: '0492acdb34c326758582df5926c316d5610cfd5a16dc52902f550610866849cf'
+  data.tar.gz: 003edf282db34a6849d14baf805347d9a42dfd964ddddd56c79c06481ac46893
 SHA512:
-  metadata.gz: 7156629804899b663856449220ecb2e159b4d75ff29dc58634c19c7628e83bcf739bbfe779a507a23e111f2472729e2d9c42cd131544af01b341254565bde553
-  data.tar.gz: 35d4e8451d94797e33c7c9aecfc3d3e9484120ceabca55410b7fb20cd8f9705a8c83f792967f77080c29da2ce939fafd471cf16242613ff75894de4b23599656
+  metadata.gz: c73c3b8c22e7e5bdf5ad7847e408f4daa334cec0c8422a0f92a556ac0320e6353a3013cce7cee68816ddb241cc4864407159f3ced02839bf46d592510770de15
+  data.tar.gz: a28eb8a2e47f5d98a5221740f154bc768557e52738481945e6c623e4f60e18c712c7b3becbb0fcb54cc43db6b616ce9cd19395eb204fbd05dd49df9106c51169

data/.rubocop.yml

@@ -1,13 +1,4 @@
-AllCops:
-  TargetRubyVersion: 2.6
-
-Style/StringLiterals:
-  Enabled: true
-  EnforcedStyle: double_quotes
-
-Style/StringLiteralsInInterpolation:
-  Enabled: true
-  EnforcedStyle: double_quotes
-
-Layout/LineLength:
-  Max: 120
+inherit_gem: { kuyio-rubocop: rubocop-default.yml }
+inherit_mode:
+  merge:
+    - Exclude

data/CHANGELOG.md

@@ -1,5 +1,19 @@
 ## [Unreleased]
 
+## [1.0.0] - 2026-07-15
+
+- Update dependencies and bundler
+- Switch to kuyio-rubocop for shared lint configuration
+- Bump required Ruby version to >= 3.4.0
+- Add rubygems_mfa_required metadata to gemspec
+- Fix rubocop offenses (ASCII comments, ambiguous precedence, stale cop directives)
+- Add Makefile with build, test, clean, and deploy targets
+- Optimize Generator: resolve hash function once via Method#call instead of send
+- Simplify rgb2hex using format string
+- Avoid unnecessary array allocation in hash_bkdr
+- Extract repeated float constants (ONE_THIRD, ONE_SIXTH, TWO_THIRDS)
+- Clean up dead code and misleading float modulo
+
 ## [0.1.0] - 2022-12-15
 
 - Initial release

data/Gemfile

@@ -9,4 +9,4 @@ gem "rake", "~> 13.0"
 
 gem "rspec", "~> 3.0"
 
-gem "rubocop", "~> 1.21"
+gem "kuyio-rubocop", github: "kuyio/kuyio-rubocop"

data/Gemfile.lock

@@ -1,3 +1,13 @@
+GIT
+  remote: https://github.com/kuyio/kuyio-rubocop.git
+  revision: f7774235c8fddd1855cda03ea0415b5dad005621
+  specs:
+    kuyio-rubocop (0.4.1)
+      rubocop (~> 1.85.0)
+      rubocop-performance (~> 1.26.0)
+      rubocop-rails (~> 2.34.0)
+      rubocop-rspec (~> 3.9.0)
+
 PATH
   remote: .
   specs:
@@ -6,52 +16,114 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    ast (2.4.2)
-    diff-lcs (1.5.0)
-    json (2.6.2)
-    parallel (1.22.1)
-    parser (3.1.2.1)
+    activesupport (8.1.3)
+      base64
+      bigdecimal
+      concurrent-ruby (~> 1.0, >= 1.3.1)
+      connection_pool (>= 2.2.5)
+      drb
+      i18n (>= 1.6, < 2)
+      json
+      logger (>= 1.4.2)
+      minitest (>= 5.1)
+      securerandom (>= 0.3)
+      tzinfo (~> 2.0, >= 2.0.5)
+      uri (>= 0.13.1)
+    ast (2.4.3)
+    base64 (0.3.0)
+    bigdecimal (4.1.2)
+    concurrent-ruby (1.3.7)
+    connection_pool (3.0.2)
+    diff-lcs (1.6.2)
+    drb (2.2.3)
+    hana (1.3.7)
+    i18n (1.15.2)
+      concurrent-ruby (~> 1.0)
+    json (2.21.1)
+    json_schemer (2.5.0)
+      bigdecimal
+      hana (~> 1.3)
+      regexp_parser (~> 2.0)
+      simpleidn (~> 0.2)
+    language_server-protocol (3.17.0.6)
+    lint_roller (1.1.0)
+    logger (1.7.0)
+    mcp (0.24.0)
+      json_schemer (>= 2.4)
+    minitest (6.0.6)
+      drb (~> 2.0)
+      prism (~> 1.5)
+    parallel (1.28.0)
+    parser (3.3.11.1)
       ast (~> 2.4.1)
+      racc
+    prism (1.9.0)
+    racc (1.8.1)
+    rack (3.2.6)
     rainbow (3.1.1)
-    rake (13.0.6)
-    regexp_parser (2.6.1)
-    rexml (3.2.5)
-    rspec (3.11.0)
-      rspec-core (~> 3.11.0)
-      rspec-expectations (~> 3.11.0)
-      rspec-mocks (~> 3.11.0)
-    rspec-core (3.11.0)
-      rspec-support (~> 3.11.0)
-    rspec-expectations (3.11.1)
+    rake (13.4.2)
+    regexp_parser (2.12.0)
+    rspec (3.13.2)
+      rspec-core (~> 3.13.0)
+      rspec-expectations (~> 3.13.0)
+      rspec-mocks (~> 3.13.0)
+    rspec-core (3.13.6)
+      rspec-support (~> 3.13.0)
+    rspec-expectations (3.13.5)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.11.0)
-    rspec-mocks (3.11.1)
+      rspec-support (~> 3.13.0)
+    rspec-mocks (3.13.8)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.11.0)
-    rspec-support (3.11.1)
-    rubocop (1.36.0)
+      rspec-support (~> 3.13.0)
+    rspec-support (3.13.7)
+    rubocop (1.85.1)
       json (~> 2.3)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
+      mcp (~> 0.6)
       parallel (~> 1.10)
-      parser (>= 3.1.2.1)
+      parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8, < 3.0)
-      rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.20.1, < 2.0)
+      regexp_parser (>= 2.9.3, < 3.0)
+      rubocop-ast (>= 1.49.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.21.0)
-      parser (>= 3.1.1.0)
-    ruby-progressbar (1.11.0)
-    unicode-display_width (2.3.0)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.50.0)
+      parser (>= 3.3.7.2)
+      prism (~> 1.7)
+    rubocop-performance (1.26.1)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.75.0, < 2.0)
+      rubocop-ast (>= 1.47.1, < 2.0)
+    rubocop-rails (2.34.3)
+      activesupport (>= 4.2.0)
+      lint_roller (~> 1.1)
+      rack (>= 1.1)
+      rubocop (>= 1.75.0, < 2.0)
+      rubocop-ast (>= 1.44.0, < 2.0)
+    rubocop-rspec (3.9.0)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.81)
+    ruby-progressbar (1.13.0)
+    securerandom (0.4.1)
+    simpleidn (0.2.3)
+    tzinfo (2.0.6)
+      concurrent-ruby (~> 1.0)
+    unicode-display_width (3.2.0)
+      unicode-emoji (~> 4.1)
+    unicode-emoji (4.2.0)
+    uri (1.1.1)
 
 PLATFORMS
   arm64-darwin-21
+  arm64-darwin-24
+  x86_64-linux
 
 DEPENDENCIES
   color_hash!
+  kuyio-rubocop!
   rake (~> 13.0)
   rspec (~> 3.0)
-  rubocop (~> 1.21)
 
 BUNDLED WITH
-   2.3.17
+  4.0.6

data/Makefile

@@ -0,0 +1,21 @@
+.PHONY: build test clean deploy lint rubocop spec
+
+build: clean
+	gem build color_hash.gemspec
+
+test: lint spec
+
+lint: rubocop
+
+rubocop:
+	bundle exec rubocop
+
+spec:
+	bundle exec rspec
+
+clean:
+	rm -f color_hash-*.gem
+	rm -rf pkg
+
+deploy: build
+	gem push color_hash-*.gem

data/lib/color_hash/generator.rb

@@ -36,65 +36,59 @@ module ColorHash
       @lightness = lightness
       @saturation = saturation
       @hue = hue
-      @hash_func = hash
+      @hash_method = method(:"hash_#{hash}")
     end
 
-    # Magic
     HUE_RESOLUTION = 727
+    ONE_THIRD = 1.0 / 3.0
+    ONE_SIXTH = 1.0 / 6.0
+    TWO_THIRDS = 2.0 / 3.0
 
-    # rubocop:disable Metrics/AbcSize
     # Calculates an HSL color value returned as an Array of the form [H, S, L]
     # from a given string.
     #
-    # H Hue ∈ [0, 360)
-    # S Saturation ∈ [0, 1]
-    # L Lightness ∈ [0, 1]
+    # H Hue in [0, 360)
+    # S Saturation in [0, 1]
+    # L Lightness in [0, 1]
     def hsl(str)
-      hash = send("hash_#{@hash_func}", str)
+      hash = @hash_method.call(str)
 
       hr = @hue[hash % @hue.count]
-      h = ((hash / @hue.count) % HUE_RESOLUTION) * (hr[:max] - hr[:min]) / HUE_RESOLUTION + hr[:min]
-
-      # h = hash % 359
+      h = (((hash / @hue.count) % HUE_RESOLUTION) * (hr[:max] - hr[:min]) / HUE_RESOLUTION) + hr[:min]
 
       hash = (hash / 360.0).ceil
-      s = @saturation[hash % @saturation.count.to_f]
+      s = @saturation[hash % @saturation.count]
 
       hash = (hash / @saturation.count.to_f).ceil
       l = @lightness[hash % @lightness.count]
 
       [h, s, l]
     end
-    # rubocop:enable Metrics/AbcSize
 
     # Calculates an RGB color value returned as an Array of the form [R, G, B]
     # from a given string.
     #
-    # R, G, B ∈ [0, 255]
+    # R, G, B in [0, 255]
     def rgb(str)
       hsl2rgb(*hsl(str))
     end
 
-    # rubocop:disable Metrics/AbcSize
-    # rubocop:disable Metrics/CyclomaticComplexity
-    # rubocop:disable Metrics/PerceivedComplexity
-    # rubocop:disable Metrics/MethodLength
     # Converts a color specified by its hue, saturation and lightness to an RGB value
     def hsl2rgb(hue, saturation, lightness)
       hue /= 360.0
       q_factor = lightness < 0.5 ? lightness * (1.0 + saturation) : (lightness + saturation) - (lightness * saturation)
-      p_factor = 2.0 * lightness - q_factor
+      p_factor = (2.0 * lightness) - q_factor
 
-      [hue + (1.0 / 3.0), hue, hue - (1.0 / 3.0)].map do |color|
-        color += 1.0 if (color / 0.5) < 0.0
-        color -= 1.0 if color > 1
+      [hue + ONE_THIRD, hue, hue - ONE_THIRD].map do |color|
+        color += 1.0 if color < 0.0
+        color -= 1.0 if color > 1.0
 
-        color = if color < (1.0 / 6.0)
-                  p_factor + (q_factor - p_factor) * 6.0 * color
+        color = if color < ONE_SIXTH
+                  p_factor + ((q_factor - p_factor) * 6.0 * color)
                 elsif color < 0.5
                   q_factor
-                elsif color < (2.0 / 3.0)
-                  p_factor + (q_factor - p_factor) * 6.0 * ((2.0 / 3.0) - color)
+                elsif color < TWO_THIRDS
+                  p_factor + ((q_factor - p_factor) * 6.0 * (TWO_THIRDS - color))
                 else
                   p_factor
                 end
@@ -102,10 +96,6 @@ module ColorHash
         (color * 255.0).round
       end
     end
-    # rubocop:enable Metrics/AbcSize
-    # rubocop:enable Metrics/CyclomaticComplexity
-    # rubocop:enable Metrics/PerceivedComplexity
-    # rubocop:enable Metrics/MethodLength
 
     # Calculates an Hexadecimal color value from a given string.
     # Returns a 6 digits hex string starting with '#'.
@@ -113,15 +103,8 @@ module ColorHash
       rgb2hex(rgb(str))
     end
 
-    # Convers a color specified by its RGB value to a hexadecimal color value.
     def rgb2hex(rgb)
-      hex = "#"
-      rgb.each do |c|
-        hex += "0" if c < 16
-        hex += c.to_s(16)
-      end
-
-      hex
+      format("#%02x%02x%02x", *rgb)
     end
 
     # Calculate a SHA2-256 based hash of the given string
@@ -142,9 +125,9 @@ module ColorHash
       str += "x"
       # Number.MAX_SAFE_INTEGER equals 9007199254740991
       max_safe = 9_007_199_254_740_991 / seed2
-      str.each_codepoint.map do |c|
+      str.each_codepoint do |c|
         hash = (hash / seed2).floor if hash > max_safe
-        hash = hash * seed + c
+        hash = (hash * seed) + c
       end
 
       hash

data/lib/color_hash/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ColorHash
-  VERSION = "0.1.0"
+  VERSION = "1.0.0"
 end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: color_hash
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Nicolas Bettenburg
-autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-12-15 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies: []
 description: Generate a color based on the given string (in the HSL color space).
 email:
@@ -22,9 +21,9 @@ files:
 - CHANGELOG.md
 - Gemfile
 - Gemfile.lock
+- Makefile
 - README.md
 - Rakefile
-- color_hash.gemspec
 - lib/color_hash.rb
 - lib/color_hash/generator.rb
 - lib/color_hash/version.rb
@@ -36,7 +35,7 @@ metadata:
   homepage_uri: https://github.com/kuyio/color_hash
   source_code_uri: https://github.com/kuyio/color_hash
   changelog_uri: https://github.com/kuyio/color_hash/CHANGELOG.md
-post_install_message:
+  rubygems_mfa_required: 'true'
 rdoc_options: []
 require_paths:
 - lib
@@ -44,15 +43,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.6.0
+      version: 3.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.17
-signing_key:
+rubygems_version: 4.0.6
 specification_version: 4
 summary: Generate a color based on the given string.
 test_files: []

data/color_hash.gemspec

@@ -1,32 +0,0 @@
-# frozen_string_literal: true
-
-require_relative "lib/color_hash/version"
-
-Gem::Specification.new do |spec|
-  spec.name = "color_hash"
-  spec.version = ColorHash::VERSION
-  spec.authors = ["Nicolas Bettenburg"]
-  spec.email = ["nicbet@kuy.io"]
-
-  spec.summary = "Generate a color based on the given string."
-  spec.description = "Generate a color based on the given string (in the HSL color space)."
-  spec.homepage = "https://github.com/kuyio/color_hash"
-  spec.required_ruby_version = ">= 2.6.0"
-
-  spec.metadata["allowed_push_host"] = "https://rubygems.org"
-
-  spec.metadata["homepage_uri"] = spec.homepage
-  spec.metadata["source_code_uri"] = "https://github.com/kuyio/color_hash"
-  spec.metadata["changelog_uri"] = "https://github.com/kuyio/color_hash/CHANGELOG.md"
-
-  # Specify which files should be added to the gem when it is released.
-  # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
-  spec.files = Dir.chdir(__dir__) do
-    `git ls-files -z`.split("\x0").reject do |f|
-      (f == __FILE__) || f.match(%r{\A(?:(?:doc|bin|test|spec|features)/|\.(?:git|travis|circleci)|appveyor)})
-    end
-  end
-  spec.bindir = "exe"
-  spec.executables = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
-  spec.require_paths = ["lib"]
-end