collector 0.1.5 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a6e634cfe44d090ae1ade6406c86595bcb09123b
-  data.tar.gz: 5ffa356d4b6b394c424c837338aa9cfec1fa0378
+  metadata.gz: f528e577d42419e81eaf07fc74f5b6883f505a12
+  data.tar.gz: f5c1caf252cbf1bac5a82067d71e17f25737d51d
 SHA512:
-  metadata.gz: de32f9ebf2e8d54ee2dcc225c4e5e46e82d021569ee6c5764e2885a4ac9d54b2bffc7afa225558efb3088059820b431a6d40b6e65ce92a2b19c00880e04e7273
-  data.tar.gz: 1120eb5efde0bdd1d8e9deda7a9ec5d1953821e227a8c1fe80680cbf52ff54522496b6e7322024c2cbadae01213f09d22005e6a6b0fc69f72a6d4a120bd3582e
+  metadata.gz: f461a77fb15f478eead83a5f82ec1e401ebeb9597d716839314afdd587e024043c1e6cf41e296b85fa5358ecde8c084735284aef511e6146392ed5ce10aa79a2
+  data.tar.gz: 6890cd548912d835d085d863a0be8cc82582589ac7344833eabcd407d93c020cdab0e12d7dd62adbef6e2ba1440585be177a10f1893c9724c19af8e1389b2b17

data/lib/collector/repository.rb

@@ -41,7 +41,7 @@ module Collector
 
       def serialize!(model)
         attributes = serialize(model)
-        attributes["_id"] = BSON::ObjectId.from_string(attributes.delete("id")) if attributes["id"]
+        attributes["_id"] = normalize_id(attributes.delete("id")) if attributes["id"]
         attributes.reject! { |key, val| val.nil? }
         attributes
       end

data/lib/collector/version.rb

@@ -1,3 +1,3 @@
 module Collector
-  VERSION = "0.1.5"
+  VERSION = "0.1.6"
 end

data/test/collector/repository_spec.rb

@@ -78,11 +78,16 @@ describe Collector::Repository do
   end
 
   describe "serialize!" do
-    it "normalize id to _id and converts to a BSON::ObjectId" do
+    it "normalize id to _id and normalize to an ObjectId" do
       model = mock(attributes: { id: "50c58f4ab392d4381a000001", foo: "bar" })
       TestModelRepository.serialize!(model).must_equal({ "_id" => BSON::ObjectId("50c58f4ab392d4381a000001"), "foo" => "bar" })
     end
 
+    it "normalize id to _id and leave it as a string if it is not an ObjectId" do
+      model = mock(attributes: { id: "some-string", foo: "bar" })
+      TestModelRepository.serialize!(model).must_equal({ "_id" => "some-string", "foo" => "bar" })
+    end
+
     it "returns a model's attributes without nil values" do
       model = mock(attributes: { foo: "bar", nothing: nil })
       TestModelRepository.serialize!(model).must_equal({ "foo" => "bar" })

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: collector
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.6
 platform: ruby
 authors:
 - Brandon Weiss