collection_json_serializer 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a38b7d4dc38ed5c1bed4033818d2e69968be6720
-  data.tar.gz: b52f5ce2efdc98b2ed6c18a75d634c61592ffff4
+  metadata.gz: 120a86d520ebce948248bd32a6c3e894ff46661c
+  data.tar.gz: 7cd6a7fadbc9b783e3da6c95e95e1bedcb079e50
 SHA512:
-  metadata.gz: 56aa051a9b31a5b8da6e218c62a75dde366d1a92fdffe55ba55340fe480954a74c212aea2715f3379a308e549f60cec1ecfad4736cb7671b2132d6954adf9d7f
-  data.tar.gz: 4946c642a0ed91dca00879ef01bf5d73c998912747434be345d7bc5c1dc7137e1673f8b4700e3b5966713964b196dd7305e94f8897ac2e5ff6880c84d499b9cd
+  metadata.gz: 15949ebd3af294d4f58fda0b7779f77ef70b88ef269c2bdabc035c5c5f0c88c9ffa01282765cd1dfcb7d0f5152605c9c3d4f115afa7ce8ac42a92403dd7ae690
+  data.tar.gz: 2295bf1900c61c5b1f5691bb0d18b4e689c80db69e2dbd5e461971299edb2af7a88c0006e74fe2f8f3d0a7412862b5b8b0c804d19a3e47a0f9ca90e07358cac1

data/README.md

@@ -149,17 +149,23 @@ Please, notice that placeholders can _only_ be used within the `items` block.
 
 #### Open Attributes Policy
 
-Collection+JSON serializer has an __open attributes policy__, which means that objects' attributes can be extended at will. That is good if you want to use many of the [extensions available](https://github.com/collection-json/extensions), and also if you need to add custom extensions to suit your particular needs. Be aware that, [as the specs say](https://github.com/collection-json/spec#7-extensibility), you must only extend attributes in a way that won't break clients that are not aware of them.
+Collection+JSON Serializer introduces an __open attributes policy__, which means that objects' attributes can be extended at will. This makes it easy to add custom extensions to suit your particular needs. Be aware that, [as the specs say](https://github.com/collection-json/spec#7-extensibility), you must only extend attributes in a way that won't break clients that are not aware of them.
+
+In order to use the Open Attributes policy, it must be declared as an extension.
 
 ```ruby
 class UserSerializer < CollectionJson::Serializer
+  # Add Open Attrs as an extension
+  extensions :open_attrs
+
+  # Now you can use your crazy properties everywhere
   items do
     attributes :id, name: { css_class: "people" }
   end
 
   template name: { regex: "/\A[a-zA-Z0-9_]*\z/" }
 
-  links profile: { css_class: "button" }
+  links profile: { on_click: "reboot_universe" }
 end
 ```
 

data/lib/collection_json_serializer.rb

@@ -7,7 +7,7 @@ require "collection_json_serializer/support"
 
 require "collection_json_serializer/serializer"
 require "collection_json_serializer/items"
-
+require "collection_json_serializer/spec"
 require "collection_json_serializer/builder"
 
 require "collection_json_serializer/validator"

data/lib/collection_json_serializer/core_ext/hash.rb

@@ -1,4 +1,11 @@
 class Hash
+  # Extract params
+  # Returns a two-key hash where the first key is :name and the second is
+  # :properties, being the latter a hash itself.
+  #
+  # hash = { hi: { prompt: "My prompt", value: "Hello!" } }
+  # hash.extract_params
+  # => { name: "hi", properties: { prompt: "My prompt", value: "Hello!" } }
   def extract_params
     params = {}
     params[:name] = keys.first

data/lib/collection_json_serializer/objects/query.rb

@@ -19,6 +19,10 @@ module CollectionJson
           @query[:prompt] = @resource[:prompt] if @resource[:prompt]
           @query[:data]   = add_data if @resource[:data]
 
+          if @serializer.uses?(:open_attrs)
+            @resource.each { |k, v| @query[k] = v unless @query.key?(k) }
+          end
+
           @query
         end
 
@@ -30,7 +34,10 @@ module CollectionJson
 
         def add_data
           @resource[:data].each_with_object([]) do |attr, data|
-            data << { name: attr[:name], value: nil.to_s }
+            h = Hash.new
+            attr.keys.each { |k| h[k] = attr[k] }
+            h[:value] = nil.to_s unless h[:value]
+            data << h
           end
         end
 

data/lib/collection_json_serializer/serializer.rb

@@ -1,6 +1,7 @@
 module CollectionJson
   class Serializer
     class << self
+      attr_accessor :extensions
       attr_accessor :href
       attr_accessor :template
       attr_accessor :links
@@ -9,12 +10,17 @@ module CollectionJson
     end
 
     def self.inherited(base)
+      base.extensions = []
       base.href = []
       base.template = []
       base.links = []
       base.queries = []
     end
 
+    def self.extensions(*attrs)
+      @extensions.concat attrs
+    end
+
     def self.href(*attrs)
       @href.concat attrs
     end
@@ -46,6 +52,10 @@ module CollectionJson
                    end
     end
 
+    def extensions
+      self.class.extensions
+    end
+
     def href
       self.class.href.first
     end
@@ -82,6 +92,10 @@ module CollectionJson
       self.class._items.present?
     end
 
+    def uses?(extension)
+      extensions.include?(extension)
+    end
+
     def invalid?
       Validator.new(self).invalid?
     end

data/lib/collection_json_serializer/spec.rb

@@ -0,0 +1,50 @@
+module CollectionJson
+  module Spec
+    DEFINITION = {
+      href: {},
+      links: {
+        href: {},
+        rel: {},
+        name: {},
+        prompt: {},
+        render: {}
+      },
+      items: {
+        href: {},
+        data: {
+          name: {},
+          value: {},
+          prompt: {}
+        },
+        links: {
+          href: {},
+          rel: {},
+          name: {},
+          prompt: {},
+          remder: {}
+        }
+      },
+      template: {
+        name: {},
+        value: {},
+        prompt: {}
+      },
+      queries: {
+        href: {},
+        rel: {},
+        name: {},
+        prompt: {},
+        data: {
+          name: {},
+          value: {}
+        }
+      },
+      error: {
+        title: {},
+        code: {},
+        message: {}
+      }
+    }
+  end
+end
+

data/lib/collection_json_serializer/validator.rb

@@ -23,7 +23,7 @@ module CollectionJson
 
       def validate
         [
-          :attributes,
+          :items,
           :href,
           :links,
           :template,
@@ -31,24 +31,58 @@ module CollectionJson
         ].each { |m| send("validate_#{m}") }
       end
 
-      def validate_attributes
+      def validate_items
+        validate_items_attributes   if attributes?
+        validate_items_links        if links?
+      end
+
+      def validate_items_attributes
         @serializer.items.attributes.each do |attr|
           params = attr.extract_params
+          validate_attributes_values(@serializer.resources, params)
+          validate_attributes_properties(params) if params[:properties]
+        end if @serializer.items? && @serializer.items.attributes?
+      end
 
-          @serializer.resources.each do |resource|
-            val = extract_value_from(resource, params[:name])
-            if value_is_invalid? val
-              error_for :value, root: :attributes, path: [params[:name]]
-            end
+      def validate_attributes_values(resources, params)
+        resources.each do |resource|
+          val = extract_value_from(resource, params[:name])
+          if value_is_invalid?(val)
+            error_for :value, root: :attributes, path: [params[:name]]
           end
+        end
+      end
 
-          params[:properties].each do |key, value|
-            if value_is_invalid? value
-              error_for :value, root: :attributes, path: [params[:name], key]
-            end
-          end if params[:properties]
+      def validate_attributes_properties(params)
+        params[:properties].each do |key, value|
+          unless definition[:items][:data].keys.include?(key.to_sym)
+            error_for(
+              :unknown_attribute,
+              root: :attributes,
+              path: [params[:name], key]
+            )
+            next
+          end unless @serializer.uses?(:open_attrs)
+
+          if value_is_invalid?(value)
+            error_for :value, root: :attributes, path: [params[:name], key]
+          end
+        end
+      end
 
-        end if @serializer.items && @serializer.items.attributes.any?
+      def validate_items_links
+        @serializer.items.links.each do |attr|
+          params = attr.extract_params
+          params[:properties].keys.each do |key|
+            unless definition[:items][:links].keys.include?(key.to_sym)
+              error_for(
+                :unknown_attribute,
+                root: :items,
+                path: [:links, params[:name], key]
+              )
+            end unless @serializer.uses?(:open_attrs)
+          end
+        end
       end
 
       def validate_href
@@ -72,6 +106,11 @@ module CollectionJson
           end
 
           link.each do |key, value|
+            unless definition[:links].keys.include?(key.to_sym)
+              error_for :unknown_attribute, root: :links, path: [key]
+              next
+            end unless @serializer.uses?(:open_attrs)
+
             case key
             when :href
               if url_is_invalid? link[:href]
@@ -91,7 +130,16 @@ module CollectionJson
           params = attr.extract_params
 
           params[:properties].each do |key, value|
-            if value_is_invalid? value
+            unless definition[:template].keys.include?(key.to_sym)
+              error_for(
+                :unknown_attribute,
+                root: :template,
+                path: [params[:name], key]
+              )
+              next
+            end unless @serializer.uses?(:open_attrs)
+
+            if value_is_invalid?(value)
               error_for :value, root: :template, path: [params[:name], key]
             end
           end if params[:properties]
@@ -103,7 +151,7 @@ module CollectionJson
         @serializer.queries.each do |query|
           params = query.extract_params
 
-          unless params[:properties].key? :href
+          unless params[:properties].key?(:href)
             error_for :missing_attribute,
                       root: :queries,
                       path: [params[:name], "href"]
@@ -111,12 +159,19 @@ module CollectionJson
             next
           end
 
-          if url_is_invalid? params[:properties][:href]
+          if url_is_invalid?(params[:properties][:href])
             error_for :url, root: :queries, path: [params[:name], "href"]
           end
 
           params[:properties].each do |key, value|
             next if key == :data || key == :href
+            unless definition[:queries].keys.include?(key.to_sym)
+              error_for(
+                :unknown_attribute,
+                root: :queries,
+                path: [params[:name], key]
+              )
+            end unless @serializer.uses?(:open_attrs)
 
             if value_is_invalid?(value)
               error_for :value, root: :queries, path: [params[:name], key]
@@ -125,6 +180,16 @@ module CollectionJson
 
           if params[:properties].key?(:data)
             params[:properties][:data].each do |hash|
+              hash.keys.each do |key|
+                unless definition[:queries][:data].keys.include?(key)
+                  error_for(
+                    :unknown_attribute,
+                    root: :queries,
+                    path: [params[:name], :data, key]
+                  )
+                end unless @serializer.uses?(:open_attrs)
+              end
+
               if value_is_invalid?(hash[:name])
                 error_for :value,
                           root: :queries,
@@ -153,6 +218,8 @@ module CollectionJson
           ending = " is an invalid value"
         when :missing_attribute
           ending = " is missing"
+        when :unknown_attribute
+          ending = " is an unknown attribute"
         else
           ending = " is an invalid value"
         end
@@ -163,6 +230,18 @@ module CollectionJson
         e << ending
         @errors[root] << e
       end
+
+      def definition
+        CollectionJson::Spec::DEFINITION
+      end
+
+      def attributes?
+        @serializer.items? && @serializer.items.attributes?
+      end
+
+      def links?
+        @serializer.items? && @serializer.items.links?
+      end
     end
   end
 end

data/lib/collection_json_serializer/version.rb

@@ -1,5 +1,5 @@
 module CollectionJson
   class Serializer
-    VERSION = "0.3.0"
+    VERSION = "0.3.1"
   end
 end

data/test/builder/builder_test.rb

@@ -153,25 +153,6 @@ module CollectionJson
           assert_equal expected.to_json, builder.to_json
         end
 
-        def test_that_any_attributes_can_be_passed_to_template
-          custom_serializer = CustomTemplateSerializer.new(@user1)
-          builder = Builder.new(custom_serializer)
-
-          expected = {
-            collection: {
-              version: "1.0",
-              template: {
-                data: [
-                  { name: "name", value: "" },
-                  { name: "email", value: "", prompt: "My email", anything: "at all", whatever: "really" }
-                ]
-              }
-            }
-          }
-
-          assert_equal expected.to_json, builder.to_json
-        end
-
         def test_that_an_invalid_serializer_raises_an_error
           invalid_serializer = InvalidSerializer.new(@user1)
           builder = Builder.new(invalid_serializer)

data/test/extensions/open_attrs_test.rb

@@ -0,0 +1,118 @@
+require "minitest_helper"
+
+module CollectionJson
+  class Serializer
+    class TestOpenAttrs < Minitest::Test
+      include TestHelper
+
+      def setup
+        @user = User.new(name: "Carles Jove", email: "hola@carlus.cat")
+        @serializer = empty_serializer_for(@user)
+        @serializer.class.extensions = [:open_attrs]
+        @serializer.class.template = [
+          email: {
+            prompt: "My email",
+            anything: "at all"
+          }
+        ]
+        @serializer.items.attributes = [
+          name:
+          {
+            anything: "at all"
+          }
+        ]
+        @serializer.items.links = [
+          dashboard: {
+            # TODO
+            # This URL shouldn't validate!
+            href: "/my-dashboard",
+            anything: "at all"
+          }
+        ]
+        @serializer.class.links = [
+          dashboard: {
+            href: "http://example.com/my-dashboard",
+            anything: "at all"
+          }
+        ]
+        @serializer.class.queries = [
+          search: {
+            href: "http://example.com/search",
+            rel: "search",
+            whatever: "doesn't matter",
+            data: [
+              name: "required",
+              anything: "at all"
+            ]
+          }
+        ]
+      end
+
+      def test_that_serializer_is_valid_using_open_attrs
+        assert @serializer.valid?, "#{@serializer} should be valid"
+      end
+
+      def test_that_a_collection_can_be_built_using_open_attrs
+        builder = Builder.new(@serializer)
+        expected = {
+          collection: {
+            version: "1.0",
+            items: [
+              {
+                data: [
+                  {
+                    name: "name",
+                    value: "Carles Jove",
+                    anything: "at all"
+                  }
+                ],
+                links: [
+                  {
+                    rel: "dashboard",
+                    href: "/my-dashboard",
+                    name: "dashboard",
+                    anything: "at all",
+                  }
+                ]
+              }
+            ],
+            links: [
+              {
+                rel: "dashboard",
+                href: "http://example.com/my-dashboard",
+                name: "dashboard",
+                anything: "at all",
+              }
+            ],
+            template: {
+              data: [
+                {
+                  name: "email",
+                  value: "",
+                  prompt: "My email",
+                  anything: "at all"
+                }
+              ]
+            },
+            queries: [
+              {
+                href: "http://example.com/search",
+                name: "search",
+                whatever: "doesn't matter",
+                rel: "search",
+                data: [
+                  name: "required",
+                  anything: "at all",
+                  value: ""
+                ]
+              }
+            ]
+          }
+        }
+
+        assert_equal JSON(expected.to_json), JSON(builder.to_json)
+      end
+    end
+  end
+end
+

data/test/minitest_helper.rb

@@ -13,6 +13,7 @@ require "active_support/inflector"
 module TestHelper
   def empty_serializer_for(object)
     serializer = CollectionJson::Serializer.new(object)
+    serializer.class.extensions = []
     serializer.class.href = []
     serializer.class.links = []
     serializer.class.template = []

data/test/objects/item_test.rb

@@ -68,38 +68,6 @@ module CollectionJson
             assert_equal expected.to_json, item.create.to_json
           end
 
-          def test_that_an_item_can_be_build_with_random_attributes
-            custom_serializer = CustomItemSerializer.new(@user1)
-            item = Item.new(custom_serializer)
-
-            expected = {
-              data: [{
-                name: "name",
-                value: "Carles Jove",
-                anything: "at all",
-                whatever: "really"
-              }]
-            }
-            assert_equal expected.to_json, item.create.to_json
-          end
-
-          def test_that_an_item_link_can_be_build_with_unlimited_attributes
-            custom_serializer = CustomItemLinksSerializer.new(@user1)
-            item = Item.new(custom_serializer)
-
-            expected = {
-              links: [{
-                rel: "dashboard",
-                name: "dashboard",
-                href: "/my-dashboard",
-                anything: "at all",
-                whatever: "really"
-              }]
-            }
-
-            assert_equal expected[:links], item.create[:links]
-          end
-
           def test_that_unknown_attributes_are_silently_ignored
             serializer = empty_serializer_for(@user1)
             serializer.items.attributes(:unknown)

data/test/serializer/dsl_test.rb

@@ -0,0 +1,28 @@
+require "minitest_helper"
+
+module CollectionJson
+  class Serializer
+    class TestDSL < Minitest::Test
+      def setup
+        @user = User.new(name: "Carles Jove", email: "hola@carlus.cat")
+        @serializer = Serializer.new(@user)
+      end
+
+      def test_top_level_dsl
+        assert @serializer.respond_to?(:href)
+        assert @serializer.respond_to?(:links)
+        assert @serializer.respond_to?(:template)
+        assert @serializer.respond_to?(:queries)
+        assert @serializer.respond_to?(:items)
+        assert @serializer.respond_to?(:extensions)
+      end
+
+      def test_items_dsl
+        assert_equal Items, @serializer.items.class
+        assert @serializer.items.respond_to?(:attributes)
+        assert @serializer.items.respond_to?(:links)
+        assert @serializer.items.respond_to?(:href)
+      end
+    end
+  end
+end

data/test/serializer/items/attributes_test.rb

@@ -11,19 +11,6 @@ module CollectionJson
       def test_attributes_properties
         assert_equal [:name, :email], @user_serializer.items.attributes
       end
-
-      def test_that_any_attributes_can_be_passed
-        custom_serializer = CustomItemSerializer.new(@user)
-        expected = [
-          name:
-          {
-            anything: "at all",
-            whatever: "really"
-          }
-        ]
-
-        assert_equal expected, custom_serializer.items.attributes
-      end
     end
   end
 end

data/test/serializer/links_test.rb

@@ -14,18 +14,6 @@ module CollectionJson
         expected = [dashboard: { href: "http://example.com/my-dashboard" }]
         assert_equal expected, @user_serializer.class.links
       end
-
-      def test_item_links_attributes_can_take_unlimited_properties
-        custom_serializer = empty_serializer_for(@user)
-        links = { dashboard: {
-          href: "/my-dashboard",
-          anything: "at all",
-          whatever: "really"
-        } }
-        custom_serializer.class.links links
-
-        assert_equal [links], custom_serializer.class.links
-      end
     end
   end
 end

data/test/serializer/serializer_test.rb

@@ -0,0 +1,24 @@
+require "minitest_helper"
+
+# Here we test Serializer's stuff _other_ than the DSL and Validations
+# - For the DSL tests, check serializer/dsl_test.rb
+# - For validation tests, check validator/validator_test.rb 
+module CollectionJson
+  class Serializer
+    class TestSerializer < Minitest::Test
+      include TestHelper
+
+      def setup
+        @user = User.new(name: "Carles Jove", email: "hola@carlus.cat")
+        @serializer = empty_serializer_for(@user)
+      end
+
+      def test_uses_method
+        @serializer.class.extensions(:open_attrs, :another_ext)
+        assert @serializer.uses?(:open_attrs)
+        assert @serializer.uses?(:another_ext)
+        refute @serializer.uses?(:unexistent_ext)
+      end
+    end
+  end
+end

data/test/serializer/spec_test.rb

@@ -0,0 +1,70 @@
+require "minitest_helper"
+
+module CollectionJson
+  module Spec
+    class TestSpec < Minitest::Test
+      include TestHelper
+
+      def test_that_random_attributes_cannot_be_passed
+        serializer = empty_serializer_for(@user)
+        serializer.items.attributes = [
+          name: { unknown: "this should not be valid" }
+        ]
+        serializer.items.links = serializer.class.links = [
+          dashboard: {
+            href: "http://example.com",
+            unknown: "this should not be valid"
+          }
+        ]
+        serializer.class.template = [
+          name: { whatever: "this should not be valid" }
+        ]
+        serializer.class.queries = [
+          name: {
+            href: "http://example.com",
+            whatever: "this should be invalid",
+            data: [
+              unknown: "this should be invalid"
+            ]
+          }
+        ]
+
+        assert serializer.invalid?,
+               "#{serializer.inspect} should be invalid"
+
+        # Items attributes
+        assert serializer.errors.key?(:attributes),
+               "#{serializer.errors.inspect} should have key attributes"
+        assert serializer.errors[:attributes][0].
+          include?("attributes:name:unknown is an unknown attribute"),
+               "#{serializer.errors[:attributes]} should include 'unknown attribute'"
+
+        # Items links
+        assert serializer.errors.key?(:items),
+               "#{serializer.errors.inspect} should have key attributes"
+        assert serializer.errors[:items][0].
+          include?("items:links:dashboard:unknown is an unknown attribute")
+
+        # Links
+        assert serializer.errors.key?(:links), "should have error for 'links'"
+        assert serializer.errors[:links][0].
+          include?("links:unknown is an unknown attribute")
+
+        # Template
+        assert serializer.errors.key?(:template),
+               "should have error for 'template'"
+        assert serializer.errors[:template][0].
+          include?("template:name:whatever is an unknown attribute")
+
+        # Queries
+        assert serializer.errors.key?(:queries),
+               "should have error for 'queries'"
+        assert serializer.errors[:queries][0].
+          include?("queries:name:whatever is an unknown attribute")
+        assert serializer.errors[:queries][1].
+          include?("queries:name:data:unknown is an unknown attribute")
+      end
+    end
+  end
+end
+

data/test/serializer/template_test.rb

@@ -11,20 +11,6 @@ module CollectionJson
       def test_template_attributes
         assert_equal [:name, email: { prompt: "My email" }], @user_serializer.class.template
       end
-
-      def test_that_any_attributes_can_be_passed
-        custom_serializer = CustomTemplateSerializer.new(@user)
-        expected = [
-          :name,
-          email: {
-            prompt: "My email",
-            anything: "at all",
-            whatever: "really"
-          }
-        ]
-
-        assert_equal expected, custom_serializer.class.template
-      end
     end
   end
 end

data/test/validator/invalid_test.rb

@@ -94,8 +94,7 @@ module CollectionJson
           @invalid_value_types.each do |invalidate|
             @invalid.items.attributes = [
               name: {
-                prompt: invalidate,
-                test: invalidate
+                prompt: invalidate
               }
             ]
 
@@ -105,8 +104,6 @@ module CollectionJson
                    "#{invalidate} should be invalid"
             assert @invalid.errors[:attributes][0].
                     include? "attributes:name:prompt is an invalid value"
-            assert @invalid.errors[:attributes][1].
-                    include? "attributes:name:test is an invalid value"
           end
         end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: collection_json_serializer
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Carles Jove i Buxeda
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-10 00:00:00.000000000 Z
+date: 2015-01-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -90,12 +90,14 @@ files:
 - lib/collection_json_serializer/objects/query.rb
 - lib/collection_json_serializer/objects/template.rb
 - lib/collection_json_serializer/serializer.rb
+- lib/collection_json_serializer/spec.rb
 - lib/collection_json_serializer/support.rb
 - lib/collection_json_serializer/validator.rb
 - lib/collection_json_serializer/validator/url.rb
 - lib/collection_json_serializer/validator/value.rb
 - lib/collection_json_serializer/version.rb
 - test/builder/builder_test.rb
+- test/extensions/open_attrs_test.rb
 - test/fixtures/models.rb
 - test/fixtures/poro.rb
 - test/fixtures/serializers/custom_item_links_serializer.rb
@@ -108,13 +110,15 @@ files:
 - test/objects/item_test.rb
 - test/objects/queries_test.rb
 - test/objects/template_test.rb
+- test/serializer/dsl_test.rb
 - test/serializer/href_test.rb
 - test/serializer/items/attributes_test.rb
 - test/serializer/items/href_test.rb
 - test/serializer/items/links_test.rb
-- test/serializer/items_test.rb
 - test/serializer/links_test.rb
 - test/serializer/queries_test.rb
+- test/serializer/serializer_test.rb
+- test/serializer/spec_test.rb
 - test/serializer/template_test.rb
 - test/support/ext_test.rb
 - test/support/support_test.rb
@@ -148,6 +152,7 @@ specification_version: 4
 summary: Serialize objects as Collection+JSON.
 test_files:
 - test/builder/builder_test.rb
+- test/extensions/open_attrs_test.rb
 - test/fixtures/models.rb
 - test/fixtures/poro.rb
 - test/fixtures/serializers/custom_item_links_serializer.rb
@@ -160,13 +165,15 @@ test_files:
 - test/objects/item_test.rb
 - test/objects/queries_test.rb
 - test/objects/template_test.rb
+- test/serializer/dsl_test.rb
 - test/serializer/href_test.rb
 - test/serializer/items/attributes_test.rb
 - test/serializer/items/href_test.rb
 - test/serializer/items/links_test.rb
-- test/serializer/items_test.rb
 - test/serializer/links_test.rb
 - test/serializer/queries_test.rb
+- test/serializer/serializer_test.rb
+- test/serializer/spec_test.rb
 - test/serializer/template_test.rb
 - test/support/ext_test.rb
 - test/support/support_test.rb

data/test/serializer/items_test.rb

@@ -1,24 +0,0 @@
-require "minitest_helper"
-
-module CollectionJson
-  class Serializer
-    class TestItems < Minitest::Test
-      def setup
-        @user = User.new(name: "Carles Jove", email: "hola@carlus.cat")
-        @user_serializer = UserSerializer.new(@user)
-      end
-
-      def test_an_items_instance_is_created
-        assert_equal Items, @user_serializer.items.class
-      end
-
-      def test_that_items_has_an_attributes_dsl
-        assert @user_serializer.items.respond_to?(:attributes)
-      end
-
-      def test_that_items_has_a_links_dsl
-        assert @user_serializer.items.respond_to?(:links)
-      end
-    end
-  end
-end