collavre 0.5.0 → 0.7.0

data/app/javascript/controllers/comments/review_quotes_store.js

@@ -0,0 +1,189 @@
+/**
+ * ReviewQuotesStore — Pure state management for review quote chips.
+ *
+ * Responsible for:
+ *   - Adding / removing / updating quotes
+ *   - Tracking the active (editing) quote
+ *   - Building markdown content for submission
+ *   - Backup / restore for send-failure rollback
+ *
+ * Does NOT touch the DOM — the controller handles all rendering.
+ */
+let _nextId = 1
+
+export default class ReviewQuotesStore {
+  constructor() {
+    this._quotes = []
+    this._activeId = null
+    this._backup = null
+  }
+
+  // --- Accessors ---
+
+  get quotes() {
+    return this._quotes
+  }
+
+  get activeId() {
+    return this._activeId
+  }
+
+  set activeId(id) {
+    this._activeId = id
+  }
+
+  get activeQuote() {
+    if (!this._activeId) return null
+    return this._quotes.find(q => q.id === this._activeId) || null
+  }
+
+  get count() {
+    return this._quotes.length
+  }
+
+  get isEmpty() {
+    return this._quotes.length === 0
+  }
+
+  get hasActive() {
+    return this._activeId !== null
+  }
+
+  // --- Mutations ---
+
+  add(commentId, text) {
+    const quote = {
+      id: _nextId++,
+      commentId,
+      text,
+      type: 'review', // 'review' | 'question'
+      feedback: '',
+    }
+    this._quotes.push(quote)
+    this._activeId = quote.id
+    return quote
+  }
+
+  remove(quoteId) {
+    const idx = this._quotes.findIndex(q => q.id === quoteId)
+    if (idx === -1) return null
+    const [removed] = this._quotes.splice(idx, 1)
+    if (this._activeId === quoteId) {
+      this._activeId = null
+    }
+    return removed
+  }
+
+  setFeedback(quoteId, feedback) {
+    const quote = this._quotes.find(q => q.id === quoteId)
+    if (quote) quote.feedback = feedback.trim()
+  }
+
+  saveActiveFeedback(textareaValue) {
+    if (!this._activeId) return
+    const quote = this._quotes.find(q => q.id === this._activeId)
+    if (quote) quote.feedback = textareaValue.trim()
+  }
+
+  commitActive(textareaValue) {
+    this.saveActiveFeedback(textareaValue)
+    this._activeId = null
+  }
+
+  toggleType(quoteId) {
+    const quote = this._quotes.find(q => q.id === quoteId)
+    if (!quote) return null
+    quote.type = quote.type === 'review' ? 'question' : 'review'
+    return quote
+  }
+
+  activate(quoteId) {
+    const quote = this._quotes.find(q => q.id === quoteId)
+    if (!quote) return null
+    this._activeId = quoteId
+    return quote
+  }
+
+  clear() {
+    this._quotes = []
+    this._activeId = null
+    this._backup = null
+  }
+
+  // --- Backup / Restore (for send-failure rollback) ---
+
+  backup(textareaValue) {
+    this._backup = {
+      quotes: JSON.parse(JSON.stringify(this._quotes)),
+      textareaValue,
+    }
+  }
+
+  restore() {
+    if (!this._backup) return null
+    this._quotes = this._backup.quotes
+    const textareaValue = this._backup.textareaValue
+    this._backup = null
+    return textareaValue
+  }
+
+  hasBackup() {
+    return this._backup !== null
+  }
+
+  // --- Markdown Builder ---
+
+  buildContent(summaryText) {
+    if (this._quotes.length === 0) return summaryText
+
+    const parts = []
+
+    this._quotes.forEach((q, i) => {
+      if (i > 0) parts.push('') // Blank line between quotes to prevent blockquote merging
+      const prefix = q.type === 'question' ? '> ❓ ' : '> '
+      const quoted = q.text.split('\n').map((line, j) => {
+        return j === 0 ? `${prefix}${line}` : `> ${line}`
+      }).join('\n')
+      parts.push(quoted)
+      if (q.feedback) {
+        parts.push('')
+        parts.push(q.feedback)
+      }
+    })
+
+    const summary = summaryText.trim()
+    if (summary) {
+      parts.push('')
+      parts.push('---')
+      parts.push(summary)
+    }
+
+    return parts.join('\n')
+  }
+
+  buildQuestionContent(quote) {
+    const prefix = '> ❓ '
+    const quoted = quote.text.split('\n').map((line, i) => {
+      return i === 0 ? `${prefix}${line}` : `> ${line}`
+    }).join('\n')
+    const parts = [quoted]
+    if (quote.feedback) {
+      parts.push('')
+      parts.push(quote.feedback)
+    }
+    return parts.join('\n')
+  }
+
+  // --- Query ---
+
+  /** Button state: 'add' | 'send-review' | 'send-question' | 'normal' */
+  get buttonState() {
+    if (this._quotes.length === 0) return 'normal'
+    if (this._activeId) {
+      const active = this.activeQuote
+      if (active && active.type === 'question') return 'send-question'
+      return 'add'
+    }
+    return 'send-review'
+  }
+}

data/app/javascript/controllers/comments/topics_controller.js

@@ -7,6 +7,7 @@ export default class extends Controller {
     connect() {
         this.topics = []
         this.canManageTopics = false
+        this.canCreateTopic = false
         this.subscribedCreativeId = null
         this.topicsSubscription = null
         // Initial load if creativeId is available (e.g. from dataset if set server-side)
@@ -15,11 +16,14 @@ export default class extends Controller {
             this.subscribe()
         }
         this.handleNewMessage = this.handleNewMessage.bind(this)
+        this.handleTopicMoved = this.handleTopicMoved.bind(this)
         window.addEventListener('comments--topics:new-message', this.handleNewMessage)
+        window.addEventListener('collavre:topic-moved', this.handleTopicMoved)
     }
 
     disconnect() {
         window.removeEventListener('comments--topics:new-message', this.handleNewMessage)
+        window.removeEventListener('collavre:topic-moved', this.handleTopicMoved)
         this.unsubscribe()
     }
 
@@ -59,9 +63,11 @@ export default class extends Controller {
                 const data = await response.json()
                 const topics = Array.isArray(data) ? data : data.topics
                 const canManage = Array.isArray(data) ? false : data.can_manage
+                const canCreateTopic = Array.isArray(data) ? false : (data.can_create_topic ?? canManage)
                 this.topics = topics
                 this.canManageTopics = canManage
-                this.renderTopics(this.topics, this.canManageTopics)
+                this.canCreateTopic = canCreateTopic
+                this.renderTopics(this.topics, this.canManageTopics, this.canCreateTopic)
                 this.restoreSelection()
             }
         } catch (e) {
@@ -85,7 +91,7 @@ export default class extends Controller {
         }
     }
 
-    renderTopics(topics, canManage = false) {
+    renderTopics(topics, canManage = false, canCreateTopic = canManage) {
         const dragActions = canManage
             ? 'dragstart->comments--topics#handleTopicDragStart dragend->comments--topics#handleTopicDragEnd'
             : ''
@@ -114,8 +120,8 @@ export default class extends Controller {
             html += `</span>`
         })
 
-        // Add create button container
-        if (canManage) {
+        // Add create button container (write permission is sufficient for topic creation)
+        if (canCreateTopic) {
             html += `<span class="topic-creation-container" data-comments--topics-target="creationContainer">
                   <button class="add-topic-btn" data-action="click->comments--topics#showInput">+</button>
                  </span>`
@@ -169,6 +175,11 @@ export default class extends Controller {
 
         this.draggingTopicId = topicId
         event.dataTransfer.setData('application/x-topic-id', topicId)
+        // Include topic move data so creative tree rows can accept this drop
+        event.dataTransfer.setData('application/x-topic-move', JSON.stringify({
+            topicId,
+            sourceCreativeId: this.creativeId
+        }))
         event.dataTransfer.effectAllowed = 'move'
 
         requestAnimationFrame(() => {
@@ -250,7 +261,7 @@ export default class extends Controller {
 
         // Update local state and UI immediately
         this.topics = topics
-        this.renderTopics(topics, this.canManageTopics)
+        this.renderTopics(topics, this.canManageTopics, this.canCreateTopic)
         this.restoreSelection()
 
         // Send to server
@@ -446,7 +457,7 @@ export default class extends Controller {
                 if (index !== -1) {
                     this.topics[index] = updatedTopic
                 }
-                this.renderTopics(this.topics, this.canManageTopics)
+                this.renderTopics(this.topics, this.canManageTopics, this.canCreateTopic)
                 this.restoreSelection()
             } else {
                 alert("Failed to update topic")
@@ -483,6 +494,19 @@ export default class extends Controller {
         }
     }
 
+    handleTopicMoved(event) {
+        const { sourceCreativeId, topicId } = event.detail
+        // Reload topics if the moved topic belonged to the currently viewed creative
+        if (String(sourceCreativeId) === String(this.creativeId)) {
+            // If we were viewing the moved topic, switch to Main
+            if (String(this.currentTopicId) === String(topicId)) {
+                this.currentTopicId = ""
+                this.dispatch("change", { detail: { topicId: "" } })
+            }
+            this.loadTopics()
+        }
+    }
+
     handleNewMessage(event) {
         const topicId = event.detail.topicId
         if (!topicId) return
@@ -601,7 +625,7 @@ export default class extends Controller {
         if (exists) return
 
         this.topics = [...topics, data.topic]
-        this.renderTopics(this.topics, this.canManageTopics)
+        this.renderTopics(this.topics, this.canManageTopics, this.canCreateTopic)
         this.restoreSelection()
     }
 
@@ -622,7 +646,7 @@ export default class extends Controller {
         })
 
         this.topics = reorderedTopics
-        this.renderTopics(this.topics, this.canManageTopics)
+        this.renderTopics(this.topics, this.canManageTopics, this.canCreateTopic)
         this.restoreSelection()
     }
 
@@ -632,7 +656,7 @@ export default class extends Controller {
         if (index === -1) return
 
         this.topics[index] = updatedTopic
-        this.renderTopics(this.topics, this.canManageTopics)
+        this.renderTopics(this.topics, this.canManageTopics, this.canCreateTopic)
         this.restoreSelection()
     }
 
@@ -649,7 +673,7 @@ export default class extends Controller {
             this.dispatch("change", { detail: { topicId: "" } })
         }
 
-        this.renderTopics(this.topics, this.canManageTopics)
+        this.renderTopics(this.topics, this.canManageTopics, this.canCreateTopic)
         this.restoreSelection()
     }
 }

data/app/javascript/controllers/index.js

@@ -14,15 +14,20 @@ import CommentsFormController from "./comments/form_controller"
 import CommentsPresenceController from "./comments/presence_controller"
 import CommentsMentionMenuController from "./comments/mention_menu_controller"
 import CommentsTopicsController from "./comments/topics_controller"
+import CommentsContextsController from "./comments/contexts_controller"
 import CommentsPopupController from "./comments/popup_controller"
 import ClickTargetController from "./click_target_controller"
 import TabsController from "./tabs_controller"
 import LinkCreativeController from "./link_creative_controller"
+import TopicSearchController from "./topic_search_controller"
 import CommonPopupController from "./common_popup_controller"
 import CommentController from "./comment_controller"
 import ReactionPickerController from "./reaction_picker_controller"
 import ShareInviteController from "./share_invite_controller"
 import ShareUserSearchController from "./share_user_search_controller"
+import CommentVersionController from "./comment_version_controller"
+import OrgChartController from "./org_chart_controller"
+import ShareModalController from "./share_modal_controller"
 
 // Export all controllers
 export {
@@ -44,11 +49,15 @@ export {
   ClickTargetController,
   TabsController,
   LinkCreativeController,
+  TopicSearchController,
   CommonPopupController,
   CommentController,
   ReactionPickerController,
   ShareInviteController,
-  ShareUserSearchController
+  ShareUserSearchController,
+  CommentVersionController,
+  OrgChartController,
+  ShareModalController
 }
 
 // Registration function for use with a Stimulus application
@@ -67,13 +76,18 @@ export function registerControllers(application) {
   application.register("comments--presence", CommentsPresenceController)
   application.register("comments--mention-menu", CommentsMentionMenuController)
   application.register("comments--topics", CommentsTopicsController)
+  application.register("comments--contexts", CommentsContextsController)
   application.register("comments--popup", CommentsPopupController)
   application.register("click-target", ClickTargetController)
   application.register("tabs", TabsController)
   application.register("link-creative", LinkCreativeController)
+  application.register("topic-search", TopicSearchController)
   application.register("common-popup", CommonPopupController)
   application.register("comment", CommentController)
   application.register("reaction-picker", ReactionPickerController)
   application.register("share-invite", ShareInviteController)
   application.register("share-user-search", ShareUserSearchController)
+  application.register("comment-version", CommentVersionController)
+  application.register("org-chart", OrgChartController)
+  application.register("share-modal", ShareModalController)
 }

data/app/javascript/controllers/org_chart_controller.js

@@ -0,0 +1,46 @@
+import { Controller } from "@hotwired/stimulus"
+
+export default class extends Controller {
+  static targets = [ "toggleAllBtn" ]
+
+  toggleAll() {
+    const details = this.element.querySelectorAll("details.org-chart-group")
+    const allOpen = Array.from(details).every(d => d.open)
+
+    details.forEach(d => d.open = !allOpen)
+
+    if (this.hasToggleAllBtnTarget) {
+      const btn = this.toggleAllBtnTarget
+      btn.textContent = allOpen
+        ? btn.dataset.expandText || btn.textContent
+        : btn.dataset.collapseText || btn.textContent
+    }
+  }
+
+  updatePermission(event) {
+    const select = event.target
+    const url = select.dataset.updateUrl
+    const permission = select.value
+    const originalClass = select.className
+
+    // Update visual class immediately
+    select.className = select.className.replace(/org-chart-permission-\w+/g, "")
+    select.classList.add("org-chart-permission-select", `org-chart-permission-${permission}`)
+
+    fetch(url, {
+      method: "PATCH",
+      headers: {
+        "Content-Type": "application/json",
+        "X-CSRF-Token": document.querySelector("meta[name='csrf-token']")?.content,
+        "Accept": "application/json"
+      },
+      body: JSON.stringify({ permission })
+    }).then(response => {
+      if (!response.ok) throw new Error("Failed")
+    }).catch(() => {
+      select.className = originalClass
+      location.reload()
+    })
+  }
+
+}