coletivo 0.0.0 → 0.0.1

data/lib/coletivo/models/person_rating.rb

@@ -6,8 +6,8 @@ module Coletivo
 
       validates :person, :rateable, :weight, :presence => true
 
-      def self.find_for_recommendation(recommendable)
-        find(:all)
+      def self.find_for_recommendation(person, rateable_type)
+        where(:rateable_type => rateable_type.to_s)
       end
     end
   end

data/lib/coletivo/models/recommendable.rb

@@ -9,7 +9,7 @@ module Coletivo
       module ClassMethods
         def find_recommendations_for(model, options = {})
           sim_totals, weighted_means = {}, {}
-          preferences = options[:preferences] ||
+          preferences = options[:preferences] ||=
             load_preferences_for_recommendation(model)
 
           preferences.each do |other, other_prefs|
@@ -41,11 +41,6 @@ module Coletivo
             .compact
         end
 
-        def find_ratings_for_recommendation(recommendable)
-          Coletivo::Config.ratings_container\
-            .find_for_recommendation(recommendable)
-        end
-
         # Map a preferences Hash by a collection of ratings.
         #
         # Rating objects have a +person+, a +rateable+ object and a +weight+.
@@ -64,21 +59,23 @@ module Coletivo
         #
         # Expected keys are :person or :rateable
         def map_ratings_to_preferences(ratings)
-          #TODO: ?? #preferences_by_ratings(:rateable, :person): Item based rec.
-          key, subkey = :person, :rateable
+          #TODO: (???) Item based mapping.
+          key, subkey = :person_id, :rateable_id
           preferences = {}
 
           ratings.each do |rating|
-            p = preferences[rating.send(key).id] ||= {}
-            p[rating.send(subkey).id] = rating.weight
+            p = preferences[rating.send(key)] ||= {}
+            p[rating.send(subkey)] = rating.weight
           end
 
           preferences
         end
 
         def load_preferences_for_recommendation(model)
-          r = model.class.find_ratings_for_recommendation(model)
-          model.class.map_ratings_to_preferences(r)
+          r = Coletivo::Config.ratings_container\
+                .find_for_recommendation(model, self)
+
+          map_ratings_to_preferences(r)
         end
       end
 

data/lib/generators/coletivo/templates/person_ratings_migration.rb

@@ -11,6 +11,8 @@ class CreatePersonRatings < ActiveRecord::Migration
 
       t.timestamps
     end
+
+    add_index :person_ratings, :rateable_type, :unique => false
   end
 
   def self.down

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: coletivo
 version: !ruby/object:Gem::Version 
-  hash: 31
+  hash: 29
   prerelease: false
   segments: 
   - 0
   - 0
-  - 0
-  version: 0.0.0
+  - 1
+  version: 0.0.1
 platform: ruby
 authors: 
 - "Di\xC3\xB3genes Falc\xC3\xA3o"
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-07-08 00:00:00 -03:00
+date: 2011-07-20 00:00:00 -03:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency