coins_paid_api 1.0.7 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 344f70ed054fc21fbd7b99ab74a2be43af3c18faf178b8dc0e507bb8787c5361
-  data.tar.gz: 67d6cec032e4ee37950ae18f25e3319fbe64cd55aa7403116a93463197d4d52f
+  metadata.gz: 37ab167accc89938d66af72334820f588f3eb25c27394b648ddac3b98ab90ef1
+  data.tar.gz: 0efb54ff9fb942ad1c689ed350a5d8bef491f963181dba8918b6240cf1259a85
 SHA512:
-  metadata.gz: 5d5ffcbb104c5b277f4196328cafc70392606541b6c840493f1896b0a35436e2338e049e4811da19f13daca8071b7a60b0b0d7a3192397096ace769fa05cb960
-  data.tar.gz: 13191a7d05cf3bd1cb8e0ef1d4e3fa005c4485b23233b080be73e1ae9481fda68ac262b761edc795d31039ec6c70d2605b96a4b8295a6ea040c3722e544ee663
+  metadata.gz: df5a0d70589d54e6fc919da11bbdf37bcf1ca8ec4df40a80f2f14d424c0e2c56a73169fe6bf23a9bd142a0f1e7160ad5ada5b455292441722e2a455107c0f925
+  data.tar.gz: 0b0a112f21a5d88455af67b2be4aeefc0e45a7d125c1d341cafd3f4b1785d486864a6bdf73b19ee57c2600713ffbf2e1cddd3144e1108e6632babcdad416e58c

data/.gitignore

@@ -1,2 +1,3 @@
 /*.gem
 /Gemfile.lock
+spec/examples.txt

data/.rubocop.yml

@@ -0,0 +1,64 @@
+require:
+  - rubocop-performance
+  - rubocop-rails
+AllCops:
+  TargetRubyVersion: 2.7
+  NewCops: enable
+  SuggestExtensions: false
+
+Naming/MethodParameterName:
+  MinNameLength: 1
+Naming/VariableNumber:
+  Enabled: false
+
+Lint/MissingCopEnableDirective:
+  Enabled: false
+
+Layout/EmptyLineAfterMagicComment:
+  Enabled: false
+Layout/LineLength:
+  Max: 120
+Layout/MultilineOperationIndentation:
+  Enabled: false
+Layout/MultilineMethodCallIndentation:
+  EnforcedStyle: indented_relative_to_receiver
+
+Style/AsciiComments:
+  Enabled: false
+Style/ClassAndModuleChildren:
+  Enabled: false
+Style/Documentation:
+  Enabled: false
+Style/FormatStringToken:
+  Enabled: false
+Style/Lambda:
+  Enabled: false
+Style/LambdaCall:
+  Enabled: false
+Style/ModuleFunction:
+  Enabled: false
+Style/PercentLiteralDelimiters:
+  PreferredDelimiters:
+    '%i': '()'
+    '%I': '()'
+    '%r': '{}'
+    '%w': '()'
+    '%W': '()'
+Style/SignalException:
+  EnforcedStyle: 'only_raise'
+
+Metrics/AbcSize:
+  Exclude:
+    - 'config/**/*'
+    - 'db/**/*'
+    - 'spec/**/*'
+Metrics/BlockLength:
+  Exclude:
+    - 'config/**/*'
+    - 'db/**/*'
+    - 'spec/**/*'
+Metrics/MethodLength:
+  Exclude:
+    - 'config/**/*'
+    - 'db/**/*'
+    - 'spec/**/*'

data/coins_paid_api.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
   s.name = 'coins_paid_api'
   s.authors = ['Artem Biserov(artembiserov)', 'Oleg Ivanov(morhekil)']
-  s.version = '1.0.7'
+  s.version = '1.3.0'
   s.files = `git ls-files`.split("\n")
   s.summary = 'Coins Paid Integration'
   s.license = 'MIT'

data/lib/coins_paid/api/callback_data.rb

@@ -23,10 +23,12 @@ module CoinsPaid
       end
 
       attribute? :currency_sent do
+        attribute :currency, Types::String
         attribute :amount, Types::String
       end
 
       attribute? :currency_received do
+        attribute :currency, Types::String
         attribute :amount, Types::String
         attribute? :amount_minus_fee, Types::String
       end

data/lib/coins_paid/api/take_address.rb

@@ -6,7 +6,12 @@ module CoinsPaid
       class Request < Dry::Struct
         attribute :foreign_id, Types::Coercible::String
         attribute :currency, Types::String
-        attribute :convert_to, Types::String
+        attribute :convert_to, Types::String.optional
+
+        def to_hash
+          convert_value = convert_to != currency ? convert_to : nil
+          super().merge(convert_to: convert_value).compact
+        end
       end
 
       class Response < Dry::Struct

data/lib/coins_paid/api/withdrawal.rb

@@ -7,8 +7,8 @@ module CoinsPaid
         attribute :foreign_id, Types::Coercible::String
         attribute :amount, Types::Coercible::String
         attribute :currency, Types::String
-        attribute :convert_to, Types::String
         attribute :address, Types::String
+        attribute? :convert_to, Types::String
         attribute? :tag, Types::String
       end
 

data/lib/coins_paid/api.rb

@@ -35,7 +35,7 @@ module CoinsPaid
       yield self
     end
 
-    def take_address(foreign_id:, currency:, convert_to:)
+    def take_address(foreign_id:, currency:, convert_to: nil)
       Requester.call(
         TakeAddress,
         foreign_id: foreign_id, currency: currency, convert_to: convert_to

data/spec/callback_spec.rb

@@ -42,11 +42,8 @@ describe CoinsPaid::API, '.callback' do
           { transaction_type: 'blockchain', type: 'deposit', id: 714576 },
           { transaction_type: 'exchange', type: 'exchange', id: 714577 }
         ],
-        currency_sent: { amount: '0.01000000' },
-        currency_received: {
-          amount_minus_fee: '90',
-          amount: '84.17070222'
-        }
+        currency_sent: { currency: 'BTC', amount: '0.01000000' },
+        currency_received: { currency: 'EUR', amount_minus_fee: '90', amount: '84.17070222' }
       }
     end
 
@@ -91,10 +88,8 @@ describe CoinsPaid::API, '.callback' do
           { transaction_type: 'exchange', type: 'exchange', id: 1 },
           { transaction_type: 'blockchain', type: 'withdrawal', id: 1 }
         ],
-        currency_sent: { amount: '381' },
-        currency_received: {
-          amount: '0.01000000'
-        }
+        currency_sent: { currency: 'EUR', amount: '381' },
+        currency_received: { currency: 'BTC', amount: '0.01000000' }
       }
     end
 
@@ -132,8 +127,8 @@ describe CoinsPaid::API, '.callback' do
         status: 'confirmed',
         foreign_id: '',
         error: '',
-        currency_sent: { amount: "0.56114000"},
-        currency_received: { amount: "80.21790617"},
+        currency_sent: { currency: 'ETH', amount: '0.56114000'},
+        currency_received: { currency: 'EUR', amount: '80.21790617'},
         transactions: [
           { transaction_type: 'exchange', type: 'exchange', id: 714576 },
         ]

data/spec/currencies_list_spec.rb

@@ -3,7 +3,8 @@
 require_relative './request_examples'
 
 describe CoinsPaid::API, '.currencies_list' do
-  endpoint = 'https://app.coinspaid.com/api/v2/currencies/list'
+  let(:endpoint) { 'https://app.coinspaid.com/api/v2/currencies/list' }
+  let(:request_body) { "{}" }
   include_context 'CoinsPaid API request'
 
   let(:expected_currencies) do
@@ -65,5 +66,5 @@ describe CoinsPaid::API, '.currencies_list' do
     expect(response).to match_array currencies
   end
 
-  it_behaves_like 'CoinsPaid API error handling', endpoint: endpoint
+  it_behaves_like 'CoinsPaid API error handling'
 end

data/spec/request_examples.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.shared_context 'CoinsPaid API request' do |request_data: {}|
+RSpec.shared_context 'CoinsPaid API request' do
   let(:signature) { 'c01dc0ffee' }
   let(:request_signature_headers) do
     {
@@ -10,11 +10,11 @@ RSpec.shared_context 'CoinsPaid API request' do |request_data: {}|
   end
 
   before do
-    allow(CoinsPaid::API::Signature).to receive(:generate).with(request_data.to_json).and_return signature
+    allow(CoinsPaid::API::Signature).to receive(:generate).with(request_body).and_return signature
   end
 end
 
-RSpec.shared_examples 'CoinsPaid API error handling' do |endpoint:, request_body: '{}'|
+RSpec.shared_examples 'CoinsPaid API error handling' do
   context 'when coins paid responded with validation errors' do
     let(:response_data) do
       {

data/spec/spec_helper.rb

@@ -10,3 +10,10 @@ require 'webmock/rspec'
 require 'pry'
 require 'coins_paid_api'
 Dir['./spec/support/**/*.rb'].each { |f| require f }
+
+RSpec.configure do |config|
+  config.filter_run focus: true
+  config.alias_example_to :fit, focus: true
+  config.run_all_when_everything_filtered = true
+  config.example_status_persistence_file_path = 'spec/examples.txt'
+end

data/spec/take_address_spec.rb

@@ -3,43 +3,69 @@
 require_relative './request_examples'
 
 describe CoinsPaid::API, '.take_address' do
-  endpoint = 'https://app.coinspaid.com/api/v2/addresses/take'
-  request_data = {
-    foreign_id: 'user-id:2048',
-    currency: 'BTC',
-    convert_to: 'EUR'
-  }
-  include_context 'CoinsPaid API request', request_data: request_data
-
-  let(:expected_address_attributes) do
-    {
-      external_id: 1,
-      address: '12983h13ro1hrt24it432t',
-      tag: '123'
-    }
+  let(:endpoint) { 'https://app.coinspaid.com/api/v2/addresses/take' }
+
+  let(:foreign_id) { 'user-id:2048' }
+  let(:currency) { 'BTC' }
+
+  let(:request_data) do
+    { foreign_id: foreign_id, currency: currency, convert_to: api_convert_to }.compact
   end
-  subject(:take_address) { described_class.take_address(request_data) }
+  let(:request_body) { request_data.to_json }
+
+  include_context 'CoinsPaid API request'
 
   let(:response_data) do
     {
       'data' => {
         'id' => 1,
         'currency' => 'BTC',
-        'convert_to' => 'EUR',
+        'convert_to' => api_convert_to,
         'address' => '12983h13ro1hrt24it432t',
         'tag' => 123,
         'foreign_id' => 'user-id:2048'
-      }
+      }.compact
     }
   end
 
-  it 'returns valid response if successful' do
-    stub_request(:post, endpoint)
-      .with(body: request_data, headers: request_signature_headers)
-      .to_return(status: 201, body: response_data.to_json)
+  let(:args) do
+    { foreign_id: 'user-id:2048', currency: 'BTC', convert_to: args_convert_to }.compact
+  end
+  subject(:take_address) { described_class.take_address(args) }
+
+  shared_examples 'successful request' do
+    it 'returns valid response' do
+      stub_request(:post, endpoint)
+        .with(body: request_body, headers: request_signature_headers)
+        .to_return(status: 201, body: response_data.to_json)
+
+      expected_address_attributes = {
+        external_id: 1,
+        address: '12983h13ro1hrt24it432t',
+        tag: '123'
+      }
+      expect(take_address).to be_struct_with_params(
+        CoinsPaid::API::TakeAddress::Response, expected_address_attributes
+      )
+    end
+  end
 
-    expect(take_address).to be_struct_with_params(CoinsPaid::API::TakeAddress::Response, expected_address_attributes)
+  context 'with explicit convert_to not matching address currency' do
+    let(:args_convert_to) { 'EUR' }
+    let(:api_convert_to) { 'EUR' }
+    it_behaves_like 'successful request'
+    it_behaves_like 'CoinsPaid API error handling'
   end
 
-  it_behaves_like 'CoinsPaid API error handling', endpoint: endpoint, request_body: request_data
+  context 'with explicit convert_to matching address currency' do
+    let(:args_convert_to) { 'BTC' }
+    let(:api_convert_to) { nil }
+    it_behaves_like 'successful request'
+  end
+
+  context 'with nil convert_to' do
+    let(:args_convert_to) { nil }
+    let(:api_convert_to) { nil }
+    it_behaves_like 'successful request'
+  end
 end

data/spec/withdrawal_spec.rb

@@ -2,10 +2,10 @@
 
 require_relative './request_examples'
 
-RSpec.shared_examples 'CoinsPaid API withdrawal' do |request_data:|
-  endpoint = 'https://app.coinspaid.com/api/v2/withdrawal/crypto'
+RSpec.shared_examples 'CoinsPaid API withdrawal' do
+  let(:endpoint) { 'https://app.coinspaid.com/api/v2/withdrawal/crypto' }
 
-  include_context 'CoinsPaid API request', request_data: request_data
+  include_context 'CoinsPaid API request'
 
   let(:response_data) do
     {
@@ -44,19 +44,28 @@ RSpec.shared_examples 'CoinsPaid API withdrawal' do |request_data:|
 end
 
 describe CoinsPaid::API, '.withdraw' do
-  base_request_data = {
-    foreign_id: 'user-id:2048',
-    amount: '0.01',
-    currency: 'EUR',
-    convert_to: 'BTC',
-    address: 'abc123'
-  }
+  let(:base_request_data) do
+    {
+      foreign_id: 'user-id:2048',
+      amount: '0.01',
+      currency: 'BTC',
+      address: 'abc123'
+    }
+  end
+  let(:request_body) { request_data.to_json }
+
+  context 'request does not include tag parameter or convert_to' do
+    let(:request_data) { base_request_data }
+    it_behaves_like 'CoinsPaid API withdrawal'
+  end
 
   context 'request includes tag parameter' do
-    it_behaves_like 'CoinsPaid API withdrawal', request_data: base_request_data.merge(tag: 'thetag')
+    let(:request_data) { base_request_data.merge(tag: 'thetag') }
+    it_behaves_like 'CoinsPaid API withdrawal'
   end
 
-  context 'request does not include tag parameter' do
-    it_behaves_like 'CoinsPaid API withdrawal', request_data: base_request_data
+  context 'request includes convert_to' do
+    let(:request_data) { base_request_data.merge(currency: 'EUR', convert_to: 'BTC') }
+    it_behaves_like 'CoinsPaid API withdrawal'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: coins_paid_api
 version: !ruby/object:Gem::Version
-  version: 1.0.7
+  version: 1.3.0
 platform: ruby
 authors:
 - Artem Biserov(artembiserov)
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-09-27 00:00:00.000000000 Z
+date: 2022-04-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dry-struct
@@ -90,6 +90,7 @@ files:
 - ".circleci/config.yml"
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - Gemfile
 - coins_paid_api.gemspec
 - lib/coins_paid/api.rb