coins_paid_api 1.0.3 → 1.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 62cd90114215368e128d6e06d4047d859bfe83ae4d919904c33ce114864deffe
-  data.tar.gz: e3b9b821e9c0b082d58cb475b7806b4e4065df0d27f051f0a795af27718a6c7a
+  metadata.gz: 344f70ed054fc21fbd7b99ab74a2be43af3c18faf178b8dc0e507bb8787c5361
+  data.tar.gz: 67d6cec032e4ee37950ae18f25e3319fbe64cd55aa7403116a93463197d4d52f
 SHA512:
-  metadata.gz: 73267b211f9944de80b673e8387a83320378b691a6af9b17803fad1aa8a15a87e59c9caea8732d4d1b23440165f57094c085b3ada36ea46fb01f1572c46eef21
-  data.tar.gz: 00abd832c2f0e895b88473aa0e4d422c232d52d74821bdeaea2e940c8bcc6fd05d3909ff2d3624185de044242c8c1546b6c8d64fe1d56c04e42c5c14381733f1
+  metadata.gz: 5d5ffcbb104c5b277f4196328cafc70392606541b6c840493f1896b0a35436e2338e049e4811da19f13daca8071b7a60b0b0d7a3192397096ace769fa05cb960
+  data.tar.gz: 13191a7d05cf3bd1cb8e0ef1d4e3fa005c4485b23233b080be73e1ae9481fda68ac262b761edc795d31039ec6c70d2605b96a4b8295a6ea040c3722e544ee663

data/coins_paid_api.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
   s.name = 'coins_paid_api'
   s.authors = ['Artem Biserov(artembiserov)', 'Oleg Ivanov(morhekil)']
-  s.version = '1.0.3'
+  s.version = '1.0.7'
   s.files = `git ls-files`.split("\n")
   s.summary = 'Coins Paid Integration'
   s.license = 'MIT'

data/lib/coins_paid/api/callback_data.rb

@@ -7,12 +7,12 @@ module CoinsPaid
       CANCELLED = 'cancelled'
 
       attribute :id, Types::Integer
-      attribute :foreign_id, Types::String
+      attribute? :foreign_id, Types::String
       attribute? :type, Types::String
       attribute? :status, Types::String
       attribute? :error, Types::Coercible::String
 
-      attribute :crypto_address do
+      attribute? :crypto_address do
         attribute :currency, Types::String
       end
 
@@ -32,7 +32,7 @@ module CoinsPaid
       end
 
       def self.from_json(attributes)
-        attributes[:foreign_id] ||= attributes.dig(:crypto_address, :foreign_id)
+        attributes[:foreign_id] ||= attributes.dig(:crypto_address, :foreign_id) || ''
         new(attributes)
       end
 

data/lib/coins_paid/api/take_address.rb

@@ -12,7 +12,7 @@ module CoinsPaid
       class Response < Dry::Struct
         attribute :external_id, Types::Integer
         attribute :address, Types::String
-        attribute :tag, Types::String.optional
+        attribute :tag, Types::Coercible::String.optional
       end
 
       PATH = 'addresses/take'

data/lib/coins_paid/api/withdrawal.rb

@@ -9,6 +9,7 @@ module CoinsPaid
         attribute :currency, Types::String
         attribute :convert_to, Types::String
         attribute :address, Types::String
+        attribute? :tag, Types::String
       end
 
       class Response < Dry::Struct

data/lib/coins_paid/api.rb

@@ -42,11 +42,8 @@ module CoinsPaid
       )
     end
 
-    def withdraw(foreign_id:, amount:, currency:, convert_to:, address:)
-      Requester.call(
-        Withdrawal,
-        foreign_id: foreign_id, amount: amount, currency: currency, convert_to: convert_to, address: address
-      )
+    def withdraw(data)
+      Requester.call(Withdrawal, data)
     end
 
     def currencies_list

data/spec/callback_spec.rb

@@ -122,4 +122,24 @@ describe CoinsPaid::API, '.callback' do
 
     it { is_expected.to be_struct_with_params(CoinsPaid::API::CallbackData, expected_params) }
   end
+
+  context 'when request_body is exchange callback data' do
+    let(:request_body) { exchange_callback_body.to_json }
+    let(:expected_params) do
+      {
+        id: 3268590,
+        type: 'exchange',
+        status: 'confirmed',
+        foreign_id: '',
+        error: '',
+        currency_sent: { amount: "0.56114000"},
+        currency_received: { amount: "80.21790617"},
+        transactions: [
+          { transaction_type: 'exchange', type: 'exchange', id: 714576 },
+        ]
+      }
+    end
+
+    it { is_expected.to be_struct_with_params(CoinsPaid::API::CallbackData, expected_params) }
+  end
 end

data/spec/support/shared/data.rb

@@ -199,4 +199,33 @@ shared_context 'coins paid callbacks' do
       'status' => 'cancelled'
     }
   end
+
+  let(:exchange_callback_body) do
+    {
+      'currency_received' => {
+        'amount' => '80.21790617',
+        'currency' => 'EUR'
+      },
+      'currency_sent' => {
+        'amount' => '0.56114000',
+        'currency' => 'ETH'
+      },
+      'error' => '',
+      'fees' => [{'type'=>'fee_crypto_sell_for_fiat', 'currency'=>'EUR', 'amount'=>'0.80217906'}],
+      'id' => 3268590,
+      'status' => 'confirmed',
+      'transactions' => [
+        {
+          'id'=>714576,
+          'currency'=>'ETH',
+          'currency_to'=>'EUR',
+          'transaction_type'=>'exchange',
+          'type'=>'exchange',
+          'amount'=>'0.56114000',
+          'amount_to'=>'80.21790617'
+        }
+      ],
+      'type' => 'exchange'
+    }
+  end
 end

data/spec/take_address_spec.rb

@@ -15,7 +15,7 @@ describe CoinsPaid::API, '.take_address' do
     {
       external_id: 1,
       address: '12983h13ro1hrt24it432t',
-      tag: 'tag-123'
+      tag: '123'
     }
   end
   subject(:take_address) { described_class.take_address(request_data) }
@@ -27,7 +27,7 @@ describe CoinsPaid::API, '.take_address' do
         'currency' => 'BTC',
         'convert_to' => 'EUR',
         'address' => '12983h13ro1hrt24it432t',
-        'tag' => 'tag-123',
+        'tag' => 123,
         'foreign_id' => 'user-id:2048'
       }
     }

data/spec/withdrawal_spec.rb

@@ -2,15 +2,9 @@
 
 require_relative './request_examples'
 
-describe CoinsPaid::API, '.withdraw' do
+RSpec.shared_examples 'CoinsPaid API withdrawal' do |request_data:|
   endpoint = 'https://app.coinspaid.com/api/v2/withdrawal/crypto'
-  request_data = {
-    foreign_id: 'user-id:2048',
-    amount: '0.01',
-    currency: 'EUR',
-    convert_to: 'BTC',
-    address: 'abc123'
-  }
+
   include_context 'CoinsPaid API request', request_data: request_data
 
   let(:response_data) do
@@ -48,3 +42,21 @@ describe CoinsPaid::API, '.withdraw' do
     end
   end
 end
+
+describe CoinsPaid::API, '.withdraw' do
+  base_request_data = {
+    foreign_id: 'user-id:2048',
+    amount: '0.01',
+    currency: 'EUR',
+    convert_to: 'BTC',
+    address: 'abc123'
+  }
+
+  context 'request includes tag parameter' do
+    it_behaves_like 'CoinsPaid API withdrawal', request_data: base_request_data.merge(tag: 'thetag')
+  end
+
+  context 'request does not include tag parameter' do
+    it_behaves_like 'CoinsPaid API withdrawal', request_data: base_request_data
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: coins_paid_api
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.0.7
 platform: ruby
 authors:
 - Artem Biserov(artembiserov)
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-04-14 00:00:00.000000000 Z
+date: 2021-09-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dry-struct