coins_paid_api 1.0.2 → 1.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2a0b6ed78179c8805c332b5823c0fbda35a2c36b9def556f05bb663f159842db
-  data.tar.gz: 36a5b14dbd8c20d5a930fd02c93214bc615827c30cc976ddbda06d0bd0c36d2a
+  metadata.gz: 020d45404c81037d89565ba5e7dcb231982db444abdbd00a6f1535bfd9e73170
+  data.tar.gz: 84f0ab1f61a80fe45dedca5cc0d0ce8467e5328315fc75d0f3812702e84774a4
 SHA512:
-  metadata.gz: ae117f6f36b65a733bfd5831115411785c0e02d1575e2bf7c3dab25c25cd757775cb830f6eab4f223f6d98729a34dd629fec4c656f16be99db337c9f23dec650
-  data.tar.gz: e4c47af403f4baef929df96749581dad1fb5a03a97210de0b4a51255346e7d6e96c66092af7e267f155991bd421102b52f9131a194be4a39006735637a565473
+  metadata.gz: cfd4a488e8434dd0ccc78b68feed059545f1d193bbaf2b226e597da371b04b454f459c4a157f55d56750805181048135322ef1671c09f82c78bb8e83186fc50f
+  data.tar.gz: c7ad6dea7bc2c80882df508506df798d7864cb59073db39f14cf46df55ea8d904d20a4416daf4e26ce8c5eee44570cd3c41b8a451760b2642f1ad1b9dc6761b9

data/Gemfile

@@ -7,5 +7,5 @@ group :development, :test do
 end
 
 group :test do
-  gem 'simplecov', require: false
+  gem 'simplecov', '0.13', require: false
 end

data/coins_paid_api.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
   s.name = 'coins_paid_api'
   s.authors = ['Artem Biserov(artembiserov)', 'Oleg Ivanov(morhekil)']
-  s.version = '1.0.2'
+  s.version = '1.0.6'
   s.files = `git ls-files`.split("\n")
   s.summary = 'Coins Paid Integration'
   s.license = 'MIT'

data/lib/coins_paid/api/callback_data.rb

@@ -7,17 +7,18 @@ module CoinsPaid
       CANCELLED = 'cancelled'
 
       attribute :id, Types::Integer
-      attribute :foreign_id, Types::String
+      attribute? :foreign_id, Types::String
       attribute? :type, Types::String
       attribute? :status, Types::String
       attribute? :error, Types::Coercible::String
 
-      attribute :crypto_address do
+      attribute? :crypto_address do
         attribute :currency, Types::String
       end
 
       attribute? :transactions, Types::Array do
         attribute :transaction_type, Types::String
+        attribute :type, Types::String
         attribute :id, Types::Integer
       end
 
@@ -31,7 +32,7 @@ module CoinsPaid
       end
 
       def self.from_json(attributes)
-        attributes[:foreign_id] ||= attributes.dig(:crypto_address, :foreign_id)
+        attributes[:foreign_id] ||= attributes.dig(:crypto_address, :foreign_id) || ''
         new(attributes)
       end
 

data/lib/coins_paid/api/withdrawal.rb

@@ -9,6 +9,7 @@ module CoinsPaid
         attribute :currency, Types::String
         attribute :convert_to, Types::String
         attribute :address, Types::String
+        attribute? :tag, Types::String
       end
 
       class Response < Dry::Struct

data/lib/coins_paid/api.rb

@@ -42,11 +42,8 @@ module CoinsPaid
       )
     end
 
-    def withdraw(foreign_id:, amount:, currency:, convert_to:, address:)
-      Requester.call(
-        Withdrawal,
-        foreign_id: foreign_id, amount: amount, currency: currency, convert_to: convert_to, address: address
-      )
+    def withdraw(data)
+      Requester.call(Withdrawal, data)
     end
 
     def currencies_list

data/spec/callback_spec.rb

@@ -39,8 +39,8 @@ describe CoinsPaid::API, '.callback' do
           currency: 'BTC'
         },
         transactions: [
-          { transaction_type: 'blockchain', id: 714576 },
-          { transaction_type: 'exchange', id: 714577 },
+          { transaction_type: 'blockchain', type: 'deposit', id: 714576 },
+          { transaction_type: 'exchange', type: 'exchange', id: 714577 }
         ],
         currency_sent: { amount: '0.01000000' },
         currency_received: {
@@ -66,8 +66,8 @@ describe CoinsPaid::API, '.callback' do
           currency: 'BTC'
         },
         transactions: [
-          { transaction_type: 'blockchain', id: 714576 },
-          { transaction_type: 'exchange', id: 714577 },
+          { transaction_type: 'blockchain', type: 'deposit', id: 714576 },
+          { transaction_type: 'exchange', type: 'exchange', id: 714577 }
         ]
       }
     end
@@ -88,8 +88,8 @@ describe CoinsPaid::API, '.callback' do
           currency: 'EUR'
         },
         transactions: [
-          { transaction_type: 'exchange', id: 1 },
-          { transaction_type: 'blockchain', id: 1 },
+          { transaction_type: 'exchange', type: 'exchange', id: 1 },
+          { transaction_type: 'blockchain', type: 'withdrawal', id: 1 }
         ],
         currency_sent: { amount: '381' },
         currency_received: {
@@ -114,8 +114,28 @@ describe CoinsPaid::API, '.callback' do
           currency: 'EUR'
         },
         transactions: [
-          { transaction_type: 'exchange', id: 714576 },
-          { transaction_type: 'blockchain', id: 714577 },
+          { transaction_type: 'exchange', type: 'exchange', id: 714576 },
+          { transaction_type: 'blockchain', type: 'withdrawal', id: 714577 }
+        ]
+      }
+    end
+
+    it { is_expected.to be_struct_with_params(CoinsPaid::API::CallbackData, expected_params) }
+  end
+
+  context 'when request_body is exchange callback data' do
+    let(:request_body) { exchange_callback_body.to_json }
+    let(:expected_params) do
+      {
+        id: 3268590,
+        type: 'exchange',
+        status: 'confirmed',
+        foreign_id: '',
+        error: '',
+        currency_sent: { amount: "0.56114000"},
+        currency_received: { amount: "80.21790617"},
+        transactions: [
+          { transaction_type: 'exchange', type: 'exchange', id: 714576 },
         ]
       }
     end

data/spec/support/shared/data.rb

@@ -199,4 +199,33 @@ shared_context 'coins paid callbacks' do
       'status' => 'cancelled'
     }
   end
+
+  let(:exchange_callback_body) do
+    {
+      'currency_received' => {
+        'amount' => '80.21790617',
+        'currency' => 'EUR'
+      },
+      'currency_sent' => {
+        'amount' => '0.56114000',
+        'currency' => 'ETH'
+      },
+      'error' => '',
+      'fees' => [{'type'=>'fee_crypto_sell_for_fiat', 'currency'=>'EUR', 'amount'=>'0.80217906'}],
+      'id' => 3268590,
+      'status' => 'confirmed',
+      'transactions' => [
+        {
+          'id'=>714576,
+          'currency'=>'ETH',
+          'currency_to'=>'EUR',
+          'transaction_type'=>'exchange',
+          'type'=>'exchange',
+          'amount'=>'0.56114000',
+          'amount_to'=>'80.21790617'
+        }
+      ],
+      'type' => 'exchange'
+    }
+  end
 end

data/spec/withdrawal_spec.rb

@@ -2,15 +2,9 @@
 
 require_relative './request_examples'
 
-describe CoinsPaid::API, '.withdraw' do
+RSpec.shared_examples 'CoinsPaid API withdrawal' do |request_data:|
   endpoint = 'https://app.coinspaid.com/api/v2/withdrawal/crypto'
-  request_data = {
-    foreign_id: 'user-id:2048',
-    amount: '0.01',
-    currency: 'EUR',
-    convert_to: 'BTC',
-    address: 'abc123'
-  }
+
   include_context 'CoinsPaid API request', request_data: request_data
 
   let(:response_data) do
@@ -48,3 +42,21 @@ describe CoinsPaid::API, '.withdraw' do
     end
   end
 end
+
+describe CoinsPaid::API, '.withdraw' do
+  base_request_data = {
+    foreign_id: 'user-id:2048',
+    amount: '0.01',
+    currency: 'EUR',
+    convert_to: 'BTC',
+    address: 'abc123'
+  }
+
+  context 'request includes tag parameter' do
+    it_behaves_like 'CoinsPaid API withdrawal', request_data: base_request_data.merge(tag: 'thetag')
+  end
+
+  context 'request does not include tag parameter' do
+    it_behaves_like 'CoinsPaid API withdrawal', request_data: base_request_data
+  end
+end

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: coins_paid_api
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.6
 platform: ruby
 authors:
 - Artem Biserov(artembiserov)
 - Oleg Ivanov(morhekil)
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-04-14 00:00:00.000000000 Z
+date: 2021-09-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dry-struct
@@ -81,8 +81,8 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.7'
-description: 
-email: 
+description:
+email:
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -112,11 +112,11 @@ files:
 - spec/support/shared/data.rb
 - spec/take_address_spec.rb
 - spec/withdrawal_spec.rb
-homepage: 
+homepage:
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -131,9 +131,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
+rubyforge_project:
 rubygems_version: 2.7.6
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Coins Paid Integration
 test_files: []