coinpare 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dc5acc59ac68bf078d8aed7c0cd936f16fda6db021bc8f14559fae43f7bc7efb
-  data.tar.gz: d6fda12725def1b6dbb210a15503f8d514ef08b96c52b53298cc6f0bb8ddd8ca
+  metadata.gz: 95d8580cc429e071a026b03263fb52cb17560486c3627867e432772285211c8a
+  data.tar.gz: b2aba6a81e5827730fe124326f7cc3ca9e5b75dd6223d884f4aa22a217175173
 SHA512:
-  metadata.gz: c3a7e96d6577e227da747c29d64be46ccb6147c1a87e133ae03860de1d9c2700af9ce36f62197277a8fa0957decf8572c4fd83aea7e28d646f00354949bf6068
-  data.tar.gz: 76675509059502f630f91ae51755981fb11a47162743b874dd58faa3b219c86fc6f043556eb257de22d1287336080f2e77c0e5318f3cb530e6f09c6bd3f04ee2
+  metadata.gz: 5b9a4a0dd8ff044e345d6f4cd103a19f6ce24ab73ed7bfd478e081cd3440eef5d2d276ced28851edba6e299ce2583cb6a287d252544ca27a88cc72d9ee86be25
+  data.tar.gz: b66f298dcaa9d28f9d9597b13c60c2fab42a66afd839b47ddb498d535bcf34a68b501e8b28690c7756d1d4d324b2fe0d2d6728f0978dcfb0c16da77a380910bc

data/CHANGELOG.md

@@ -1,5 +1,16 @@
 # Change log
 
+## [v0.3.0] - 2020-11-09
+
+### Changed
+* Change gemspec to only package lib files and include metadata
+* Update all the tty and thor runtime dependencies
+* Remove tty-color as a dependency
+* Change to make tty-screen an explicit runtime dependency
+
+### Fixed
+* Fix Ruby 2.7 keyword conversion errors
+
 ## [v0.2.0] - 2019-01-12
 
 ### Added
@@ -15,5 +26,6 @@
 
 * Initial implementation and release
 
+[v0.3.0]: https://github.com/piotrmurach/coinpare/compare/v0.2.0...v0.3.0
 [v0.2.0]: https://github.com/piotrmurach/coinpare/compare/v0.1.0...v0.2.0
 [v0.1.0]: https://github.com/piotrmurach/coinpare/compare/v0.1.0

data/exe/coinpare

@@ -1,11 +1,11 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
 
-lib_path = File.expand_path('../lib', __dir__)
-$:.unshift(lib_path) if !$:.include?(lib_path)
-require 'coinpare/cli'
+lib_path = File.expand_path("../lib", __dir__)
+$LOAD_PATH.unshift(lib_path) unless $LOAD_PATH.include?(lib_path)
+require "coinpare/cli"
 
-Signal.trap('INT') do
+Signal.trap("INT") do
   warn("\n#{caller.join("\n")}: interrupted")
   exit(1)
 end

data/lib/coinpare/cli.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
-require 'thor'
-require 'pastel'
-require 'tty-font'
+require "thor"
+require "pastel"
+require "tty-font"
 
 module Coinpare
   # Handle the application command line parsing
@@ -14,16 +14,17 @@ module Coinpare
     Error = Class.new(StandardError)
 
     def help(*args)
-      font =  TTY::Font.new(:standard)
-      pastel = Pastel.new(enabled: !options['no-color'])
+      font = TTY::Font.new(:standard)
+      pastel = Pastel.new(enabled: !options["no-color"])
       puts pastel.yellow(font.write("Coinpare"))
       super
     end
 
     class_option :"no-color", type: :boolean, default: false,
-                              desc: 'Disable colorization in output'
+                              desc: "Disable colorization in output"
 
-    desc 'coins NAMES...', 'Get all the current trading data for the coin names...'
+    desc "coins NAMES...", "Get all the current trading data for the " \
+                           "coin names..."
     long_desc <<-DESC
       Get all the current trading info (price, vol, open, high, low etc)
       of any list of cryptocurrencies in any other currency that you need.
@@ -39,31 +40,33 @@ module Coinpare
 
       > $ coinpare coins BTC ETH --exchange coinbase
     DESC
-    method_option :base, aliases: '-b', type: :string, default: "USD",
-                         desc: 'The currency symbol to convert into',
-                         banner: 'CURRENCY'
-    method_option :columns, aliases: '-c', type: :array,
-                            desc: 'Specify columns to display',
-                            banner: '0 1 2'
-    method_option :exchange, aliases: '-e', type: :string, default: "CCCAGG",
-                             desc: 'Name of exchange',
-                             banner: 'name'
-    method_option :help, aliases: '-h', type: :boolean,
-                         desc: 'Display usage information'
-    method_option :top, aliases: '-t', type: :numeric, default: 10, banner: 'N',
-                        desc: "The number of top coins by total volume accross all markets in 24 hours"
-    method_option :watch, aliases: '-w', banner: 'N',
-                          desc: 'Automatically refresh data every n seconds, default 5 sec'
+    method_option :base, aliases: "-b", type: :string, default: "USD",
+                         desc: "The currency symbol to convert into",
+                         banner: "CURRENCY"
+    method_option :columns, aliases: "-c", type: :array,
+                            desc: "Specify columns to display",
+                            banner: "0 1 2"
+    method_option :exchange, aliases: "-e", type: :string, default: "CCCAGG",
+                             desc: "Name of exchange",
+                             banner: "name"
+    method_option :help, aliases: "-h", type: :boolean,
+                         desc: "Display usage information"
+    method_option :top, aliases: "-t", type: :numeric, default: 10, banner: "N",
+                        desc: "The number of top coins by total volume " \
+                              "accross all markets in 24 hours"
+    method_option :watch, aliases: "-w", banner: "N",
+                          desc: "Automatically refresh data every n seconds," \
+                                " default 5 sec"
     def coins(*names)
       if options[:help]
-        invoke :help, ['coins']
+        invoke :help, ["coins"]
       else
-        require_relative 'commands/coins'
+        require_relative "commands/coins"
         Coinpare::Commands::Coins.new(names, options).execute
       end
     end
 
-    desc 'holdings', 'Keep track of all your cryptocurrency investments'
+    desc "holdings", "Keep track of all your cryptocurrency investments"
     long_desc <<-DESC
       Get the current trading prices and their change in value and percentage
       for all your cryptocurrency investments.
@@ -76,36 +79,40 @@ module Coinpare
 
       > $ coinpare holdings --exchange coinbase --base USD
     DESC
-    method_option :add, aliases: '-a', type: :boolean,
-                  desc: "Add a new coin without altering any existhing holdings"
-    method_option :base, aliases: '-b', type: :string,
-                         desc: 'The currency symbol to convert into',
-                         banner: 'CURRENCY'
+    method_option :add, aliases: "-a", type: :boolean,
+                        desc: "Add a new coin without altering any " \
+                              "existhing holdings"
+    method_option :base, aliases: "-b", type: :string,
+                         desc: "The currency symbol to convert into",
+                         banner: "CURRENCY"
     method_option :clear, type: :boolean, default: false,
-                          desc: 'Remove all coins from your existing holdings'
-    method_option :edit, type: :string, banner: 'editor',
-                         desc: 'Open the holdings configuration file for editing in EDITOR, or the default editor if not specified.'
-    method_option :exchange, aliases: '-e', type: :string,
-                             desc: 'Name of exchange', banner: 'NAME'
-    method_option :help, aliases: '-h', type: :boolean,
-                         desc: 'Display usage information'
-    method_option :pie, aliases: '-p', type: :string,
-                        desc: 'Display data in a pie chart format',
-                        banner: 'RADIUS'
+                          desc: "Remove all coins from your existing holdings"
+    method_option :edit, type: :string, banner: "editor",
+                         desc: "Open the holdings configuration file for " \
+                               "editing in EDITOR, or the default editor " \
+                               "if not specified."
+    method_option :exchange, aliases: "-e", type: :string,
+                             desc: "Name of exchange", banner: "NAME"
+    method_option :help, aliases: "-h", type: :boolean,
+                         desc: "Display usage information"
+    method_option :pie, aliases: "-p", type: :string,
+                        desc: "Display data in a pie chart format",
+                        banner: "RADIUS"
     method_option :remove, type: :boolean,
-                  desc: "Remove the given coin(s) from holdings"
-    method_option :watch, aliases: '-w', banner: 'N',
-                          desc: 'Automatically refresh data every n seconds, default 5 sec'
+                           desc: "Remove the given coin(s) from holdings"
+    method_option :watch, aliases: "-w", banner: "N",
+                          desc: "Automatically refresh data every n seconds," \
+                                " default 5 sec"
     def holdings(*)
       if options[:help]
-        invoke :help, ['holdings']
+        invoke :help, ["holdings"]
       else
-        require_relative 'commands/holdings'
+        require_relative "commands/holdings"
         Coinpare::Commands::Holdings.new(options).execute
       end
     end
 
-    desc 'markets [NAME]', 'Get top markets by volume for a currency pair'
+    desc "markets [NAME]", "Get top markets by volume for a currency pair"
     long_desc <<-DESC
       Get top markets by volume for a currency pair.
 
@@ -120,32 +127,34 @@ module Coinpare
 
       > $ coinpare markets ETH -b BTC
     DESC
-    method_option :base, aliases: '-b', type: :string, default: "USD",
-                         desc: 'The currency symbol to convert into',
-                         banner: 'CURRENCY'
-    method_option :columns, aliases: '-c', type: :array,
-                            desc: 'Specify columns to display',
-                            banner: '0 1 2'
-    method_option :help, aliases: '-h', type: :boolean,
-                         desc: 'Display usage information'
-    method_option :top, aliases: '-t', type: :numeric, default: 10,
-                        desc: "The number of top exchanges by total volume in 24 hours"
-    method_option :watch, aliases: '-w', banner: 'N',
-                          desc: 'Automatically refresh data every n seconds, default 5 sec'
-    def markets(name = 'BTC')
+    method_option :base, aliases: "-b", type: :string, default: "USD",
+                         desc: "The currency symbol to convert into",
+                         banner: "CURRENCY"
+    method_option :columns, aliases: "-c", type: :array,
+                            desc: "Specify columns to display",
+                            banner: "0 1 2"
+    method_option :help, aliases: "-h", type: :boolean,
+                         desc: "Display usage information"
+    method_option :top, aliases: "-t", type: :numeric, default: 10,
+                        desc: "The number of top exchanges by total volume " \
+                              "in 24 hours"
+    method_option :watch, aliases: "-w", banner: "N",
+                          desc: "Automatically refresh data every n seconds," \
+                                " default 5 sec"
+    def markets(name = "BTC")
       if options[:help]
-        invoke :help, ['markets']
+        invoke :help, ["markets"]
       else
-        require_relative 'commands/markets'
+        require_relative "commands/markets"
         Coinpare::Commands::Markets.new(name, options).execute
       end
     end
 
-    desc 'version', 'coinpare version'
+    desc "version", "coinpare version"
     def version
-      require_relative 'version'
+      require_relative "version"
       puts "v#{Coinpare::VERSION}"
     end
-    map %w(--version -v) => :version
+    map %w[--version -v] => :version
   end
 end

data/lib/coinpare/command.rb

@@ -3,22 +3,22 @@
 module Coinpare
   class Command
     SYMBOLS = {
-      down_arrow: '▼',
-      up_arrow: '▲'
+      down_arrow: "▼",
+      up_arrow: "▲"
     }.freeze
 
     # The default interval for auto updating data
     DEFAULT_INTERVAL = 5
 
-    trap('SIGINT') { exit }
+    trap("SIGINT") { exit }
 
     # Main configuration
     # @api public
     def config
       @config ||= begin
         config = TTY::Config.new
-        config.filename = 'coinpare'
-        config.extname = '.toml'
+        config.filename = "coinpare"
+        config.extname = ".toml"
         config.append_path Dir.pwd
         config.append_path Dir.home
         config
@@ -28,7 +28,7 @@ module Coinpare
     # Time for when the data was fetched
     # @api public
     def timestamp
-      "#{Time.now.strftime("%d %B %Y")} at #{Time.now.strftime("%I:%M:%S %p %Z")}"
+      "#{Time.now.strftime('%d %B %Y')} at #{Time.now.strftime('%I:%M:%S %p %Z')}"
     end
 
     # The exchange, currency & time banner
@@ -43,6 +43,7 @@ module Coinpare
     # @api public
     def pick_arrow(change)
       return if change.zero?
+
       change > 0 ? SYMBOLS[:up_arrow] : SYMBOLS[:down_arrow]
     end
 
@@ -52,6 +53,7 @@ module Coinpare
 
     def pick_color(change)
       return :none if change.zero?
+
       change > 0 ? :green : :red
     end
 
@@ -64,29 +66,30 @@ module Coinpare
     end
 
     def shorten_currency(value)
-      if value > 10 ** 9
-         (value / 10 ** 9).to_f.round(2).to_s + ' B'
-      elsif value > 10 ** 6
-        (value / 10 ** 6).to_f.round(2).to_s + ' M'
+      if value > 10**9
+        "#{(value / 10**9).to_f.round(2)} B"
+      elsif value > 10**6
+        "#{(value / 10**6).to_f.round(2)} M"
       else
         value
       end
     end
 
     def precision(value, decimals = 2)
-      part = value.to_s.split('.')[1]
+      part = value.to_s.split(".")[1]
       return 0 if part.nil?
+
       value.between?(0, 1) ? (part.index(/[^0]/) + decimals) : decimals
     end
 
     def round_to(value, prec = nil)
       prec = precision(value) if prec.nil?
-      "%.#{prec}f" % value
+      format("%.#{prec}f", value)
     end
 
     def number_to_currency(value)
-      whole, part = value.to_s.split('.')
-      part = '.' + part unless part.nil?
+      whole, part = value.to_s.split(".")
+      part = "." + part unless part.nil?
       "#{whole.gsub(/(\d)(?=(\d{3})+(?!\d))/, '\\1,')}#{part}"
     end
 
@@ -106,7 +109,7 @@ module Coinpare
     #
     # @api public
     def cursor
-      require 'tty-cursor'
+      require "tty-cursor"
       TTY::Cursor
     end
 
@@ -116,7 +119,7 @@ module Coinpare
     #
     # @api public
     def editor
-      require 'tty-editor'
+      require "tty-editor"
       TTY::Editor
     end
 
@@ -126,7 +129,7 @@ module Coinpare
     #
     # @api public
     def screen
-      require 'tty-screen'
+      require "tty-screen"
       TTY::Screen
     end
   end # Command

data/lib/coinpare/commands/coins.rb

@@ -1,13 +1,13 @@
 # frozen_string_literal: true
 
-require 'pastel'
-require 'tty-pager'
-require 'tty-spinner'
-require 'tty-table'
-require 'timers'
+require "pastel"
+require "tty-pager"
+require "tty-spinner"
+require "tty-table"
+require "timers"
 
-require_relative '../command'
-require_relative '../fetcher'
+require_relative "../command"
+require_relative "../fetcher"
 
 module Coinpare
   module Commands
@@ -17,7 +17,7 @@ module Coinpare
         @options = options
         @pastel = Pastel.new
         @timers = Timers::Group.new
-        @spinner = TTY::Spinner.new(':spinner Fetching data...',
+        @spinner = TTY::Spinner.new(":spinner Fetching data...",
                                     format: :dots, clear: true)
       end
 
@@ -25,9 +25,9 @@ module Coinpare
         pager = TTY::Pager.new(output: output)
         @spinner.auto_spin
 
-        if @options['watch']
+        if @options["watch"]
           output.print cursor.hide
-          interval = @options['watch'].to_f > 0 ? @options['watch'].to_f : DEFAULT_INTERVAL
+          interval = @options["watch"].to_f > 0 ? @options["watch"].to_f : DEFAULT_INTERVAL
           @timers.now_and_every(interval) { display_coins(output, pager) }
           loop { @timers.wait }
         else
@@ -35,7 +35,7 @@ module Coinpare
         end
       ensure
         @spinner.stop
-        if @options['watch']
+        if @options["watch"]
           @timers.cancel
           output.print cursor.clear_screen_down
           output.print cursor.show
@@ -48,10 +48,11 @@ module Coinpare
         if @names.empty? # no coins provided
           @names = setup_top_coins
         end
-        response = Fetcher.fetch_prices(@names.map(&:upcase).join(','),
-                                        @options['base'].upcase, @options)
+        response = Fetcher.fetch_prices(@names.map(&:upcase).join(","),
+                                        @options["base"].upcase, @options)
         return unless response
-        table = setup_table(response['RAW'], response['DISPLAY'])
+
+        table = setup_table(response["RAW"], response["DISPLAY"])
         @spinner.stop
 
         lines = banner(@options).lines.size + 1 + table.rows_size + 3
@@ -59,9 +60,9 @@ module Coinpare
       end
 
       def clear_output(output, lines)
-        output.print cursor.clear_screen_down if @options['watch']
+        output.print cursor.clear_screen_down if @options["watch"]
         yield if block_given?
-        output.print cursor.up(lines) if @options['watch']
+        output.print cursor.up(lines) if @options["watch"]
       end
 
       def print_results(table, output, pager)
@@ -77,41 +78,44 @@ module Coinpare
       end
 
       def setup_top_coins
-        response = Fetcher.fetch_top_coins_by_volume(@options['base'].upcase,
+        response = Fetcher.fetch_top_coins_by_volume(@options["base"].upcase,
                                                      @options)
         return unless response
-        response['Data'].map { |coin| coin['CoinInfo']['Name'] }[0...@options['top']]
+
+        response["Data"].map { |coin| coin["CoinInfo"]["Name"] }[0...@options["top"]]
       end
 
       def setup_table(raw_data, display_data)
         table = TTY::Table.new(header: [
-          { value: 'Coin', alignment: :left },
-          'Price',
-          'Chg. 24H',
-          'Chg.% 24H',
-          'Open 24H',
-          'High 24H',
-          'Low 24H',
-          'Direct Vol. 24H',
-          'Total Vol. 24H',
-          'Market Cap'
+          { value: "Coin", alignment: :left },
+          "Price",
+          "Chg. 24H",
+          "Chg.% 24H",
+          "Open 24H",
+          "High 24H",
+          "Low 24H",
+          "Direct Vol. 24H",
+          "Total Vol. 24H",
+          "Market Cap"
         ])
 
         @names.each do |name|
-          coin_data = display_data[name.upcase][@options['base'].upcase]
-          coin_raw_data = raw_data[name.upcase][@options['base'].upcase]
-          change24h = coin_raw_data['CHANGE24HOUR']
+          coin_data = display_data[name.upcase][@options["base"].upcase]
+          coin_raw_data = raw_data[name.upcase][@options["base"].upcase]
+          change24h = coin_raw_data["CHANGE24HOUR"]
           coin_details = [
             { value: add_color(name.upcase, :yellow), alignment: :left },
-            add_color(coin_data['PRICE'], pick_color(change24h)),
-            add_color("#{pick_arrow(change24h)} #{coin_data['CHANGE24HOUR']}", pick_color(change24h)),
-            add_color("#{pick_arrow(change24h)} #{coin_data['CHANGEPCT24HOUR']}%", pick_color(change24h)),
-            coin_data['OPEN24HOUR'],
-            coin_data['HIGH24HOUR'],
-            coin_data['LOW24HOUR'],
-            coin_data['VOLUME24HOURTO'],
-            coin_data['TOTALVOLUME24HTO'],
-            coin_data['MKTCAP']
+            add_color(coin_data["PRICE"], pick_color(change24h)),
+            add_color("#{pick_arrow(change24h)} #{coin_data['CHANGE24HOUR']}",
+                      pick_color(change24h)),
+            add_color("#{pick_arrow(change24h)} #{coin_data['CHANGEPCT24HOUR']}%",
+                      pick_color(change24h)),
+            coin_data["OPEN24HOUR"],
+            coin_data["HIGH24HOUR"],
+            coin_data["LOW24HOUR"],
+            coin_data["VOLUME24HOURTO"],
+            coin_data["TOTALVOLUME24HTO"],
+            coin_data["MKTCAP"]
           ]
           table << coin_details
         end