coinbase-sdk 0.0.5 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 98cd32134ee8acb14c9dc018f39e7af188646b546998c4182cd50d7ae75f2816
-  data.tar.gz: df6ff19c63798ec10f054972aa75edef79fe65ae39c93cbe0941c77db251e5d6
+  metadata.gz: 82ed68757d7f8c6d946fed0b3220fe8657d07926bef5f90c50bb279ebb035087
+  data.tar.gz: 3b1df1f99ac447f197d0b636ca3d617c670142a42159a42f12a9c60fb2982c0e
 SHA512:
-  metadata.gz: a209d25aa72fc185fb667a5ef7b8de617341dba449b0a02b15ad95bc0c434140932353e12258f4665b35ef60e37b5346efca76db811cc5a308cfc69b907f37b8
-  data.tar.gz: 8856f048ea3ecb664559665e2422d60b6c12d607526aea4bea75f8e8273cf0584b2206e14dcb4e99bdca3436114b03961558be36029b40614d018028f9d41183
+  metadata.gz: 0d943a6ff62431d82b72f58ed48fa13f48297c57ef39e7d9efc3afe45141a8d85ffc327f5fbaba9f250c366d398e1961cc61ec2619f3ae7cdaff8012664b6f18
+  data.tar.gz: 391942f2797f2c5e8bed4adeff0cfb159f5f8bea90ad4bdebc61a5904929687bbcf73006e14ad1c5f5d9e3d8fb4ee57cbd33ac84af21928fd7b6685004aed63b

data/lib/coinbase/address.rb

@@ -71,59 +71,44 @@ module Coinbase
       Coinbase::Balance.from_model_and_asset_id(response, asset_id).amount
     end
 
-    # Transfers the given amount of the given Asset to the given address. Only same-Network Transfers are supported.
+    # Transfers the given amount of the given Asset to the specified address or wallet.
+    # Only same-network Transfers are supported.
     # @param amount [Integer, Float, BigDecimal] The amount of the Asset to send.
     # @param asset_id [Symbol] The ID of the Asset to send. For Ether, :eth, :gwei, and :wei are supported.
     # @param destination [Wallet | Address | String] The destination of the transfer. If a Wallet, sends to the Wallet's
     #  default address. If a String, interprets it as the address ID.
-    # @return [String] The hash of the Transfer transaction.
+    # @return [Coinbase::Transfer] The Transfer object.
     def transfer(amount, asset_id, destination)
-      raise 'Cannot transfer from address without private key loaded' if @key.nil?
+      destination_address, destination_network = destination_address_and_network(destination)
 
-      raise ArgumentError, "Unsupported asset: #{asset_id}" unless Coinbase::Asset.supported?(asset_id)
-
-      if destination.is_a?(Wallet)
-        raise ArgumentError, 'Transfer must be on the same Network' if destination.network_id != network_id
+      validate_can_transfer!(amount, asset_id, destination_network)
 
-        destination = destination.default_address.id
-      elsif destination.is_a?(Address)
-        raise ArgumentError, 'Transfer must be on the same Network' if destination.network_id != network_id
+      transfer = create_transfer(amount, asset_id, destination_address)
 
-        destination = destination.id
-      end
-
-      current_balance = balance(asset_id)
-      if current_balance < amount
-        raise ArgumentError, "Insufficient funds: #{amount} requested, but only #{current_balance} available"
-      end
+      # If a server signer is managing keys, it will sign and broadcast the underlying transfer transaction out of band.
+      return transfer if Coinbase.use_server_signer?
 
-      create_transfer_request = {
-        amount: Coinbase::Asset.to_atomic_amount(amount, asset_id).to_i.to_s,
-        network_id: network_id,
-        asset_id: Coinbase::Asset.primary_denomination(asset_id).to_s,
-        destination: destination
-      }
-
-      transfer_model = Coinbase.call_api do
-        transfers_api.create_transfer(wallet_id, id, create_transfer_request)
-      end
+      broadcast_transfer(transfer, transfer.transaction.sign(@key))
+    end
 
-      transfer = Coinbase::Transfer.new(transfer_model)
+    # Trades the given amount of the given Asset for another Asset.
+    # Only same-network Trades are supported.
+    # @param amount [Integer, Float, BigDecimal] The amount of the Asset to send.
+    # @param from_asset_id [Symbol] The ID of the Asset to trade from. For Ether, :eth, :gwei, and :wei are supported.
+    # @param to_asset_id [Symbol] The ID of the Asset to trade to. For Ether, :eth, :gwei, and :wei are supported.
+    # @return [Coinbase::Trade] The Trade object.
+    def trade(amount, from_asset_id, to_asset_id)
+      validate_can_trade!(amount, from_asset_id, to_asset_id)
 
-      transaction = transfer.transaction
-      transaction.sign(@key)
+      trade = create_trade(amount, from_asset_id, to_asset_id)
 
-      signed_payload = transaction.hex
+      # NOTE: Trading does not yet support server signers at this point.
 
-      broadcast_transfer_request = {
-        signed_payload: signed_payload
-      }
+      payloads = { signed_payload: trade.transaction.sign(@key) }
 
-      transfer_model = Coinbase.call_api do
-        transfers_api.broadcast_transfer(wallet_id, id, transfer.id, broadcast_transfer_request)
-      end
+      payloads[:approve_tx_signed_payload] = trade.approve_transaction.sign(@key) unless trade.approve_transaction.nil?
 
-      Coinbase::Transfer.new(transfer_model)
+      broadcast_trade(trade, **payloads)
     end
 
     # Returns whether the Address has a private key backing it to sign transactions.
@@ -170,12 +155,13 @@ module Coinbase
       page = nil
 
       loop do
-        puts "fetch transfers page: #{page}"
         response = Coinbase.call_api do
           transfers_api.list_transfers(wallet_id, id, { limit: 100, page: page })
         end
 
-        transfers.concat(response.data.map { |transfer| Coinbase::Transfer.new(transfer) }) if response.data
+        break if response.data.empty?
+
+        transfers.concat(response.data.map { |transfer| Coinbase::Transfer.new(transfer) })
 
         break unless response.has_more
 
@@ -194,5 +180,92 @@ module Coinbase
     def transfers_api
       @transfers_api ||= Coinbase::Client::TransfersApi.new(Coinbase.configuration.api_client)
     end
+
+    def trades_api
+      @trades_api ||= Coinbase::Client::TradesApi.new(Coinbase.configuration.api_client)
+    end
+
+    def destination_address_and_network(destination)
+      return [destination.default_address.id, destination.network_id] if destination.is_a?(Wallet)
+      return [destination.id, destination.network_id] if destination.is_a?(Address)
+
+      [destination, network_id]
+    end
+
+    def validate_can_transfer!(amount, asset_id, destination_network_id)
+      raise 'Cannot transfer from address without private key loaded' unless can_sign? || Coinbase.use_server_signer?
+
+      raise ArgumentError, "Unsupported asset: #{asset_id}" unless Coinbase::Asset.supported?(asset_id)
+
+      raise ArgumentError, 'Transfer must be on the same Network' unless destination_network_id == network_id
+
+      current_balance = balance(asset_id)
+
+      return unless current_balance < amount
+
+      raise ArgumentError, "Insufficient funds: #{amount} requested, but only #{current_balance} available"
+    end
+
+    def create_transfer(amount, asset_id, destination)
+      create_transfer_request = {
+        amount: Coinbase::Asset.to_atomic_amount(amount, asset_id).to_i.to_s,
+        network_id: network_id,
+        asset_id: Coinbase::Asset.primary_denomination(asset_id).to_s,
+        destination: destination
+      }
+
+      transfer_model = Coinbase.call_api do
+        transfers_api.create_transfer(wallet_id, id, create_transfer_request)
+      end
+
+      Coinbase::Transfer.new(transfer_model)
+    end
+
+    def broadcast_transfer(transfer, signed_payload)
+      transfer_model = Coinbase.call_api do
+        transfers_api.broadcast_transfer(wallet_id, id, transfer.id, { signed_payload: signed_payload })
+      end
+
+      Coinbase::Transfer.new(transfer_model)
+    end
+
+    def validate_can_trade!(amount, from_asset_id, to_asset_id)
+      raise 'Cannot trade from address without private key loaded' unless can_sign?
+
+      raise ArgumentError, "Unsupported from asset: #{from_asset_id}" unless Coinbase::Asset.supported?(from_asset_id)
+      raise ArgumentError, "Unsupported to asset: #{to_asset_id}" unless Coinbase::Asset.supported?(to_asset_id)
+
+      current_balance = balance(from_asset_id)
+
+      return unless current_balance < amount
+
+      raise ArgumentError, "Insufficient funds: #{amount} requested, but only #{current_balance} available"
+    end
+
+    def create_trade(amount, from_asset_id, to_asset_id)
+      create_trade_request = {
+        amount: Coinbase::Asset.to_atomic_amount(amount, from_asset_id).to_i.to_s,
+        from_asset_id: Coinbase::Asset.primary_denomination(from_asset_id).to_s,
+        to_asset_id: Coinbase::Asset.primary_denomination(to_asset_id).to_s
+      }
+
+      trade_model = Coinbase.call_api do
+        trades_api.create_trade(wallet_id, id, create_trade_request)
+      end
+
+      Coinbase::Trade.new(trade_model)
+    end
+
+    def broadcast_trade(trade, signed_payload:, approve_tx_signed_payload: nil)
+      req = { signed_payload: signed_payload }
+
+      req[:approve_transaction_signed_payload] = approve_tx_signed_payload unless approve_tx_signed_payload.nil?
+
+      trade_model = Coinbase.call_api do
+        trades_api.broadcast_trade(wallet_id, id, trade.id, req)
+      end
+
+      Coinbase::Trade.new(trade_model)
+    end
   end
 end

data/lib/coinbase/asset.rb

@@ -61,26 +61,40 @@ module Coinbase
       asset_id
     end
 
+    def self.from_model(asset_model)
+      raise unless asset_model.is_a?(Coinbase::Client::Asset)
+
+      new(
+        network_id: Coinbase.to_sym(asset_model.network_id),
+        asset_id: Coinbase.to_sym(asset_model.asset_id),
+        address_id: asset_model.contract_address,
+        decimals: asset_model.decimals
+      )
+    end
+
     # Returns a new Asset object. Do not use this method. Instead, use the Asset constants defined in
     # the Coinbase module.
     # @param network_id [Symbol] The ID of the Network to which the Asset belongs
     # @param asset_id [Symbol] The Asset ID
-    # @param display_name [String] The Asset's display name
+    # @param display_name [String] (Optional) The Asset's display name
     # @param address_id [String] (Optional) The Asset's address ID, if one exists
-    def initialize(network_id:, asset_id:, display_name:, address_id: nil)
+    # @param decimals [Integer] (Optional) The number of decimal places the Asset uses
+    def initialize(network_id:, asset_id:, display_name: nil, address_id: nil, decimals: nil)
       @network_id = network_id
       @asset_id = asset_id
       @display_name = display_name
       @address_id = address_id
+      @decimals = decimals
     end
 
-    attr_reader :network_id, :asset_id, :display_name, :address_id
+    attr_reader :network_id, :asset_id, :display_name, :address_id, :decimals
 
     # Returns a string representation of the Asset.
     # @return [String] a string representation of the Asset
     def to_s
       "Coinbase::Asset{network_id: '#{network_id}', asset_id: '#{asset_id}', display_name: '#{display_name}'" +
-        (address_id.nil? ? '}' : ", address_id: '#{address_id}'}")
+        (address_id.nil? ? '}' : ", address_id: '#{address_id}'}") +
+        (decimals.nil? ? '}' : ", decimals: '#{decimals}'}")
     end
 
     # Same as to_s.

data/lib/coinbase/authenticator.rb

@@ -38,7 +38,7 @@ module Coinbase
 
       claims = {
         sub: Coinbase.configuration.api_key_name,
-        iss: 'coinbase-cloud',
+        iss: 'cdp',
         aud: ['cdp_service'],
         nbf: Time.now.to_i,
         exp: Time.now.to_i + 60, # Expiration time: 1 minute from now.