coin-market 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c9be0ef5ce58c0040b1440851a69f245cb612e4b
-  data.tar.gz: e49e6b1f8b10bd4a9f1c07fadbed2f8b6444a7cf
+  metadata.gz: 0ff1e42ac06a874df93f4bd2cf40b6eb0663cc03
+  data.tar.gz: 594415f9d72f6706c481a548c9ab51298291caf6
 SHA512:
-  metadata.gz: c4049b1bd97d675cba02081748a6c8054d88035e54d415ae238c23a0d91b47172a9702217ad94073e6227048b5f2731bf297a37de9657a8d094b70e519a374ef
-  data.tar.gz: 9d2e438cfac8c061c569d4380bfcc0fcc9584b189fc1807915d64eedb8532723f62981094b0aac4e1306d6764e512d198eb3fb30af078be968e33cdca678880a
+  metadata.gz: 53c576528f25bc90d4312f6fe9dbc963bbb973f050219a17c80637de58e80fed37349af9c519d75552a4db69a1b0b9d2988f32f4cc5651819b699233b1864487
+  data.tar.gz: 0e11716c23d6f3e8710ba46391a47ee4f6f45194671e5e41d54184f087aaab9ab8f33f64ac9cbf36b2e4b2c98ef4343a9930dbd61f66a9446f6807b9fd89cae4

data/README.md

@@ -22,9 +22,13 @@ Or install it yourself as:
 ## Usage
 
 ### Korbit
+
+https://apidocs.korbit.co.kr/
+
 ```ruby
 require 'coin-market'
 
+# ticker
 korbit = Coin::Market::Korbit.new
 response = korbit.get_ticker_btc_krw
 => {"timestamp"=>1512415955593, "last"=>"13357500"}
@@ -38,6 +42,31 @@ response = korbit.get_ticker_eth_krw
 response = korbit.get_ticker_xrp_krw
 => {"timestamp"=>1512415720622, "last"=>"286"}
 
+
+# ticker detail
+korbit.get_ticker_detailed_btc_krw
+=> {"timestamp"=>1512419385635,
+ "last"=>"13410000",
+ "bid"=>"13410000",
+ "ask"=>"13410500",
+ "low"=>"12833000",
+ "high"=>"13500000",
+ "volume"=>"4690.751945329017480177",
+ "change"=>"43500",
+ "changePercent"=>"0.33"}
+
+korbit.get_ticker_detailed_eth_krw
+=> {"timestamp"=>1512418570222,
+ "last"=>"542900",
+ "bid"=>"542450",
+ "ask"=>"542950",
+ "low"=>"532400",
+ "high"=>"549800",
+ "volume"=>"23443.919674902796768231",
+ "change"=>"-50",
+ "changePercent"=>"-0.01"}
+
+
 ```
 
 ### Coinone

data/coin-market.gemspec

@@ -26,6 +26,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.2"
   
-  spec.add_dependency "rest-client", "~> 2.1"
+  spec.add_dependency "rest-client", "~> 2.0"
   spec.required_ruby_version = ">= 2.0.0"
 end

data/lib/coin/market.rb

@@ -6,47 +6,77 @@ require 'json'
 module Coin
   module Market
     BTC_KRW = "btc_krw"
+    ETH_KRW = "eth_krw"
     ETC_KRW = "etc_krw"
     XRP_KRW = "xrp_krw"
     BCH_KRW = "bch_krw"
+
+    SUPPORT_CURRENCY = [BTC_KRW, ETH_KRW, ETC_KRW, XRP_KRW, BCH_KRW]
     
     class Korbit
       GET_TICKER = "https://api.korbit.co.kr/v1/ticker"
+      GET_TICKER_DETAILED = "https://api.korbit.co.kr/v1/ticker/detailed"
 
-      def get_ticker_btc_krw()
-        get_ticker(BTC_KRW)
-      end
+      def self.create_method(currency)
+        define_method "get_ticker_#{currency}" do
+          get_ticker(currency)
+        end
 
-      def get_ticker_eth_krw()
-        get_ticker(ETC_KRW)
+        define_method "get_ticker_detailed_#{currency}" do
+          get_ticker_detailed(currency)
+        end
       end
 
-      def get_ticker_xrp_krw()
-        get_ticker(XRP_KRW)
+      create_method(BTC_KRW)
+      create_method(ETH_KRW)
+      create_method(ETC_KRW)
+      create_method(XRP_KRW)
+      create_method(BCH_KRW)
+      
+
+      def get_ticker_detailed(currency_pair)
+        unless is_supported_ticker(currency_pair)
+          raise Exceptions::CannotSupportException, __method__ + currency_pair
+        end
+
+        ticker = _process_api(get_ticker_detailed_with_currency_pair(currency_pair))
+
+        if ticker.nil?
+          raise Exceptions::NetworkException, __method__ + currency_pair
+        end
+        ticker
       end
 
-      def get_ticker_bch_krw()
-        get_ticker(BCH_KRW)
+      def _process_api(url)
+        http_response = RestClient.get(url)
+        JSON.parse(http_response.body)
       end
-      
+
       def get_ticker(currency_pair)
         unless is_supported_ticker(currency_pair)
-          raise Exceptions::CannotSupportException, 'get_ticker_' + currency_pair
+          raise Exceptions::CannotSupportException, __method__ + currency_pair
         end
-        http_response = RestClient.get(make_currency_pair(currency_pair))
-        ticker = JSON.parse(http_response.body)
+
+        ticker = _process_api(get_ticker_with_currency_pair(currency_pair))
+
         if ticker.nil?
-          raise Exceptions::NetworkException, 'get_ticker_' + currency_pair
+          raise Exceptions::NetworkException, __method__ + currency_pair
         end
         ticker
       end
 
-      def make_currency_pair(currency_pair)
+      private
+
+      def get_ticker_with_currency_pair(currency_pair)
         GET_TICKER + "?=currency_pair=" + currency_pair
       end
 
+      def get_ticker_detailed_with_currency_pair(currency_pair)
+        GET_TICKER_DETAILED + "?=currency_pair=" + currency_pair
+      end
+      
       def is_supported_ticker(currency_pair)
-        currency_pair == BTC_KRW || currency_pair == ETC_KRW || currency_pair == XRP_KRW || currency_pair == BCH_KRW
+        SUPPORT_CURRENCY.include?(currency_pair)
       end
 
     end

data/lib/coin/market/version.rb

@@ -1,5 +1,5 @@
 module Coin
   module Market
-    VERSION = "0.1.0"
+    VERSION = "0.2.0"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: coin-market
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - suhanlee
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: '2.0'
 description: Coin Marekts API Libary including korbit, bitthumb, coinone, coinnest
 email:
 - suhan.lee.k@gmail.com