cognition 2.0.8 → 2.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 32aec8b43747dc3d4e93dde52b11976060dee440
-  data.tar.gz: 29694fbdf558c9599f7867d14985ccd05e50bce0
+SHA256:
+  metadata.gz: b3b0f0c99709eaabea164fe5e9f7cd5022331b28f39f74024f2a5d52fdcd8b1d
+  data.tar.gz: ef2823646928bfdd3ff9e60e9b91e980181a08af2a445a919404ebba1709e43c
 SHA512:
-  metadata.gz: f14281cbedf9470605b6fcf454b1f862c5f0e0a58297a0afa6e16f7279a04ffafdbfa71824a8963d6c0bd8ba900bbfc0c90513238c837107e3e6678886569e59
-  data.tar.gz: b6bae92cad86c46c055d33ef13ca60f67f6159c8628d4710e195ae0f73e10db90510b5fada35a6d820c3aaaa313d4e3a200e95b3ecf172d39e1c23a2a1d3dc99
+  metadata.gz: 6f53ef31b1ec20592b7a23b45c492a598515fac294e442a4ce6f35e4d97fed345afd4e131fc63707c07dbe9f0a2024695b55608f21c345196c1489c61138fba0
+  data.tar.gz: 06230123d76191225a842b675d05f277399c1184758068fcd0357b23beef18208cd2f529e0247ceec72440d5ef8a1012e93c820136fce85ad0fee35e4833fcc2

data/README.md

@@ -62,7 +62,9 @@ msg.reply("foo")   # Posts 'content=foo' to http://foo.bar/baz
 
 ## Creating a Plugin
 Creating plugins is easy. Subclass `Cognition::Plugins::Base` and setup your
-matches and logic that should be run:
+matches and logic that should be run.  Your methods will be passed the `msg`
+object and any `metadata` you've passed to the bot's `process` method.  Here's
+an example plugin:
 ```ruby
 class Hello < Cognition::Plugins::Base
   # Simple string based matcher. Must match *EXACTLY*

data/cognition.gemspec

@@ -18,12 +18,12 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "httparty", "~> 0.8"
-  spec.add_dependency "tilt", "~> 1.4"
+  spec.add_dependency "httparty", "~> 0.15"
+  spec.add_dependency "tilt", "~> 2.0"
 
   spec.add_development_dependency "bundler", "~> 1.7"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "minitest", "~> 5.0"
   spec.add_development_dependency "webmock", "~> 1.20"
-  spec.add_development_dependency "haml", "~> 4.0"
+  spec.add_development_dependency "haml", "~> 5.0"
 end

data/lib/cognition/bot.rb

@@ -45,7 +45,7 @@ module Cognition
     def process_msg(msg)
       response = false
       matchers.each do |matcher|
-        if matcher.attempt(msg)
+        if matcher.attempt(msg) != false
           response = matcher.response
           break
         end

data/lib/cognition/matcher.rb

@@ -4,7 +4,7 @@ module Cognition
 
     def initialize(trigger, options = {}, &action)
       fail ArgumentError, "matcher must have a trigger" unless trigger
-      fail ArgumentError, "matcher must have a action" unless action
+      fail ArgumentError, "matcher must have an action" unless action
       @trigger = trigger
       @help = options[:help] ||= {}
       @action = action
@@ -18,12 +18,13 @@ module Cognition
 
     def attempt(msg)
       return false unless matches?(msg)
-
       run(msg)
     end
 
     def run(msg)
-      @response = action.call(msg, match_data)
+      @response = action.call(msg, match_data).to_s
+    rescue => e
+      @response = "#{e.class}: #{e.message}\n#{e.backtrace.join("\n")}"
     end
 
     def matches?(msg)

data/lib/cognition/plugins/cognition/plugins/default/views/help.html.erb

@@ -1,7 +1,5 @@
-<table>
+<ul>
 <% @help.each do |text| %>
-  <tr>
-    <td><%= CGI.escapeHTML(text) %></td>
-  </tr>
+  <li><%= CGI.escapeHTML(text) %></li>
 <% end %>
-</table>
+</ul>

data/lib/cognition/plugins/default.rb

@@ -19,7 +19,7 @@ module Cognition
       def help(msg, match_data = nil)
         type = msg.metadata[:type] ||= "text"
         if match_data[:command].nil? || match_data[:command].empty?
-          @help = bot.help
+          @help = bot.help.sort
         else
           @help = bot.help.find_all { |text| text.match match_data[:command] }
         end

data/lib/cognition/version.rb

@@ -1,3 +1,3 @@
 module Cognition
-  VERSION = "2.0.8"
+  VERSION = "2.1.3"
 end

data/test/test_default_plugin.rb

@@ -7,7 +7,7 @@ class DefaultPluginTest < Minitest::Test
   end
 
   def test_returns_help
-    help = "ping - Test if the endpoint is responding. Returns PONG.\nhelp - Lists all commands with help\nhelp <command> - Lists help for <command>"
+    help = "help - Lists all commands with help\nhelp <command> - Lists help for <command>\nping - Test if the endpoint is responding. Returns PONG."
     assert_equal help, @bot.process("help")
   end
 

data/test/test_matcher.rb

@@ -74,8 +74,26 @@ class MatcherTest < Minitest::Test
     matcher_with_help = Cognition::Matcher.new(/hello\s*(?<name>.*)/, { help: { "hello" => "says hello" } }, &proc(&method(:dummy_method)))
     assert_equal ["hello - says hello"], matcher_with_help.help
   end
+
+  def test_raises_exception_when_command_fails
+    msg = Cognition::Message.new("boom")
+    matcher = Cognition::Matcher.new(/boom/, {}, &proc(&method(:blow_up)))
+    matcher.attempt(msg)
+    assert matcher.response.include? "ZeroDivisionError"
+  end
+
+  def test_empty_response_is_not_a_failure
+    msg = Cognition::Message.new("empty")
+    matcher = Cognition::Matcher.new(/empty/, {}, &proc {})
+    matcher.attempt(msg)
+    assert_equal "", matcher.response
+  end
 end
 
 def dummy_method(_, match_data)
   "Hello #{match_data['name']}"
 end
+
+def blow_up(msg, match_data)
+  raise ZeroDivisionError, "divided by 0"
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cognition
 version: !ruby/object:Gem::Version
-  version: 2.0.8
+  version: 2.1.3
 platform: ruby
 authors:
 - Nathan Anderson
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2016-09-14 00:00:00.000000000 Z
+date: 2024-02-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '0.15'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '0.15'
 - !ruby/object:Gem::Dependency
   name: tilt
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.4'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.4'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -100,14 +100,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '5.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '5.0'
 description: Match text; run commands. Works great for building a chatbot!
 email:
 - andnat@gmail.com
@@ -153,7 +153,7 @@ homepage: https://github.com/basecamp/cognition
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -168,9 +168,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.1
-signing_key: 
+rubygems_version: 3.5.4
+signing_key:
 specification_version: 4
 summary: A rules engine for running commands.
 test_files: