coffeelint 0.2.6 → 0.2.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 344ed179d709d31cb9cfc849b08bfee88b8aec30
-  data.tar.gz: 505057ae769bedb0e2703c0190cb3bf248a68e3e
+  metadata.gz: c911352ec2b63e923e39d097f0e77bfa86e78e11
+  data.tar.gz: 48e9f7be428f2c7db10e1842cc44e3b98f39471e
 SHA512:
-  metadata.gz: 2d810eeab5acfc59ff90273a0c084dac875a059fc05bba4caf09a3e84b727649d766b7c344f1092d6a92a45c879314c4a5bd7dc2a60b189e97aed0590da755a5
-  data.tar.gz: c7f271a95c8c5dfc6c9b85b77bdab7f4f3c973380877415adab41fb7bee057add6fe00bc60bee59119987149a332fb9f8b2d6615d3563e6e8a03983dc8ddc831
+  metadata.gz: c9514800789c878c521b808a94e1f9220bd5686f70a392915acfd482495b77878a3729ea65db813809986abd6866bf569be40ea8934d6241e0d641e52c9346c7
+  data.tar.gz: 3e23fb9822c1e448cdf0f15c563bd87d6f9a4e65a728a1dc1e696c2d28a141c1ae7d8c9c2f0030f03e35b408e460974f29fb36d250b5e6bfb634bde0e1ac5b19

data/.gitmodules

@@ -1,3 +1,3 @@
 [submodule "coffeelint"]
 	path = coffeelint
-	url = git://github.com/zmbush/coffeelint.git
+	url = git://github.com/clutchski/coffeelint.git

data/README.md

@@ -1,6 +1,6 @@
 # Coffeelint [![Build Status](https://travis-ci.org/zmbush/coffeelint-ruby.svg?branch=master)](https://travis-ci.org/zmbush/coffeelint-ruby) [![Gem Version](https://badge.fury.io/rb/coffeelint.png)](http://badge.fury.io/rb/coffeelint)
 
-Using coffeelint version: v1.2.0-6-g20613f6
+Using coffeelint version: v1.3.0
 
 Coffeelint is a set of simple ruby bindings for [coffeelint](https://github.com/clutchski/coffeelint).
 

data/coffeelint/lib/coffeelint.js

@@ -2,7 +2,7 @@
 module.exports={
   "name": "coffeelint",
   "description": "Lint your CoffeeScript",
-  "version": "1.2.0",
+  "version": "1.3.0",
   "homepage": "http://www.coffeelint.org",
   "keywords": [
     "lint",
@@ -460,6 +460,8 @@ coffeelint.registerRule(_dereq_('./rules/no_debugger.coffee'));
 
 coffeelint.registerRule(_dereq_('./rules/no_interpolation_in_single_quotes.coffee'));
 
+coffeelint.registerRule(_dereq_('./rules/no_empty_functions.coffee'));
+
 hasSyntaxError = function(source) {
   try {
     CoffeeScript.tokens(source);
@@ -556,7 +558,7 @@ coffeelint.lint = function(source, userConfig, literate) {
 };
 
 
-},{"./../package.json":1,"./ast_linter.coffee":2,"./lexical_linter.coffee":5,"./line_linter.coffee":6,"./rules.coffee":7,"./rules/arrow_spacing.coffee":8,"./rules/camel_case_classes.coffee":9,"./rules/colon_assignment_spacing.coffee":10,"./rules/cyclomatic_complexity.coffee":11,"./rules/duplicate_key.coffee":12,"./rules/empty_constructor_needs_parens.coffee":13,"./rules/indentation.coffee":14,"./rules/line_endings.coffee":15,"./rules/max_line_length.coffee":16,"./rules/missing_fat_arrows.coffee":17,"./rules/newlines_after_classes.coffee":18,"./rules/no_backticks.coffee":19,"./rules/no_debugger.coffee":20,"./rules/no_empty_param_list.coffee":21,"./rules/no_implicit_braces.coffee":22,"./rules/no_implicit_parens.coffee":23,"./rules/no_interpolation_in_single_quotes.coffee":24,"./rules/no_plusplus.coffee":25,"./rules/no_stand_alone_at.coffee":26,"./rules/no_tabs.coffee":27,"./rules/no_throwing_strings.coffee":28,"./rules/no_trailing_semicolons.coffee":29,"./rules/no_trailing_whitespace.coffee":30,"./rules/no_unnecessary_double_quotes.coffee":31,"./rules/no_unnecessary_fat_arrows.coffee":32,"./rules/non_empty_constructor_needs_parens.coffee":33,"./rules/space_operators.coffee":34}],5:[function(_dereq_,module,exports){
+},{"./../package.json":1,"./ast_linter.coffee":2,"./lexical_linter.coffee":5,"./line_linter.coffee":6,"./rules.coffee":7,"./rules/arrow_spacing.coffee":8,"./rules/camel_case_classes.coffee":9,"./rules/colon_assignment_spacing.coffee":10,"./rules/cyclomatic_complexity.coffee":11,"./rules/duplicate_key.coffee":12,"./rules/empty_constructor_needs_parens.coffee":13,"./rules/indentation.coffee":14,"./rules/line_endings.coffee":15,"./rules/max_line_length.coffee":16,"./rules/missing_fat_arrows.coffee":17,"./rules/newlines_after_classes.coffee":18,"./rules/no_backticks.coffee":19,"./rules/no_debugger.coffee":20,"./rules/no_empty_functions.coffee":21,"./rules/no_empty_param_list.coffee":22,"./rules/no_implicit_braces.coffee":23,"./rules/no_implicit_parens.coffee":24,"./rules/no_interpolation_in_single_quotes.coffee":25,"./rules/no_plusplus.coffee":26,"./rules/no_stand_alone_at.coffee":27,"./rules/no_tabs.coffee":28,"./rules/no_throwing_strings.coffee":29,"./rules/no_trailing_semicolons.coffee":30,"./rules/no_trailing_whitespace.coffee":31,"./rules/no_unnecessary_double_quotes.coffee":32,"./rules/no_unnecessary_fat_arrows.coffee":33,"./rules/non_empty_constructor_needs_parens.coffee":34,"./rules/space_operators.coffee":35}],5:[function(_dereq_,module,exports){
 var BaseLinter, LexicalLinter, TokenApi,
   __hasProp = {}.hasOwnProperty,
   __extends = function(child, parent) { for (var key in parent) { if (__hasProp.call(parent, key)) child[key] = parent[key]; } function ctor() { this.constructor = child; } ctor.prototype = parent.prototype; child.prototype = new ctor(); child.__super__ = parent.prototype; return child; },
@@ -1353,7 +1355,7 @@ module.exports = MaxLineLength = (function() {
     var limitComments, lineLength, max, _ref, _ref1;
     max = (_ref = lineApi.config[this.rule.name]) != null ? _ref.value : void 0;
     limitComments = (_ref1 = lineApi.config[this.rule.name]) != null ? _ref1.limitComments : void 0;
-    lineLength = line.length;
+    lineLength = line.trimRight().length;
     if (lineApi.isLiterate() && regexes.literateComment.test(line)) {
       lineLength -= 2;
     }
@@ -1571,6 +1573,50 @@ module.exports = NoDebugger = (function() {
 
 
 },{}],21:[function(_dereq_,module,exports){
+var NoEmptyFunctions, isEmptyCode;
+
+isEmptyCode = function(node, astApi) {
+  var nodeName;
+  nodeName = astApi.getNodeName(node);
+  return nodeName === 'Code' && node.body.isEmpty();
+};
+
+module.exports = NoEmptyFunctions = (function() {
+  function NoEmptyFunctions() {}
+
+  NoEmptyFunctions.prototype.rule = {
+    name: 'no_empty_functions',
+    level: 'ignore',
+    message: 'Empty function',
+    description: "Disallows declaring empty functions. The goal of this rule is that\nunintentional empty callbacks can be detected:\n<pre>\n<code>someFunctionWithCallback ->\ndoSomethingSignificant()\n</code>\n</pre>\nThe problem is that the call to\n<tt>doSomethingSignificant</tt> will be made regardless\nof <tt>someFunctionWithCallback</tt>'s execution. It can\nbe because you did not indent the call to\n<tt>doSomethingSignificant</tt> properly.\n\nIf you really meant that <tt>someFunctionWithCallback</tt>\nshould call a callback that does nothing, you can write your code\nthis way:\n<pre>\n<code>someFunctionWithCallback ->\n    undefined\ndoSomethingSignificant()\n</code>\n</pre>"
+  };
+
+  NoEmptyFunctions.prototype.lintAST = function(node, astApi) {
+    this.lintNode(node, astApi);
+    return void 0;
+  };
+
+  NoEmptyFunctions.prototype.lintNode = function(node, astApi) {
+    var error;
+    if (isEmptyCode(node, astApi)) {
+      error = astApi.createError({
+        lineNumber: node.locationData.first_line + 1
+      });
+      this.errors.push(error);
+    }
+    return node.eachChild((function(_this) {
+      return function(child) {
+        return _this.lintNode(child, astApi);
+      };
+    })(this));
+  };
+
+  return NoEmptyFunctions;
+
+})();
+
+
+},{}],22:[function(_dereq_,module,exports){
 var NoEmptyParamList;
 
 module.exports = NoEmptyParamList = (function() {
@@ -1596,7 +1642,7 @@ module.exports = NoEmptyParamList = (function() {
 })();
 
 
-},{}],22:[function(_dereq_,module,exports){
+},{}],23:[function(_dereq_,module,exports){
 var NoImplicitBraces;
 
 module.exports = NoImplicitBraces = (function() {
@@ -1645,7 +1691,7 @@ module.exports = NoImplicitBraces = (function() {
 })();
 
 
-},{}],23:[function(_dereq_,module,exports){
+},{}],24:[function(_dereq_,module,exports){
 var NoImplicitParens;
 
 module.exports = NoImplicitParens = (function() {
@@ -1687,7 +1733,7 @@ module.exports = NoImplicitParens = (function() {
 })();
 
 
-},{}],24:[function(_dereq_,module,exports){
+},{}],25:[function(_dereq_,module,exports){
 var NoInterpolationInSingleQuotes;
 
 module.exports = NoInterpolationInSingleQuotes = (function() {
@@ -1714,7 +1760,7 @@ module.exports = NoInterpolationInSingleQuotes = (function() {
 })();
 
 
-},{}],25:[function(_dereq_,module,exports){
+},{}],26:[function(_dereq_,module,exports){
 var NoPlusPlus;
 
 module.exports = NoPlusPlus = (function() {
@@ -1740,7 +1786,7 @@ module.exports = NoPlusPlus = (function() {
 })();
 
 
-},{}],26:[function(_dereq_,module,exports){
+},{}],27:[function(_dereq_,module,exports){
 var NoStandAloneAt;
 
 module.exports = NoStandAloneAt = (function() {
@@ -1776,7 +1822,7 @@ module.exports = NoStandAloneAt = (function() {
 })();
 
 
-},{}],27:[function(_dereq_,module,exports){
+},{}],28:[function(_dereq_,module,exports){
 var NoTabs, indentationRegex,
   __indexOf = [].indexOf || function(item) { for (var i = 0, l = this.length; i < l; i++) { if (i in this && this[i] === item) return i; } return -1; };
 
@@ -1807,7 +1853,7 @@ module.exports = NoTabs = (function() {
 })();
 
 
-},{}],28:[function(_dereq_,module,exports){
+},{}],29:[function(_dereq_,module,exports){
 var NoThrowingStrings;
 
 module.exports = NoThrowingStrings = (function() {
@@ -1834,7 +1880,7 @@ module.exports = NoThrowingStrings = (function() {
 })();
 
 
-},{}],29:[function(_dereq_,module,exports){
+},{}],30:[function(_dereq_,module,exports){
 var NoTrailingSemicolons, regexes,
   __slice = [].slice;
 
@@ -1883,7 +1929,7 @@ module.exports = NoTrailingSemicolons = (function() {
 })();
 
 
-},{}],30:[function(_dereq_,module,exports){
+},{}],31:[function(_dereq_,module,exports){
 var NoTrailingWhitespace, regexes;
 
 regexes = {
@@ -1946,7 +1992,7 @@ module.exports = NoTrailingWhitespace = (function() {
 })();
 
 
-},{}],31:[function(_dereq_,module,exports){
+},{}],32:[function(_dereq_,module,exports){
 var NoUnnecessaryDoubleQuotes;
 
 module.exports = NoUnnecessaryDoubleQuotes = (function() {
@@ -1999,7 +2045,7 @@ module.exports = NoUnnecessaryDoubleQuotes = (function() {
 })();
 
 
-},{}],32:[function(_dereq_,module,exports){
+},{}],33:[function(_dereq_,module,exports){
 var NoUnnecessaryFatArrows, any,
   __bind = function(fn, me){ return function(){ return fn.apply(me, arguments); }; };
 
@@ -2076,7 +2122,7 @@ module.exports = NoUnnecessaryFatArrows = (function() {
 })();
 
 
-},{}],33:[function(_dereq_,module,exports){
+},{}],34:[function(_dereq_,module,exports){
 var NonEmptyConstructorNeedsParens, ParentClass,
   __hasProp = {}.hasOwnProperty,
   __extends = function(child, parent) { for (var key in parent) { if (__hasProp.call(parent, key)) child[key] = parent[key]; } function ctor() { this.constructor = child; } ctor.prototype = parent.prototype; child.prototype = new ctor(); child.__super__ = parent.prototype; return child; };
@@ -2108,7 +2154,7 @@ module.exports = NonEmptyConstructorNeedsParens = (function(_super) {
 })(ParentClass);
 
 
-},{"./empty_constructor_needs_parens.coffee":13}],34:[function(_dereq_,module,exports){
+},{"./empty_constructor_needs_parens.coffee":13}],35:[function(_dereq_,module,exports){
 var SpaceOperators,
   __indexOf = [].indexOf || function(item) { for (var i = 0, l = this.length; i < l; i++) { if (i in this && this[i] === item) return i; } return -1; };
 

data/lib/coffeelint.rb

@@ -69,9 +69,9 @@ module Coffeelint
       puts "  #{good} " + Coffeelint.green(name, pretty_output)
       return true
     else
-      failed = false
+      no_failures = true
       if errors.any? {|e| e["level"] == "error"}
-        failed = true
+        no_failures = false
         puts "  #{bad} " + Coffeelint.red(name, pretty_output)
       else
         puts "  #{warn} " + Coffeelint.yellow(name, pretty_output)
@@ -93,7 +93,7 @@ module Coffeelint
         end
         puts ": #{error["message"]}. #{error["context"]}."
       end
-      return failed
+      return no_failures
     end
   end
 

data/lib/coffeelint/version.rb

@@ -1,3 +1,3 @@
 module Coffeelint
-  VERSION = "0.2.6"
+  VERSION = "0.2.7"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: coffeelint
 version: !ruby/object:Gem::Version
-  version: 0.2.6
+  version: 0.2.7
 platform: ruby
 authors:
 - Zachary Bush
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-09 00:00:00.000000000 Z
+date: 2014-04-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: coffee-script