coffeelint 0.2.3 → 0.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 12213463c6912beabd247d01c967b81a52e1ba65
-  data.tar.gz: 440bdcd9141c0acdb17b6bae17fee664bd561ee8
+  metadata.gz: 52e26570cb6aeb608b13718ee0643a3587799f5b
+  data.tar.gz: 87ca1b9e93e502ab77443fd76ab7f8b227c098cd
 SHA512:
-  metadata.gz: 1b65aaf5269d62114576b8543bdcaec783e7d1cb9e7d634340dfe5cc4781ff270e0ba2a1fff7e8a65c9fdaf74e6782d1ab550b4139311ddbad97d378630e4e22
-  data.tar.gz: 75cf7d50c532da9d6e57d8dd2066389d5e0d6f572d532d7488bc160dcac7d6046206b8246691cbc6b955e740aa6a84021e039db48749107d576b91b252204f3a
+  metadata.gz: 4bb4389a7e90c880e22ffb9a11f4e881a70225749c410a707d37c8e59d7e0c028c2386d979659804eaa4d612054c93bc817cba2f382ac42640f085a9ce6c5e26
+  data.tar.gz: 0dda5a52009fe77364cc10812362b249dd48368410d3796700e2d0c521a44ecfb53bd17419d66a4b836e9fe8bdccd5b82edd4b1fedb6199f6328254e6c55c40e

data/.gitmodules

@@ -1,3 +1,3 @@
 [submodule "coffeelint"]
 	path = coffeelint
-	url = git://github.com/clutchski/coffeelint.git
+	url = git://github.com/zmbush/coffeelint.git

data/README.md

@@ -1,6 +1,6 @@
 # Coffeelint [![Build Status](https://travis-ci.org/zmbush/coffeelint-ruby.svg?branch=master)](https://travis-ci.org/zmbush/coffeelint-ruby) [![Gem Version](https://badge.fury.io/rb/coffeelint.png)](http://badge.fury.io/rb/coffeelint)
 
-Using coffeelint version: v1.1.0
+Using coffeelint version: v1.1.0-21-g5dc0408-20-gc896693
 
 Coffeelint is a set of simple ruby bindings for [coffeelint](https://github.com/clutchski/coffeelint).
 

data/coffeelint.gemspec

@@ -21,6 +21,7 @@ Gem::Specification.new do |gem|
 
   gem.add_dependency "coffee-script"
   gem.add_dependency "json"
+  gem.add_dependency "execjs"
 
   gem.add_development_dependency 'rspec'
   gem.add_development_dependency 'rake'

data/coffeelint/lib/coffeelint.js

@@ -25,7 +25,7 @@ module.exports={
     "optimist": ">=0.2.8",
     "coffee-script": "~1.7",
     "glob": ">=3.1.9",
-    "browserify": "~3.x",
+    "browserify": "~3.37",
     "coffeeify": "~0.6.0"
   },
   "devDependencies": {
@@ -53,17 +53,61 @@ module.exports={
 }
 
 },{}],2:[function(_dereq_,module,exports){
-var ASTApi, ASTLinter, BaseLinter,
+var ASTApi, ASTLinter, BaseLinter, hasChildren, node_children,
   __hasProp = {}.hasOwnProperty,
   __extends = function(child, parent) { for (var key in parent) { if (__hasProp.call(parent, key)) child[key] = parent[key]; } function ctor() { this.constructor = child; } ctor.prototype = parent.prototype; child.prototype = new ctor(); child.__super__ = parent.prototype; return child; };
 
 BaseLinter = _dereq_('./base_linter.coffee');
 
+node_children = {
+  Class: ['variable', 'parent', 'body'],
+  Code: ['params', 'body'],
+  For: ['body', 'source', 'guard', 'step'],
+  If: ['condition', 'body', 'elseBody'],
+  Obj: ['properties'],
+  Op: ['first', 'second'],
+  Switch: ['subject', 'cases', 'otherwise'],
+  Try: ['attempt', 'recovery', 'ensure'],
+  Value: ['base', 'properties'],
+  While: ['condition', 'guard', 'body']
+};
+
+hasChildren = function(node, children) {
+  var _ref;
+  return (node != null ? (_ref = node.children) != null ? _ref.length : void 0 : void 0) === children.length && (node != null ? node.children.every(function(elem, i) {
+    return elem === children[i];
+  }) : void 0);
+};
+
 ASTApi = (function() {
   function ASTApi(config) {
     this.config = config;
   }
 
+  ASTApi.prototype.getNodeName = function(node) {
+    var children, name, _ref;
+    name = node != null ? (_ref = node.constructor) != null ? _ref.name : void 0 : void 0;
+    if (name === (function() {
+      var _results;
+      _results = [];
+      for (name in node_children) {
+        if (!__hasProp.call(node_children, name)) continue;
+        _results.push(name);
+      }
+      return _results;
+    })()) {
+      return name;
+    } else {
+      for (name in node_children) {
+        if (!__hasProp.call(node_children, name)) continue;
+        children = node_children[name];
+        if (hasChildren(node, children)) {
+          return name;
+        }
+      }
+    }
+  };
+
   return ASTApi;
 
 })();
@@ -418,6 +462,12 @@ coffeelint.registerRule(_dereq_('./rules/missing_fat_arrows.coffee'));
 
 coffeelint.registerRule(_dereq_('./rules/non_empty_constructor_needs_parens.coffee'));
 
+coffeelint.registerRule(_dereq_('./rules/no_unnecessary_double_quotes.coffee'));
+
+coffeelint.registerRule(_dereq_('./rules/no_debugger.coffee'));
+
+coffeelint.registerRule(_dereq_('./rules/no_interpolation_in_single_quotes.coffee'));
+
 hasSyntaxError = function(source) {
   try {
     CoffeeScript.tokens(source);
@@ -514,7 +564,7 @@ coffeelint.lint = function(source, userConfig, literate) {
 };
 
 
-},{"./../package.json":1,"./ast_linter.coffee":2,"./lexical_linter.coffee":5,"./line_linter.coffee":6,"./rules.coffee":7,"./rules/arrow_spacing.coffee":8,"./rules/camel_case_classes.coffee":9,"./rules/colon_assignment_spacing.coffee":10,"./rules/cyclomatic_complexity.coffee":11,"./rules/duplicate_key.coffee":12,"./rules/empty_constructor_needs_parens.coffee":13,"./rules/indentation.coffee":14,"./rules/line_endings.coffee":15,"./rules/max_line_length.coffee":16,"./rules/missing_fat_arrows.coffee":17,"./rules/newlines_after_classes.coffee":18,"./rules/no_backticks.coffee":19,"./rules/no_empty_param_list.coffee":20,"./rules/no_implicit_braces.coffee":21,"./rules/no_implicit_parens.coffee":22,"./rules/no_plusplus.coffee":23,"./rules/no_stand_alone_at.coffee":24,"./rules/no_tabs.coffee":25,"./rules/no_throwing_strings.coffee":26,"./rules/no_trailing_semicolons.coffee":27,"./rules/no_trailing_whitespace.coffee":28,"./rules/no_unnecessary_fat_arrows.coffee":29,"./rules/non_empty_constructor_needs_parens.coffee":30,"./rules/space_operators.coffee":31}],5:[function(_dereq_,module,exports){
+},{"./../package.json":1,"./ast_linter.coffee":2,"./lexical_linter.coffee":5,"./line_linter.coffee":6,"./rules.coffee":7,"./rules/arrow_spacing.coffee":8,"./rules/camel_case_classes.coffee":9,"./rules/colon_assignment_spacing.coffee":10,"./rules/cyclomatic_complexity.coffee":11,"./rules/duplicate_key.coffee":12,"./rules/empty_constructor_needs_parens.coffee":13,"./rules/indentation.coffee":14,"./rules/line_endings.coffee":15,"./rules/max_line_length.coffee":16,"./rules/missing_fat_arrows.coffee":17,"./rules/newlines_after_classes.coffee":18,"./rules/no_backticks.coffee":19,"./rules/no_debugger.coffee":20,"./rules/no_empty_param_list.coffee":21,"./rules/no_implicit_braces.coffee":22,"./rules/no_implicit_parens.coffee":23,"./rules/no_interpolation_in_single_quotes.coffee":24,"./rules/no_plusplus.coffee":25,"./rules/no_stand_alone_at.coffee":26,"./rules/no_tabs.coffee":27,"./rules/no_throwing_strings.coffee":28,"./rules/no_trailing_semicolons.coffee":29,"./rules/no_trailing_whitespace.coffee":30,"./rules/no_unnecessary_double_quotes.coffee":31,"./rules/no_unnecessary_fat_arrows.coffee":32,"./rules/non_empty_constructor_needs_parens.coffee":33,"./rules/space_operators.coffee":34}],5:[function(_dereq_,module,exports){
 var BaseLinter, LexicalLinter, TokenApi,
   __hasProp = {}.hasOwnProperty,
   __extends = function(child, parent) { for (var key in parent) { if (__hasProp.call(parent, key)) child[key] = parent[key]; } function ctor() { this.constructor = child; } ctor.prototype = parent.prototype; child.prototype = new ctor(); child.__super__ = parent.prototype; return child; },
@@ -978,7 +1028,7 @@ module.exports = NoTabs = (function() {
 
   NoTabs.prototype.getComplexity = function(node) {
     var complexity, name, _ref;
-    name = node.constructor.name;
+    name = this.astApi.getNodeName(node);
     complexity = name === 'If' || name === 'While' || name === 'For' || name === 'Try' ? 1 : name === 'Op' && ((_ref = node.operator) === '&&' || _ref === '||') ? 1 : name === 'Switch' ? node.cases.length : 0;
     return complexity;
   };
@@ -990,8 +1040,8 @@ module.exports = NoTabs = (function() {
   };
 
   NoTabs.prototype.lintNode = function(node, line) {
-    var complexity, error, name, rule;
-    name = node.constructor.name;
+    var complexity, error, name, rule, _ref;
+    name = (_ref = this.astApi) != null ? _ref.getNodeName(node) : void 0;
     complexity = this.getComplexity(node);
     node.eachChild((function(_this) {
       return function(childNode) {
@@ -1333,60 +1383,25 @@ module.exports = MaxLineLength = (function() {
 
 
 },{}],17:[function(_dereq_,module,exports){
-var MissingFatArrows, any, isClass, isCode, isFatArrowCode, isObject, isThis, isValue, methodsOfClass, needsFatArrow,
+var MissingFatArrows, any,
+  __bind = function(fn, me){ return function(){ return fn.apply(me, arguments); }; },
   __indexOf = [].indexOf || function(item) { for (var i = 0, l = this.length; i < l; i++) { if (i in this && this[i] === item) return i; } return -1; };
 
-isCode = function(node) {
-  return (node != null ? node.constructor.name : void 0) === 'Code';
-};
-
-isClass = function(node) {
-  return node.constructor.name === 'Class';
-};
-
-isValue = function(node) {
-  return node.constructor.name === 'Value';
-};
-
-isObject = function(node) {
-  return node.constructor.name === 'Obj';
-};
-
-isThis = function(node) {
-  return isValue(node) && node.base.value === 'this';
-};
-
-isFatArrowCode = function(node) {
-  return isCode(node) && node.bound;
-};
-
 any = function(arr, test) {
   return arr.reduce((function(res, elt) {
     return res || test(elt);
   }), false);
 };
 
-needsFatArrow = function(node) {
-  return isCode(node) && (any(node.params, function(param) {
-    return param.contains(isThis) != null;
-  }) || (node.body.contains(isThis) != null));
-};
-
-methodsOfClass = function(classNode) {
-  var bodyNodes, returnNode;
-  bodyNodes = classNode.body.expressions;
-  returnNode = bodyNodes[bodyNodes.length - 1];
-  if ((returnNode != null) && isValue(returnNode) && isObject(returnNode.base)) {
-    return returnNode.base.properties.map(function(assignNode) {
-      return assignNode.value;
-    }).filter(isCode);
-  } else {
-    return [];
-  }
-};
-
 module.exports = MissingFatArrows = (function() {
-  function MissingFatArrows() {}
+  function MissingFatArrows() {
+    this.isFatArrowCode = __bind(this.isFatArrowCode, this);
+    this.isThis = __bind(this.isThis, this);
+    this.isObject = __bind(this.isObject, this);
+    this.isValue = __bind(this.isValue, this);
+    this.isClass = __bind(this.isClass, this);
+    this.isCode = __bind(this.isCode, this);
+  }
 
   MissingFatArrows.prototype.rule = {
     name: 'missing_fat_arrows',
@@ -1396,37 +1411,83 @@ module.exports = MissingFatArrows = (function() {
   };
 
   MissingFatArrows.prototype.lintAST = function(node, astApi) {
-    this.lintNode(node, astApi);
+    this.astApi = astApi;
+    this.lintNode(node);
     return void 0;
   };
 
-  MissingFatArrows.prototype.lintNode = function(node, astApi, methods) {
+  MissingFatArrows.prototype.lintNode = function(node, methods) {
     var error;
     if (methods == null) {
       methods = [];
     }
-    if ((!isFatArrowCode(node)) && (__indexOf.call(methods, node) < 0) && (needsFatArrow(node))) {
-      error = astApi.createError({
+    if ((!this.isFatArrowCode(node)) && (__indexOf.call(methods, node) < 0) && (this.needsFatArrow(node))) {
+      error = this.astApi.createError({
         lineNumber: node.locationData.first_line + 1
       });
       this.errors.push(error);
     }
     return node.eachChild((function(_this) {
       return function(child) {
-        return _this.lintNode(child, astApi, (function() {
+        return _this.lintNode(child, (function() {
           switch (false) {
-            case !isClass(node):
-              return methodsOfClass(node);
-            case !isCode(node):
+            case !this.isClass(node):
+              return this.methodsOfClass(node);
+            case !this.isCode(node):
               return [];
             default:
               return methods;
           }
-        })());
+        }).call(_this));
       };
     })(this));
   };
 
+  MissingFatArrows.prototype.isCode = function(node) {
+    return this.astApi.getNodeName(node) === 'Code';
+  };
+
+  MissingFatArrows.prototype.isClass = function(node) {
+    return this.astApi.getNodeName(node) === 'Class';
+  };
+
+  MissingFatArrows.prototype.isValue = function(node) {
+    return this.astApi.getNodeName(node) === 'Value';
+  };
+
+  MissingFatArrows.prototype.isObject = function(node) {
+    return this.astApi.getNodeName(node) === 'Obj';
+  };
+
+  MissingFatArrows.prototype.isThis = function(node) {
+    return this.isValue(node) && node.base.value === 'this';
+  };
+
+  MissingFatArrows.prototype.isFatArrowCode = function(node) {
+    return this.isCode(node) && node.bound;
+  };
+
+  MissingFatArrows.prototype.needsFatArrow = function(node) {
+    return this.isCode(node) && (any(node.params, (function(_this) {
+      return function(param) {
+        return param.contains(_this.isThis) != null;
+      };
+    })(this)) || (node.body.contains(this.isThis) != null));
+  };
+
+  MissingFatArrows.prototype.methodsOfClass = function(classNode) {
+    var bodyNodes, returnNode;
+    bodyNodes = classNode.body.expressions;
+    returnNode = bodyNodes[bodyNodes.length - 1];
+    if ((returnNode != null) && this.isValue(returnNode) && this.isObject(returnNode.base)) {
+      return returnNode.base.properties.map(function(assignNode) {
+        return assignNode.value;
+      }).filter(this.isCode);
+    } else {
+      return [];
+    }
+  };
+
   return MissingFatArrows;
 
 })();
@@ -1492,6 +1553,32 @@ module.exports = NoBackticks = (function() {
 
 
 },{}],20:[function(_dereq_,module,exports){
+var NoDebugger;
+
+module.exports = NoDebugger = (function() {
+  function NoDebugger() {}
+
+  NoDebugger.prototype.rule = {
+    name: 'no_debugger',
+    level: 'warn',
+    message: 'Debugger statements will cause warnings',
+    description: "This rule detects the `debugger` statement.\nThis rule is `warn` by default."
+  };
+
+  NoDebugger.prototype.tokens = ["DEBUGGER"];
+
+  NoDebugger.prototype.lintToken = function(token, tokenApi) {
+    return {
+      context: "found '" + token[0] + "'"
+    };
+  };
+
+  return NoDebugger;
+
+})();
+
+
+},{}],21:[function(_dereq_,module,exports){
 var NoEmptyParamList;
 
 module.exports = NoEmptyParamList = (function() {
@@ -1517,7 +1604,7 @@ module.exports = NoEmptyParamList = (function() {
 })();
 
 
-},{}],21:[function(_dereq_,module,exports){
+},{}],22:[function(_dereq_,module,exports){
 var NoImplicitBraces;
 
 module.exports = NoImplicitBraces = (function() {
@@ -1566,7 +1653,7 @@ module.exports = NoImplicitBraces = (function() {
 })();
 
 
-},{}],22:[function(_dereq_,module,exports){
+},{}],23:[function(_dereq_,module,exports){
 var NoImplicitParens;
 
 module.exports = NoImplicitParens = (function() {
@@ -1574,15 +1661,33 @@ module.exports = NoImplicitParens = (function() {
 
   NoImplicitParens.prototype.rule = {
     name: 'no_implicit_parens',
+    strict: true,
     level: 'ignore',
     message: 'Implicit parens are forbidden',
     description: "This rule prohibits implicit parens on function calls.\n<pre>\n<code># Some folks don't like this style of coding.\nmyFunction a, b, c\n\n# And would rather it always be written like this:\nmyFunction(a, b, c)\n</code>\n</pre>\nImplicit parens are permitted by default, since their use is\nidiomatic CoffeeScript."
   };
 
-  NoImplicitParens.prototype.tokens = ["CALL_START"];
+  NoImplicitParens.prototype.tokens = ["CALL_END"];
 
   NoImplicitParens.prototype.lintToken = function(token, tokenApi) {
-    return token.generated;
+    var i, t;
+    if (token.generated) {
+      if (tokenApi.config[this.rule.name].strict !== false) {
+        return true;
+      } else {
+        i = -1;
+        while (true) {
+          t = tokenApi.peek(i);
+          if ((t == null) || t[0] === 'CALL_START') {
+            return true;
+          }
+          if (t.newLine) {
+            return null;
+          }
+          i -= 1;
+        }
+      }
+    }
   };
 
   return NoImplicitParens;
@@ -1590,7 +1695,34 @@ module.exports = NoImplicitParens = (function() {
 })();
 
 
-},{}],23:[function(_dereq_,module,exports){
+},{}],24:[function(_dereq_,module,exports){
+var NoInterpolationInSingleQuotes;
+
+module.exports = NoInterpolationInSingleQuotes = (function() {
+  function NoInterpolationInSingleQuotes() {}
+
+  NoInterpolationInSingleQuotes.prototype.rule = {
+    name: 'no_interpolation_in_single_quotes',
+    level: 'ignore',
+    message: 'Interpolation in single quoted strings is forbidden',
+    description: 'This rule prohibits string interpolation in a single quoted string.\n<pre>\n<code># String interpolation in single quotes is not allowed:\nfoo = \'#{bar}\'\n\n# Double quotes is OK of course\nfoo = "#{bar}"\n</code>\n</pre>\nString interpolation in single quoted strings is permitted by \ndefault.'
+  };
+
+  NoInterpolationInSingleQuotes.prototype.tokens = ['STRING'];
+
+  NoInterpolationInSingleQuotes.prototype.lintToken = function(token, tokenApi) {
+    var hasInterpolation, tokenValue;
+    tokenValue = token[1];
+    hasInterpolation = tokenValue.match(/#\{[^}]+\}/);
+    return hasInterpolation;
+  };
+
+  return NoInterpolationInSingleQuotes;
+
+})();
+
+
+},{}],25:[function(_dereq_,module,exports){
 var NoPlusPlus;
 
 module.exports = NoPlusPlus = (function() {
@@ -1616,7 +1748,7 @@ module.exports = NoPlusPlus = (function() {
 })();
 
 
-},{}],24:[function(_dereq_,module,exports){
+},{}],26:[function(_dereq_,module,exports){
 var NoStandAloneAt;
 
 module.exports = NoStandAloneAt = (function() {
@@ -1652,7 +1784,7 @@ module.exports = NoStandAloneAt = (function() {
 })();
 
 
-},{}],25:[function(_dereq_,module,exports){
+},{}],27:[function(_dereq_,module,exports){
 var NoTabs, indentationRegex,
   __indexOf = [].indexOf || function(item) { for (var i = 0, l = this.length; i < l; i++) { if (i in this && this[i] === item) return i; } return -1; };
 
@@ -1683,7 +1815,7 @@ module.exports = NoTabs = (function() {
 })();
 
 
-},{}],26:[function(_dereq_,module,exports){
+},{}],28:[function(_dereq_,module,exports){
 var NoThrowingStrings;
 
 module.exports = NoThrowingStrings = (function() {
@@ -1710,7 +1842,7 @@ module.exports = NoThrowingStrings = (function() {
 })();
 
 
-},{}],27:[function(_dereq_,module,exports){
+},{}],29:[function(_dereq_,module,exports){
 var NoTrailingSemicolons, regexes,
   __slice = [].slice;
 
@@ -1759,7 +1891,7 @@ module.exports = NoTrailingSemicolons = (function() {
 })();
 
 
-},{}],28:[function(_dereq_,module,exports){
+},{}],30:[function(_dereq_,module,exports){
 var NoTrailingWhitespace, regexes;
 
 regexes = {
@@ -1822,20 +1954,62 @@ module.exports = NoTrailingWhitespace = (function() {
 })();
 
 
-},{}],29:[function(_dereq_,module,exports){
-var NoUnnecessaryFatArrows, any, isCode, isFatArrowCode, isThis, needsFatArrow;
+},{}],31:[function(_dereq_,module,exports){
+var NoUnnecessaryDoubleQuotes;
 
-isCode = function(node) {
-  return node.constructor.name === 'Code';
-};
+module.exports = NoUnnecessaryDoubleQuotes = (function() {
+  function NoUnnecessaryDoubleQuotes() {}
 
-isFatArrowCode = function(node) {
-  return isCode(node) && node.bound;
-};
+  NoUnnecessaryDoubleQuotes.prototype.rule = {
+    name: 'no_unnecessary_double_quotes',
+    level: 'ignore',
+    message: 'Unnecessary double quotes are forbidden',
+    description: 'This rule prohibits double quotes unless string interpolation is \nused or the string contains single quotes.\n<pre>\n<code># Double quotes are discouraged:\nfoo = "bar"\n\n# Unless string interpolation is used:\nfoo = "#{bar}baz"\n\n# Or they prevent cumbersome escaping:\nfoo = "I\'m just following the \'rules\'"\n</code>\n</pre>\nDouble quotes are permitted by default.'
+  };
 
-isThis = function(node) {
-  return node.constructor.name === 'Value' && node.base.value === 'this';
-};
+  NoUnnecessaryDoubleQuotes.prototype.tokens = ['STRING'];
+
+  NoUnnecessaryDoubleQuotes.prototype.lintToken = function(token, tokenApi) {
+    var hasLegalConstructs, stringValue, tokenValue;
+    tokenValue = token[1];
+    stringValue = tokenValue.match(/^\"(.*)\"$/);
+    if (!stringValue) {
+      return false;
+    }
+    hasLegalConstructs = this.isInterpolated(tokenApi) || this.containsSingleQuote(tokenValue);
+    return !hasLegalConstructs;
+  };
+
+  NoUnnecessaryDoubleQuotes.prototype.isInterpolated = function(tokenApi) {
+    var currentIndex, i, isInterpolated, lineTokens, token, tokenName, _i, _ref;
+    currentIndex = tokenApi.i;
+    isInterpolated = false;
+    lineTokens = tokenApi.tokensByLine[tokenApi.lineNumber];
+    for (i = _i = 1; 1 <= currentIndex ? _i <= currentIndex : _i >= currentIndex; i = 1 <= currentIndex ? ++_i : --_i) {
+      token = tokenApi.peek(-i);
+      tokenName = token[0];
+      if (tokenName === ')' && token.stringEnd) {
+        break;
+      } else if (tokenName === '(' && ((_ref = token.origin) != null ? _ref[1] : void 0) === "string interpolation") {
+        isInterpolated = true;
+        break;
+      }
+    }
+    return isInterpolated;
+  };
+
+  NoUnnecessaryDoubleQuotes.prototype.containsSingleQuote = function(tokenValue) {
+    return tokenValue.indexOf("'") !== -1;
+  };
+
+  return NoUnnecessaryDoubleQuotes;
+
+})();
+
+
+},{}],32:[function(_dereq_,module,exports){
+var NoUnnecessaryFatArrows, any,
+  __bind = function(fn, me){ return function(){ return fn.apply(me, arguments); }; };
 
 any = function(arr, test) {
   return arr.reduce((function(res, elt) {
@@ -1843,16 +2017,11 @@ any = function(arr, test) {
   }), false);
 };
 
-needsFatArrow = function(node) {
-  return isCode(node) && (any(node.params, function(param) {
-    return param.contains(isThis) != null;
-  }) || (node.body.contains(isThis) != null) || (node.body.contains(function(child) {
-    return isFatArrowCode(child) && needsFatArrow(child);
-  }) != null));
-};
-
 module.exports = NoUnnecessaryFatArrows = (function() {
-  function NoUnnecessaryFatArrows() {}
+  function NoUnnecessaryFatArrows() {
+    this.needsFatArrow = __bind(this.needsFatArrow, this);
+    this.isThis = __bind(this.isThis, this);
+  }
 
   NoUnnecessaryFatArrows.prototype.rule = {
     name: 'no_unnecessary_fat_arrows',
@@ -1862,31 +2031,60 @@ module.exports = NoUnnecessaryFatArrows = (function() {
   };
 
   NoUnnecessaryFatArrows.prototype.lintAST = function(node, astApi) {
-    this.lintNode(node, astApi);
+    this.astApi = astApi;
+    this.lintNode(node);
     return void 0;
   };
 
-  NoUnnecessaryFatArrows.prototype.lintNode = function(node, astApi) {
+  NoUnnecessaryFatArrows.prototype.lintNode = function(node) {
     var error;
-    if ((isFatArrowCode(node)) && (!needsFatArrow(node))) {
-      error = astApi.createError({
+    if ((this.isFatArrowCode(node)) && (!this.needsFatArrow(node))) {
+      error = this.astApi.createError({
         lineNumber: node.locationData.first_line + 1
       });
       this.errors.push(error);
     }
     return node.eachChild((function(_this) {
       return function(child) {
-        return _this.lintNode(child, astApi);
+        return _this.lintNode(child);
       };
     })(this));
   };
 
+  NoUnnecessaryFatArrows.prototype.isCode = function(node) {
+    return this.astApi.getNodeName(node) === 'Code';
+  };
+
+  NoUnnecessaryFatArrows.prototype.isFatArrowCode = function(node) {
+    return this.isCode(node) && node.bound;
+  };
+
+  NoUnnecessaryFatArrows.prototype.isValue = function(node) {
+    return this.astApi.getNodeName(node) === 'Value';
+  };
+
+  NoUnnecessaryFatArrows.prototype.isThis = function(node) {
+    return this.isValue(node) && node.base.value === 'this';
+  };
+
+  NoUnnecessaryFatArrows.prototype.needsFatArrow = function(node) {
+    return this.isCode(node) && (any(node.params, (function(_this) {
+      return function(param) {
+        return param.contains(_this.isThis) != null;
+      };
+    })(this)) || (node.body.contains(this.isThis) != null) || (node.body.contains((function(_this) {
+      return function(child) {
+        return _this.isFatArrowCode(child) && _this.needsFatArrow(child);
+      };
+    })(this)) != null));
+  };
+
   return NoUnnecessaryFatArrows;
 
 })();
 
 
-},{}],30:[function(_dereq_,module,exports){
+},{}],33:[function(_dereq_,module,exports){
 var NonEmptyConstructorNeedsParens, ParentClass,
   __hasProp = {}.hasOwnProperty,
   __extends = function(child, parent) { for (var key in parent) { if (__hasProp.call(parent, key)) child[key] = parent[key]; } function ctor() { this.constructor = child; } ctor.prototype = parent.prototype; child.prototype = new ctor(); child.__super__ = parent.prototype; return child; };
@@ -1918,7 +2116,7 @@ module.exports = NonEmptyConstructorNeedsParens = (function(_super) {
 })(ParentClass);
 
 
-},{"./empty_constructor_needs_parens.coffee":13}],31:[function(_dereq_,module,exports){
+},{"./empty_constructor_needs_parens.coffee":13}],34:[function(_dereq_,module,exports){
 var SpaceOperators,
   __indexOf = [].indexOf || function(item) { for (var i = 0, l = this.length; i < l; i++) { if (i in this && this[i] === item) return i; } return -1; };
 

data/lib/coffeelint/version.rb

@@ -1,3 +1,3 @@
 module Coffeelint
-  VERSION = "0.2.3"
+  VERSION = "0.2.5"
 end

data/spec/coffeelint_spec.rb

@@ -18,4 +18,26 @@ describe Coffeelint do
     results = Coffeelint.lint('apple;', :config_file => "/tmp/coffeelint.json")
     results.length.should == 0
   end
+
+  it 'should report missing fat arrow' do
+    results = Coffeelint.lint "hey: ->\n  @bort()\n", :missing_fat_arrows => { :level => "error" }
+    results.length.should == 1
+  end
+
+  it 'should report unnecessary fat arrow' do
+    results = Coffeelint.lint "hey: =>\n  bort()\n", :no_unnecessary_fat_arrows => { :level => "error" }
+    results.length.should == 1
+  end
+
+  it 'should report cyclomatic complexity' do
+    results = Coffeelint.lint(<<-EOF, :cyclomatic_complexity => { :level => "error" })
+      x = ->
+        1 and 2 and 3 and
+        4 and 5 and 6 and
+        7 and 8 and 9 and
+        10 and 11
+    EOF
+    results.length.should == 1
+    results[0]['name'].should == 'cyclomatic_complexity'
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: coffeelint
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.5
 platform: ruby
 authors:
 - Zachary Bush
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-31 00:00:00.000000000 Z
+date: 2014-04-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: coffee-script
@@ -38,6 +38,20 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: execjs
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement