codice-fiscale 0.0.9 → 1.0.0

data/spec/lib/codice_fiscale/italian_citizen_spec.rb

@@ -9,11 +9,11 @@ describe CodiceFiscale::ItalianCitizen do
 
   describe '#initialize' do
     it 'accepts 1 attribute' do
-      lambda { marco }.should_not raise_error
+      expect { marco }.not_to raise_error
     end
 
     it 'do not accepts 0 attribute' do
-      lambda { described_class.new }.should raise_error(ArgumentError)
+      expect { described_class.new }.to raise_error(ArgumentError)
     end
   end
 
@@ -21,8 +21,8 @@ describe CodiceFiscale::ItalianCitizen do
   describe '#validations' do
     describe 'when all attributes are valid' do
       it 'is valid' do
-        marco.should be_valid
-        john.should be_valid
+        expect(marco).to be_valid
+        expect(john).to be_valid
       end
     end
 
@@ -31,7 +31,7 @@ describe CodiceFiscale::ItalianCitizen do
 
       it 'is not valid' do
         citizen_without_name.valid?
-        citizen_without_name.errors[:name].should_not be_empty
+        expect(citizen_without_name.errors[:name]).not_to be_empty
       end
     end
 
@@ -40,7 +40,7 @@ describe CodiceFiscale::ItalianCitizen do
 
       it 'is not valid' do
         citizen_with_strange_gender.valid?
-        citizen_with_strange_gender.errors[:gender].should_not be_empty
+        expect(citizen_with_strange_gender.errors[:gender]).not_to be_empty
       end
     end
 
@@ -49,7 +49,7 @@ describe CodiceFiscale::ItalianCitizen do
 
       it 'is not valid' do
         citizen_with_invalid_province.valid?
-        citizen_with_invalid_province.errors[:province_code].should_not be_empty
+        expect(citizen_with_invalid_province.errors[:province_code]).not_to be_empty
       end
     end
 
@@ -58,7 +58,7 @@ describe CodiceFiscale::ItalianCitizen do
 
       it 'is not valid' do
         citizen_with_invalid_date.valid?
-        citizen_with_invalid_date.errors[:birthdate].should_not be_empty
+        expect(citizen_with_invalid_date.errors[:birthdate]).not_to be_empty
       end
     end
   end

data/spec/lib/codice_fiscale_spec.rb

@@ -1,25 +1,34 @@
+# -*- encoding: utf-8 -*-
 require 'spec_helper'
 
 describe CodiceFiscale do
   describe '#calculate' do
-    let(:mario_attributes) { {:name => 'mario', :surname => 'rossi', :gender => :male, :birthdate => Date.new(1987, 1, 1),
-                              :province_code => 'lc', :city_name => 'Abbadia Lariana'} }
-
     before do
       subject.config.city_code = nil
       subject.config.country_code = nil
     end
 
     it 'returns the expected code' do
-      subject.calculate(mario_attributes).should == 'RSSMRA87A01A005V'
+      # Please note that the following are completely made-up data
+      [
+        [{:name => 'mario', :surname => 'rossi', :gender => :male, :birthdate => Date.new(1987, 1, 1), :province_code => 'lc', :city_name => 'Abbadia Lariana'}, "RSSMRA87A01A005V"],
+        [{:name => "Marco", :surname => "Rossi", :gender => :male, :birthdate => Date.new(1983, 5, 3), :city_name => "Oggiono", :province_code => "LC"}, "RSSMRC83E03G009W"],
+        [{:name => "John", :surname => "Smith", :gender => :male, :birthdate => Date.new(1988, 5, 3), :country_name => "Francia"}, "SMTJHN88E03Z110R"],
+        [{:name => "John", :surname => "Smith", :gender => :male, :birthdate => Date.new(1988, 5, 3), :country_name => "France"}, "SMTJHN88E03Z110R"],
+        [{:name => "John", :surname => "Smith", :gender => :male, :birthdate => Date.new(1988, 5, 3), :country_name => "Sao Tomé e Principe"}, "SMTJHN88E03Z341A"],
+        [{:name => "Marco", :surname => "Rossi", :gender => :male, :birthdate => Date.new(1983, 5, 3), :city_name => "Forlì", :province_code =>"FC"}, "RSSMRC83E03D704X"],
+      ].each do |row|
+        params, expected_code = row[0], row[1]
+        expect(subject.calculate(params)).to eq expected_code
+      end
     end
 
     context 'when params are not valid' do
-      let(:invalid_attributes) { mario_attributes.merge(:name => '') }
+      let(:invalid_attributes) { {:name => ''} }
 
       it 'raises an error' do
-        lambda { subject.calculate(invalid_attributes) }.should raise_error(ArgumentError)
+        expect { subject.calculate(invalid_attributes) }.to raise_error(ArgumentError)
       end
     end
   end
-end
+end

data/spec/spec_helper.rb

@@ -3,5 +3,3 @@ def fixtures_path
 end
 
 require File.expand_path '../../lib/codice_fiscale', __FILE__
-
-

metadata

@@ -1,17 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: codice-fiscale
 version: !ruby/object:Gem::Version
-  version: 0.0.9
+  version: 1.0.0
 platform: ruby
 authors:
 - topac
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-22 00:00:00.000000000 Z
+date: 2019-06-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -25,7 +25,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: guard-rspec
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -39,33 +39,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rb-fsevent
+  name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.1
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.1
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: growl
+  name: rb-fsevent
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.9.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.9.1
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
@@ -94,7 +94,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: Calculate the italian fiscal code
+description: Calculate the Italian Tax ID (Codice Fiscale)
 email:
 - dani.m.mobile@gmail.com
 executables: []
@@ -102,6 +102,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".travis.yml"
 - Gemfile
 - Guardfile
 - LICENSE
@@ -118,16 +119,13 @@ files:
 - lib/codice_fiscale/helpers.rb
 - lib/codice_fiscale/italian_citizen.rb
 - lib/codice_fiscale/version.rb
-- spec/fixtures/city_codes.csv
-- spec/fixtures/country_codes.csv
 - spec/lib/codice_fiscale/alphabet_spec.rb
 - spec/lib/codice_fiscale/codes_spec.rb
 - spec/lib/codice_fiscale/fiscal_code_spec.rb
-- spec/lib/codice_fiscale/helpers_spec.rb
 - spec/lib/codice_fiscale/italian_citizen_spec.rb
 - spec/lib/codice_fiscale_spec.rb
 - spec/spec_helper.rb
-homepage: https://github.com/daniele-m/codice_fiscale
+homepage: https://github.com/topac/codice_fiscale
 licenses: []
 metadata: {}
 post_install_message: 
@@ -145,18 +143,14 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
-summary: Calculate the italian fiscal code
+summary: Calculate the Italian Tax ID (Codice Fiscale)
 test_files:
-- spec/fixtures/city_codes.csv
-- spec/fixtures/country_codes.csv
 - spec/lib/codice_fiscale/alphabet_spec.rb
 - spec/lib/codice_fiscale/codes_spec.rb
 - spec/lib/codice_fiscale/fiscal_code_spec.rb
-- spec/lib/codice_fiscale/helpers_spec.rb
 - spec/lib/codice_fiscale/italian_citizen_spec.rb
 - spec/lib/codice_fiscale_spec.rb
 - spec/spec_helper.rb

data/spec/fixtures/city_codes.csv

@@ -1 +0,0 @@
-CODICE NAZIONALE,CODICE CATASTALE BELFIORE aggiornato al 1/9/1999 ora non pi in uso,PROVINCIA,DENOMINAZIONE COMUNE,ANNOTAZIONE,VARIAZIONE CODICE NAZAZIONALE,VARIAZIONE CODICE CATASTALE,VARIAZIONE PROVINCIA,VARIAZIONE DENOMINAZIONE DEL COMUNE,DATA COSTITUZIONE,DATA VARIAZIONE

data/spec/fixtures/country_codes.csv

@@ -1 +0,0 @@
-CONTIN,SIGLA,DENOMINAZ,CODICE,DATAIST,DATASOP,CODRIF,DATAVARIAZ

data/spec/lib/codice_fiscale/helpers_spec.rb

@@ -1,4 +0,0 @@
-require 'spec_helper'
-
-
-#TODO