coder_wally 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ec3f117479a41d224184d23682f03c5756e9c312
-  data.tar.gz: b3902c02004878ad333b805bbbdae7022f3e451f
+  metadata.gz: 09158bbcb126bc9fbb9fcfd4eaff98d646017548
+  data.tar.gz: 7dc0e8d397038d0f315263dcd530a7ace464775d
 SHA512:
-  metadata.gz: 24434fbdf0747f6b3ccb0173ded350e5b41649604f8d01ccf320da0c6112f9cf770328a1cce5e00c8928db4874eb61be64757e8e1d7edeaa75e1f8b62840a0fa
-  data.tar.gz: 65372cdbe3b2eb38bea2500af500253ee1a643beda3547c050882776fcf84d30f5400d4348765eea5bfec44e74c958088af5697059d9f6a2a2c74c29aee59b72
+  metadata.gz: e0b7f1da6275413792bd7d23d20d430c803d191ce6643b0d00eba7c7b03ba72e06bef77a546bf06be64be0582591f1209c0eae552bd344c348cfe48eb4244e22
+  data.tar.gz: cf18c3a4a70e483dabb092eca36a8f5ba7005fb633db642ffd139d81c5579f5fa662044a7225d27b484cc5c98962d8bb7f91fa9442bb19390f70ce65abe4c7c0

data/.rubocop.yml

@@ -0,0 +1,6 @@
+AllCops:
+  Exclude:
+    - coder_wally.gemspec
+    - Rakefile
+
+inherit_from: .rubocop_todo.yml

data/.rubocop_todo.yml

@@ -0,0 +1,11 @@
+# This configuration was generated by `rubocop --auto-gen-config`
+# on 2015-02-06 22:59:06 +0000 using RuboCop version 0.29.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 2
+# Configuration parameters: AllowURI, URISchemes.
+Metrics/LineLength:
+  Max: 111

data/.ruby-version

@@ -1 +1 @@
-ruby-2.1.5
+ruby-2.1.3

data/README.md

@@ -1,7 +1,8 @@
 # CoderWally 
 
+[![Build Status](https://circleci.com/gh/gregstewart/coder_wally.svg?style=badge)](https://circleci.com/gh/gregstewart/coder_wally)
+
 [![Gem Version](https://badge.fury.io/rb/coder_wally.svg)](http://badge.fury.io/rb/coder_wally)
-[![Build Status](https://travis-ci.org/gregstewart/coder_wally.svg?branch=master)](https://travis-ci.org/gregstewart/coder_wally)
 [![Coverage Status](https://coveralls.io/repos/gregstewart/coder_wally/badge.svg)](https://coveralls.io/r/gregstewart/coder_wally)
 [![Code Climate](https://codeclimate.com/github/gregstewart/coder_wally/badges/gpa.svg)](https://codeclimate.com/github/gregstewart/coder_wally)
 [![Dependency Status](https://gemnasium.com/gregstewart/coder_wally.svg)](https://gemnasium.com/gregstewart/coder_wally)

data/bin/coder_wally

@@ -5,4 +5,4 @@ require 'coder_wally'
 client = CoderWally::Client.new
 coder_wally = client.get_everything_for ARGV[0]
 
-puts coder_wally.inspect
+puts coder_wally.inspect

data/circle.yml

@@ -0,0 +1,6 @@
+machine:
+  ruby:
+    version: 2.1.3
+dependencies:
+  pre:
+    - gem install bundler --version "=1.7"

data/coder_wally.gemspec

@@ -22,4 +22,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "webmock", "~>1.20.4"
   spec.add_development_dependency "coveralls"
+  spec.add_development_dependency "rubocop"
 end

data/lib/coder_wally/account.rb

@@ -5,9 +5,9 @@ module CoderWally
     # Dynamically create account properties
     def initialize(collection_of_accounts)
       collection_of_accounts.each do |account, value|
-        singleton_class.class_eval do; attr_accessor "#{account}"; end
-        self.instance_variable_set("@#{account}", value)
+        singleton_class.class_eval { attr_accessor "#{account}" }
+        instance_variable_set("@#{account}", value)
       end
     end
   end
-end
+end

data/lib/coder_wally/api.rb

@@ -11,50 +11,50 @@ module CoderWally
 
       begin
         JSON.parse(json.read)
-      rescue JSON::ParserError => error
+      rescue JSON::ParserError
         raise InvalidJson, 'Received invalid json in response'
       end
     end
 
     private
-      # Dispatch the request
-      def send_request(url)
-        begin
-          open(url)
-        rescue OpenURI::HTTPError => error
-          handle_user_not_found_error(error)
-          handle_server_error(error)
-        end
-      end
 
-      # Parse status code from error
-      def get_status_code(error)
-        error.io.status[0]
-      end
+    # Dispatch the request
+    def send_request(url)
+      open(url)
+    rescue OpenURI::HTTPError => error
+      handle_user_not_found_error(error)
+      handle_server_error(error)
+    end
 
-      # Raise server error
-      def handle_server_error(error)
-        raise ServerError, 'Server error' if  get_status_code(error) == '500'
-      end
+    # Parse status code from error
+    def get_status_code(error)
+      error.io.status[0]
+    end
 
-      # Raise user not found error
-      def handle_user_not_found_error(error)
-        raise UserNotFoundError, 'User not found' if  get_status_code(error) == '404'
-      end
+    # Raise server error
+    def handle_server_error(error)
+      fail ServerError, 'Server error' if get_status_code(error) == '500'
+    end
 
-      # Build user URI from username and api url
-      def uri_for_user(username)
-        raise(ArgumentError, 'Please provide a username') if username.empty?
+    # Raise user not found error
+    def handle_user_not_found_error(error)
+      fail UserNotFoundError, 'User not found' if get_status_code(error) == '404'
+    end
 
-        URI.parse(api_url % username)
-      end
+    # Build user URI from username and api url
+    def uri_for_user(username)
+      fail ArgumentError, 'Please provide a username' if username.empty?
 
-      # The URL of the API we'll use.
-      def api_url
-        'https://coderwall.com/%s.json'
-      end
+      URI.parse(api_url % username)
+    end
+
+    # The URL of the API we'll use.
+    def api_url
+      'https://coderwall.com/%s.json'
+    end
   end
 end
+
 # Handles user not found exception
 class UserNotFoundError < StandardError
 end
@@ -64,4 +64,4 @@ class ServerError < StandardError
 end
 # Handles bad JSON
 class InvalidJson < StandardError
-end
+end

data/lib/coder_wally/badge.rb

@@ -1,16 +1,16 @@
 # All code in the gem is namespaced under this module.
 module CoderWally
-    # Stores Badge properties
-    class Badge 
-        # Object properties 
-        attr_reader :name, :badge, :description, :created
-        
-        # Initialise object with a hash of values
-        def initialize(hashed_badge)
-          @name = hashed_badge.fetch('name')
-          @badge = hashed_badge.fetch('badge')
-          @description = hashed_badge.fetch('description')
-          @created = hashed_badge.fetch('created')
-        end
+  # Stores Badge properties
+  class Badge
+    # Object properties
+    attr_reader :name, :badge, :description, :created
+
+    # Initialise object with a hash of values
+    def initialize(hashed_badge)
+      @name = hashed_badge.fetch('name')
+      @badge = hashed_badge.fetch('badge')
+      @description = hashed_badge.fetch('description')
+      @created = hashed_badge.fetch('created')
     end
-end
+  end
+end

data/lib/coder_wally/builder.rb

@@ -22,7 +22,7 @@ module CoderWally
     end
 
     # build CoderWall object from API response
-    def build response
+    def build(response)
       badges = parse_badges(response)
       accounts = parse_accounts(response)
       user = parse_user(response)

data/lib/coder_wally/client.rb

@@ -1,34 +1,35 @@
 module CoderWally
-    # Client to access the API
-    class Client
-        # Instantiate class
-        def initialize
-          @api = API.new
-          @builder = Builder.new
-        end
+  # Client to access the API
+  class Client
+    # Instantiate class
+    def initialize
+      @api = API.new
+      @builder = Builder.new
+    end
 
-        # Get badges for given user and return has collection of `Badge`s
-        def get_badges_for username
-          coder_wall = build_coder_wall_from_response(username)
-          coder_wall.badges
-        end
-        
-        # Get user details for given user and return a `User` object
-        def get_details_for username
-          coder_wall = build_coder_wall_from_response(username)
-          coder_wall.user
-        end
+    # Get badges for given user and return has collection of `Badge`s
+    def get_badges_for(username)
+      coder_wall = build_coder_wall_from_response(username)
+      coder_wall.badges
+    end
 
-        # Get all the information available for a given user, returns a `CoderWall` object
-        def get_everything_for username
-          build_coder_wall_from_response(username)
-        end
+    # Get user details for given user and return a `User` object
+    def get_details_for(username)
+      coder_wall = build_coder_wall_from_response(username)
+      coder_wall.user
+    end
+
+    # Get all the information available for a given user,
+    # returns a `CoderWall` object
+    def get_everything_for(username)
+      build_coder_wall_from_response(username)
+    end
 
-        # Builds a CoderWall object
-        def build_coder_wall_from_response(username)
-          json_response = @api.fetch(username)
+    # Builds a CoderWall object
+    def build_coder_wall_from_response(username)
+      json_response = @api.fetch(username)
 
-          @builder.build(json_response)
-        end
+      @builder.build(json_response)
     end
+  end
 end

data/lib/coder_wally/coder_wall.rb

@@ -1,17 +1,17 @@
 # All code in the gem is namespaced under this module.
 module CoderWally
-    # Stores all CoderWall attributes
-    class CoderWall
-      # :badges is the collection of user badges
-      # :user is the `User` object
-      # :accounts is the `Account` object
-      attr_reader :badges, :user, :accounts
+  # Stores all CoderWall attributes
+  class CoderWall
+    # :badges is the collection of user badges
+    # :user is the `User` object
+    # :accounts is the `Account` object
+    attr_reader :badges, :user, :accounts
 
-      # Instantiate the class with data
-      def initialize(badges, user, accounts)
-        @badges = badges
-        @user = user
-        @accounts = accounts
-      end
+    # Instantiate the class with data
+    def initialize(badges, user, accounts)
+      @badges = badges
+      @user = user
+      @accounts = accounts
     end
-end
+  end
+end

data/lib/coder_wally/user.rb

@@ -1,17 +1,17 @@
 # All code in the gem is namespaced under this module.
 module CoderWally
-    # Stores user properties
-    class User 
-        # Object properties 
-        attr_reader :name, :username, :location, :team, :endorsements
-        
-        # Initialise object with a hash of values
-        def initialize(name, username, location, team, endorsements)
-          @name = name
-          @username = username
-          @location = location 
-          @team = team
-          @endorsements = endorsements
-        end
+  # Stores user properties
+  class User
+    # Object properties
+    attr_reader :name, :username, :location, :team, :endorsements
+
+    # Initialise object with a hash of values
+    def initialize(name, username, location, team, endorsements)
+      @name = name
+      @username = username
+      @location = location
+      @team = team
+      @endorsements = endorsements
     end
-end
+  end
+end

data/lib/coder_wally/version.rb

@@ -1,4 +1,5 @@
+# All code in the gem is namespaced under this module.
 module CoderWally
   # The current version of CoderWally.
-  VERSION = '0.1.0'
+  VERSION = '0.1.1'
 end

data/lib/coder_wally.rb

@@ -6,4 +6,3 @@ require 'coder_wally/coder_wall'
 require 'coder_wally/api'
 require 'coder_wally/builder'
 require 'coder_wally/client'
-

data/test/account_test.rb

@@ -3,11 +3,11 @@ require 'coder_wally/account'
 
 describe 'Account' do
   it 'creates an account object with dynamic attributes' do
-    json_parsed = {'github' => 'gregstewart', 'twitter' => '_greg_stewart_'}
+    json_parsed = { 'github' => 'gregstewart', 'twitter' => '_greg_stewart_' }
 
     account = CoderWally::Account.new(json_parsed)
 
     account.github.must_equal 'gregstewart'
     account.twitter.must_equal '_greg_stewart_'
   end
-end
+end

data/test/coder_wally_test.rb

@@ -4,15 +4,19 @@ require 'coder_wally'
 describe 'Coder Wally' do
   before do
     @client = CoderWally::Client.new
+    @accept_encoding = 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3'
+    @success_fixture = File.dirname(__FILE__) + '/./fixtures/200.json'
   end
 
   describe 'user badges' do
     describe 'valid user' do
       before do
-        success_response = open(File.expand_path(File.dirname(__FILE__) + '/./fixtures/200.json')).read
-        stub_request(:get, 'https://coderwall.com/me.json').
-          with(:headers => {'Accept' => '*/*', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent' => 'Ruby'}).
-          to_return(:status => 200, :body => success_response, :headers => {})
+        success_response = open(File.expand_path(@success_fixture)).read
+        stub_request(:get, 'https://coderwall.com/me.json')
+          .with(headers: { 'Accept' => '*/*',
+                           'Accept-Encoding' => @accept_encoding,
+                           'User-Agent' => 'Ruby' })
+          .to_return(status: 200, body:  success_response, headers: {})
       end
 
       it 'returns a hash of badges' do
@@ -29,64 +33,75 @@ describe 'Coder Wally' do
     describe 'invalid user' do
       it 'throws an exception when no user is passed in' do
         err = -> { @client.get_badges_for }.must_raise ArgumentError
-        err.message.must_match /wrong number/
+        err.message.must_match(/wrong number/)
       end
 
       it 'throws an exception when empty string is passed in' do
         err = -> { @client.get_badges_for '' }.must_raise ArgumentError
-        err.message.must_match /Please provide a username/
+        err.message.must_match(/Please provide a username/)
       end
 
       describe 'not found' do
         before do
-          not_found_response = open(File.expand_path(File.dirname(__FILE__) + '/./fixtures/404.json')).read
-          stub_request(:get, 'https://coderwall.com/me.json').
-            with(:headers => {'Accept' => '*/*', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent' => 'Ruby'}).
-            to_return(:status => 404, :body => not_found_response, :headers => {})
+          not_found_fixture = File.dirname(__FILE__) + '/./fixtures/404.json'
+          not_found_response = open(File.expand_path(not_found_fixture)).read
+          stub_request(:get, 'https://coderwall.com/me.json')
+            .with(headers: { 'Accept' => '*/*',
+                             'Accept-Encoding' => @accept_encoding,
+                             'User-Agent' => 'Ruby' })
+            .to_return(status: 404, body:  not_found_response, headers: {})
         end
 
         it 'throws a UserNotFoundError when the user is not found' do
           err = -> { @client.get_badges_for('me') }.must_raise UserNotFoundError
-          err.message.must_match /User not found/
+          err.message.must_match(/User not found/)
         end
       end
     end
 
     describe 'service throws an error' do
       before do
-        server_error = open(File.expand_path(File.dirname(__FILE__) + '/./fixtures/empty.json')).read
-        stub_request(:get, 'https://coderwall.com/me.json').
-          with(:headers => {'Accept' => '*/*', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent' => 'Ruby'}).
-          to_return(:status => 500, :body => server_error, :headers => {})
+        empty_fixture = File.dirname(__FILE__) + '/./fixtures/empty.json'
+        server_error = open(File.expand_path(empty_fixture)).read
+        stub_request(:get, 'https://coderwall.com/me.json')
+          .with(headers: { 'Accept' => '*/*',
+                           'Accept-Encoding' => @accept_encoding,
+                           'User-Agent' => 'Ruby' })
+          .to_return(status: 500, body:  server_error, headers: {})
       end
 
       it 'throws a ServerError when the server response is 500' do
         err = -> { @client.get_badges_for('me') }.must_raise ServerError
-        err.message.must_match /Server error/
+        err.message.must_match(/Server error/)
       end
     end
 
     describe 'bad data' do
       before do
-        bad_data = open(File.expand_path(File.dirname(__FILE__) + '/./fixtures/bad.json')).read
-        stub_request(:get, 'https://coderwall.com/me.json').
-          with(:headers => {'Accept' => '*/*', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent' => 'Ruby'}).
-          to_return(:status => 200, :body => bad_data, :headers => {})
+        bad_json_fixture = File.dirname(__FILE__) + '/./fixtures/bad.json'
+        bad_data = open(File.expand_path(bad_json_fixture)).read
+        stub_request(:get, 'https://coderwall.com/me.json')
+          .with(headers: { 'Accept' => '*/*',
+                           'Accept-Encoding' => @accept_encoding,
+                           'User-Agent' => 'Ruby' })
+          .to_return(status: 200, body:  bad_data, headers: {})
       end
 
       it 'throws a InvalidJson exception when bad JSON is returned' do
         err = -> { @client.get_badges_for('me') }.must_raise InvalidJson
-        err.message.must_match /invalid json/
+        err.message.must_match(/invalid json/)
       end
     end
   end
 
   describe 'user details' do
     before do
-      success_response = open(File.expand_path(File.dirname(__FILE__) + '/./fixtures/200.json')).read
-      stub_request(:get, 'https://coderwall.com/me.json').
-        with(:headers => {'Accept' => '*/*', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent' => 'Ruby'}).
-        to_return(:status => 200, :body => success_response, :headers => {})
+      success_response = open(File.expand_path(@success_fixture)).read
+      stub_request(:get, 'https://coderwall.com/me.json')
+        .with(headers: { 'Accept' => '*/*',
+                         'Accept-Encoding' => @accept_encoding,
+                         'User-Agent' => 'Ruby' })
+        .to_return(status: 200, body:  success_response, headers: {})
     end
 
     it 'returns a user' do
@@ -102,10 +117,12 @@ describe 'Coder Wally' do
 
   describe 'everything' do
     before do
-      success_response = open(File.expand_path(File.dirname(__FILE__) + '/./fixtures/200.json')).read
-      stub_request(:get, 'https://coderwall.com/me.json').
-        with(:headers => {'Accept' => '*/*', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent' => 'Ruby'}).
-        to_return(:status => 200, :body => success_response, :headers => {})
+      success_response = open(File.expand_path(@success_fixture)).read
+      stub_request(:get, 'https://coderwall.com/me.json')
+        .with(headers: { 'Accept' => '*/*',
+                         'Accept-Encoding' => @accept_encoding,
+                         'User-Agent' => 'Ruby' })
+        .to_return(status: 200, body:  success_response, headers: {})
 
       @coder_wall = @client.get_everything_for('me')
     end
@@ -127,5 +144,4 @@ describe 'Coder Wally' do
       @coder_wall.accounts.must_be_instance_of CoderWally::Account
     end
   end
-
-end
+end

data/test/test_helper.rb

@@ -1,3 +1,3 @@
 require 'webmock/minitest'
 require 'coveralls'
-Coveralls.wear!
+Coveralls.wear!

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: coder_wally
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Greg Stewart
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-03 00:00:00.000000000 Z
+date: 2015-02-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -66,6 +66,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: A simple gem to fetch user badges from Coder Wall
 email:
 - gregs@tcias.co.uk
@@ -76,6 +90,8 @@ extra_rdoc_files: []
 files:
 - ".coveralls.yml"
 - ".gitignore"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".ruby-version"
 - ".travis.yml"
 - Gemfile
@@ -83,6 +99,7 @@ files:
 - README.md
 - Rakefile
 - bin/coder_wally
+- circle.yml
 - coder_wally.gemspec
 - lib/coder_wally.rb
 - lib/coder_wally/account.rb
@@ -120,7 +137,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.3
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: A simple gem to fetch user badges from Coder Wall