codeowners-checker 1.0.3 → 1.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b2ab2f62e2427574e64399dc1a1f3681aafc9280af254f04214f1b9be7d50944
-  data.tar.gz: 562d0c9c43d6f49694820b25ed7b47ad7474f72ba097b98dcd4c1292cacdc62e
+  metadata.gz: 4e2f46c087d367f8963223d632e6231db0b4b010595fba6190dc362b06846af6
+  data.tar.gz: 48aecfde1e7f978742558e66752f05e6b452b565f04a43a0a951caf4c431d333
 SHA512:
-  metadata.gz: 2c0cac23ce8db93e59db7466709a33a90acd43e8168d1ddc22ad57ba1ceff569df2c4d14bc43b71d2fd08a476c182fc467837862c630315db6eeffce9b11c5ab
-  data.tar.gz: a4541d789b24f3baf6adae817bde3d1fd04cf49e2c26e0fea177067c4186a2724b31515ec3811e58286624a83e9f7b1adfd05cb964a6fd9b3170f5f1c0e4f36f
+  metadata.gz: 154979b0d6a14f51fd914bcf6a2422e83e90ecf9c2afb3dfe19c476bfe0868ea1018fa6c8e53b0ee99342e8cbc7837bef2153fe8aa9f0385ef177600fd630719
+  data.tar.gz: 15fef3967b0859b85a6c053b1cd8dfcea829e02f2cdcc701c26906e3fea03b9e8c3823cfa63691cb4cfe7b0fb9d5b76070bd4698f38ceba86a15a5f3c12efd66

data/README.md

@@ -1,3 +1,5 @@
+[![CircleCI](https://circleci.com/gh/toptal/codeowners-checker.svg?style=svg)](https://circleci.com/gh/toptal/codeowners-checker)
+
 # Codeowners Checker
 
 This gem checks if the GitHub codeowners are specified to all files changes

data/codeowners-checker.gemspec

@@ -28,6 +28,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rb-readline', '~> 0.5.5'
   spec.add_development_dependency 'rspec', '~> 3.0'
+  spec.add_development_dependency 'rspec_junit_formatter', '~> 0.4.1'
   spec.add_development_dependency 'rubocop', '~> 0.61.1'
   spec.add_development_dependency 'rubocop-rspec', '~> 1.30'
   spec.add_development_dependency 'simplecov', '~> 0.16.1'

data/lib/codeowners/checker/code_owners.rb

@@ -38,7 +38,8 @@ module Codeowners
       private
 
       def list
-        @list ||= @file_manager.content.yield_self do |list|
+        @list ||= begin
+          list = @file_manager.content
           transform_line_procs.each do |transform_line_proc|
             list = list.flat_map { |line| transform_line_proc.call(line) }.compact
           end

data/lib/codeowners/checker/group.rb

@@ -108,7 +108,7 @@ module Codeowners
 
       def remove(line)
         @list.safe_delete(line)
-        remove! unless any?(Pattern)
+        remove! unless any? { |object| object.is_a? Pattern }
       end
 
       def remove!

data/lib/codeowners/checker/group/group_begin_comment.rb

@@ -9,7 +9,7 @@ module Codeowners
       # of a group.
       class GroupBeginComment < Comment
         def self.match?(line)
-          line.lstrip.start_with?(/^#+ BEGIN/)
+          line.lstrip =~ /^#+ BEGIN/
         end
       end
     end

data/lib/codeowners/checker/group/group_end_comment.rb

@@ -9,7 +9,7 @@ module Codeowners
       # of a group.
       class GroupEndComment < Comment
         def self.match?(line)
-          line.lstrip.start_with?(/^#+ END/)
+          line.lstrip =~ /^#+ END/
         end
       end
     end

data/lib/codeowners/checker/group/pattern.rb

@@ -33,10 +33,14 @@ module Codeowners
         end
 
         def match_file?(file)
-          if !pattern.include?('/') || pattern.include?('**')
-            File.fnmatch(pattern.gsub(%r{^/}, ''), file, File::FNM_DOTMATCH)
+          File.fnmatch(pattern.gsub(%r{^/}, ''), file, fn_options)
+        end
+
+        def fn_options
+          if pattern.include?('**')
+            File::FNM_DOTMATCH
           else
-            File.fnmatch(pattern.gsub(%r{^/}, ''), file, File::FNM_PATHNAME | File::FNM_DOTMATCH)
+            File::FNM_DOTMATCH | File::FNM_PATHNAME
           end
         end
 

data/lib/codeowners/checker/version.rb

@@ -2,6 +2,6 @@
 
 module Codeowners
   class Checker
-    VERSION = '1.0.3'
+    VERSION = '1.0.4'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: codeowners-checker
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.0.4
 platform: ruby
 authors:
 - Jônatas Davi Paganini
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-07-17 00:00:00.000000000 Z
+date: 2019-09-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fuzzy_match
@@ -124,6 +124,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rspec_junit_formatter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.4.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.4.1
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement